{"id":24625,"url":"https://patchwork.libcamera.org/api/patches/24625/?format=json","web_url":"https://patchwork.libcamera.org/patch/24625/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251014075252.2876485-10-stefan.klug@ideasonboard.com>","date":"2025-10-14T07:52:31","name":"[v1,09/12] ipa: rkisp1: lsc: Pass crop rectangle as parameter","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"db2eef6b238f479988a587a21267d8da3839897a","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24625/mbox/","series":[{"id":5498,"url":"https://patchwork.libcamera.org/api/series/5498/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5498","date":"2025-10-14T07:52:22","name":"Add resampling support for polynomial LSC data","version":1,"mbox":"https://patchwork.libcamera.org/series/5498/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24625/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24625/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9AAD7BF415\n\tfor ;\n\tTue, 14 Oct 2025 07:53:26 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 503BC605E6;\n\tTue, 14 Oct 2025 09:53:26 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3347C605E6\n\tfor ;\n\tTue, 14 Oct 2025 09:53:25 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:61fb:8e55:ff1e:be62])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id ED5C6741;\n\tTue, 14 Oct 2025 09:51:46 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"f3RAHuR/\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1760428307;\n\tbh=wbAH6rM15jLZHDvo20itwrBqufMWQudO9JpuIDDPktw=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=f3RAHuR/lcTsFV2GewoGJbcxcBnpdCFs0YxXkpbEK/EmUQpxyFVKhmpbbBtdLfN5a\n\tH+z7X6bO8HXeL6jeRvneku8ZWnfkmPkge2uTuZYsaust8Pd8bfJWcngBWo1zWmvd3h\n\tD6WLRJUzDh2YU8g1dvN3WUvWHP/AbQHQ0/HzaDxo=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ","Subject":"[PATCH v1 09/12] ipa: rkisp1: lsc: Pass crop rectangle as parameter","Date":"Tue, 14 Oct 2025 09:52:31 +0200","Message-ID":"<20251014075252.2876485-10-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.48.1","In-Reply-To":"<20251014075252.2876485-1-stefan.klug@ideasonboard.com>","References":"<20251014075252.2876485-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"In preparation for the upcoming rework, pass the crop rectangle as\nparameter to samplePolynomial(). This patch contains no functional\nchange.\n\nSigned-off-by: Stefan Klug \n---\n src/ipa/rkisp1/algorithms/lsc.cpp | 22 ++++++++++++----------\n 1 file changed, 12 insertions(+), 10 deletions(-)","diff":"diff --git a/src/ipa/rkisp1/algorithms/lsc.cpp b/src/ipa/rkisp1/algorithms/lsc.cpp\nindex 2fbc8bd1b242..29cd7efd83ef 100644\n--- a/src/ipa/rkisp1/algorithms/lsc.cpp\n+++ b/src/ipa/rkisp1/algorithms/lsc.cpp\n@@ -91,7 +91,8 @@ private:\n \tstd::vector sizesListToPositions(const std::vector &sizes);\n \tstd::vector samplePolynomial(const LscPolynomial &poly,\n \t\t\t\t\t const std::vector &xPositions,\n-\t\t\t\t\t const std::vector &yPositions);\n+\t\t\t\t\t const std::vector &yPositions,\n+\t\t\t\t\t const Rectangle &cropRectangle);\n \n \tSize sensorSize_;\n \tRectangle cropRectangle_;\n@@ -134,10 +135,10 @@ int LscPolynomialLoader::parseLscData(const YamlObject &yamlSets,\n \n \t\tstd::vector xPos(sizesListToPositions(xSizes_));\n \t\tstd::vector yPos(sizesListToPositions(ySizes_));\n-\t\tset.r = samplePolynomial(*pr, xPos, yPos);\n-\t\tset.gr = samplePolynomial(*pgr, xPos, yPos);\n-\t\tset.gb = samplePolynomial(*pgb, xPos, yPos);\n-\t\tset.b = samplePolynomial(*pb, xPos, yPos);\n+\t\tset.r = samplePolynomial(*pr, xPos, yPos, cropRectangle_);\n+\t\tset.gr = samplePolynomial(*pgr, xPos, yPos, cropRectangle_);\n+\t\tset.gb = samplePolynomial(*pgb, xPos, yPos, cropRectangle_);\n+\t\tset.b = samplePolynomial(*pb, xPos, yPos, cropRectangle_);\n \t}\n \n \tif (lscData.empty()) {\n@@ -176,13 +177,14 @@ std::vector LscPolynomialLoader::sizesListToPositions(const std::vector<\n \n std::vector LscPolynomialLoader::samplePolynomial(const LscPolynomial &poly,\n \t\t\t\t\t\t\t const std::vector &xPositions,\n-\t\t\t\t\t\t\t const std::vector &yPositions)\n+\t\t\t\t\t\t\t const std::vector &yPositions,\n+\t\t\t\t\t\t\t const Rectangle &cropRectangle)\n {\n \tdouble m = poly.getM();\n-\tdouble x0 = cropRectangle_.x / m;\n-\tdouble y0 = cropRectangle_.y / m;\n-\tdouble w = cropRectangle_.width / m;\n-\tdouble h = cropRectangle_.height / m;\n+\tdouble x0 = cropRectangle.x / m;\n+\tdouble y0 = cropRectangle.y / m;\n+\tdouble w = cropRectangle.width / m;\n+\tdouble h = cropRectangle.height / m;\n \tstd::vector samples;\n \n \tsamples.reserve(xPositions.size() * yPositions.size());\n","prefixes":["v1","09/12"]}