{"id":24624,"url":"https://patchwork.libcamera.org/api/patches/24624/?format=json","web_url":"https://patchwork.libcamera.org/patch/24624/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251014075252.2876485-9-stefan.klug@ideasonboard.com>","date":"2025-10-14T07:52:30","name":"[v1,08/12] ipa: rkisp1: lsc: Pass sampling positions into samplePolynomial","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"b79022e2c3d80784f86226bcb44f4d15fb27518c","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24624/mbox/","series":[{"id":5498,"url":"https://patchwork.libcamera.org/api/series/5498/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5498","date":"2025-10-14T07:52:22","name":"Add resampling support for polynomial LSC data","version":1,"mbox":"https://patchwork.libcamera.org/series/5498/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24624/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24624/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0F537BF415\n\tfor ;\n\tTue, 14 Oct 2025 07:53:25 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B499F605DD;\n\tTue, 14 Oct 2025 09:53:24 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D300E605D0\n\tfor ;\n\tTue, 14 Oct 2025 09:53:22 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:61fb:8e55:ff1e:be62])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id A9082741;\n\tTue, 14 Oct 2025 09:51:44 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"PHGBvyCp\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1760428304;\n\tbh=pqB0nGkdsqNB9H6pqQ6rULwqSv30iPl+tcON4T3/W48=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=PHGBvyCpMiLOF1ciUd4HxKjziFbjAsVeLd6GbUHChiR6Vpf6PqJas+tlcTFXXasgJ\n\tCzGgACpBeGnklZIDEubH3EQySyOUKpVwzx05rzc/9PqTcef3iIxUYBqwXKgMQXbwT1\n\taXYh294pam7mg7fy4YS7+hGvzH/eYlIIfZ0Dp9sM=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ","Subject":"[PATCH v1 08/12] ipa: rkisp1: lsc: Pass sampling positions into\n\tsamplePolynomial","Date":"Tue, 14 Oct 2025 09:52:30 +0200","Message-ID":"<20251014075252.2876485-9-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.48.1","In-Reply-To":"<20251014075252.2876485-1-stefan.klug@ideasonboard.com>","References":"<20251014075252.2876485-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"There is no need to recalculate the sampling positions over and over.\nPass them as parameter into the sampling function. The vectors are still\nkept inside the loop as this is also a preparatory change for the\nupcoming refactoring.\n\nSigned-off-by: Stefan Klug \n---\n src/ipa/rkisp1/algorithms/lsc.cpp | 37 +++++++++++++++----------------\n 1 file changed, 18 insertions(+), 19 deletions(-)","diff":"diff --git a/src/ipa/rkisp1/algorithms/lsc.cpp b/src/ipa/rkisp1/algorithms/lsc.cpp\nindex 0c1bb470c346..2fbc8bd1b242 100644\n--- a/src/ipa/rkisp1/algorithms/lsc.cpp\n+++ b/src/ipa/rkisp1/algorithms/lsc.cpp\n@@ -89,7 +89,9 @@ public:\n \n private:\n \tstd::vector sizesListToPositions(const std::vector &sizes);\n-\tstd::vector samplePolynomial(const LscPolynomial &poly);\n+\tstd::vector samplePolynomial(const LscPolynomial &poly,\n+\t\t\t\t\t const std::vector &xPositions,\n+\t\t\t\t\t const std::vector &yPositions);\n \n \tSize sensorSize_;\n \tRectangle cropRectangle_;\n@@ -129,10 +131,13 @@ int LscPolynomialLoader::parseLscData(const YamlObject &yamlSets,\n \t\tpgr->setReferenceImageSize(sensorSize_);\n \t\tpgb->setReferenceImageSize(sensorSize_);\n \t\tpb->setReferenceImageSize(sensorSize_);\n-\t\tset.r = samplePolynomial(*pr);\n-\t\tset.gr = samplePolynomial(*pgr);\n-\t\tset.gb = samplePolynomial(*pgb);\n-\t\tset.b = samplePolynomial(*pb);\n+\n+\t\tstd::vector xPos(sizesListToPositions(xSizes_));\n+\t\tstd::vector yPos(sizesListToPositions(ySizes_));\n+\t\tset.r = samplePolynomial(*pr, xPos, yPos);\n+\t\tset.gr = samplePolynomial(*pgr, xPos, yPos);\n+\t\tset.gb = samplePolynomial(*pgb, xPos, yPos);\n+\t\tset.b = samplePolynomial(*pb, xPos, yPos);\n \t}\n \n \tif (lscData.empty()) {\n@@ -169,10 +174,10 @@ std::vector LscPolynomialLoader::sizesListToPositions(const std::vector<\n \treturn positions;\n }\n \n-std::vector LscPolynomialLoader::samplePolynomial(const LscPolynomial &poly)\n+std::vector LscPolynomialLoader::samplePolynomial(const LscPolynomial &poly,\n+\t\t\t\t\t\t\t const std::vector &xPositions,\n+\t\t\t\t\t\t\t const std::vector &yPositions)\n {\n-\tconstexpr int k = RKISP1_CIF_ISP_LSC_SAMPLES_MAX;\n-\n \tdouble m = poly.getM();\n \tdouble x0 = cropRectangle_.x / m;\n \tdouble y0 = cropRectangle_.y / m;\n@@ -180,18 +185,12 @@ std::vector LscPolynomialLoader::samplePolynomial(const LscPolynomial\n \tdouble h = cropRectangle_.height / m;\n \tstd::vector samples;\n \n-\tASSERT(xSizes_.size() * 2 + 1 == k);\n-\tASSERT(ySizes_.size() * 2 + 1 == k);\n-\n-\tsamples.reserve(k * k);\n-\n-\tstd::vector xPos(sizesListToPositions(xSizes_));\n-\tstd::vector yPos(sizesListToPositions(ySizes_));\n+\tsamples.reserve(xPositions.size() * yPositions.size());\n \n-\tfor (int y = 0; y < k; y++) {\n-\t\tfor (int x = 0; x < k; x++) {\n-\t\t\tdouble xp = x0 + xPos[x] * w;\n-\t\t\tdouble yp = y0 + yPos[y] * h;\n+\tfor (double y : yPositions) {\n+\t\tfor (double x : xPositions) {\n+\t\t\tdouble xp = x0 + x * w;\n+\t\t\tdouble yp = y0 + y * h;\n \t\t\t/*\n \t\t\t * The hardware uses 2.10 fixed point format and limits\n \t\t\t * the legal values to [1..3.999]. Scale and clamp the\n","prefixes":["v1","08/12"]}