[{"id":36235,"web_url":"https://patchwork.libcamera.org/comment/36235/","msgid":"<0d1a7896-81a7-468f-8f81-207a887a7f62@ideasonboard.com>","date":"2025-10-14T08:12:37","subject":"Re: [PATCH v1 06/12] ipa: rkisp1: lsc: Rename res to samples","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2025. 10. 14. 9:52 keltezéssel, Stefan Klug írta:\n> Rename res to samples to better describe the intent. This was noted in\n> review after the series was merged.\n> \n> Signed-off-by: Stefan Klug \n> ---\n\nReviewed-by: Barnabás Pőcze \n\n\n> src/ipa/rkisp1/algorithms/lsc.cpp | 8 ++++----\n> 1 file changed, 4 insertions(+), 4 deletions(-)\n> \n> diff --git a/src/ipa/rkisp1/algorithms/lsc.cpp b/src/ipa/rkisp1/algorithms/lsc.cpp\n> index e4938dbd657c..e46943f4bae0 100644\n> --- a/src/ipa/rkisp1/algorithms/lsc.cpp\n> +++ b/src/ipa/rkisp1/algorithms/lsc.cpp\n> @@ -166,12 +166,12 @@ private:\n> \t\tdouble y0 = cropRectangle_.y / m;\n> \t\tdouble w = cropRectangle_.width / m;\n> \t\tdouble h = cropRectangle_.height / m;\n> -\t\tstd::vector res;\n> +\t\tstd::vector samples;\n> \n> \t\tASSERT(xSizes_.size() * 2 + 1 == k);\n> \t\tASSERT(ySizes_.size() * 2 + 1 == k);\n> \n> -\t\tres.reserve(k * k);\n> +\t\tsamples.reserve(k * k);\n> \n> \t\tstd::vector xPos(sizesListToPositions(xSizes_));\n> \t\tstd::vector yPos(sizesListToPositions(ySizes_));\n> @@ -189,10 +189,10 @@ private:\n> \t\t\t\t\tpoly.sampleAtNormalizedPixelPos(xp, yp) *\n> \t\t\t\t\t1024);\n> \t\t\t\tv = std::min(std::max(v, 1024), 4095);\n> -\t\t\t\tres.push_back(v);\n> +\t\t\t\tsamples.push_back(v);\n> \t\t\t}\n> \t\t}\n> -\t\treturn res;\n> +\t\treturn samples;\n> \t}\n> \n> \tSize sensorSize_;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 31DC5BF415\n\tfor ;\n\tTue, 14 Oct 2025 08:12:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C3BC4605D0;\n\tTue, 14 Oct 2025 10:12:39 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C9BE160316\n\tfor ;\n\tTue, 14 Oct 2025 10:12:37 +0200 (CEST)","from [192.168.33.20] (185.182.214.105.nat.pool.zt.hu\n\t[185.182.214.105])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 94E75C73;\n\tTue, 14 Oct 2025 10:10:59 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"R7iwNGC5\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1760429459;\n\tbh=nF8M7/cA2hays+Z38SCFqAIBQJY45cg2PyjCXUURhSM=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=R7iwNGC5JeEgNoLA0tr0rKsjBTp15RI044EP9OTQH7KVHvv1eFfk6YVO4eToq3Gg+\n\tlI6ujSTSSabdOckqiQh64JoJEmVBktuTy7BcxB1IgI/yw5RextWKSLaJTTgqf5htLD\n\t3MXOD0ALhmgDO4b3Ql98U9joq+dgHfghAwx9nbjo=","Message-ID":"<0d1a7896-81a7-468f-8f81-207a887a7f62@ideasonboard.com>","Date":"Tue, 14 Oct 2025 10:12:37 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v1 06/12] ipa: rkisp1: lsc: Rename res to samples","To":"Stefan Klug ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20251014075252.2876485-1-stefan.klug@ideasonboard.com>\n\t<20251014075252.2876485-7-stefan.klug@ideasonboard.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20251014075252.2876485-7-stefan.klug@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":36502,"web_url":"https://patchwork.libcamera.org/comment/36502/","msgid":"<95d6842e-621d-4664-b719-325782e1ae12@ideasonboard.com>","date":"2025-10-27T21:13:18","subject":"Re: [PATCH v1 06/12] ipa: rkisp1: lsc: Rename res to samples","submitter":{"id":241,"url":"https://patchwork.libcamera.org/api/people/241/","name":"Rui Wang","email":"rui.wang@ideasonboard.com"},"content":"On 2025-10-14 03:52, Stefan Klug wrote:\n> Rename res to samples to better describe the intent. This was noted in\n> review after the series was merged.\n>\n> Signed-off-by: Stefan Klug \n> ---\n> src/ipa/rkisp1/algorithms/lsc.cpp | 8 ++++----\n> 1 file changed, 4 insertions(+), 4 deletions(-)\n>\n> diff --git a/src/ipa/rkisp1/algorithms/lsc.cpp b/src/ipa/rkisp1/algorithms/lsc.cpp\n> index e4938dbd657c..e46943f4bae0 100644\n> --- a/src/ipa/rkisp1/algorithms/lsc.cpp\n> +++ b/src/ipa/rkisp1/algorithms/lsc.cpp\n> @@ -166,12 +166,12 @@ private:\n> \t\tdouble y0 = cropRectangle_.y / m;\n> \t\tdouble w = cropRectangle_.width / m;\n> \t\tdouble h = cropRectangle_.height / m;\n> -\t\tstd::vector res;\n> +\t\tstd::vector samples;\n> \n> \t\tASSERT(xSizes_.size() * 2 + 1 == k);\n> \t\tASSERT(ySizes_.size() * 2 + 1 == k);\n> \n> -\t\tres.reserve(k * k);\n> +\t\tsamples.reserve(k * k);\n> \n> \t\tstd::vector xPos(sizesListToPositions(xSizes_));\n> \t\tstd::vector yPos(sizesListToPositions(ySizes_));\n> @@ -189,10 +189,10 @@ private:\n> \t\t\t\t\tpoly.sampleAtNormalizedPixelPos(xp, yp) *\n> \t\t\t\t\t1024);\n> \t\t\t\tv = std::min(std::max(v, 1024), 4095);\n> -\t\t\t\tres.push_back(v);\n> +\t\t\t\tsamples.push_back(v);\n> \t\t\t}\n> \t\t}\n> -\t\treturn res;\n> +\t\treturn samples;\n> \t}\n> \n> \tSize sensorSize_;\n\n\nReviewed-by: Rui Wang ","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7DA89BE080\n\tfor ;\n\tMon, 27 Oct 2025 21:13:33 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 96D356078B;\n\tMon, 27 Oct 2025 22:13:32 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 15DE06069A\n\tfor ;\n\tMon, 27 Oct 2025 22:13:31 +0100 (CET)","from [192.168.31.114] (unknown [209.216.122.90])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CF459E70\n\tfor ;\n\tMon, 27 Oct 2025 22:11:42 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"RAJT7IiT\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1761599503;\n\tbh=pwKoHgJO2UB1EmnZkLFLWVm99fYnu+1bcVfCQIAWeD8=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=RAJT7IiTt58XtMXO6VNMYFRng8nmXunRi8Hzn9ft+QKAHz/ZiwbhrO+Z2TFQkn9jt\n\t61gzePJA7nh6/0dzXW3SnpPX6HpPUKfaoQzkibIfa9Z5A0YnNi9ZMZ41waUgVNb+BX\n\tdNaxlGlsMPHJHiq3Bl3V4O8ntulJom1EXY4CTMP0=","Message-ID":"<95d6842e-621d-4664-b719-325782e1ae12@ideasonboard.com>","Date":"Mon, 27 Oct 2025 17:13:18 -0400","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v1 06/12] ipa: rkisp1: lsc: Rename res to samples","To":"libcamera-devel@lists.libcamera.org","References":"<20251014075252.2876485-1-stefan.klug@ideasonboard.com>\n\t<20251014075252.2876485-7-stefan.klug@ideasonboard.com>","Content-Language":"en-US","From":"rui wang ","In-Reply-To":"<20251014075252.2876485-7-stefan.klug@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]