[{"id":36445,"web_url":"https://patchwork.libcamera.org/comment/36445/","msgid":"<15bb6770-9a04-44a6-9b6e-6043c5e73937@ideasonboard.com>","date":"2025-10-24T16:11:56","subject":"Re: [PATCH v1 05/12] ipa: rkisp1: lsc: Rename res to ret","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2025. 10. 14. 9:52 keltezéssel, Stefan Klug írta:\n> Rename res to ret as that is used in libcamera for return codes.\n> \n> Signed-off-by: Stefan Klug \n> ---\n> src/ipa/rkisp1/algorithms/lsc.cpp | 13 +++++++------\n> 1 file changed, 7 insertions(+), 6 deletions(-)\n> \n> diff --git a/src/ipa/rkisp1/algorithms/lsc.cpp b/src/ipa/rkisp1/algorithms/lsc.cpp\n> index bb58386ae646..e4938dbd657c 100644\n> --- a/src/ipa/rkisp1/algorithms/lsc.cpp\n> +++ b/src/ipa/rkisp1/algorithms/lsc.cpp\n> @@ -320,28 +320,29 @@ int LensShadingCorrection::init([[maybe_unused]] IPAContext &context,\n> \t\treturn -EINVAL;\n> \t}\n> \n> +\tint ret = 0;\n> \tstd::map lscData;\n> -\tint res = 0;\n> +\n\nI think I liked the previous order better.\n\nReviewed-by: Barnabás Pőcze \n\n\n> \tstd::string type = tuningData[\"type\"].get(\"table\");\n> \tif (type == \"table\") {\n> \t\tLOG(RkISP1Lsc, Debug) << \"Loading tabular LSC data.\";\n> \t\tauto loader = LscTableLoader();\n> -\t\tres = loader.parseLscData(yamlSets, lscData);\n> +\t\tret = loader.parseLscData(yamlSets, lscData);\n> \t} else if (type == \"polynomial\") {\n> \t\tLOG(RkISP1Lsc, Debug) << \"Loading polynomial LSC data.\";\n> \t\tauto loader = LscPolynomialLoader(context.sensorInfo.activeAreaSize,\n> \t\t\t\t\t\t context.sensorInfo.analogCrop,\n> \t\t\t\t\t\t xSize_,\n> \t\t\t\t\t\t ySize_);\n> -\t\tres = loader.parseLscData(yamlSets, lscData);\n> +\t\tret = loader.parseLscData(yamlSets, lscData);\n> \t} else {\n> \t\tLOG(RkISP1Lsc, Error) << \"Unsupported LSC data type '\"\n> \t\t\t\t << type << \"'\";\n> -\t\tres = -EINVAL;\n> +\t\tret = -EINVAL;\n> \t}\n> \n> -\tif (res)\n> -\t\treturn res;\n> +\tif (ret)\n> +\t\treturn ret;\n> \n> \tsets_.setData(std::move(lscData));\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6ACB8BE080\n\tfor ;\n\tFri, 24 Oct 2025 16:12:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 28A26609B6;\n\tFri, 24 Oct 2025 18:12:01 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9B902608DC\n\tfor ;\n\tFri, 24 Oct 2025 18:11:59 +0200 (CEST)","from [192.168.33.13] (185.221.141.231.nat.pool.zt.hu\n\t[185.221.141.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E2AE1122A;\n\tFri, 24 Oct 2025 18:10:13 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"t4I4ijFi\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1761322214;\n\tbh=LuTheg9XIuNE5Jn+nz38DlMnWCZcXyTm1geLtzWzVc0=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=t4I4ijFiAC45LLhD3wa7eploeuBuqQvXsdorcc5k05ajT/AmnKkpgtgVnLn4V3lZe\n\tcB/3mmtyjFcyQbwNnassjMj/XX/YufgxJKfJO/HRK7GKvP+cMnel8k9rjDqfBa8ZJQ\n\tN8cHz2DR7jh1HM4yWO6cnwxmDmNz1FK3O0R4IHFY=","Message-ID":"<15bb6770-9a04-44a6-9b6e-6043c5e73937@ideasonboard.com>","Date":"Fri, 24 Oct 2025 18:11:56 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v1 05/12] ipa: rkisp1: lsc: Rename res to ret","To":"Stefan Klug ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20251014075252.2876485-1-stefan.klug@ideasonboard.com>\n\t<20251014075252.2876485-6-stefan.klug@ideasonboard.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20251014075252.2876485-6-stefan.klug@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":36501,"web_url":"https://patchwork.libcamera.org/comment/36501/","msgid":"","date":"2025-10-27T21:01:09","subject":"Re: [PATCH v1 05/12] ipa: rkisp1: lsc: Rename res to ret","submitter":{"id":241,"url":"https://patchwork.libcamera.org/api/people/241/","name":"Rui Wang","email":"rui.wang@ideasonboard.com"},"content":"On 2025-10-14 03:52, Stefan Klug wrote:\n> Rename res to ret as that is used in libcamera for return codes.\n>\n> Signed-off-by: Stefan Klug \n> ---\n> src/ipa/rkisp1/algorithms/lsc.cpp | 13 +++++++------\n> 1 file changed, 7 insertions(+), 6 deletions(-)\n>\n> diff --git a/src/ipa/rkisp1/algorithms/lsc.cpp b/src/ipa/rkisp1/algorithms/lsc.cpp\n> index bb58386ae646..e4938dbd657c 100644\n> --- a/src/ipa/rkisp1/algorithms/lsc.cpp\n> +++ b/src/ipa/rkisp1/algorithms/lsc.cpp\n> @@ -320,28 +320,29 @@ int LensShadingCorrection::init([[maybe_unused]] IPAContext &context,\n> \t\treturn -EINVAL;\n> \t}\n> \n> +\tint ret = 0;\n> \tstd::map lscData;\n> -\tint res = 0;\n> +\n> \tstd::string type = tuningData[\"type\"].get(\"table\");\n> \tif (type == \"table\") {\n> \t\tLOG(RkISP1Lsc, Debug) << \"Loading tabular LSC data.\";\n> \t\tauto loader = LscTableLoader();\n> -\t\tres = loader.parseLscData(yamlSets, lscData);\n> +\t\tret = loader.parseLscData(yamlSets, lscData);\n> \t} else if (type == \"polynomial\") {\n> \t\tLOG(RkISP1Lsc, Debug) << \"Loading polynomial LSC data.\";\n> \t\tauto loader = LscPolynomialLoader(context.sensorInfo.activeAreaSize,\n> \t\t\t\t\t\t context.sensorInfo.analogCrop,\n> \t\t\t\t\t\t xSize_,\n> \t\t\t\t\t\t ySize_);\n> -\t\tres = loader.parseLscData(yamlSets, lscData);\n> +\t\tret = loader.parseLscData(yamlSets, lscData);\n> \t} else {\n> \t\tLOG(RkISP1Lsc, Error) << \"Unsupported LSC data type '\"\n> \t\t\t\t << type << \"'\";\n> -\t\tres = -EINVAL;\n> +\t\tret = -EINVAL;\n> \t}\n> \n> -\tif (res)\n> -\t\treturn res;\n> +\tif (ret)\n> +\t\treturn ret;\n> \n> \tsets_.setData(std::move(lscData));\n> \n\nReviewed-by: Rui Wang \n\nReviewed-by: Rui Wang \n\nReviewed-by: Rui Wang ","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F074CC3259\n\tfor ;\n\tMon, 27 Oct 2025 21:01:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AB32E6078C;\n\tMon, 27 Oct 2025 22:01:23 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CC97F6069A\n\tfor ;\n\tMon, 27 Oct 2025 22:01:21 +0100 (CET)","from [192.168.31.114] (unknown [209.216.122.90])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BAE48E9B\n\tfor ;\n\tMon, 27 Oct 2025 21:59:33 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"WQIZgqyn\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1761598773;\n\tbh=WJ38bJnrf2wYKnaqvQV4Li6LP9X5Mke1nNRslqgiIh8=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=WQIZgqynbQ1hPCtdGaPNXSI15KxzwuWRHo1Nw+OyncxWjHvrohrbOOCLMLrLx8Pmv\n\tQTvwKIjErpkEgWutg51anCGxYqBsLgczoj7M3cCidh11yPGnCDq4O/2OWvkm1ALJEM\n\t9ZpuOItoZSvaLERSa5COZ+F3t7tah6VleMCt66sk=","Message-ID":"","Date":"Mon, 27 Oct 2025 17:01:09 -0400","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v1 05/12] ipa: rkisp1: lsc: Rename res to ret","To":"libcamera-devel@lists.libcamera.org","References":"<20251014075252.2876485-1-stefan.klug@ideasonboard.com>\n\t<20251014075252.2876485-6-stefan.klug@ideasonboard.com>","Content-Language":"en-US","From":"rui wang ","In-Reply-To":"<20251014075252.2876485-6-stefan.klug@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":37517,"web_url":"https://patchwork.libcamera.org/comment/37517/","msgid":"<176780108920.21455.1900715714385383457@localhost>","date":"2026-01-07T15:51:29","subject":"Re: [PATCH v1 05/12] ipa: rkisp1: lsc: Rename res to ret","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"content":"Hi Barnabás,\n\nThank you for the review.\n\nQuoting Barnabás Pőcze (2025-10-24 18:11:56)\n> 2025. 10. 14. 9:52 keltezéssel, Stefan Klug írta:\n> > Rename res to ret as that is used in libcamera for return codes.\n> > \n> > Signed-off-by: Stefan Klug \n> > ---\n> > src/ipa/rkisp1/algorithms/lsc.cpp | 13 +++++++------\n> > 1 file changed, 7 insertions(+), 6 deletions(-)\n> > \n> > diff --git a/src/ipa/rkisp1/algorithms/lsc.cpp b/src/ipa/rkisp1/algorithms/lsc.cpp\n> > index bb58386ae646..e4938dbd657c 100644\n> > --- a/src/ipa/rkisp1/algorithms/lsc.cpp\n> > +++ b/src/ipa/rkisp1/algorithms/lsc.cpp\n> > @@ -320,28 +320,29 @@ int LensShadingCorrection::init([[maybe_unused]] IPAContext &context,\n> > return -EINVAL;\n> > }\n> > \n> > + int ret = 0;\n> > std::map lscData;\n> > - int res = 0;\n> > +\n> \n> I think I liked the previous order better.\n\nI restored the old one as it adheres to reverse xmas tree.\n\n> \n> Reviewed-by: Barnabás Pőcze \n\nThanks!\n\nRegards,\nStefan\n\n> \n> \n> > std::string type = tuningData[\"type\"].get(\"table\");\n> > if (type == \"table\") {\n> > LOG(RkISP1Lsc, Debug) << \"Loading tabular LSC data.\";\n> > auto loader = LscTableLoader();\n> > - res = loader.parseLscData(yamlSets, lscData);\n> > + ret = loader.parseLscData(yamlSets, lscData);\n> > } else if (type == \"polynomial\") {\n> > LOG(RkISP1Lsc, Debug) << \"Loading polynomial LSC data.\";\n> > auto loader = LscPolynomialLoader(context.sensorInfo.activeAreaSize,\n> > context.sensorInfo.analogCrop,\n> > xSize_,\n> > ySize_);\n> > - res = loader.parseLscData(yamlSets, lscData);\n> > + ret = loader.parseLscData(yamlSets, lscData);\n> > } else {\n> > LOG(RkISP1Lsc, Error) << \"Unsupported LSC data type '\"\n> > << type << \"'\";\n> > - res = -EINVAL;\n> > + ret = -EINVAL;\n> > }\n> > \n> > - if (res)\n> > - return res;\n> > + if (ret)\n> > + return ret;\n> > \n> > sets_.setData(std::move(lscData));\n> > \n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 464D5BDCBF\n\tfor ;\n\tWed, 7 Jan 2026 15:51:34 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 777C361FBB;\n\tWed, 7 Jan 2026 16:51:33 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7691261F84\n\tfor ;\n\tWed, 7 Jan 2026 16:51:32 +0100 (CET)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:d809:713a:29af:b139])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 8839D73B;\n\tWed, 7 Jan 2026 16:51:10 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"astTA97h\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1767801070;\n\tbh=WW9PPf2Txhegu9Kym2S5lMQ98L4fscfFMk56IPpQhbc=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=astTA97h+QxHOeWz8WSUmAtpH/mz4pVHBvWo5hPrVhylxG7zIaAJTd57n6YUvNtlQ\n\tbW1/8qhEvW8dmIIRfovrL+ozXQNomItZrmRBPsfHq3/QF97plUT6FWyt1eF3K011zM\n\t8H+mmlLaXX5STMxkiNy8a21Kwbyq6JEgNBZlDl1o=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<15bb6770-9a04-44a6-9b6e-6043c5e73937@ideasonboard.com>","References":"<20251014075252.2876485-1-stefan.klug@ideasonboard.com>\n\t<20251014075252.2876485-6-stefan.klug@ideasonboard.com>\n\t<15bb6770-9a04-44a6-9b6e-6043c5e73937@ideasonboard.com>","Subject":"Re: [PATCH v1 05/12] ipa: rkisp1: lsc: Rename res to ret","From":"Stefan Klug ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Wed, 07 Jan 2026 16:51:29 +0100","Message-ID":"<176780108920.21455.1900715714385383457@localhost>","User-Agent":"alot/0.12.dev8+g2c003385c862.d20250602","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]