[{"id":36237,"web_url":"https://patchwork.libcamera.org/comment/36237/","msgid":"<8d39aebc-409c-446e-9f4b-511b89eb7504@ideasonboard.com>","date":"2025-10-14T08:13:44","subject":"Re: [PATCH v1 03/12] ipa: rkisp1: lsc: Replace assert with ASSERT","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2025. 10. 14. 9:52 keltezéssel, Stefan Klug írta:\n> Replace assert() by ASSERT() and drop a set of unnecessary curly braces.\n> Those were noticed in the former review but after the series was\n> applied. Fix them now.\n> \n> Signed-off-by: Stefan Klug \n> ---\n\nReviewed-by: Barnabás Pőcze \n\n\n> src/ipa/rkisp1/algorithms/lsc.cpp | 9 ++++-----\n> 1 file changed, 4 insertions(+), 5 deletions(-)\n> \n> diff --git a/src/ipa/rkisp1/algorithms/lsc.cpp b/src/ipa/rkisp1/algorithms/lsc.cpp\n> index ab0ada4eed46..c581e6441853 100644\n> --- a/src/ipa/rkisp1/algorithms/lsc.cpp\n> +++ b/src/ipa/rkisp1/algorithms/lsc.cpp\n> @@ -33,11 +33,10 @@ template\n> void interpolateVector(const std::vector &a, const std::vector &b,\n> \t\t std::vector &dest, double lambda)\n> {\n> -\tassert(a.size() == b.size());\n> +\tASSERT(a.size() == b.size());\n> \tdest.resize(a.size());\n> -\tfor (size_t i = 0; i < a.size(); i++) {\n> +\tfor (size_t i = 0; i < a.size(); i++)\n> \t\tdest[i] = a[i] * (1.0 - lambda) + b[i] * lambda;\n> -\t}\n> }\n> \n> template<>\n> @@ -167,8 +166,8 @@ private:\n> \t\tdouble h = cropRectangle_.height / m;\n> \t\tstd::vector res;\n> \n> -\t\tassert(xSizes_.size() * 2 + 1 == k);\n> -\t\tassert(ySizes_.size() * 2 + 1 == k);\n> +\t\tASSERT(xSizes_.size() * 2 + 1 == k);\n> +\t\tASSERT(ySizes_.size() * 2 + 1 == k);\n> \n> \t\tres.reserve(k * k);\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D8D85BF415\n\tfor ;\n\tTue, 14 Oct 2025 08:13:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 94431605A8;\n\tTue, 14 Oct 2025 10:13:49 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 72C9F60316\n\tfor ;\n\tTue, 14 Oct 2025 10:13:47 +0200 (CEST)","from [192.168.33.20] (185.182.214.105.nat.pool.zt.hu\n\t[185.182.214.105])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 275C7C73;\n\tTue, 14 Oct 2025 10:12:09 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"rFEmJW17\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1760429529;\n\tbh=kssblWod1VA3Gye+kdyiNtYtaar+ZmHwemiwwE7Nlxk=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=rFEmJW17hCMy6RPbEmfIEeq3n3g3EaDZnwLdyAEqqjD0GjMTquYn6dqrbtXAixOn+\n\tTFo2C2iVzVZ2TXnOrlQZBb5B5/I8LaeZyA5J7Z4vB+yZ+N3UHTRxIiwaP8ttKTqOB0\n\td8KiGIi6MqNgFsA+vMDb+PWPYfT9bgbZCN60KHjQ=","Message-ID":"<8d39aebc-409c-446e-9f4b-511b89eb7504@ideasonboard.com>","Date":"Tue, 14 Oct 2025 10:13:44 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v1 03/12] ipa: rkisp1: lsc: Replace assert with ASSERT","To":"Stefan Klug ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20251014075252.2876485-1-stefan.klug@ideasonboard.com>\n\t<20251014075252.2876485-4-stefan.klug@ideasonboard.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20251014075252.2876485-4-stefan.klug@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":36469,"web_url":"https://patchwork.libcamera.org/comment/36469/","msgid":"<44027dbb-cc2d-4526-b851-9c50536e3383@ideasonboard.com>","date":"2025-10-25T13:54:58","subject":"Re: [PATCH v1 03/12] ipa: rkisp1: lsc: Replace assert with ASSERT","submitter":{"id":241,"url":"https://patchwork.libcamera.org/api/people/241/","name":"Rui Wang","email":"rui.wang@ideasonboard.com"},"content":"On 2025-10-14 03:52, Stefan Klug wrote:\n> Replace assert() by ASSERT() and drop a set of unnecessary curly braces.\n> Those were noticed in the former review but after the series was\n> applied. Fix them now.\n>\n> Signed-off-by: Stefan Klug \n> ---\n> src/ipa/rkisp1/algorithms/lsc.cpp | 9 ++++-----\n> 1 file changed, 4 insertions(+), 5 deletions(-)\n>\n> diff --git a/src/ipa/rkisp1/algorithms/lsc.cpp b/src/ipa/rkisp1/algorithms/lsc.cpp\n> index ab0ada4eed46..c581e6441853 100644\n> --- a/src/ipa/rkisp1/algorithms/lsc.cpp\n> +++ b/src/ipa/rkisp1/algorithms/lsc.cpp\n> @@ -33,11 +33,10 @@ template\n> void interpolateVector(const std::vector &a, const std::vector &b,\n> \t\t std::vector &dest, double lambda)\n> {\n> -\tassert(a.size() == b.size());\n> +\tASSERT(a.size() == b.size());\n> \tdest.resize(a.size());\n> -\tfor (size_t i = 0; i < a.size(); i++) {\n> +\tfor (size_t i = 0; i < a.size(); i++)\n> \t\tdest[i] = a[i] * (1.0 - lambda) + b[i] * lambda;\n> -\t}\n> }\n> \n> template<>\n> @@ -167,8 +166,8 @@ private:\n> \t\tdouble h = cropRectangle_.height / m;\n> \t\tstd::vector res;\n> \n> -\t\tassert(xSizes_.size() * 2 + 1 == k);\n> -\t\tassert(ySizes_.size() * 2 + 1 == k);\n> +\t\tASSERT(xSizes_.size() * 2 + 1 == k);\n> +\t\tASSERT(ySizes_.size() * 2 + 1 == k);\n> \n> \t\tres.reserve(k * k);\n> \nReviewed by Rui","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2C642BE080\n\tfor ;\n\tSat, 25 Oct 2025 13:55:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 711F1606B2;\n\tSat, 25 Oct 2025 15:55:12 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C1B6460697\n\tfor ;\n\tSat, 25 Oct 2025 15:55:11 +0200 (CEST)","from [192.168.31.114] (unknown [209.216.122.90])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0D2495B3\n\tfor ;\n\tSat, 25 Oct 2025 15:53:24 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"c+21hhMc\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1761400405;\n\tbh=OKwKygXjf8E0BOozTGx67GvYRt2bkmRz6BRzOYPuiVg=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=c+21hhMc8Z+ZjzPs9pd5sCAk7mpE7FHxgxBucOimrzSaFa3/wx82XWnHDE1YQ5PGH\n\tenieyoMnvSfWLS9VoAgIXPbX9SM1//E2IsZVB1NdzmIPasf6Q4QKMHJ9JMUJgl9m21\n\teDzOkJRhRs4zgYxieH1sMRPOgeiBrW1echATjeoQ=","Message-ID":"<44027dbb-cc2d-4526-b851-9c50536e3383@ideasonboard.com>","Date":"Sat, 25 Oct 2025 09:54:58 -0400","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v1 03/12] ipa: rkisp1: lsc: Replace assert with ASSERT","To":"libcamera-devel@lists.libcamera.org","References":"<20251014075252.2876485-1-stefan.klug@ideasonboard.com>\n\t<20251014075252.2876485-4-stefan.klug@ideasonboard.com>","Content-Language":"en-US","From":"rui wang ","In-Reply-To":"<20251014075252.2876485-4-stefan.klug@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":36499,"web_url":"https://patchwork.libcamera.org/comment/36499/","msgid":"","date":"2025-10-27T20:59:01","subject":"Re: [PATCH v1 03/12] ipa: rkisp1: lsc: Replace assert with ASSERT","submitter":{"id":241,"url":"https://patchwork.libcamera.org/api/people/241/","name":"Rui Wang","email":"rui.wang@ideasonboard.com"},"content":"On 2025-10-14 03:52, Stefan Klug wrote:\n> Replace assert() by ASSERT() and drop a set of unnecessary curly braces.\n> Those were noticed in the former review but after the series was\n> applied. Fix them now.\n>\n> Signed-off-by: Stefan Klug \n> ---\n> src/ipa/rkisp1/algorithms/lsc.cpp | 9 ++++-----\n> 1 file changed, 4 insertions(+), 5 deletions(-)\n>\n> diff --git a/src/ipa/rkisp1/algorithms/lsc.cpp b/src/ipa/rkisp1/algorithms/lsc.cpp\n> index ab0ada4eed46..c581e6441853 100644\n> --- a/src/ipa/rkisp1/algorithms/lsc.cpp\n> +++ b/src/ipa/rkisp1/algorithms/lsc.cpp\n> @@ -33,11 +33,10 @@ template\n> void interpolateVector(const std::vector &a, const std::vector &b,\n> \t\t std::vector &dest, double lambda)\n> {\n> -\tassert(a.size() == b.size());\n> +\tASSERT(a.size() == b.size());\n> \tdest.resize(a.size());\n> -\tfor (size_t i = 0; i < a.size(); i++) {\n> +\tfor (size_t i = 0; i < a.size(); i++)\n> \t\tdest[i] = a[i] * (1.0 - lambda) + b[i] * lambda;\n> -\t}\n> }\n> \n> template<>\n> @@ -167,8 +166,8 @@ private:\n> \t\tdouble h = cropRectangle_.height / m;\n> \t\tstd::vector res;\n> \n> -\t\tassert(xSizes_.size() * 2 + 1 == k);\n> -\t\tassert(ySizes_.size() * 2 + 1 == k);\n> +\t\tASSERT(xSizes_.size() * 2 + 1 == k);\n> +\t\tASSERT(ySizes_.size() * 2 + 1 == k);\n> \n> \t\tres.reserve(k * k);\n> \n\n\nReviewed-by: Rui Wang ","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0B555C3259\n\tfor ;\n\tMon, 27 Oct 2025 20:59:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 45D646077F;\n\tMon, 27 Oct 2025 21:59:16 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C5B3B6069A\n\tfor ;\n\tMon, 27 Oct 2025 21:59:14 +0100 (CET)","from [192.168.31.114] (unknown [209.216.122.90])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 63601E9B\n\tfor ;\n\tMon, 27 Oct 2025 21:57:26 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"IRhXU2c6\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1761598646;\n\tbh=Vtiws3dYCdWM7/UqOxl342ljRRZAieHmnz6lEEt4rUA=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=IRhXU2c64FNdwhHr/X4h/uVzilEdKPojOZi8OFX2sVx0kpILWTMz2WAHdNvYDcGqZ\n\tnAW7PHZIi51Pax54J5PgRx7GjbNfRwECRR5rVLhr4obQW+lGN0nXQuIxOPsuYrbfDA\n\tJdrgfr8IJlw0umSTDL+AwiCMeNsk14H0CMGEbzTA=","Message-ID":"","Date":"Mon, 27 Oct 2025 16:59:01 -0400","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v1 03/12] ipa: rkisp1: lsc: Replace assert with ASSERT","To":"libcamera-devel@lists.libcamera.org","References":"<20251014075252.2876485-1-stefan.klug@ideasonboard.com>\n\t<20251014075252.2876485-4-stefan.klug@ideasonboard.com>","Content-Language":"en-US","From":"rui wang ","In-Reply-To":"<20251014075252.2876485-4-stefan.klug@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]