[{"id":36236,"web_url":"https://patchwork.libcamera.org/comment/36236/","msgid":"<ff16091c-3b34-4953-b05a-3fce1d0a8f0f@ideasonboard.com>","date":"2025-10-14T08:12:51","subject":"Re: [PATCH v1 02/12] ipa: rkisp1: lsc: Drop unused function\n\tdeclaration","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2025. 10. 14. 9:52 keltezéssel, Stefan Klug írta:\n> The interpolateTable() function is not implemented anywhere. Drop the\n> declaration.\n> \n> Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\n> ---\n\nIt seems removed by you in a6adaa7283ce2ca22692a1d28b404a9ab15b59f0.\n\nReviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n\n\n>   src/ipa/rkisp1/algorithms/lsc.h | 3 ---\n>   1 file changed, 3 deletions(-)\n> \n> diff --git a/src/ipa/rkisp1/algorithms/lsc.h b/src/ipa/rkisp1/algorithms/lsc.h\n> index 0e3745d5589c..7b68dda1a0d4 100644\n> --- a/src/ipa/rkisp1/algorithms/lsc.h\n> +++ b/src/ipa/rkisp1/algorithms/lsc.h\n> @@ -39,9 +39,6 @@ public:\n>   private:\n>   \tvoid setParameters(rkisp1_cif_isp_lsc_config &config);\n>   \tvoid copyTable(rkisp1_cif_isp_lsc_config &config, const Components &set0);\n> -\tvoid interpolateTable(rkisp1_cif_isp_lsc_config &config,\n> -\t\t\t      const Components &set0, const Components &set1,\n> -\t\t\t      const uint32_t ct);\n>   \n>   \tipa::Interpolator<Components> sets_;\n>   \tstd::vector<double> xSize_;","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 27B02BF415\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 14 Oct 2025 08:12:56 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C891F605D0;\n\tTue, 14 Oct 2025 10:12:55 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8353460530\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 14 Oct 2025 10:12:54 +0200 (CEST)","from [192.168.33.20] (185.182.214.105.nat.pool.zt.hu\n\t[185.182.214.105])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3AFC3C73;\n\tTue, 14 Oct 2025 10:11:16 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"JyjT/BeT\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1760429476;\n\tbh=DICTldavt//e3Ru1xn9Rpask/zuc+Kf7mG/Vq+vSXj4=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=JyjT/BeTIH2uRlQaU1VKwUWtuxTc35T1torJnMSyW36LRQifFz2A4m8hNt80a5+Pz\n\tPAFb10AVjQgK1k9f79SjeoJwrNjY9vPJ1yRYAb3JDZYtWefvHseNg48e6/d8V31Fu0\n\tKbsr2EA7fayK3BeNSbQGItb73/bCbFQACSYzeFHM=","Message-ID":"<ff16091c-3b34-4953-b05a-3fce1d0a8f0f@ideasonboard.com>","Date":"Tue, 14 Oct 2025 10:12:51 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v1 02/12] ipa: rkisp1: lsc: Drop unused function\n\tdeclaration","To":"Stefan Klug <stefan.klug@ideasonboard.com>,\n\tlibcamera-devel@lists.libcamera.org","References":"<20251014075252.2876485-1-stefan.klug@ideasonboard.com>\n\t<20251014075252.2876485-3-stefan.klug@ideasonboard.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>","Content-Language":"en-US, hu-HU","In-Reply-To":"<20251014075252.2876485-3-stefan.klug@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":36241,"web_url":"https://patchwork.libcamera.org/comment/36241/","msgid":"<176043695693.2966332.12099520268617959681@localhost>","date":"2025-10-14T10:15:56","subject":"Re: [PATCH v1 02/12] ipa: rkisp1: lsc: Drop unused function\n\tdeclaration","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"content":"Hi,\n\nThank you for the review.\n\nQuoting Barnabás Pőcze (2025-10-14 10:12:51)\n> 2025. 10. 14. 9:52 keltezéssel, Stefan Klug írta:\n> > The interpolateTable() function is not implemented anywhere. Drop the\n> > declaration.\n> > \n> > Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\n> > ---\n> \n> It seems removed by you in a6adaa7283ce2ca22692a1d28b404a9ab15b59f0.\n\nI feared so :-)\n\n> \n> Reviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n\nThanks,\nStefan\n\n> \n> \n> >   src/ipa/rkisp1/algorithms/lsc.h | 3 ---\n> >   1 file changed, 3 deletions(-)\n> > \n> > diff --git a/src/ipa/rkisp1/algorithms/lsc.h b/src/ipa/rkisp1/algorithms/lsc.h\n> > index 0e3745d5589c..7b68dda1a0d4 100644\n> > --- a/src/ipa/rkisp1/algorithms/lsc.h\n> > +++ b/src/ipa/rkisp1/algorithms/lsc.h\n> > @@ -39,9 +39,6 @@ public:\n> >   private:\n> >       void setParameters(rkisp1_cif_isp_lsc_config &config);\n> >       void copyTable(rkisp1_cif_isp_lsc_config &config, const Components &set0);\n> > -     void interpolateTable(rkisp1_cif_isp_lsc_config &config,\n> > -                           const Components &set0, const Components &set1,\n> > -                           const uint32_t ct);\n> >   \n> >       ipa::Interpolator<Components> sets_;\n> >       std::vector<double> xSize_;\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 33698C3264\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 14 Oct 2025 10:16:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1B990605E4;\n\tTue, 14 Oct 2025 12:16:01 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B991060443\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 14 Oct 2025 12:15:59 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:61fb:8e55:ff1e:be62])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 5DCD1741;\n\tTue, 14 Oct 2025 12:14:21 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"MSG8q+zr\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1760436861;\n\tbh=0hVZv9B1GFShDB7x7xzBebr9Ism67uB4hrUJWasVAvA=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=MSG8q+zrdL5LovgRkmpxphuI0Plgd9rxHrIwPf2ajl/zyxVnFFWsps4EN1+8smT4M\n\tTuNH6+/6t/8F5vU5S5LDhGIWP3mzuZNfoCTg/6xt+jbeZdrZuvMziAXN2pyXFgv+Tc\n\tb2VsKuyK2A5nBrIcOTFVVAkv8u0MjfoGEv/kjIvs=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<ff16091c-3b34-4953-b05a-3fce1d0a8f0f@ideasonboard.com>","References":"<20251014075252.2876485-1-stefan.klug@ideasonboard.com>\n\t<20251014075252.2876485-3-stefan.klug@ideasonboard.com>\n\t<ff16091c-3b34-4953-b05a-3fce1d0a8f0f@ideasonboard.com>","Subject":"Re: [PATCH v1 02/12] ipa: rkisp1: lsc: Drop unused function\n\tdeclaration","From":"Stefan Klug <stefan.klug@ideasonboard.com>","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 14 Oct 2025 12:15:56 +0200","Message-ID":"<176043695693.2966332.12099520268617959681@localhost>","User-Agent":"alot/0.12.dev8+g2c003385c862.d20250602","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":36456,"web_url":"https://patchwork.libcamera.org/comment/36456/","msgid":"<7fc3a6d4-c3f3-4a73-b02b-2a47754bbc77@ideasonboard.com>","date":"2025-10-24T21:25:47","subject":"Re: [PATCH v1 02/12] ipa: rkisp1: lsc: Drop unused function\n\tdeclaration","submitter":{"id":241,"url":"https://patchwork.libcamera.org/api/people/241/","name":"Rui Wang","email":"rui.wang@ideasonboard.com"},"content":"On 2025-10-14 03:52, Stefan Klug wrote:\n> The interpolateTable() function is not implemented anywhere. Drop the \n> declaration. Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com> \n> --- src/ipa/rkisp1/algorithms/lsc.h | 3 --- 1 file changed, 3 \n> deletions(-) diff --git a/src/ipa/rkisp1/algorithms/lsc.h \n> b/src/ipa/rkisp1/algorithms/lsc.h index 0e3745d5589c..7b68dda1a0d4 \n> 100644 --- a/src/ipa/rkisp1/algorithms/lsc.h +++ \n> b/src/ipa/rkisp1/algorithms/lsc.h @@ -39,9 +39,6 @@ public: private: \n> void setParameters(rkisp1_cif_isp_lsc_config &config); void \n> copyTable(rkisp1_cif_isp_lsc_config &config, const Components &set0); \n> - void interpolateTable(rkisp1_cif_isp_lsc_config &config, - const \n> Components &set0, const Components &set1, - const uint32_t ct); \n> ipa::Interpolator<Components> sets_; std::vector<double> xSize_;\n\n\nReviewed by Rui.","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 009B6C3259\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 24 Oct 2025 21:26:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A8B77609E6;\n\tFri, 24 Oct 2025 23:26:01 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CB715609B1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 24 Oct 2025 23:25:59 +0200 (CEST)","from [192.168.31.114] (unknown [209.216.122.90])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BF3E6EFF\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 24 Oct 2025 23:24:13 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"SsKWtnHp\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1761341053;\n\tbh=y5rUuo0l+KwEu5zM5a+wPMeNy8TYeuqBdnnmo72NH14=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=SsKWtnHpVmgjaDfOVJBTfEyZNbFACUsyXPT0a/UPk48SrmKkk4IK2YdZM/XAXcIF5\n\tpPt/GXUzRi5oReE/uYMdJMiP3RavOSVf3bscf9VpdY0QVBCFuf4eXdOaCF4f+EC9x3\n\tteRFOFkCcANwgTD0ukxdt+Gen6t+HqAEOpJ+M41I=","Content-Type":"multipart/alternative;\n\tboundary=\"------------EjyUaYs6eqVZ0Od7zKyBP3J7\"","Message-ID":"<7fc3a6d4-c3f3-4a73-b02b-2a47754bbc77@ideasonboard.com>","Date":"Fri, 24 Oct 2025 17:25:47 -0400","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v1 02/12] ipa: rkisp1: lsc: Drop unused function\n\tdeclaration","To":"libcamera-devel@lists.libcamera.org","References":"<20251014075252.2876485-1-stefan.klug@ideasonboard.com>\n\t<20251014075252.2876485-3-stefan.klug@ideasonboard.com>","Content-Language":"en-US","From":"rui wang <rui.wang@ideasonboard.com>","In-Reply-To":"<20251014075252.2876485-3-stefan.klug@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":36457,"web_url":"https://patchwork.libcamera.org/comment/36457/","msgid":"<20251024222105.GC13023@pendragon.ideasonboard.com>","date":"2025-10-24T22:21:05","subject":"Re: [PATCH v1 02/12] ipa: rkisp1: lsc: Drop unused function\n\tdeclaration","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Rui,\n\nMails to the list should be in plain text, please disable HTML in your\nmail client for the libcamera-devel mailing list.\n\nOn Fri, Oct 24, 2025 at 05:25:47PM -0400, Rui Wang wrote:\n> \n> On 2025-10-14 03:52, Stefan Klug wrote:\n> \n>     The interpolateTable() function is not implemented anywhere. Drop the\n>     declaration.\n> \n>     Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\n>     ---\n>      src/ipa/rkisp1/algorithms/lsc.h | 3 ---\n>      1 file changed, 3 deletions(-)\n> \n>     diff --git a/src/ipa/rkisp1/algorithms/lsc.h b/src/ipa/rkisp1/algorithms/lsc.h\n>     index 0e3745d5589c..7b68dda1a0d4 100644\n>     --- a/src/ipa/rkisp1/algorithms/lsc.h\n>     +++ b/src/ipa/rkisp1/algorithms/lsc.h\n>     @@ -39,9 +39,6 @@ public:\n>      private:\n>             void setParameters(rkisp1_cif_isp_lsc_config &config);\n>             void copyTable(rkisp1_cif_isp_lsc_config &config, const Components &set0);\n>     -       void interpolateTable(rkisp1_cif_isp_lsc_config &config,\n>     -                             const Components &set0, const Components &set1,\n>     -                             const uint32_t ct);\n> \n>             ipa::Interpolator<Components> sets_;\n>             std::vector<double> xSize_;\n> \n> \n> Reviewed by Rui.\n\nThe right syntax is\n\nReviewed-by: Name <email address>\n\nto let tools such as 'git am', b4 or patchwork parse the tags correctly.\nWe broadly follow the Linux kernel process, you can find more\ninformation at https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst.","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EE57ABE080\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 24 Oct 2025 22:21:21 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1F1C160A7B;\n\tSat, 25 Oct 2025 00:21:21 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 80FC760875\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 25 Oct 2025 00:21:19 +0200 (CEST)","from pendragon.ideasonboard.com (82-203-161-16.bb.dnainternet.fi\n\t[82.203.161.16])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 648AC5B3;\n\tSat, 25 Oct 2025 00:19:33 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"WnuyLBz3\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1761344373;\n\tbh=v4zU9nyC7XrXeJng29Yeb8NEVaAtZ1EpRMdgdSZ+YzQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=WnuyLBz3pQx9HjKuz3t6+97kdJLn5pzBNKh6VgMNAYw8/iTjJjzy1eU43W+h73IvV\n\ticfOdtVqBmQWF+2RAya/eHc2Rg9lr4Gyc6j/8WWnRfG3rEBT1tghKH8CItap4mkUjH\n\tDomVG33fgh25W9vlMHO5lqH4a2P1DL+w1JYLAtIg=","Date":"Sat, 25 Oct 2025 01:21:05 +0300","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"rui wang <rui.wang@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v1 02/12] ipa: rkisp1: lsc: Drop unused function\n\tdeclaration","Message-ID":"<20251024222105.GC13023@pendragon.ideasonboard.com>","References":"<20251014075252.2876485-1-stefan.klug@ideasonboard.com>\n\t<20251014075252.2876485-3-stefan.klug@ideasonboard.com>\n\t<7fc3a6d4-c3f3-4a73-b02b-2a47754bbc77@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<7fc3a6d4-c3f3-4a73-b02b-2a47754bbc77@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":36507,"web_url":"https://patchwork.libcamera.org/comment/36507/","msgid":"<20251028092746.GA13023@pendragon.ideasonboard.com>","date":"2025-10-28T09:27:46","subject":"Re: [PATCH v1 02/12] ipa: rkisp1: lsc: Drop unused function\n\tdeclaration","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Tue, Oct 14, 2025 at 09:52:24AM +0200, Stefan Klug wrote:\n> The interpolateTable() function is not implemented anywhere. Drop the\n> declaration.\n> \n> Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n> ---\n>  src/ipa/rkisp1/algorithms/lsc.h | 3 ---\n>  1 file changed, 3 deletions(-)\n> \n> diff --git a/src/ipa/rkisp1/algorithms/lsc.h b/src/ipa/rkisp1/algorithms/lsc.h\n> index 0e3745d5589c..7b68dda1a0d4 100644\n> --- a/src/ipa/rkisp1/algorithms/lsc.h\n> +++ b/src/ipa/rkisp1/algorithms/lsc.h\n> @@ -39,9 +39,6 @@ public:\n>  private:\n>  \tvoid setParameters(rkisp1_cif_isp_lsc_config &config);\n>  \tvoid copyTable(rkisp1_cif_isp_lsc_config &config, const Components &set0);\n> -\tvoid interpolateTable(rkisp1_cif_isp_lsc_config &config,\n> -\t\t\t      const Components &set0, const Components &set1,\n> -\t\t\t      const uint32_t ct);\n>  \n>  \tipa::Interpolator<Components> sets_;\n>  \tstd::vector<double> xSize_;","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D8D10C3259\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 28 Oct 2025 09:28:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 91DD06079E;\n\tTue, 28 Oct 2025 10:28:01 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D3EA8603ED\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 28 Oct 2025 10:27:59 +0100 (CET)","from pendragon.ideasonboard.com (unknown [193.209.96.36])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 49D7816A7; \n\tTue, 28 Oct 2025 10:26:11 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"fTAdDOev\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1761643571;\n\tbh=5UWYby7o96tRsjp1EKW2G84pppI7GntZ481u7iorLcg=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=fTAdDOeva7n7U8hvMzloVkCnDT6YsiV6eqAyX04HeJo22GNMMPLgmXm0hUXmKzB4B\n\tfjNSxKvuQr3bqJwTGHTog78tBi1hL2UiTuoDKH6nsaVjWGqxNuzwWN2HIGDWZkgt6h\n\tlOPWJ3vfXiytB8Tk9o+SevR0jwcEMyG6xBWoUg3g=","Date":"Tue, 28 Oct 2025 11:27:46 +0200","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Stefan Klug <stefan.klug@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v1 02/12] ipa: rkisp1: lsc: Drop unused function\n\tdeclaration","Message-ID":"<20251028092746.GA13023@pendragon.ideasonboard.com>","References":"<20251014075252.2876485-1-stefan.klug@ideasonboard.com>\n\t<20251014075252.2876485-3-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20251014075252.2876485-3-stefan.klug@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]