[{"id":36234,"web_url":"https://patchwork.libcamera.org/comment/36234/","msgid":"","date":"2025-10-14T08:12:31","subject":"Re: [PATCH v1 01/12] ipa: rkisp1: lsc: Drop unused member variable","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2025. 10. 14. 9:52 keltezéssel, Stefan Klug írta:\n> The Components::ct member is not used anywhere. Drop it.\n> \n> Signed-off-by: Stefan Klug \n> ---\n\nReviewed-by: Barnabás Pőcze \n\n\n> src/ipa/rkisp1/algorithms/lsc.cpp | 2 --\n> src/ipa/rkisp1/algorithms/lsc.h | 1 -\n> 2 files changed, 3 deletions(-)\n> \n> diff --git a/src/ipa/rkisp1/algorithms/lsc.cpp b/src/ipa/rkisp1/algorithms/lsc.cpp\n> index e7301bfec863..ab0ada4eed46 100644\n> --- a/src/ipa/rkisp1/algorithms/lsc.cpp\n> +++ b/src/ipa/rkisp1/algorithms/lsc.cpp\n> @@ -113,7 +113,6 @@ public:\n> \t\t\t\treturn -EINVAL;\n> \t\t\t}\n> \n> -\t\t\tset.ct = ct;\n> \t\t\tpr->setReferenceImageSize(sensorSize_);\n> \t\t\tpgr->setReferenceImageSize(sensorSize_);\n> \t\t\tpgb->setReferenceImageSize(sensorSize_);\n> @@ -221,7 +220,6 @@ public:\n> \n> \t\t\tLensShadingCorrection::Components &set = lscData[ct];\n> \n> -\t\t\tset.ct = ct;\n> \t\t\tset.r = parseTable(yamlSet, \"r\");\n> \t\t\tset.gr = parseTable(yamlSet, \"gr\");\n> \t\t\tset.gb = parseTable(yamlSet, \"gb\");\n> diff --git a/src/ipa/rkisp1/algorithms/lsc.h b/src/ipa/rkisp1/algorithms/lsc.h\n> index 5a0824e36dd5..0e3745d5589c 100644\n> --- a/src/ipa/rkisp1/algorithms/lsc.h\n> +++ b/src/ipa/rkisp1/algorithms/lsc.h\n> @@ -30,7 +30,6 @@ public:\n> \t\t RkISP1Params *params) override;\n> \n> \tstruct Components {\n> -\t\tuint32_t ct;\n> \t\tstd::vector r;\n> \t\tstd::vector gr;\n> \t\tstd::vector gb;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 086C9BF415\n\tfor ;\n\tTue, 14 Oct 2025 08:12:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 142336054E;\n\tTue, 14 Oct 2025 10:12:37 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BEACC60316\n\tfor ;\n\tTue, 14 Oct 2025 10:12:34 +0200 (CEST)","from [192.168.33.20] (185.182.214.105.nat.pool.zt.hu\n\t[185.182.214.105])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7E103C73;\n\tTue, 14 Oct 2025 10:10:56 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"YwlzTFP4\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1760429456;\n\tbh=bombsdhiFFhq/DWlGt7aYY4OeQiHgJQ9Vn0NanGHFoQ=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=YwlzTFP4DQIIctqCV1po4fAcxnWQphQp97EBDbkaqtpaE21KX8IRyn5pk3nlm+pUB\n\tIoYHhRnfDEVFR/4RQrzth20yqIXARMS67DLs6eH6ruUdq2NNUM7W5cujWd1eAP5ekf\n\t6VF9PkACxA3DbOfZTZS+UtpQ9MfiNAdSv+MTk3x8=","Message-ID":"","Date":"Tue, 14 Oct 2025 10:12:31 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v1 01/12] ipa: rkisp1: lsc: Drop unused member variable","To":"Stefan Klug ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20251014075252.2876485-1-stefan.klug@ideasonboard.com>\n\t<20251014075252.2876485-2-stefan.klug@ideasonboard.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20251014075252.2876485-2-stefan.klug@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":36455,"web_url":"https://patchwork.libcamera.org/comment/36455/","msgid":"","date":"2025-10-24T21:19:46","subject":"Re: [PATCH v1 01/12] ipa: rkisp1: lsc: Drop unused member variable","submitter":{"id":241,"url":"https://patchwork.libcamera.org/api/people/241/","name":"Rui Wang","email":"rui.wang@ideasonboard.com"},"content":"On 2025-10-14 03:52, Stefan Klug wrote:\n> The Components::ct member is not used anywhere. Drop it. \n> Signed-off-by: Stefan Klug --- \n> src/ipa/rkisp1/algorithms/lsc.cpp | 2 -- \n> src/ipa/rkisp1/algorithms/lsc.h | 1 - 2 files changed, 3 deletions(-) \n> diff --git a/src/ipa/rkisp1/algorithms/lsc.cpp \n> b/src/ipa/rkisp1/algorithms/lsc.cpp index e7301bfec863..ab0ada4eed46 \n> 100644 --- a/src/ipa/rkisp1/algorithms/lsc.cpp +++ \n> b/src/ipa/rkisp1/algorithms/lsc.cpp @@ -113,7 +113,6 @@ public: return \n> -EINVAL; } - set.ct = ct; pr->setReferenceImageSize(sensorSize_); \n> pgr->setReferenceImageSize(sensorSize_); \n> pgb->setReferenceImageSize(sensorSize_); @@ -221,7 +220,6 @@ public: \n> LensShadingCorrection::Components &set = lscData[ct]; - set.ct = ct; \n> set.r = parseTable(yamlSet, \"r\"); set.gr = parseTable(yamlSet, \"gr\"); \n> set.gb = parseTable(yamlSet, \"gb\"); diff --git \n> a/src/ipa/rkisp1/algorithms/lsc.h b/src/ipa/rkisp1/algorithms/lsc.h \n> index 5a0824e36dd5..0e3745d5589c 100644 --- \n> a/src/ipa/rkisp1/algorithms/lsc.h +++ \n> b/src/ipa/rkisp1/algorithms/lsc.h @@ -30,7 +30,6 @@ public: \n> RkISP1Params *params) override; struct Components { - uint32_t ct; \n> std::vector r; std::vector gr; \n> std::vector gb;\n\n\nReviewd by Rui Wang","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 88CA4BE080\n\tfor ;\n\tFri, 24 Oct 2025 21:20:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9ED89609E0;\n\tFri, 24 Oct 2025 23:20:01 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6F2D1609B1\n\tfor ;\n\tFri, 24 Oct 2025 23:19:59 +0200 (CEST)","from [192.168.31.114] (unknown [209.216.122.90])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5D5D7EFF\n\tfor ;\n\tFri, 24 Oct 2025 23:18:13 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"aAfwaCnA\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1761340693;\n\tbh=J4qpXREJe++yiENijpuCnHw5Q6NdGSOjYuP6SwYuP/c=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=aAfwaCnA6BQDHs9oFoUnOkpJrpbEzkxhsr6b0vbQ705BGDirtPq34Sa4abjIcTKPf\n\tnjT3KAhC5t4LpCMJoaWaBCCC/1/Ee3rYLhtDSDnicCzcjGXPQKBNrMY5Aprg40R8uE\n\tF8fnWb0syXS5gTKoOrGRjE5Xsh7+o1qaExq7qqE4=","Content-Type":"multipart/alternative;\n\tboundary=\"------------udPKu4XV0ELyTRYM6fZNE0W5\"","Message-ID":"","Date":"Fri, 24 Oct 2025 17:19:46 -0400","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v1 01/12] ipa: rkisp1: lsc: Drop unused member variable","To":"libcamera-devel@lists.libcamera.org","References":"<20251014075252.2876485-1-stefan.klug@ideasonboard.com>\n\t<20251014075252.2876485-2-stefan.klug@ideasonboard.com>","Content-Language":"en-US","From":"rui wang ","In-Reply-To":"<20251014075252.2876485-2-stefan.klug@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":36497,"web_url":"https://patchwork.libcamera.org/comment/36497/","msgid":"<41093bc6-b0df-45e8-8b98-78c282a8f43b@ideasonboard.com>","date":"2025-10-27T20:53:58","subject":"Re: [PATCH v1 01/12] ipa: rkisp1: lsc: Drop unused member variable","submitter":{"id":241,"url":"https://patchwork.libcamera.org/api/people/241/","name":"Rui Wang","email":"rui.wang@ideasonboard.com"},"content":"On 2025-10-14 03:52, Stefan Klug wrote:\n> The Components::ct member is not used anywhere. Drop it.\n>\n> Signed-off-by: Stefan Klug \n> ---\n> src/ipa/rkisp1/algorithms/lsc.cpp | 2 --\n> src/ipa/rkisp1/algorithms/lsc.h | 1 -\n> 2 files changed, 3 deletions(-)\n>\n> diff --git a/src/ipa/rkisp1/algorithms/lsc.cpp b/src/ipa/rkisp1/algorithms/lsc.cpp\n> index e7301bfec863..ab0ada4eed46 100644\n> --- a/src/ipa/rkisp1/algorithms/lsc.cpp\n> +++ b/src/ipa/rkisp1/algorithms/lsc.cpp\n> @@ -113,7 +113,6 @@ public:\n> \t\t\t\treturn -EINVAL;\n> \t\t\t}\n> \n> -\t\t\tset.ct = ct;\n> \t\t\tpr->setReferenceImageSize(sensorSize_);\n> \t\t\tpgr->setReferenceImageSize(sensorSize_);\n> \t\t\tpgb->setReferenceImageSize(sensorSize_);\n> @@ -221,7 +220,6 @@ public:\n> \n> \t\t\tLensShadingCorrection::Components &set = lscData[ct];\n> \n> -\t\t\tset.ct = ct;\n> \t\t\tset.r = parseTable(yamlSet, \"r\");\n> \t\t\tset.gr = parseTable(yamlSet, \"gr\");\n> \t\t\tset.gb = parseTable(yamlSet, \"gb\");\n> diff --git a/src/ipa/rkisp1/algorithms/lsc.h b/src/ipa/rkisp1/algorithms/lsc.h\n> index 5a0824e36dd5..0e3745d5589c 100644\n> --- a/src/ipa/rkisp1/algorithms/lsc.h\n> +++ b/src/ipa/rkisp1/algorithms/lsc.h\n> @@ -30,7 +30,6 @@ public:\n> \t\t RkISP1Params *params) override;\n> \n> \tstruct Components {\n> -\t\tuint32_t ct;\n> \t\tstd::vector r;\n> \t\tstd::vector gr;\n> \t\tstd::vector gb;\n>\n> Reviewed-by: Rui Wang ","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 29FD8BE080\n\tfor ;\n\tMon, 27 Oct 2025 20:54:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AD1CB6077A;\n\tMon, 27 Oct 2025 21:54:12 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 263836069A\n\tfor ;\n\tMon, 27 Oct 2025 21:54:11 +0100 (CET)","from [192.168.31.114] (unknown [209.216.122.90])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BB162E9B\n\tfor ;\n\tMon, 27 Oct 2025 21:52:22 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ItbBRcLS\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1761598343;\n\tbh=GGf+jcwG5YRnzBq5aNm4IRsNXYNkU3JqKheSiChh5ZY=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=ItbBRcLSBuj/QvBx3G2Epg349v7i/+Uw6ntsV8B6FPx9P2Swn9m5sfZ2Cke4hnmlQ\n\tGLHfOGjjElfp5v0QNkgBsxtjYcqXC8D466FDU1gvr9Sj8waXdTgqpNqheWbxLuTJnK\n\ttxeCyEzzhxfMN/56BHEz98n+qeKDLn1owX7PirGM=","Message-ID":"<41093bc6-b0df-45e8-8b98-78c282a8f43b@ideasonboard.com>","Date":"Mon, 27 Oct 2025 16:53:58 -0400","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v1 01/12] ipa: rkisp1: lsc: Drop unused member variable","To":"libcamera-devel@lists.libcamera.org","References":"<20251014075252.2876485-1-stefan.klug@ideasonboard.com>\n\t<20251014075252.2876485-2-stefan.klug@ideasonboard.com>","Content-Language":"en-US","From":"rui wang ","In-Reply-To":"<20251014075252.2876485-2-stefan.klug@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":36498,"web_url":"https://patchwork.libcamera.org/comment/36498/","msgid":"","date":"2025-10-27T20:56:44","subject":"Re: [PATCH v1 01/12] ipa: rkisp1: lsc: Drop unused member variable","submitter":{"id":241,"url":"https://patchwork.libcamera.org/api/people/241/","name":"Rui Wang","email":"rui.wang@ideasonboard.com"},"content":"On 2025-10-14 03:52, Stefan Klug wrote:\n> The Components::ct member is not used anywhere. Drop it.\n>\n> Signed-off-by: Stefan Klug \n> ---\n> src/ipa/rkisp1/algorithms/lsc.cpp | 2 --\n> src/ipa/rkisp1/algorithms/lsc.h | 1 -\n> 2 files changed, 3 deletions(-)\n>\n> diff --git a/src/ipa/rkisp1/algorithms/lsc.cpp b/src/ipa/rkisp1/algorithms/lsc.cpp\n> index e7301bfec863..ab0ada4eed46 100644\n> --- a/src/ipa/rkisp1/algorithms/lsc.cpp\n> +++ b/src/ipa/rkisp1/algorithms/lsc.cpp\n> @@ -113,7 +113,6 @@ public:\n> \t\t\t\treturn -EINVAL;\n> \t\t\t}\n> \n> -\t\t\tset.ct = ct;\n> \t\t\tpr->setReferenceImageSize(sensorSize_);\n> \t\t\tpgr->setReferenceImageSize(sensorSize_);\n> \t\t\tpgb->setReferenceImageSize(sensorSize_);\n> @@ -221,7 +220,6 @@ public:\n> \n> \t\t\tLensShadingCorrection::Components &set = lscData[ct];\n> \n> -\t\t\tset.ct = ct;\n> \t\t\tset.r = parseTable(yamlSet, \"r\");\n> \t\t\tset.gr = parseTable(yamlSet, \"gr\");\n> \t\t\tset.gb = parseTable(yamlSet, \"gb\");\n> diff --git a/src/ipa/rkisp1/algorithms/lsc.h b/src/ipa/rkisp1/algorithms/lsc.h\n> index 5a0824e36dd5..0e3745d5589c 100644\n> --- a/src/ipa/rkisp1/algorithms/lsc.h\n> +++ b/src/ipa/rkisp1/algorithms/lsc.h\n> @@ -30,7 +30,6 @@ public:\n> \t\t RkISP1Params *params) override;\n> \n> \tstruct Components {\n> -\t\tuint32_t ct;\n> \t\tstd::vector r;\n> \t\tstd::vector gr;\n> \t\tstd::vector gb;\n\nReviewed-by: Rui Wang ","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 38788BE080\n\tfor ;\n\tMon, 27 Oct 2025 20:56:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8031F60770;\n\tMon, 27 Oct 2025 21:56:57 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B490D6069A\n\tfor ;\n\tMon, 27 Oct 2025 21:56:56 +0100 (CET)","from [192.168.31.114] (unknown [209.216.122.90])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8B2548BC\n\tfor ;\n\tMon, 27 Oct 2025 21:55:08 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"IyGA4q21\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1761598508;\n\tbh=SRmCkYjF78/J939wa9ZStzID2HOc3gDP/qUyap3E3kI=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=IyGA4q21zsIIExDI8dbdZJ5XvotuFaQ4tsSpNR/vaCWzWUr0sYfztDvdA/q2e3z2z\n\tm0J5fQP7JMrnV3YUsPIKmwZDbb39ePbvHGrCMJ7o40EenV9Kf6RxqlppBGgm3NSLK1\n\tVaR3QMOIgTCyWdaAIswATGKbXNsNaHi1w+uwCSiM=","Message-ID":"","Date":"Mon, 27 Oct 2025 16:56:44 -0400","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v1 01/12] ipa: rkisp1: lsc: Drop unused member variable","To":"libcamera-devel@lists.libcamera.org","References":"<20251014075252.2876485-1-stefan.klug@ideasonboard.com>\n\t<20251014075252.2876485-2-stefan.klug@ideasonboard.com>","Content-Language":"en-US","From":"rui wang ","In-Reply-To":"<20251014075252.2876485-2-stefan.klug@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]