{"id":24617,"url":"https://patchwork.libcamera.org/api/patches/24617/?format=json","web_url":"https://patchwork.libcamera.org/patch/24617/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251014075252.2876485-2-stefan.klug@ideasonboard.com>","date":"2025-10-14T07:52:23","name":"[v1,01/12] ipa: rkisp1: lsc: Drop unused member variable","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"39d85ad1e3b9c1d40cca1731917279650380e2c9","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24617/mbox/","series":[{"id":5498,"url":"https://patchwork.libcamera.org/api/series/5498/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5498","date":"2025-10-14T07:52:22","name":"Add resampling support for polynomial LSC data","version":1,"mbox":"https://patchwork.libcamera.org/series/5498/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24617/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24617/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 65522BF415\n\tfor ;\n\tTue, 14 Oct 2025 07:53:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1759960580;\n\tTue, 14 Oct 2025 09:53:02 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5D9AF60316\n\tfor ;\n\tTue, 14 Oct 2025 09:53:01 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:61fb:8e55:ff1e:be62])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 13D13C73;\n\tTue, 14 Oct 2025 09:51:23 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"nAj7EOVQ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1760428283;\n\tbh=NY4t52LW7OV3tZg/BUnq/jRegL5QfDM5Iu0/WOHoxt4=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=nAj7EOVQFLsHlc0dL2hUZQOhFFSXSy3IcVVoDTdc+oPj3V26IEGzrRI/B5gLEV+kl\n\tNAFqCYhg3OWvPGeWIASVGePxlgCM5yULv72uCPY8jvFl+QcM4MWnCn0By0AWHUa+hy\n\t5b8CCxWG0mmDgnT3UODrOXh5om8szcqsRT8jYHqY=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ","Subject":"[PATCH v1 01/12] ipa: rkisp1: lsc: Drop unused member variable","Date":"Tue, 14 Oct 2025 09:52:23 +0200","Message-ID":"<20251014075252.2876485-2-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.48.1","In-Reply-To":"<20251014075252.2876485-1-stefan.klug@ideasonboard.com>","References":"<20251014075252.2876485-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The Components::ct member is not used anywhere. Drop it.\n\nSigned-off-by: Stefan Klug \n---\n src/ipa/rkisp1/algorithms/lsc.cpp | 2 --\n src/ipa/rkisp1/algorithms/lsc.h | 1 -\n 2 files changed, 3 deletions(-)","diff":"diff --git a/src/ipa/rkisp1/algorithms/lsc.cpp b/src/ipa/rkisp1/algorithms/lsc.cpp\nindex e7301bfec863..ab0ada4eed46 100644\n--- a/src/ipa/rkisp1/algorithms/lsc.cpp\n+++ b/src/ipa/rkisp1/algorithms/lsc.cpp\n@@ -113,7 +113,6 @@ public:\n \t\t\t\treturn -EINVAL;\n \t\t\t}\n \n-\t\t\tset.ct = ct;\n \t\t\tpr->setReferenceImageSize(sensorSize_);\n \t\t\tpgr->setReferenceImageSize(sensorSize_);\n \t\t\tpgb->setReferenceImageSize(sensorSize_);\n@@ -221,7 +220,6 @@ public:\n \n \t\t\tLensShadingCorrection::Components &set = lscData[ct];\n \n-\t\t\tset.ct = ct;\n \t\t\tset.r = parseTable(yamlSet, \"r\");\n \t\t\tset.gr = parseTable(yamlSet, \"gr\");\n \t\t\tset.gb = parseTable(yamlSet, \"gb\");\ndiff --git a/src/ipa/rkisp1/algorithms/lsc.h b/src/ipa/rkisp1/algorithms/lsc.h\nindex 5a0824e36dd5..0e3745d5589c 100644\n--- a/src/ipa/rkisp1/algorithms/lsc.h\n+++ b/src/ipa/rkisp1/algorithms/lsc.h\n@@ -30,7 +30,6 @@ public:\n \t\t RkISP1Params *params) override;\n \n \tstruct Components {\n-\t\tuint32_t ct;\n \t\tstd::vector r;\n \t\tstd::vector gr;\n \t\tstd::vector gb;\n","prefixes":["v1","01/12"]}