{"id":24607,"url":"https://patchwork.libcamera.org/api/patches/24607/?format=json","web_url":"https://patchwork.libcamera.org/patch/24607/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251013063132.89521-8-uajain@igalia.com>","date":"2025-10-13T06:31:32","name":"[v2,3/3] gstreamer: Improve logging for buffer pool activation","commit_ref":null,"pull_url":null,"state":"rejected","archived":false,"hash":"228460638239fca10565514251434254eecded2f","submitter":{"id":232,"url":"https://patchwork.libcamera.org/api/people/232/?format=json","name":"Umang Jain","email":"uajain@igalia.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24607/mbox/","series":[{"id":5492,"url":"https://patchwork.libcamera.org/api/series/5492/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5492","date":"2025-10-13T06:31:32","name":null,"version":2,"mbox":"https://patchwork.libcamera.org/series/5492/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24607/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24607/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 16176BE080\n\tfor ;\n\tMon, 13 Oct 2025 06:31:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AFA0B60470;\n\tMon, 13 Oct 2025 08:31:34 +0200 (CEST)","from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6F3F66046E\n\tfor ;\n\tMon, 13 Oct 2025 08:31:33 +0200 (CEST)","from [49.36.127.56] (helo=uajain)\n\tby fanzine2.igalia.com with esmtpsa \n\t(Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256)\n\t(Exim) id 1v8C5k-008oQ5-9n; Mon, 13 Oct 2025 08:31:32 +0200"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=igalia.com header.i=@igalia.com\n\theader.b=\"BvUJ10of\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;\n\ts=20170329;\n\th=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:\n\tMessage-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID:\n\tContent-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc\n\t:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:\n\tList-Post:List-Owner:List-Archive;\n\tbh=ZVKL58T9bvVnSUeAwCdECV612uFHvtauHHtjmYzpxhs=;\n\tb=BvUJ10of7EVdJ+Kcy+79t8wJvC\n\t+fjUzuAiEHScwREk0pyb8TnE0tJz5XmtNboT7ShCAZmliojZl+fWJsEzLH8O9i2SS6zRLXacqkILO\n\tQPpucdCn8UmAd8+ELFA6mKAQMUiuISMUl3mKdt+IvQJoMyu/lYf8rpZbgZNiI8HROt3Lfsw1VY/P4\n\thvpOo0p6yv230oebW5wmGfpLDzUEjEytwzOX3AdTTHCMd9SJ00XdlqVFKPkezONUrlKrn2aABbYSP\n\t0wqPKdw4O2EdT8HjtdxM9L2hZEpSZfH/E6rb324gurIiqwsIg9K19aYphw/HebJfiFO9DW87vunit\n\tf3CoEwJg==;","From":"Umang Jain ","To":"libcamera-devel@lists.libcamera.org","Cc":"Nicolas Dufresne ,\n\tUmang Jain ","Subject":"[PATCH v2 3/3] gstreamer: Improve logging for buffer pool activation","Date":"Mon, 13 Oct 2025 12:01:32 +0530","Message-ID":"<20251013063132.89521-8-uajain@igalia.com>","X-Mailer":"git-send-email 2.51.0","In-Reply-To":"<20251013063132.89521-1-uajain@igalia.com>","References":"<20251013063132.89521-1-uajain@igalia.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"If the negotiation is going to fail, log the GST_ELEMENT_ERROR in\ngst_libcamera_src_negotiate(), instead of logging in downstream method\nchain.\n\nSigned-off-by: Umang Jain \nReviewed-by: Nicolas Dufresne \n---\n src/gstreamer/gstlibcamerasrc.cpp | 10 ++++++----\n 1 file changed, 6 insertions(+), 4 deletions(-)","diff":"diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp\nindex 07bb6b2f..75e0864c 100644\n--- a/src/gstreamer/gstlibcamerasrc.cpp\n+++ b/src/gstreamer/gstlibcamerasrc.cpp\n@@ -581,9 +581,7 @@ gst_libcamera_create_video_pool(GstLibcameraSrc *self, GstPad *srcpad,\n \t}\n \n \tif (!gst_buffer_pool_set_active(pool, true)) {\n-\t\tGST_ELEMENT_ERROR(self, RESOURCE, SETTINGS,\n-\t\t\t\t (\"Failed to active buffer pool\"),\n-\t\t\t\t (\"gst_libcamera_src_negotiate() failed.\"));\n+\t\tGST_ERROR(\"Failed to activate buffer pool\");\n \t\treturn { nullptr, -EINVAL };\n \t}\n \n@@ -686,8 +684,12 @@ gst_libcamera_src_negotiate(GstLibcameraSrc *self)\n \t\t\tstd::tie(video_pool, ret) =\n \t\t\t\tgst_libcamera_create_video_pool(self, srcpad,\n \t\t\t\t\t\t\t\tcaps, &info);\n-\t\t\tif (ret)\n+\t\t\tif (ret) {\n+\t\t\t\tGST_ELEMENT_ERROR(self, RESOURCE, SETTINGS,\n+\t\t\t\t\t\t (\"Failed to create video pool: %s\", g_strerror(-ret)),\n+\t\t\t\t\t\t (\"gst_libcamera_src_negotiate() failed.\"));\n \t\t\t\treturn false;\n+\t\t\t}\n \t\t}\n \n \t\tGstLibcameraPool *pool = gst_libcamera_pool_new(self->allocator,\n","prefixes":["v2","3/3"]}