[{"id":36209,"web_url":"https://patchwork.libcamera.org/comment/36209/","msgid":"<176027998086.935713.14840869203777636223@ping.linuxembedded.co.uk>","date":"2025-10-12T14:39:40","subject":"Re: [PATCH v5 2/3] pipeline: simple: Increase internal buffers for\n\tsoftware ISP to 4","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Robert Mader (2025-10-12 15:20:51)\n> The Simple Pipeline handler supports a variety of hardware with\n> different capabilities and performances.\n> \n> To improve performance and reliability of the cameras across the\n> supported range, increase the number of internal buffers to 4.\n> \n> This allows lower performance devices more opportunity to process the\n> frames and increases stability.\n> \n> Align the Simple Pipeline handler and Soft ISP buffering with the other\n> hardware based platforms and use 4 internal buffers.\n> \n> Signed-off-by: Robert Mader \n> Reviewed-by: Milan Zamazal \n\nReviewed-by: Kieran Bingham \n\n> \n> ---\n> \n> This has been applied in postmarketOS since Oct 2024 and has fixed issues\n> reported by users.\n> ---\n> src/libcamera/pipeline/simple/simple.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n> index 6e8271346..6a2ffe624 100644\n> --- a/src/libcamera/pipeline/simple/simple.cpp\n> +++ b/src/libcamera/pipeline/simple/simple.cpp\n> @@ -418,7 +418,7 @@ protected:\n> \n> private:\n> static constexpr unsigned int kMaxQueuedRequestsDevice = 4;\n> - static constexpr unsigned int kNumInternalBuffers = 3;\n> + static constexpr unsigned int kNumInternalBuffers = 4;\n> \n> struct EntityData {\n> std::unique_ptr video;\n> -- \n> 2.51.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D5C17BF415\n\tfor ;\n\tSun, 12 Oct 2025 14:39:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 292A560456;\n\tSun, 12 Oct 2025 16:39:45 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 25C5F603ED\n\tfor ;\n\tSun, 12 Oct 2025 16:39:44 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1B41329A;\n\tSun, 12 Oct 2025 16:38:07 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"mL7l7G25\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1760279887;\n\tbh=J6SUy5tSq9pi0lcsS9o5qz1nFHhdqjKFz6t3XHY8d5Y=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=mL7l7G25nUpz/c/kWsa/hYtad5OIjD6rHBUV8JbrCSQrmu5Ntl5KzPqVGIDgZ4/Ti\n\t2moZ2hem07SX6GhUdmbnggV2GXnP1uEdQS1wGDoBI+3PTYPH8mrsG/0vxozZ9yNBwa\n\txC7fRtN4X4ymNUx657j8I/AzQ/yUcU5e2XeNwk28=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20251012142052.90611-3-robert.mader@collabora.com>","References":"<20251012142052.90611-1-robert.mader@collabora.com>\n\t<20251012142052.90611-3-robert.mader@collabora.com>","Subject":"Re: [PATCH v5 2/3] pipeline: simple: Increase internal buffers for\n\tsoftware ISP to 4","From":"Kieran Bingham ","Cc":"Robert Mader ,\n\tMilan Zamazal ","To":"Robert Mader ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Sun, 12 Oct 2025 15:39:40 +0100","Message-ID":"<176027998086.935713.14840869203777636223@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]