[{"id":36199,"web_url":"https://patchwork.libcamera.org/comment/36199/","msgid":"<99b42deff81ceab0a9b44e65ae615df602c6ac9e.camel@collabora.com>","date":"2025-10-10T15:33:51","subject":"Re: [PATCH 3/3] gstreamer: Improve logging for buffer pool\n\tactivation","submitter":{"id":31,"url":"https://patchwork.libcamera.org/api/people/31/","name":"Nicolas Dufresne","email":"nicolas.dufresne@collabora.com"},"content":"Hi,\n\nLe vendredi 10 octobre 2025 à 19:48 +0530, Umang Jain a écrit :\n> If the negotiation is going to fail, log the GST_ELEMENT_ERROR in\n> gst_libcamera_src_negotiate(), instead of logging in downstream method\n> chain.\n> \n> Signed-off-by: Umang Jain \n\nReviewed-by: Nicolas Dufresne \n\nbr,\nNicolas\n\n> ---\n>  src/gstreamer/gstlibcamerasrc.cpp | 10 ++++++----\n>  1 file changed, 6 insertions(+), 4 deletions(-)\n> \n> diff --git a/src/gstreamer/gstlibcamerasrc.cpp\n> b/src/gstreamer/gstlibcamerasrc.cpp\n> index a5dbdfd4..5a1b2676 100644\n> --- a/src/gstreamer/gstlibcamerasrc.cpp\n> +++ b/src/gstreamer/gstlibcamerasrc.cpp\n> @@ -581,9 +581,7 @@ gst_libcamera_create_video_pool(GstLibcameraSrc *self,\n> GstPad *srcpad,\n>  \t}\n>  \n>  \tif (!gst_buffer_pool_set_active(pool, true)) {\n> -\t\tGST_ELEMENT_ERROR(self, RESOURCE, SETTINGS,\n> -\t\t\t\t  (\"Failed to active buffer pool\"),\n> -\t\t\t\t  (\"gst_libcamera_src_negotiate() failed.\"));\n> +\t\tGST_ERROR(\"Failed to activate buffer pool\");\n>  \t\treturn { nullptr, -EINVAL };\n>  \t}\n>  \n> @@ -686,8 +684,12 @@ gst_libcamera_src_negotiate(GstLibcameraSrc *self)\n>  \t\t\tstd::tie(video_pool, ret) =\n>  \t\t\t\tgst_libcamera_create_video_pool(self, srcpad,\n>  \t\t\t\t\t\t\t\tcaps, &info);\n> -\t\t\tif (ret)\n> +\t\t\tif (ret) {\n> +\t\t\t\tGST_ELEMENT_ERROR(self, RESOURCE, SETTINGS,\n> +\t\t\t\t\t\t  (\"Failed to create video\n> pool: %s\", g_strerror(-ret)),\n> +\t\t\t\t\t\t \n> (\"gst_libcamera_src_negotiate() failed.\"));\n>  \t\t\t\treturn false;\n> +\t\t\t}\n>  \t\t}\n>  \n>  \t\tGstLibcameraPool *pool = gst_libcamera_pool_new(self-\n> >allocator,","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 374CCBE080\n\tfor ;\n\tFri, 10 Oct 2025 15:33:56 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A41076B5C4;\n\tFri, 10 Oct 2025 17:33:55 +0200 (CEST)","from bali.collaboradmins.com (bali.collaboradmins.com\n\t[148.251.105.195])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D86526B599\n\tfor ;\n\tFri, 10 Oct 2025 17:33:53 +0200 (CEST)","from [IPv6:2606:6d00:17:ebd3::c41] (unknown\n\t[IPv6:2606:6d00:17:ebd3::c41])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (4096 bits)\n\tserver-digest SHA256)\n\t(No client certificate requested) (Authenticated sender: nicolas)\n\tby bali.collaboradmins.com (Postfix) with ESMTPSA id F3B7117E1272;\n\tFri, 10 Oct 2025 17:33:52 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=collabora.com header.i=@collabora.com\n\theader.b=\"cfMbXIfk\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com;\n\ts=mail; t=1760110433;\n\tbh=CeiMBwI50opZCAj5F/ThL47EgGH0YMt0fku61Avkstg=;\n\th=Subject:From:To:Date:In-Reply-To:References:From;\n\tb=cfMbXIfkVGB6R6NMtg5Y7oeOqKuz1oD79+/aAFkkLxp9ogl5ycNs/0M7D61+RwASr\n\tStfqKw1maxhsY/GywojYruE/Jbld4RYlNMYGxns+whGOqhd17yPQVgG23tuoaD1iOd\n\t4jh0+THyDxYMNmnxofnQJlFLpwnsuyx7W20QoiW8R1nmK7AXjqbB9zrGMAO3sB+FYV\n\tIfjFEgyWrAm+TtPE2ls3EW17GFJ6oxYC5im/nQHnFJ+5Ra4XemWxInhbvQYXSJVRGJ\n\tMs99xoTklG9T72AlWOaSPxgK/AV+lvRbe6z276Y+36PxgzS/cJT/vNfTMEW8HJa2k5\n\tNuRq0NBCbNtLw==","Message-ID":"<99b42deff81ceab0a9b44e65ae615df602c6ac9e.camel@collabora.com>","Subject":"Re: [PATCH 3/3] gstreamer: Improve logging for buffer pool\n\tactivation","From":"Nicolas Dufresne ","To":"Umang Jain , libcamera-devel@lists.libcamera.org","Date":"Fri, 10 Oct 2025 11:33:51 -0400","In-Reply-To":"<20251010141826.42995-4-uajain@igalia.com>","References":"<20251010141826.42995-1-uajain@igalia.com>\n\t<20251010141826.42995-4-uajain@igalia.com>","Autocrypt":"addr=nicolas.dufresne@collabora.com; prefer-encrypt=mutual;\n\tkeydata=mDMEaCN2ixYJKwYBBAHaRw8BAQdAM0EHepTful3JOIzcPv6ekHOenE1u0vDG1gdHFrChD\n\t/e0J05pY29sYXMgRHVmcmVzbmUgPG5pY29sYXNAbmR1ZnJlc25lLmNhPoicBBMWCgBEAhsDBQsJCA\n\tcCAiICBhUKCQgLAgQWAgMBAh4HAheABQkJZfd1FiEE7w1SgRXEw8IaBG8S2UGUUSlgcvQFAmibrjo\n\tCGQEACgkQ2UGUUSlgcvQlQwD/RjpU1SZYcKG6pnfnQ8ivgtTkGDRUJ8gP3fK7+XUjRNIA/iXfhXMN\n\tabIWxO2oCXKf3TdD7aQ4070KO6zSxIcxgNQFtDFOaWNvbGFzIER1ZnJlc25lIDxuaWNvbGFzLmR1Z\n\tnJlc25lQGNvbGxhYm9yYS5jb20+iJkEExYKAEECGwMFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4\n\tAWIQTvDVKBFcTDwhoEbxLZQZRRKWBy9AUCaCyyxgUJCWX3dQAKCRDZQZRRKWBy9ARJAP96pFmLffZ\n\tsmBUpkyVBfFAf+zq6BJt769R0al3kHvUKdgD9G7KAHuioxD2v6SX7idpIazjzx8b8rfzwTWyOQWHC\n\tAAS0LU5pY29sYXMgRHVmcmVzbmUgPG5pY29sYXMuZHVmcmVzbmVAZ21haWwuY29tPoiZBBMWCgBBF\n\tiEE7w1SgRXEw8IaBG8S2UGUUSlgcvQFAmibrGYCGwMFCQll93UFCwkIBwICIgIGFQoJCAsCBBYCAw\n\tECHgcCF4AACgkQ2UGUUSlgcvRObgD/YnQjfi4+L8f4fI7p1pPMTwRTcaRdy6aqkKEmKsCArzQBAK8\n\tbRLv9QjuqsE6oQZra/RB4widZPvphs78H0P6NmpIJ","Organization":"Collabora Canada","Content-Type":"multipart/signed; micalg=\"pgp-sha512\";\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"=-NBsNpx8jIObN2owg2XP9\"","User-Agent":"Evolution 3.56.2 (3.56.2-2.fc42) ","MIME-Version":"1.0","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]