[{"id":36197,"web_url":"https://patchwork.libcamera.org/comment/36197/","msgid":"","date":"2025-10-10T15:29:39","subject":"Re: [PATCH 1/3] gstreamer: Shorten function name","submitter":{"id":31,"url":"https://patchwork.libcamera.org/api/people/31/","name":"Nicolas Dufresne","email":"nicolas.dufresne@collabora.com"},"content":"Hi,\n\nLe vendredi 10 octobre 2025 à 19:48 +0530, Umang Jain a écrit :\n> Shorten the following utility function name:\n> \tgst_libcamera_stream_configuration_to_caps()\n> to\n> \tgst_libcamera_stream_cfg_to_caps()\n> \n> Comestic fix only for slight readability enhancement.\n\nAs you can see, I'm not an acronym kind of person, but I guess if you made the\neffort to patch it, its because it bothers you enough :-D\n\nReviewed-by: Nicolas Dufresne \n\n> \n> Signed-off-by: Umang Jain \n> ---\n>  src/gstreamer/gstlibcamera-utils.cpp | 4 ++--\n>  src/gstreamer/gstlibcamera-utils.h   | 4 ++--\n>  src/gstreamer/gstlibcamerasrc.cpp    | 4 ++--\n>  3 files changed, 6 insertions(+), 6 deletions(-)\n> \n> diff --git a/src/gstreamer/gstlibcamera-utils.cpp b/src/gstreamer/gstlibcamera-utils.cpp\n> index bfb094c9..09f274b5 100644\n> --- a/src/gstreamer/gstlibcamera-utils.cpp\n> +++ b/src/gstreamer/gstlibcamera-utils.cpp\n> @@ -408,8 +408,8 @@ gst_libcamera_stream_formats_to_caps(const StreamFormats &formats)\n>  }\n>  \n>  GstCaps *\n> -gst_libcamera_stream_configuration_to_caps(const StreamConfiguration &stream_cfg,\n> -\t\t\t\t\t   GstVideoTransferFunction transfer)\n> +gst_libcamera_stream_cfg_to_caps(const StreamConfiguration &stream_cfg,\n> +\t\t\t\t GstVideoTransferFunction transfer)\n>  {\n>  \tGstCaps *caps = gst_caps_new_empty();\n>  \tGstStructure *s = bare_structure_from_format(stream_cfg.pixelFormat);\n> diff --git a/src/gstreamer/gstlibcamera-utils.h b/src/gstreamer/gstlibcamera-utils.h\n> index 35df56fb..06ea9289 100644\n> --- a/src/gstreamer/gstlibcamera-utils.h\n> +++ b/src/gstreamer/gstlibcamera-utils.h\n> @@ -16,8 +16,8 @@\n>  #include \n>  \n>  GstCaps *gst_libcamera_stream_formats_to_caps(const libcamera::StreamFormats &formats);\n> -GstCaps *gst_libcamera_stream_configuration_to_caps(const libcamera::StreamConfiguration &stream_cfg,\n> -\t\t\t\t\t\t    GstVideoTransferFunction transfer);\n> +GstCaps *gst_libcamera_stream_cfg_to_caps(const libcamera::StreamConfiguration &stream_cfg,\n> +\t\t\t\t\t  GstVideoTransferFunction transfer);\n>  void gst_libcamera_configure_stream_from_caps(libcamera::StreamConfiguration &stream_cfg,\n>  \t\t\t\t\t      GstCaps *caps, GstVideoTransferFunction *transfer);\n>  void gst_libcamera_get_framerate_from_caps(GstCaps *caps, GstStructure *element_caps);\n> diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp\n> index 79a025a5..9ff90d9a 100644\n> --- a/src/gstreamer/gstlibcamerasrc.cpp\n> +++ b/src/gstreamer/gstlibcamerasrc.cpp\n> @@ -645,7 +645,7 @@ gst_libcamera_src_negotiate(GstLibcameraSrc *self)\n>  \t\tGstPad *srcpad = state->srcpads_[i];\n>  \t\tconst StreamConfiguration &stream_cfg = state->config_->at(i);\n>  \n> -\t\tg_autoptr(GstCaps) caps = gst_libcamera_stream_configuration_to_caps(stream_cfg, transfer[i]);\n> +\t\tg_autoptr(GstCaps) caps = gst_libcamera_stream_cfg_to_caps(stream_cfg, transfer[i]);\n>  \t\tgst_libcamera_framerate_to_caps(caps, element_caps);\n>  \n>  \t\tif (status == CameraConfiguration::Adjusted &&\n> @@ -673,7 +673,7 @@ gst_libcamera_src_negotiate(GstLibcameraSrc *self)\n>  \t\tGstBufferPool *video_pool = nullptr;\n>  \t\tGstVideoInfo info;\n>  \n> -\t\tg_autoptr(GstCaps) caps = gst_libcamera_stream_configuration_to_caps(stream_cfg, transfer[i]);\n> +\t\tg_autoptr(GstCaps) caps = gst_libcamera_stream_cfg_to_caps(stream_cfg, transfer[i]);\n>  \n>  \t\tgst_video_info_from_caps(&info, caps);\n>  \t\tgst_libcamera_pad_set_video_info(srcpad, &info);","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D6A20BE080\n\tfor ;\n\tFri, 10 Oct 2025 15:29:44 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F2B0C6B60E;\n\tFri, 10 Oct 2025 17:29:43 +0200 (CEST)","from bali.collaboradmins.com (bali.collaboradmins.com\n\t[IPv6:2a01:4f8:201:9162::2])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3B1B26B599\n\tfor ;\n\tFri, 10 Oct 2025 17:29:42 +0200 (CEST)","from [IPv6:2606:6d00:17:ebd3::c41] (unknown\n\t[IPv6:2606:6d00:17:ebd3::c41])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (4096 bits))\n\t(No client certificate requested) (Authenticated sender: nicolas)\n\tby bali.collaboradmins.com (Postfix) with ESMTPSA id 351AC17E0CF8;\n\tFri, 10 Oct 2025 17:29:41 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=collabora.com header.i=@collabora.com\n\theader.b=\"qE+gtvO/\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com;\n\ts=mail; t=1760110181;\n\tbh=IWPnOJ/MjMy19Y+BSnCbunEw6j+o3wGDgWhqgqbEC3Y=;\n\th=Subject:From:To:Date:In-Reply-To:References:From;\n\tb=qE+gtvO/Zm6EuJ7OybZnR4lgHDNPl4wQ8fU7KUOp8YpRxD0fXjvsAWQw+lKCAxxSI\n\tmjPiSvklqkvcU5cbTyjSDASxlFgDp8XpoiKQU9XbjvZHvfOWewJGpzltUiZucdsT38\n\tLorxx8BaykfvJAykqfIij33OTMwqYxHxn3gfER2Gdu2+DSDKRr6zCNcvAAZT0yXaek\n\tc/j967PeHjr8ft4taiutqXwwGb2MOFNn3BJR7Nj5prin5JqC6S504Pd3TQpKX1idHQ\n\tjU92chaiigh5fBEWPNgHKT+8ryyXMa1k+oVOE+7sy7V1rUjnHYxUbDe2gLMkQXq4Ia\n\tAA40QfWlrwK/g==","Message-ID":"","Subject":"Re: [PATCH 1/3] gstreamer: Shorten function name","From":"Nicolas Dufresne ","To":"Umang Jain , libcamera-devel@lists.libcamera.org","Date":"Fri, 10 Oct 2025 11:29:39 -0400","In-Reply-To":"<20251010141826.42995-2-uajain@igalia.com>","References":"<20251010141826.42995-1-uajain@igalia.com>\n\t<20251010141826.42995-2-uajain@igalia.com>","Autocrypt":"addr=nicolas.dufresne@collabora.com; prefer-encrypt=mutual;\n\tkeydata=mDMEaCN2ixYJKwYBBAHaRw8BAQdAM0EHepTful3JOIzcPv6ekHOenE1u0vDG1gdHFrChD\n\t/e0J05pY29sYXMgRHVmcmVzbmUgPG5pY29sYXNAbmR1ZnJlc25lLmNhPoicBBMWCgBEAhsDBQsJCA\n\tcCAiICBhUKCQgLAgQWAgMBAh4HAheABQkJZfd1FiEE7w1SgRXEw8IaBG8S2UGUUSlgcvQFAmibrjo\n\tCGQEACgkQ2UGUUSlgcvQlQwD/RjpU1SZYcKG6pnfnQ8ivgtTkGDRUJ8gP3fK7+XUjRNIA/iXfhXMN\n\tabIWxO2oCXKf3TdD7aQ4070KO6zSxIcxgNQFtDFOaWNvbGFzIER1ZnJlc25lIDxuaWNvbGFzLmR1Z\n\tnJlc25lQGNvbGxhYm9yYS5jb20+iJkEExYKAEECGwMFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4\n\tAWIQTvDVKBFcTDwhoEbxLZQZRRKWBy9AUCaCyyxgUJCWX3dQAKCRDZQZRRKWBy9ARJAP96pFmLffZ\n\tsmBUpkyVBfFAf+zq6BJt769R0al3kHvUKdgD9G7KAHuioxD2v6SX7idpIazjzx8b8rfzwTWyOQWHC\n\tAAS0LU5pY29sYXMgRHVmcmVzbmUgPG5pY29sYXMuZHVmcmVzbmVAZ21haWwuY29tPoiZBBMWCgBBF\n\tiEE7w1SgRXEw8IaBG8S2UGUUSlgcvQFAmibrGYCGwMFCQll93UFCwkIBwICIgIGFQoJCAsCBBYCAw\n\tECHgcCF4AACgkQ2UGUUSlgcvRObgD/YnQjfi4+L8f4fI7p1pPMTwRTcaRdy6aqkKEmKsCArzQBAK8\n\tbRLv9QjuqsE6oQZra/RB4widZPvphs78H0P6NmpIJ","Organization":"Collabora Canada","Content-Type":"multipart/signed; micalg=\"pgp-sha512\";\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"=-NZKwwe9+PGJRmosynut6\"","User-Agent":"Evolution 3.56.2 (3.56.2-2.fc42) ","MIME-Version":"1.0","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":36198,"web_url":"https://patchwork.libcamera.org/comment/36198/","msgid":"<69b5553b-3b84-41ab-ad52-7b4f5be254c9@ideasonboard.com>","date":"2025-10-10T15:30:58","subject":"Re: [PATCH 1/3] gstreamer: Shorten function name","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2025. 10. 10. 16:18 keltezéssel, Umang Jain írta:\n> Shorten the following utility function name:\n> \tgst_libcamera_stream_configuration_to_caps()\n> to\n> \tgst_libcamera_stream_cfg_to_caps()\n> \n> Comestic fix only for slight readability enhancement.\n> \n> Signed-off-by: Umang Jain \n> ---\n\nReviewed-by: Barnabás Pőcze \n\n\n> src/gstreamer/gstlibcamera-utils.cpp | 4 ++--\n> src/gstreamer/gstlibcamera-utils.h | 4 ++--\n> src/gstreamer/gstlibcamerasrc.cpp | 4 ++--\n> 3 files changed, 6 insertions(+), 6 deletions(-)\n> \n> diff --git a/src/gstreamer/gstlibcamera-utils.cpp b/src/gstreamer/gstlibcamera-utils.cpp\n> index bfb094c9..09f274b5 100644\n> --- a/src/gstreamer/gstlibcamera-utils.cpp\n> +++ b/src/gstreamer/gstlibcamera-utils.cpp\n> @@ -408,8 +408,8 @@ gst_libcamera_stream_formats_to_caps(const StreamFormats &formats)\n> }\n> \n> GstCaps *\n> -gst_libcamera_stream_configuration_to_caps(const StreamConfiguration &stream_cfg,\n> -\t\t\t\t\t GstVideoTransferFunction transfer)\n> +gst_libcamera_stream_cfg_to_caps(const StreamConfiguration &stream_cfg,\n> +\t\t\t\t GstVideoTransferFunction transfer)\n> {\n> \tGstCaps *caps = gst_caps_new_empty();\n> \tGstStructure *s = bare_structure_from_format(stream_cfg.pixelFormat);\n> diff --git a/src/gstreamer/gstlibcamera-utils.h b/src/gstreamer/gstlibcamera-utils.h\n> index 35df56fb..06ea9289 100644\n> --- a/src/gstreamer/gstlibcamera-utils.h\n> +++ b/src/gstreamer/gstlibcamera-utils.h\n> @@ -16,8 +16,8 @@\n> #include \n> \n> GstCaps *gst_libcamera_stream_formats_to_caps(const libcamera::StreamFormats &formats);\n> -GstCaps *gst_libcamera_stream_configuration_to_caps(const libcamera::StreamConfiguration &stream_cfg,\n> -\t\t\t\t\t\t GstVideoTransferFunction transfer);\n> +GstCaps *gst_libcamera_stream_cfg_to_caps(const libcamera::StreamConfiguration &stream_cfg,\n> +\t\t\t\t\t GstVideoTransferFunction transfer);\n> void gst_libcamera_configure_stream_from_caps(libcamera::StreamConfiguration &stream_cfg,\n> \t\t\t\t\t GstCaps *caps, GstVideoTransferFunction *transfer);\n> void gst_libcamera_get_framerate_from_caps(GstCaps *caps, GstStructure *element_caps);\n> diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp\n> index 79a025a5..9ff90d9a 100644\n> --- a/src/gstreamer/gstlibcamerasrc.cpp\n> +++ b/src/gstreamer/gstlibcamerasrc.cpp\n> @@ -645,7 +645,7 @@ gst_libcamera_src_negotiate(GstLibcameraSrc *self)\n> \t\tGstPad *srcpad = state->srcpads_[i];\n> \t\tconst StreamConfiguration &stream_cfg = state->config_->at(i);\n> \n> -\t\tg_autoptr(GstCaps) caps = gst_libcamera_stream_configuration_to_caps(stream_cfg, transfer[i]);\n> +\t\tg_autoptr(GstCaps) caps = gst_libcamera_stream_cfg_to_caps(stream_cfg, transfer[i]);\n> \t\tgst_libcamera_framerate_to_caps(caps, element_caps);\n> \n> \t\tif (status == CameraConfiguration::Adjusted &&\n> @@ -673,7 +673,7 @@ gst_libcamera_src_negotiate(GstLibcameraSrc *self)\n> \t\tGstBufferPool *video_pool = nullptr;\n> \t\tGstVideoInfo info;\n> \n> -\t\tg_autoptr(GstCaps) caps = gst_libcamera_stream_configuration_to_caps(stream_cfg, transfer[i]);\n> +\t\tg_autoptr(GstCaps) caps = gst_libcamera_stream_cfg_to_caps(stream_cfg, transfer[i]);\n> \n> \t\tgst_video_info_from_caps(&info, caps);\n> \t\tgst_libcamera_pad_set_video_info(srcpad, &info);","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 14FA4BE080\n\tfor ;\n\tFri, 10 Oct 2025 15:31:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CE05E6B60E;\n\tFri, 10 Oct 2025 17:31:02 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A06446B599\n\tfor ;\n\tFri, 10 Oct 2025 17:31:01 +0200 (CEST)","from [192.168.33.28] (185.182.214.121.nat.pool.zt.hu\n\t[185.182.214.121])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0FE8A22F;\n\tFri, 10 Oct 2025 17:29:26 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"PW9RVS0U\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1760110166;\n\tbh=XAEh8Z6rmtQufiB2627kXjmwOc2oyfS94LPSurFh5NY=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=PW9RVS0U7NcIfli+PQ0XA5JsEilyLfzcMKmgEnd/YBOnCgViC6P++ud0zP8LqUWFf\n\teu+FnnQaoBL8yuZyjhyyLbwD0qZ92eLx3ZH8wrYRbGVHElQJvGChb1zjebbO/QIs6K\n\tJLspMmOTEAoYgkKtrYbChJRInZL36VconcNOf4UQ=","Message-ID":"<69b5553b-3b84-41ab-ad52-7b4f5be254c9@ideasonboard.com>","Date":"Fri, 10 Oct 2025 17:30:58 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 1/3] gstreamer: Shorten function name","To":"Umang Jain , libcamera-devel@lists.libcamera.org","Cc":"Nicolas Dufresne ","References":"<20251010141826.42995-1-uajain@igalia.com>\n\t<20251010141826.42995-2-uajain@igalia.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20251010141826.42995-2-uajain@igalia.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":36217,"web_url":"https://patchwork.libcamera.org/comment/36217/","msgid":"<20251013102020.GI29493@pendragon.ideasonboard.com>","date":"2025-10-13T10:20:20","subject":"Re: [PATCH 1/3] gstreamer: Shorten function name","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Fri, Oct 10, 2025 at 11:29:39AM -0400, Nicolas Dufresne wrote:\n> Le vendredi 10 octobre 2025 à 19:48 +0530, Umang Jain a écrit :\n> > Shorten the following utility function name:\n> > \tgst_libcamera_stream_configuration_to_caps()\n> > to\n> > \tgst_libcamera_stream_cfg_to_caps()\n> > \n> > Comestic fix only for slight readability enhancement.\n> \n> As you can see, I'm not an acronym kind of person, but I guess if you made the\n> effort to patch it, its because it bothers you enough :-D\n\nNeither am I :-) We try to spell things out as much as possible through\nthe libcamera code base, unless there are good reasons to do otherwise.\n\n> Reviewed-by: Nicolas Dufresne \n> \n> > Signed-off-by: Umang Jain \n> > ---\n> >  src/gstreamer/gstlibcamera-utils.cpp | 4 ++--\n> >  src/gstreamer/gstlibcamera-utils.h   | 4 ++--\n> >  src/gstreamer/gstlibcamerasrc.cpp    | 4 ++--\n> >  3 files changed, 6 insertions(+), 6 deletions(-)\n> > \n> > diff --git a/src/gstreamer/gstlibcamera-utils.cpp b/src/gstreamer/gstlibcamera-utils.cpp\n> > index bfb094c9..09f274b5 100644\n> > --- a/src/gstreamer/gstlibcamera-utils.cpp\n> > +++ b/src/gstreamer/gstlibcamera-utils.cpp\n> > @@ -408,8 +408,8 @@ gst_libcamera_stream_formats_to_caps(const StreamFormats &formats)\n> >  }\n> >  \n> >  GstCaps *\n> > -gst_libcamera_stream_configuration_to_caps(const StreamConfiguration &stream_cfg,\n> > -\t\t\t\t\t   GstVideoTransferFunction transfer)\n> > +gst_libcamera_stream_cfg_to_caps(const StreamConfiguration &stream_cfg,\n> > +\t\t\t\t GstVideoTransferFunction transfer)\n> >  {\n> >  \tGstCaps *caps = gst_caps_new_empty();\n> >  \tGstStructure *s = bare_structure_from_format(stream_cfg.pixelFormat);\n> > diff --git a/src/gstreamer/gstlibcamera-utils.h b/src/gstreamer/gstlibcamera-utils.h\n> > index 35df56fb..06ea9289 100644\n> > --- a/src/gstreamer/gstlibcamera-utils.h\n> > +++ b/src/gstreamer/gstlibcamera-utils.h\n> > @@ -16,8 +16,8 @@\n> >  #include \n> >  \n> >  GstCaps *gst_libcamera_stream_formats_to_caps(const libcamera::StreamFormats &formats);\n> > -GstCaps *gst_libcamera_stream_configuration_to_caps(const libcamera::StreamConfiguration &stream_cfg,\n> > -\t\t\t\t\t\t    GstVideoTransferFunction transfer);\n> > +GstCaps *gst_libcamera_stream_cfg_to_caps(const libcamera::StreamConfiguration &stream_cfg,\n> > +\t\t\t\t\t  GstVideoTransferFunction transfer);\n> >  void gst_libcamera_configure_stream_from_caps(libcamera::StreamConfiguration &stream_cfg,\n> >  \t\t\t\t\t      GstCaps *caps, GstVideoTransferFunction *transfer);\n> >  void gst_libcamera_get_framerate_from_caps(GstCaps *caps, GstStructure *element_caps);\n> > diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp\n> > index 79a025a5..9ff90d9a 100644\n> > --- a/src/gstreamer/gstlibcamerasrc.cpp\n> > +++ b/src/gstreamer/gstlibcamerasrc.cpp\n> > @@ -645,7 +645,7 @@ gst_libcamera_src_negotiate(GstLibcameraSrc *self)\n> >  \t\tGstPad *srcpad = state->srcpads_[i];\n> >  \t\tconst StreamConfiguration &stream_cfg = state->config_->at(i);\n> >  \n> > -\t\tg_autoptr(GstCaps) caps = gst_libcamera_stream_configuration_to_caps(stream_cfg, transfer[i]);\n> > +\t\tg_autoptr(GstCaps) caps = gst_libcamera_stream_cfg_to_caps(stream_cfg, transfer[i]);\n> >  \t\tgst_libcamera_framerate_to_caps(caps, element_caps);\n> >  \n> >  \t\tif (status == CameraConfiguration::Adjusted &&\n> > @@ -673,7 +673,7 @@ gst_libcamera_src_negotiate(GstLibcameraSrc *self)\n> >  \t\tGstBufferPool *video_pool = nullptr;\n> >  \t\tGstVideoInfo info;\n> >  \n> > -\t\tg_autoptr(GstCaps) caps = gst_libcamera_stream_configuration_to_caps(stream_cfg, transfer[i]);\n> > +\t\tg_autoptr(GstCaps) caps = gst_libcamera_stream_cfg_to_caps(stream_cfg, transfer[i]);\n> >  \n> >  \t\tgst_video_info_from_caps(&info, caps);\n> >  \t\tgst_libcamera_pad_set_video_info(srcpad, &info);","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C5D85BF415\n\tfor ;\n\tMon, 13 Oct 2025 10:20:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B2B256031A;\n\tMon, 13 Oct 2025 12:20:29 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5AD716031A\n\tfor ;\n\tMon, 13 Oct 2025 12:20:27 +0200 (CEST)","from pendragon.ideasonboard.com (82-203-166-19.bb.dnainternet.fi\n\t[82.203.166.19])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 64917591;\n\tMon, 13 Oct 2025 12:18:49 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"MesPG83z\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1760350729;\n\tbh=oE4xqXZGnd0IH2gG9O9Go8RvfWkmaLslic5Wwm7rNxM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=MesPG83zttFFtnj3fLoFsNHYHXCK1/JlQFd1H+IUXK0KiOc0+aVl/QMloNqpIKSiG\n\t/DKyAztyAXWXDvkRTwpHPXGiVWxcz48MIwTkPgi6igdHhJZr1vtbSFJXbZf5iRSTA5\n\tbxPuPKGTtSc57yj8ix9ma+9yWyWnv88jkylBUIa0=","Date":"Mon, 13 Oct 2025 13:20:20 +0300","From":"Laurent Pinchart ","To":"Nicolas Dufresne ","Cc":"Umang Jain , libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 1/3] gstreamer: Shorten function name","Message-ID":"<20251013102020.GI29493@pendragon.ideasonboard.com>","References":"<20251010141826.42995-1-uajain@igalia.com>\n\t<20251010141826.42995-2-uajain@igalia.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]