{"id":24582,"url":"https://patchwork.libcamera.org/api/patches/24582/?format=json","web_url":"https://patchwork.libcamera.org/patch/24582/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251010141826.42995-2-uajain@igalia.com>","date":"2025-10-10T14:18:24","name":"[1/3] gstreamer: Shorten function name","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"9553939a209303af9c24c90b983a490db4daaac1","submitter":{"id":232,"url":"https://patchwork.libcamera.org/api/people/232/?format=json","name":"Umang Jain","email":"uajain@igalia.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24582/mbox/","series":[{"id":5484,"url":"https://patchwork.libcamera.org/api/series/5484/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5484","date":"2025-10-10T14:18:23","name":"gstreamer: some assorted fixes","version":1,"mbox":"https://patchwork.libcamera.org/series/5484/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24582/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24582/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BD5BDC3264\n\tfor ;\n\tFri, 10 Oct 2025 14:18:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4EA0B6B61A;\n\tFri, 10 Oct 2025 16:18:17 +0200 (CEST)","from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9A7946B599\n\tfor ;\n\tFri, 10 Oct 2025 16:18:13 +0200 (CEST)","from [49.36.127.56] (helo=uajain)\n\tby fanzine2.igalia.com with esmtpsa \n\t(Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256)\n\t(Exim) id 1v7Dwi-007uJd-Jp; Fri, 10 Oct 2025 16:18:12 +0200"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=igalia.com header.i=@igalia.com\n\theader.b=\"IT4L+Hjw\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;\n\ts=20170329;\n\th=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:\n\tMessage-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID:\n\tContent-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc\n\t:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:\n\tList-Post:List-Owner:List-Archive;\n\tbh=lQCB/mFJNjsE+FX8VE5OPZLqLNj33oVg34Lks0OQBvw=;\n\tb=IT4L+Hjw4gLgrtm7bvqsnz9ZUx\n\tgiKquNS+ixR64rBl+WD2i5+MnORmUD1/JUVkRehkI1w6o/dwOH9nrstqpz3jB0iZau3Htc9Xxq0aR\n\tB5OxtOINGLCDSDB5tt6h4wRGFxDMAf4dAYNpbf0qABAziRozTFZ8yS2zQWLrbdR+kSBXhpdzXCo0c\n\tI27uFLylGrzQ6lcEsJs9n09WAQ+yJ9jPfgMbhFeaH1+h1FTZsr+/SXN3Ne7zKFOtzMvPHeXGYlxux\n\tzRBtyG9gGhD3UHCPTgPVGIOdqSfM4vl8MmUOPWSOCxaKzhU5euhcjuH9nhmeGsOvtuYaG087ur8OK\n\tqnGgUExA==;","From":"Umang Jain ","To":"libcamera-devel@lists.libcamera.org","Cc":"Nicolas Dufresne ,\n\tUmang Jain ","Subject":"[PATCH 1/3] gstreamer: Shorten function name","Date":"Fri, 10 Oct 2025 19:48:24 +0530","Message-ID":"<20251010141826.42995-2-uajain@igalia.com>","X-Mailer":"git-send-email 2.50.1","In-Reply-To":"<20251010141826.42995-1-uajain@igalia.com>","References":"<20251010141826.42995-1-uajain@igalia.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Shorten the following utility function name:\n\tgst_libcamera_stream_configuration_to_caps()\nto\n\tgst_libcamera_stream_cfg_to_caps()\n\nComestic fix only for slight readability enhancement.\n\nSigned-off-by: Umang Jain \n---\n src/gstreamer/gstlibcamera-utils.cpp | 4 ++--\n src/gstreamer/gstlibcamera-utils.h | 4 ++--\n src/gstreamer/gstlibcamerasrc.cpp | 4 ++--\n 3 files changed, 6 insertions(+), 6 deletions(-)","diff":"diff --git a/src/gstreamer/gstlibcamera-utils.cpp b/src/gstreamer/gstlibcamera-utils.cpp\nindex bfb094c9..09f274b5 100644\n--- a/src/gstreamer/gstlibcamera-utils.cpp\n+++ b/src/gstreamer/gstlibcamera-utils.cpp\n@@ -408,8 +408,8 @@ gst_libcamera_stream_formats_to_caps(const StreamFormats &formats)\n }\n \n GstCaps *\n-gst_libcamera_stream_configuration_to_caps(const StreamConfiguration &stream_cfg,\n-\t\t\t\t\t GstVideoTransferFunction transfer)\n+gst_libcamera_stream_cfg_to_caps(const StreamConfiguration &stream_cfg,\n+\t\t\t\t GstVideoTransferFunction transfer)\n {\n \tGstCaps *caps = gst_caps_new_empty();\n \tGstStructure *s = bare_structure_from_format(stream_cfg.pixelFormat);\ndiff --git a/src/gstreamer/gstlibcamera-utils.h b/src/gstreamer/gstlibcamera-utils.h\nindex 35df56fb..06ea9289 100644\n--- a/src/gstreamer/gstlibcamera-utils.h\n+++ b/src/gstreamer/gstlibcamera-utils.h\n@@ -16,8 +16,8 @@\n #include \n \n GstCaps *gst_libcamera_stream_formats_to_caps(const libcamera::StreamFormats &formats);\n-GstCaps *gst_libcamera_stream_configuration_to_caps(const libcamera::StreamConfiguration &stream_cfg,\n-\t\t\t\t\t\t GstVideoTransferFunction transfer);\n+GstCaps *gst_libcamera_stream_cfg_to_caps(const libcamera::StreamConfiguration &stream_cfg,\n+\t\t\t\t\t GstVideoTransferFunction transfer);\n void gst_libcamera_configure_stream_from_caps(libcamera::StreamConfiguration &stream_cfg,\n \t\t\t\t\t GstCaps *caps, GstVideoTransferFunction *transfer);\n void gst_libcamera_get_framerate_from_caps(GstCaps *caps, GstStructure *element_caps);\ndiff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp\nindex 79a025a5..9ff90d9a 100644\n--- a/src/gstreamer/gstlibcamerasrc.cpp\n+++ b/src/gstreamer/gstlibcamerasrc.cpp\n@@ -645,7 +645,7 @@ gst_libcamera_src_negotiate(GstLibcameraSrc *self)\n \t\tGstPad *srcpad = state->srcpads_[i];\n \t\tconst StreamConfiguration &stream_cfg = state->config_->at(i);\n \n-\t\tg_autoptr(GstCaps) caps = gst_libcamera_stream_configuration_to_caps(stream_cfg, transfer[i]);\n+\t\tg_autoptr(GstCaps) caps = gst_libcamera_stream_cfg_to_caps(stream_cfg, transfer[i]);\n \t\tgst_libcamera_framerate_to_caps(caps, element_caps);\n \n \t\tif (status == CameraConfiguration::Adjusted &&\n@@ -673,7 +673,7 @@ gst_libcamera_src_negotiate(GstLibcameraSrc *self)\n \t\tGstBufferPool *video_pool = nullptr;\n \t\tGstVideoInfo info;\n \n-\t\tg_autoptr(GstCaps) caps = gst_libcamera_stream_configuration_to_caps(stream_cfg, transfer[i]);\n+\t\tg_autoptr(GstCaps) caps = gst_libcamera_stream_cfg_to_caps(stream_cfg, transfer[i]);\n \n \t\tgst_video_info_from_caps(&info, caps);\n \t\tgst_libcamera_pad_set_video_info(srcpad, &info);\n","prefixes":["1/3"]}