[{"id":36183,"web_url":"https://patchwork.libcamera.org/comment/36183/","msgid":"<176009173352.935713.18292685806781468472@ping.linuxembedded.co.uk>","date":"2025-10-10T10:22:13","subject":"Re: [PATCH v4 3/3] pipeline: simple: Initialize\n\tmaxQueuedRequestsDevice to 4","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Robert Mader (2025-10-10 10:22:26)\n> Now that the pipeline handler supports high buffer counts, apps may\n> queue more requests, exhausting e.g. frame contexts (see\n> ipa::soft::kMaxFrameContexts => 16).\n> \n> Thus limit the number of queued requests to 4, corresponding to the\n> the previous buffer limit.\n> \n> Suggested-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n> Signed-off-by: Robert Mader <robert.mader@collabora.com>\n\nOddly enough - I think this series is backwards :D\n\nI think applying as \n\n3/3 Restrict pipeline queuing (to 3?) Prevent ever overflowing\n2/3 Increase buffering (to tested limits)\n1/3 Open the flood gates to let more requests be queued safely\n\nHandles this in a truely bisectable/safe way.\n\nBut that would require rewriting the commit messages and might be just\noverkill :D\n\nAnyway for this patch:\n\n\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\n> ---\n>  src/libcamera/pipeline/simple/simple.cpp | 4 +++-\n>  1 file changed, 3 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n> index c4cb7c391..dec9f6514 100644\n> --- a/src/libcamera/pipeline/simple/simple.cpp\n> +++ b/src/libcamera/pipeline/simple/simple.cpp\n> @@ -420,6 +420,7 @@ protected:\n>         int queueRequestDevice(Camera *camera, Request *request) override;\n>  \n>  private:\n> +       static constexpr unsigned int kMaxQueuedRequestsDevice = 4;\n>         static constexpr unsigned int kNumInternalBuffers = 4;\n>  \n>         struct EntityData {\n> @@ -1287,7 +1288,8 @@ CameraConfiguration::Status SimpleCameraConfiguration::validate()\n>   */\n>  \n>  SimplePipelineHandler::SimplePipelineHandler(CameraManager *manager)\n> -       : PipelineHandler(manager), converter_(nullptr)\n> +       : PipelineHandler(manager, kMaxQueuedRequestsDevice),\n> +         converter_(nullptr)\n>  {\n>  }\n>  \n> -- \n> 2.51.0\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8CA89BE080\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 10 Oct 2025 10:22:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 97CE46B60E;\n\tFri, 10 Oct 2025 12:22:18 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A8DB16B599\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 10 Oct 2025 12:22:16 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 45F1B2C5;\n\tFri, 10 Oct 2025 12:20:41 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"vnxaUSRH\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1760091641;\n\tbh=jfyCqf/LRjQ+1iVMhdTxrKudazV3gPhE87Pe2zGbBs8=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=vnxaUSRHKf7QFLljqRqjtZ8nTFb3qCd6zXILzKwRPgAAYcNnqqr/4FqDk8HYo+eDI\n\ttsPuADhWuwAqWeHqjszqBPr0s6G1PN+pYk7FW+fyVSgPqvsjwcHE9Q+G+Z3ohhHLl4\n\tKQWy4tfHnZYuelkTXximVzQML1kyjcNzSaxZY9is=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20251010092226.41228-3-robert.mader@collabora.com>","References":"<20251010092226.41228-1-robert.mader@collabora.com>\n\t<20251010092226.41228-3-robert.mader@collabora.com>","Subject":"Re: [PATCH v4 3/3] pipeline: simple: Initialize\n\tmaxQueuedRequestsDevice to 4","From":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Cc":"Robert Mader <robert.mader@collabora.com>, =?utf-8?q?Barnab=C3=A1s_P?=\n\t=?utf-8?b?xZFjemU=?= <barnabas.pocze@ideasonboard.com>","To":"Robert Mader <robert.mader@collabora.com>,\n\tlibcamera-devel@lists.libcamera.org","Date":"Fri, 10 Oct 2025 11:22:13 +0100","Message-ID":"<176009173352.935713.18292685806781468472@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":36186,"web_url":"https://patchwork.libcamera.org/comment/36186/","msgid":"<dab917d1-0102-481c-8dbb-b8866e228e3e@ideasonboard.com>","date":"2025-10-10T12:07:04","subject":"Re: [PATCH v4 3/3] pipeline: simple: Initialize\n\tmaxQueuedRequestsDevice to 4","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2025. 10. 10. 11:22 keltezéssel, Robert Mader írta:\n> Now that the pipeline handler supports high buffer counts, apps may\n> queue more requests, exhausting e.g. frame contexts (see\n> ipa::soft::kMaxFrameContexts => 16).\n> \n> Thus limit the number of queued requests to 4, corresponding to the\n> the previous buffer limit.\n> \n> Suggested-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n> Signed-off-by: Robert Mader <robert.mader@collabora.com>\n> ---\n\nTested-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n\nAs far as I could test, this avoids the fatal assertion\nwhen the number of quued buffers is > 16.\n\n\n>   src/libcamera/pipeline/simple/simple.cpp | 4 +++-\n>   1 file changed, 3 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n> index c4cb7c391..dec9f6514 100644\n> --- a/src/libcamera/pipeline/simple/simple.cpp\n> +++ b/src/libcamera/pipeline/simple/simple.cpp\n> @@ -420,6 +420,7 @@ protected:\n>   \tint queueRequestDevice(Camera *camera, Request *request) override;\n>   \n>   private:\n> +\tstatic constexpr unsigned int kMaxQueuedRequestsDevice = 4;\n>   \tstatic constexpr unsigned int kNumInternalBuffers = 4;\n>   \n>   \tstruct EntityData {\n> @@ -1287,7 +1288,8 @@ CameraConfiguration::Status SimpleCameraConfiguration::validate()\n>    */\n>   \n>   SimplePipelineHandler::SimplePipelineHandler(CameraManager *manager)\n> -\t: PipelineHandler(manager), converter_(nullptr)\n> +\t: PipelineHandler(manager, kMaxQueuedRequestsDevice),\n> +\t  converter_(nullptr)\n>   {\n>   }\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8A1D0BE080\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 10 Oct 2025 12:07:09 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3BF876B60F;\n\tFri, 10 Oct 2025 14:07:09 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2B6FD6B599\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 10 Oct 2025 14:07:08 +0200 (CEST)","from [192.168.33.28] (185.182.214.121.nat.pool.zt.hu\n\t[185.182.214.121])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B4CB45B3;\n\tFri, 10 Oct 2025 14:05:32 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"cUopKq34\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1760097932;\n\tbh=iB1poU8Lojja+4qAFxdNX7Yawc+kIZrUAp2+VmO6lYU=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=cUopKq34ihRBZE4sphGcAqOsmaJ4C4Y+sqBP4EbVN2U3vvgLsSnpxTt6McPapOEp5\n\tuFy5z+O2GYKAUhtkuWrlENAAqd5xMnYumPQz8krIwRk3oni6V9BJFDOasZ2EdM7j5o\n\tLOKW2s+lQ2neKXi9SukWVi4v0PKNa0UnE+Thd+Zg=","Message-ID":"<dab917d1-0102-481c-8dbb-b8866e228e3e@ideasonboard.com>","Date":"Fri, 10 Oct 2025 14:07:04 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v4 3/3] pipeline: simple: Initialize\n\tmaxQueuedRequestsDevice to 4","To":"Robert Mader <robert.mader@collabora.com>,\n\tlibcamera-devel@lists.libcamera.org","References":"<20251010092226.41228-1-robert.mader@collabora.com>\n\t<20251010092226.41228-3-robert.mader@collabora.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>","Content-Language":"en-US, hu-HU","In-Reply-To":"<20251010092226.41228-3-robert.mader@collabora.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":36194,"web_url":"https://patchwork.libcamera.org/comment/36194/","msgid":"<ea404a89-d841-4e00-938a-e99d42877792@collabora.com>","date":"2025-10-10T15:17:59","subject":"Re: [PATCH v4 3/3] pipeline: simple: Initialize\n\tmaxQueuedRequestsDevice to 4","submitter":{"id":140,"url":"https://patchwork.libcamera.org/api/people/140/","name":"Robert Mader","email":"robert.mader@collabora.com"},"content":"On 10/10/25 14:07, Barnabás Pőcze wrote:\n> 2025. 10. 10. 11:22 keltezéssel, Robert Mader írta:\n>> Now that the pipeline handler supports high buffer counts, apps may\n>> queue more requests, exhausting e.g. frame contexts (see\n>> ipa::soft::kMaxFrameContexts => 16).\n>>\n>> Thus limit the number of queued requests to 4, corresponding to the\n>> the previous buffer limit.\n>>\n>> Suggested-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n>> Signed-off-by: Robert Mader <robert.mader@collabora.com>\n>> ---\n>\n> Tested-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n>\n> As far as I could test, this avoids the fatal assertion\n> when the number of quued buffers is > 16.\nNice, thanks!\n>\n>>   src/libcamera/pipeline/simple/simple.cpp | 4 +++-\n>>   1 file changed, 3 insertions(+), 1 deletion(-)\n>>\n>> diff --git a/src/libcamera/pipeline/simple/simple.cpp \n>> b/src/libcamera/pipeline/simple/simple.cpp\n>> index c4cb7c391..dec9f6514 100644\n>> --- a/src/libcamera/pipeline/simple/simple.cpp\n>> +++ b/src/libcamera/pipeline/simple/simple.cpp\n>> @@ -420,6 +420,7 @@ protected:\n>>       int queueRequestDevice(Camera *camera, Request *request) override;\n>>     private:\n>> +    static constexpr unsigned int kMaxQueuedRequestsDevice = 4;\n>>       static constexpr unsigned int kNumInternalBuffers = 4;\n>>         struct EntityData {\n>> @@ -1287,7 +1288,8 @@ CameraConfiguration::Status \n>> SimpleCameraConfiguration::validate()\n>>    */\n>>     SimplePipelineHandler::SimplePipelineHandler(CameraManager *manager)\n>> -    : PipelineHandler(manager), converter_(nullptr)\n>> +    : PipelineHandler(manager, kMaxQueuedRequestsDevice),\n>> +      converter_(nullptr)\n>>   {\n>>   }\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BEAC4BE080\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 10 Oct 2025 15:18:08 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 882716B599;\n\tFri, 10 Oct 2025 17:18:08 +0200 (CEST)","from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com\n\t[136.143.188.112])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 84F4B6B599\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 10 Oct 2025 17:18:06 +0200 (CEST)","by mx.zohomail.com with SMTPS id 1760109482170231.97489005297416; \n\tFri, 10 Oct 2025 08:18:02 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=collabora.com\n\theader.i=robert.mader@collabora.com header.b=\"DkeTccZc\"; \n\tdkim-atps=neutral","ARC-Seal":"i=1; a=rsa-sha256; t=1760109483; cv=none; \n\td=zohomail.com; s=zohoarc; \n\tb=PUZPEtripx+a8GqXKXw/9slPoxpURiAaiqqaW9vmru2cipurs39HAwvWnZ2BgqeL/efwG5RVwOHEQcwCkHFxqV6b2ihLIHicIgBgyS81pk+U/Z33Ggih7J6rvXW12SU16NYMjpIexx97EVopT4Q72byhHpOynSUQzgRkT2ryyJw=","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; \n\ts=zohoarc; t=1760109483;\n\th=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To:Cc;\n\tbh=MhYmtOPrqx0MGKvq3WIc2RayLu0K2dF7kX0yJcI438M=; \n\tb=Zf9f7A1YrHfGc/6Ii68YmVXmHo7gD88ARRA3tONBgMZgF+rHMNcFgS4KnrHppCI0gyqdoTkARbvsX6pYD2zTRkZuroeEWGNwEaeXDGanUc4qoGnfutOqsWHgrJ8Uly4/jA5HkxxzsQgpJkJVAgVECbboHaJJ2DI/vBg4ykpywLQ=","ARC-Authentication-Results":"i=1; mx.zohomail.com;\n\tdkim=pass  header.i=collabora.com;\n\tspf=pass  smtp.mailfrom=robert.mader@collabora.com;\n\tdmarc=pass header.from=<robert.mader@collabora.com>","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1760109483;\n\ts=zohomail; d=collabora.com; i=robert.mader@collabora.com;\n\th=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To:Cc;\n\tbh=MhYmtOPrqx0MGKvq3WIc2RayLu0K2dF7kX0yJcI438M=;\n\tb=DkeTccZcxGazwOT9h5Vk6oktN1r+xFZp5MUZ6oCJXNVlB8qqofeXYx5H5sDqIbol\n\t+9k5V+G3H/Oolv+4Xn5ktPmPPmXw/YPv5tae7Q9Tx/wjzlFnkJisMz6dgi5+6gfDQbD\n\trY2RJrPWfbDCUps5JIYiesuRXx8qOZdfAQ4qWm54=","Message-ID":"<ea404a89-d841-4e00-938a-e99d42877792@collabora.com>","Date":"Fri, 10 Oct 2025 17:17:59 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v4 3/3] pipeline: simple: Initialize\n\tmaxQueuedRequestsDevice to 4","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>,\n\tlibcamera-devel@lists.libcamera.org","References":"<20251010092226.41228-1-robert.mader@collabora.com>\n\t<20251010092226.41228-3-robert.mader@collabora.com>\n\t<dab917d1-0102-481c-8dbb-b8866e228e3e@ideasonboard.com>","Content-Language":"en-US, de-DE","From":"Robert Mader <robert.mader@collabora.com>","In-Reply-To":"<dab917d1-0102-481c-8dbb-b8866e228e3e@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":36196,"web_url":"https://patchwork.libcamera.org/comment/36196/","msgid":"<20d3ce36-5470-49d0-9bba-02f08c55f06a@collabora.com>","date":"2025-10-10T15:20:15","subject":"Re: [PATCH v4 3/3] pipeline: simple: Initialize\n\tmaxQueuedRequestsDevice to 4","submitter":{"id":140,"url":"https://patchwork.libcamera.org/api/people/140/","name":"Robert Mader","email":"robert.mader@collabora.com"},"content":"On 10/10/25 12:22, Kieran Bingham wrote:\n> Quoting Robert Mader (2025-10-10 10:22:26)\n>> Now that the pipeline handler supports high buffer counts, apps may\n>> queue more requests, exhausting e.g. frame contexts (see\n>> ipa::soft::kMaxFrameContexts => 16).\n>>\n>> Thus limit the number of queued requests to 4, corresponding to the\n>> the previous buffer limit.\n>>\n>> Suggested-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n>> Signed-off-by: Robert Mader <robert.mader@collabora.com>\n> Oddly enough - I think this series is backwards :D\n>\n> I think applying as\n>\n> 3/3 Restrict pipeline queuing (to 3?) Prevent ever overflowing\n> 2/3 Increase buffering (to tested limits)\n> 1/3 Open the flood gates to let more requests be queued safely\n>\n> Handles this in a truely bisectable/safe way.\n>\n> But that would require rewriting the commit messages and might be just\n> overkill :D\n\nI can spin a v5 over the weekend or on Monday, however feel free to \nalready land with any suggestions to the commit message :)\n\n>\n> Anyway for this patch:\n>\n>\n> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n>\n>> ---\n>>   src/libcamera/pipeline/simple/simple.cpp | 4 +++-\n>>   1 file changed, 3 insertions(+), 1 deletion(-)\n>>\n>> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n>> index c4cb7c391..dec9f6514 100644\n>> --- a/src/libcamera/pipeline/simple/simple.cpp\n>> +++ b/src/libcamera/pipeline/simple/simple.cpp\n>> @@ -420,6 +420,7 @@ protected:\n>>          int queueRequestDevice(Camera *camera, Request *request) override;\n>>   \n>>   private:\n>> +       static constexpr unsigned int kMaxQueuedRequestsDevice = 4;\n>>          static constexpr unsigned int kNumInternalBuffers = 4;\n>>   \n>>          struct EntityData {\n>> @@ -1287,7 +1288,8 @@ CameraConfiguration::Status SimpleCameraConfiguration::validate()\n>>    */\n>>   \n>>   SimplePipelineHandler::SimplePipelineHandler(CameraManager *manager)\n>> -       : PipelineHandler(manager), converter_(nullptr)\n>> +       : PipelineHandler(manager, kMaxQueuedRequestsDevice),\n>> +         converter_(nullptr)\n>>   {\n>>   }\n>>   \n>> -- \n>> 2.51.0\n>>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 12164BF415\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 10 Oct 2025 15:20:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BD6E46B5C4;\n\tFri, 10 Oct 2025 17:20:26 +0200 (CEST)","from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com\n\t[136.143.188.112])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E89076B599\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 10 Oct 2025 17:20:23 +0200 (CEST)","by mx.zohomail.com with SMTPS id 1760109617588713.0069010121091;\n\tFri, 10 Oct 2025 08:20:17 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=collabora.com\n\theader.i=robert.mader@collabora.com header.b=\"hUbR4aAn\"; \n\tdkim-atps=neutral","ARC-Seal":"i=1; a=rsa-sha256; t=1760109620; cv=none; \n\td=zohomail.com; s=zohoarc; \n\tb=OUc8TInCNWrLHCoBxBuovcdEkhURHZsl1PEw+jHfil1Sl8gDQIIeLHvyHTcIHN7bxHATTFrRXxZhnzdpCP9CmJjYpOQRBRs47lG3jTz4OHJ9ATmX5EyDKz3N9LQe0EtorAGMG+PNxfGfAnCaGcstLYLyefyWdo30sjDuINXztuY=","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; \n\ts=zohoarc; t=1760109620;\n\th=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To;\n\tbh=JE7CYT0qIAUtZ/lHSHi6fjuAp/NHol4DKNaaAx3IybM=; \n\tb=gGxpLVGN0Bt0e90DuIbhVQeajpmMW+c6I+luG1W9mZuKEEiywl5V7uDQFXP7pWhsPajMnpMVGVmJoifZBcFiV4mHlG5EX/YIsE7RBDQt5LtOU17jcXMJFJRWB9bg4CD2sAy8XCUmbakY6jpMyO/oxVLpaY/zkNGsKUtTZ8K8Cig=","ARC-Authentication-Results":"i=1; mx.zohomail.com;\n\tdkim=pass  header.i=collabora.com;\n\tspf=pass  smtp.mailfrom=robert.mader@collabora.com;\n\tdmarc=pass header.from=<robert.mader@collabora.com>","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1760109620;\n\ts=zohomail; d=collabora.com; i=robert.mader@collabora.com;\n\th=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To;\n\tbh=JE7CYT0qIAUtZ/lHSHi6fjuAp/NHol4DKNaaAx3IybM=;\n\tb=hUbR4aAnFRaAGQaSnDMFURBN/jTYL7Jz+OK8Wk5JwbXf9TqqZDBWG3FGvPeDJIS4\n\tfUf1qlaQPjvw1qk30HMPccrGnjY08JRR/+bKpSxMTjQEDVOVXY+pnqFnNJFWSdQOsbN\n\t2GkKNUwjF5uENAaCVb2XbmInlBm9cOEoQy2gDAUg=","Message-ID":"<20d3ce36-5470-49d0-9bba-02f08c55f06a@collabora.com>","Date":"Fri, 10 Oct 2025 17:20:15 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v4 3/3] pipeline: simple: Initialize\n\tmaxQueuedRequestsDevice to 4","To":"Kieran Bingham <kieran.bingham@ideasonboard.com>,\n\tlibcamera-devel@lists.libcamera.org","Cc":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>","References":"<20251010092226.41228-1-robert.mader@collabora.com>\n\t<20251010092226.41228-3-robert.mader@collabora.com>\n\t<176009173352.935713.18292685806781468472@ping.linuxembedded.co.uk>","Content-Language":"en-US, de-DE","From":"Robert Mader <robert.mader@collabora.com>","In-Reply-To":"<176009173352.935713.18292685806781468472@ping.linuxembedded.co.uk>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]