{"id":24576,"url":"https://patchwork.libcamera.org/api/patches/24576/?format=json","web_url":"https://patchwork.libcamera.org/patch/24576/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251010092226.41228-2-robert.mader@collabora.com>","date":"2025-10-10T09:22:25","name":"[v4,2/3] pipeline: simple: Increase internal buffers for software ISP to 4","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"6c655b93548d91b318ce54ca2dbd15d3f5d92f43","submitter":{"id":140,"url":"https://patchwork.libcamera.org/api/people/140/?format=json","name":"Robert Mader","email":"robert.mader@collabora.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24576/mbox/","series":[{"id":5482,"url":"https://patchwork.libcamera.org/api/series/5482/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5482","date":"2025-10-10T09:22:24","name":"[v4,1/3] pipeline: simple: Allow buffer counts from 1 to 32","version":4,"mbox":"https://patchwork.libcamera.org/series/5482/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24576/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24576/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D2F3CBE080\n\tfor ;\n\tFri, 10 Oct 2025 09:23:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 86ACD613AB;\n\tFri, 10 Oct 2025 11:23:10 +0200 (CEST)","from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com\n\t[136.143.188.112])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 831C5613AB\n\tfor ;\n\tFri, 10 Oct 2025 11:23:08 +0200 (CEST)","by mx.zohomail.com with SMTPS id 1760088182945181.03089471734825; \n\tFri, 10 Oct 2025 02:23:02 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=collabora.com\n\theader.i=robert.mader@collabora.com header.b=\"ADupL4Gh\"; \n\tdkim-atps=neutral","ARC-Seal":"i=1; a=rsa-sha256; t=1760088185; cv=none; \n\td=zohomail.com; s=zohoarc; \n\tb=P6Ip2/DEu9aoMltAXPksQweFFEeSgZHqzMGIkszFz1xWBkEg3B9D91y0ApFxNJqlCL8+pQbxXuhF4HK3831hM3GAy5bryoq9Q+5rRe7XRGnCSJV8D1lsTV+6GO5oxq/GGqRKfA+x9gIRA2BFb5Sb+sYSgA78yI6FBkDtdPaw2VA=","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; \n\ts=zohoarc; t=1760088185;\n\th=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To;\n\tbh=lewmQ3pFJYZKfPVu8AxdW3PwJ4VBMHRhi6uMLIuh9Uo=; \n\tb=M+xN3ckF/SmoJTQO217k5SO0mJKHerJVoQ7R3FX37NOlHQTKtJFPR53xePRtlNCItB2cTtbBP5IwCqp9uEAJODd7oCuM/mNbDUXnwjZ9iiinrqpvYkD3ne6gOtuQUfEu8rZPfOkbMkN2izG+o8lEidKZRuu7mJtxBXeOitApB6M=","ARC-Authentication-Results":"i=1; mx.zohomail.com;\n\tdkim=pass header.i=collabora.com;\n\tspf=pass smtp.mailfrom=robert.mader@collabora.com;\n\tdmarc=pass header.from=","DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1760088185;\n\ts=zohomail; d=collabora.com; i=robert.mader@collabora.com;\n\th=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Message-Id:Reply-To;\n\tbh=lewmQ3pFJYZKfPVu8AxdW3PwJ4VBMHRhi6uMLIuh9Uo=;\n\tb=ADupL4Ghyzwl+5wQ582JNOb/m/r1OFkl5FJyoB9aR03OAVVHhwsAoBB5IVWPK5xA\n\t1AArVcfDoPDh3KUZtNq9MAsgFjb8f3ME2f0zfZTExUTePcqq8cLgkwpE0G0KHBhbWKP\n\teCChJ3DyYC7pLtiQrnmjFgwKfFBojwMzv8ZcjBS8=","From":"Robert Mader ","To":"libcamera-devel@lists.libcamera.org","Cc":"Robert Mader ,\n\tMilan Zamazal ","Subject":"[PATCH v4 2/3] pipeline: simple: Increase internal buffers for\n\tsoftware ISP to 4","Date":"Fri, 10 Oct 2025 11:22:25 +0200","Message-ID":"<20251010092226.41228-2-robert.mader@collabora.com>","X-Mailer":"git-send-email 2.51.0","In-Reply-To":"<20251010092226.41228-1-robert.mader@collabora.com>","References":"<20251010092226.41228-1-robert.mader@collabora.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"This has been shipped downstream in postmarketOS for a while and, in\nsome cases, seems to improve stability on not-so-great drivers. It also\nbrings the software ISP in line with the default used otherwise.\n\nSigned-off-by: Robert Mader \nReviewed-by: Milan Zamazal \n---\n src/libcamera/pipeline/simple/simple.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\nindex 2dcba04ec..c4cb7c391 100644\n--- a/src/libcamera/pipeline/simple/simple.cpp\n+++ b/src/libcamera/pipeline/simple/simple.cpp\n@@ -420,7 +420,7 @@ protected:\n \tint queueRequestDevice(Camera *camera, Request *request) override;\n \n private:\n-\tstatic constexpr unsigned int kNumInternalBuffers = 3;\n+\tstatic constexpr unsigned int kNumInternalBuffers = 4;\n \n \tstruct EntityData {\n \t\tstd::unique_ptr video;\n","prefixes":["v4","2/3"]}