[{"id":36111,"web_url":"https://patchwork.libcamera.org/comment/36111/","msgid":"","date":"2025-10-03T14:17:34","subject":"Re: [PATCH v2 3/4] ipa: rpi: pisp: Add a DecompandAlgorithm class","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"content":"HI Naush\n\nThanks for the patch.\n\nOn Fri, 3 Oct 2025 at 13:18, Naushir Patuck wrote:\n>\n> The decompand algorithm implementation will subclass the\n> DecompandAlgorithm class. This will be needed for setting the initial\n> decompand values in a future commit.\n>\n> Signed-off-by: Naushir Patuck \n> Tested-by: Nick Hollinghurst \n\nReviewed-by: David Plowman \n\nThanks!\nDavid\n\n> ---\n> src/ipa/rpi/controller/decompand_algorithm.h | 24 ++++++++++++++++++++\n> src/ipa/rpi/controller/rpi/decompand.cpp | 2 +-\n> src/ipa/rpi/controller/rpi/decompand.h | 5 ++--\n> 3 files changed, 27 insertions(+), 4 deletions(-)\n> create mode 100644 src/ipa/rpi/controller/decompand_algorithm.h\n>\n> diff --git a/src/ipa/rpi/controller/decompand_algorithm.h b/src/ipa/rpi/controller/decompand_algorithm.h\n> new file mode 100644\n> index 000000000000..f19f8c109323\n> --- /dev/null\n> +++ b/src/ipa/rpi/controller/decompand_algorithm.h\n> @@ -0,0 +1,24 @@\n> +/* SPDX-License-Identifier: BSD-2-Clause */\n> +/*\n> + * Copyright (C) 2025, Raspberry Pi Ltd\n> + *\n> + * Decompand control algorithm interface\n> + */\n> +#pragma once\n> +\n> +#include \"libipa/pwl.h\"\n> +\n> +#include \"algorithm.h\"\n> +\n> +namespace RPiController {\n> +\n> +class DecompandAlgorithm : public Algorithm\n> +{\n> +public:\n> + DecompandAlgorithm(Controller *controller = NULL)\n> + : Algorithm(controller)\n> + {\n> + }\n> +};\n> +\n> +} /* namespace RPiController */\n> diff --git a/src/ipa/rpi/controller/rpi/decompand.cpp b/src/ipa/rpi/controller/rpi/decompand.cpp\n> index 2036750f82f4..5b4c2e5524af 100644\n> --- a/src/ipa/rpi/controller/rpi/decompand.cpp\n> +++ b/src/ipa/rpi/controller/rpi/decompand.cpp\n> @@ -13,7 +13,7 @@ LOG_DEFINE_CATEGORY(RPiDecompand)\n> #define NAME \"rpi.decompand\"\n>\n> Decompand::Decompand(Controller *controller)\n> - : Algorithm(controller)\n> + : DecompandAlgorithm(controller)\n> {\n> }\n>\n> diff --git a/src/ipa/rpi/controller/rpi/decompand.h b/src/ipa/rpi/controller/rpi/decompand.h\n> index 38b26a21e6d5..0f2a9b3bbdc4 100644\n> --- a/src/ipa/rpi/controller/rpi/decompand.h\n> +++ b/src/ipa/rpi/controller/rpi/decompand.h\n> @@ -2,10 +2,9 @@\n>\n> #include \n>\n> +#include \"../decompand_algorithm.h\"\n> #include \"../decompand_status.h\"\n>\n> -#include \"algorithm.h\"\n> -\n> namespace RPiController {\n>\n> struct DecompandConfig {\n> @@ -13,7 +12,7 @@ struct DecompandConfig {\n> libcamera::ipa::Pwl decompandCurve;\n> };\n>\n> -class Decompand : public Algorithm\n> +class Decompand : public DecompandAlgorithm\n> {\n> public:\n> Decompand(Controller *controller = nullptr);\n> --\n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1DB28C324C\n\tfor ;\n\tFri, 3 Oct 2025 14:17:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 269DC6B5F3;\n\tFri, 3 Oct 2025 16:17:48 +0200 (CEST)","from mail-qk1-x72b.google.com (mail-qk1-x72b.google.com\n\t[IPv6:2607:f8b0:4864:20::72b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F014769318\n\tfor ;\n\tFri, 3 Oct 2025 16:17:46 +0200 (CEST)","by mail-qk1-x72b.google.com with SMTP id\n\taf79cd13be357-854fcb187b2so266410185a.2\n\tfor ;\n\tFri, 03 Oct 2025 07:17:46 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"tzDq2+cs\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1759501066; x=1760105866;\n\tdarn=lists.libcamera.org; \n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=I39Dy4dtLLJTqOJ0V5OOUaBoWci1kSvsbvphqAzrXRA=;\n\tb=tzDq2+csT1iWjGaHmr3gM+M0JUyrRCFNKyfm5VHTcasuVDUTsggBrPYCRfT3CklAio\n\tQPKJ5O0koVmwZEC4CjpNc+46V/O7LWEGhxC4zaUMc3C+a8VyWMUal4e+Tku6uHozad3c\n\tXD9XHeOW0ksWDhcWq37uUKe9HcBYKzTz8jos3FKO06Zaoi3Kuhy4/TURi39Ji4z45V9k\n\tcEwcPsoFZITwn8jgyEoEci7OKCILWo99W+Co+EuyiVbI7GLOwWokRFw9B57450KuaWMx\n\tLeh0n6R3L5oDz6K/vnpaViIyJicW/EXLHbUUJKyU8OD7MVr/BqrfS5yyLDX/dKWKNALX\n\tlORg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1759501066; x=1760105866;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=I39Dy4dtLLJTqOJ0V5OOUaBoWci1kSvsbvphqAzrXRA=;\n\tb=w9Iay3oABBIFluY/lkbu2T7vKTeYuUn8kSPZ/DDI97+OPJ0OquBputiZ/1xM2PP6eU\n\t0K+AZu/nhytfmGf842kDLSxZSEgqqo62VfxLwrMG7U/w7oU4Y5n2gdaNgbiOW6F9/ylc\n\tZ4UwTjNm9PA+sb1ifbrIfzoEo/+GnvDJvxss7o0uy0bXH5UVNIjh97uiHFc6+6ETjKKK\n\tCpJsTEdUSyF0u2Kwz9iN3KZmOhhC/qeqrw1HL06OfI+dlCylfhHLtHatT1qt1241+fws\n\tztrJiv/GZ3YMgA7JV3d7UOewP6KeJCuTwW+PDVed23vUWYYc91cSEpQxFkUO0ul0LbSz\n\tXngg==","X-Gm-Message-State":"AOJu0Yx2iE6qwT0c5irJCQbi1K3Y34eVxPOhWEVOXMoYGjMQE1iiQNUR\n\tv7bnf+raYa+eErwUZjigsKU2rv6OL3zlJNMwhF3wSVt1fs4Dx7AK1QVfRXK25jQiVzTi9mwSQFQ\n\tCqaHs/iSkt9XZAjXIi3VSVKjDqGQKPFjzk4P/bBFBEQ==","X-Gm-Gg":"ASbGncuKDi7xXt2/SFmeAFjRt9Xz7CylRhCWLQcNXlpx53OSbXAXSphv6Z24izqjYim\n\tkZExlYo4TQcrtsl6haB9skZH8F+f15Q+SuFvUTDWG8jyJ5vKc25rYrhvcclHbzt5gLy/R6RjSCJ\n\twcTsJquhIoqhqCBSjTq2XzOV8COP39o+KR5zloqUyCZZe2PlmM/p+Mqxpvfc3Gx2F3llvjFpAqe\n\tRCZiJjVBNAT6Yf8SH11gG0gBPqcnmJWGdzkCcD0WjqWx0kNwTKgcKUI2wIr+J0=","X-Google-Smtp-Source":"AGHT+IHpDDWoPglx73YwHDWr+zCzh/gtCcbjdyY+WTPBn1ubiYCoTYWN15t/INPhGA2CaYhg+SEsfvX9IaDw2/uh2I0=","X-Received":"by 2002:a05:620a:31a9:b0:870:ab:430c with SMTP id\n\taf79cd13be357-87a3bc6ad4dmr435146985a.81.1759501065693;\n\tFri, 03 Oct 2025 07:17:45 -0700 (PDT)","MIME-Version":"1.0","References":"<20251003121821.659081-1-naush@raspberrypi.com>\n\t<20251003121821.659081-4-naush@raspberrypi.com>","In-Reply-To":"<20251003121821.659081-4-naush@raspberrypi.com>","From":"David Plowman ","Date":"Fri, 3 Oct 2025 15:17:34 +0100","X-Gm-Features":"AS18NWBuwNW3LAEmG3GaV1XlwmAE-TMFwJj5Bj626nHlnKqzf3gHxa1CQzJVQsg","Message-ID":"","Subject":"Re: [PATCH v2 3/4] ipa: rpi: pisp: Add a DecompandAlgorithm class","To":"Naushir Patuck ","Cc":"libcamera-devel@lists.libcamera.org, \n\tNick Hollinghurst ","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]