[{"id":36100,"web_url":"https://patchwork.libcamera.org/comment/36100/","msgid":"<5bf4070f-6dc9-49db-8c2a-ce1d790f1b0a@ideasonboard.com>","date":"2025-10-03T09:52:14","subject":"Re: [PATCH 1/2] libcamera: ipa_manager: Create IPA by name","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"Hi\n\n\n2025. 10. 03. 11:27 keltezéssel, Jacopo Mondi írta:\n> From: Hans de Goede \n> \n> Currently createIPA() / IPAManager::module() assume that there is a 1:1\n> relationship between pipeline handlers and IPAs and IPA matching is done\n> based on matching the pipe to ipaModuleInfo.pipelineName[].\n> \n> One way to allow using a single IPA with multiple pipelines would be to\n> allow the IPA to declare itself compatible with more than one pipeline,\n> turning ipaModuleInfo.pipelineName[] into e.g. a vector. But the way\n> ipaModuleInfo is loaded as an ELF symbol requires it to be a simple flat\n> C-struct.\n> \n> Instead, move the IPA creation procedure to be name-based, introducing\n> an overload to IPAManager::createIPA(pipe, name, minVer, maxVer) that\n> allows to specify the name of the IPA module to match. Pipeline handlers\n> that wants to use their name as matching criteria can continue doing so\n> using the already existing createIPA(pipe, minVer, maxVer) overload.\n\nWhen this was first proposed, I looked at the possibility of adding the name to the\ngenerated proxy type as a static constexpr member to avoid any potential type confusion.\nBut sadly the way the raspberry pi modules are handled makes that more complicated.\n\n\n> \n> Signed-off-by: Hans de Goede \n> Signed-off-by: Jacopo Mondi \n> ---\n> include/libcamera/internal/ipa_manager.h | 14 +++++++++++--\n> include/libcamera/internal/ipa_module.h | 4 ++--\n> src/libcamera/ipa_manager.cpp | 34 ++++++++++++++++++++++++++------\n> src/libcamera/ipa_module.cpp | 12 +++++------\n> 4 files changed, 48 insertions(+), 16 deletions(-)\n> \n> diff --git a/include/libcamera/internal/ipa_manager.h b/include/libcamera/internal/ipa_manager.h\n> index f8ce780169e617088557888d7c8dae2d3f10ec08..8bc8680be0a4a6db0cdb57c1a9400c23efecda0c 100644\n> --- a/include/libcamera/internal/ipa_manager.h\n> +++ b/include/libcamera/internal/ipa_manager.h\n> @@ -34,12 +34,14 @@ public:\n> \n> \ttemplate\n> \tstatic std::unique_ptr createIPA(PipelineHandler *pipe,\n> +\t\t\t\t\t const char *name,\n> \t\t\t\t\t uint32_t minVersion,\n> \t\t\t\t\t uint32_t maxVersion)\n> +\n> \t{\n> \t\tCameraManager *cm = pipe->cameraManager();\n\nSince `pipe` is only used to get the camera manager, could we take that as argument instead?\n\n\nRegards,\nBarnabás Pőcze\n\n> \t\tIPAManager *self = cm->_d()->ipaManager();\n> -\t\tIPAModule *m = self->module(pipe, minVersion, maxVersion);\n> +\t\tIPAModule *m = self->module(name, minVersion, maxVersion);\n> \t\tif (!m)\n> \t\t\treturn nullptr;\n> \n> @@ -60,6 +62,14 @@ public:\n> \t\treturn proxy;\n> \t}\n> \n> +\ttemplate\n> +\tstatic std::unique_ptr createIPA(PipelineHandler *pipe,\n> +\t\t\t\t\t uint32_t minVersion,\n> +\t\t\t\t\t uint32_t maxVersion)\n> +\t{\n> +\t\treturn createIPA(pipe, pipe->name(), minVersion, maxVersion);\n> +\t}\n> +\n> #if HAVE_IPA_PUBKEY\n> \tstatic const PubKey &pubKey()\n> \t{\n> @@ -72,7 +82,7 @@ private:\n> \t\t std::vector &files);\n> \tunsigned int addDir(const char *libDir, unsigned int maxDepth = 0);\n> \n> -\tIPAModule *module(PipelineHandler *pipe, uint32_t minVersion,\n> +\tIPAModule *module(const char *name, uint32_t minVersion,\n> \t\t\t uint32_t maxVersion);\n> \n> \tbool isSignatureValid(IPAModule *ipa) const;\n> diff --git a/include/libcamera/internal/ipa_module.h b/include/libcamera/internal/ipa_module.h\n> index 15f19492c3a027a0bc4f9572188d13af41fcd450..a0a53764e1394abed3bab92cdde9f33a86441c5f 100644\n> --- a/include/libcamera/internal/ipa_module.h\n> +++ b/include/libcamera/internal/ipa_module.h\n> @@ -36,8 +36,8 @@ public:\n> \n> \tIPAInterface *createInterface();\n> \n> -\tbool match(PipelineHandler *pipe,\n> -\t\t uint32_t minVersion, uint32_t maxVersion) const;\n> +\tbool match(const char *name, uint32_t minVersion,\n> +\t\t uint32_t maxVersion) const;\n> \n> protected:\n> \tstd::string logPrefix() const override;\n> diff --git a/src/libcamera/ipa_manager.cpp b/src/libcamera/ipa_manager.cpp\n> index 35171d097136a6d85b8f518c099f8228f9eacd6f..f62a4ee5fd012d23ce178d59f84c6ab49513376b 100644\n> --- a/src/libcamera/ipa_manager.cpp\n> +++ b/src/libcamera/ipa_manager.cpp\n> @@ -247,15 +247,15 @@ unsigned int IPAManager::addDir(const char *libDir, unsigned int maxDepth)\n> \n> /**\n> * \\brief Retrieve an IPA module that matches a given pipeline handler\n> - * \\param[in] pipe The pipeline handler\n> + * \\param[in] name The IPA module string identifier\n> * \\param[in] minVersion Minimum acceptable version of IPA module\n> * \\param[in] maxVersion Maximum acceptable version of IPA module\n> */\n> -IPAModule *IPAManager::module(PipelineHandler *pipe, uint32_t minVersion,\n> +IPAModule *IPAManager::module(const char *name, uint32_t minVersion,\n> \t\t\t uint32_t maxVersion)\n> {\n> \tfor (const auto &module : modules_) {\n> -\t\tif (module->match(pipe, minVersion, maxVersion))\n> +\t\tif (module->match(name, minVersion, maxVersion))\n> \t\t\treturn module.get();\n> \t}\n> \n> @@ -263,12 +263,34 @@ IPAModule *IPAManager::module(PipelineHandler *pipe, uint32_t minVersion,\n> }\n> \n> /**\n> - * \\fn IPAManager::createIPA()\n> - * \\brief Create an IPA proxy that matches a given pipeline handler\n> - * \\param[in] pipe The pipeline handler that wants a matching IPA proxy\n> + * \\fn IPAManager::createIPA(PipelineHandler *pipe, const char *ipaName, uint32_t minVersion, uint32_t maxVersion)\n> + * \\brief Create an IPA proxy that matches the requested name and version\n> + * \\param[in] pipe The pipeline handler that wants to create the IPA module\n> + * \\param[in] ipaName The IPA module name\n> * \\param[in] minVersion Minimum acceptable version of IPA module\n> * \\param[in] maxVersion Maximum acceptable version of IPA module\n> *\n> + * Create an IPA module using \\a name as the matching identifier. This overload\n> + * allows pipeline handlers to create an IPA module by specifying its name\n> + * instead of relying on the fact that the IPA module matches the pipeline\n> + * handler's one.\n> + *\n> + * \\return A newly created IPA proxy, or nullptr if no matching IPA module is\n> + * found or if the IPA proxy fails to initialize\n> + */\n> +\n> +/**\n> + * \\fn IPAManager::createIPA(PipelineHandler *pipe, uint32_t minVersion, uint32_t maxVersion)\n> + * \\brief Create an IPA proxy that matches the pipeline handler name and the\n> + * requested version\n> + * \\param[in] pipe The pipeline handler that wants to create the IPA module\n> + * \\param[in] minVersion Minimum acceptable version of IPA module\n> + * \\param[in] maxVersion Maximum acceptable version of IPA module\n> + *\n> + * Create an IPA module using the pipeline handler name as the matching\n> + * identifier. This overload allows pipeline handler to create an IPA module\n> + * whose name matches the pipeline handler one.\n> + *\n> * \\return A newly created IPA proxy, or nullptr if no matching IPA module is\n> * found or if the IPA proxy fails to initialize\n> */\n> diff --git a/src/libcamera/ipa_module.cpp b/src/libcamera/ipa_module.cpp\n> index e6ea61e4482983a83b4185c4309f2c514ed24fc2..0bd6f14626fe2038072f48b70ca4341b0eb8cef5 100644\n> --- a/src/libcamera/ipa_module.cpp\n> +++ b/src/libcamera/ipa_module.cpp\n> @@ -463,21 +463,21 @@ IPAInterface *IPAModule::createInterface()\n> \n> /**\n> * \\brief Verify if the IPA module matches a given pipeline handler\n> - * \\param[in] pipe Pipeline handler to match with\n> + * \\param[in] name The IPA module name\n> * \\param[in] minVersion Minimum acceptable version of IPA module\n> * \\param[in] maxVersion Maximum acceptable version of IPA module\n> *\n> - * This function checks if this IPA module matches the \\a pipe pipeline handler,\n> + * This function checks if this IPA module matches the requested \\a name\n> * and the input version range.\n> *\n> - * \\return True if the pipeline handler matches the IPA module, or false otherwise\n> + * \\return True if the IPA module matches, or false otherwise\n> */\n> -bool IPAModule::match(PipelineHandler *pipe,\n> -\t\t uint32_t minVersion, uint32_t maxVersion) const\n> +bool IPAModule::match(const char *name, uint32_t minVersion,\n> +\t\t uint32_t maxVersion) const\n> {\n> \treturn info_.pipelineVersion >= minVersion &&\n> \t info_.pipelineVersion <= maxVersion &&\n> -\t !strcmp(info_.pipelineName, pipe->name());\n> +\t !strcmp(info_.name, name);\n> }\n> \n> std::string IPAModule::logPrefix() const\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 64B7EBF415\n\tfor ;\n\tFri, 3 Oct 2025 09:52:21 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EE4836B5F3;\n\tFri, 3 Oct 2025 11:52:19 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 79B646B599\n\tfor ;\n\tFri, 3 Oct 2025 11:52:18 +0200 (CEST)","from [192.168.33.17] (185.182.214.142.nat.pool.zt.hu\n\t[185.182.214.142])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C2B151340;\n\tFri, 3 Oct 2025 11:50:47 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"V2XbZ0uJ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1759485048;\n\tbh=2rL99QAs5J1QGjeAQZLmqrF832WuE6iLV4VJMgwRRT8=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=V2XbZ0uJ/3EKhtZJeuKQzPwJt2czMQizCl1Kq9r9lyEclJcsL6CcRGVdSPl+Mc+4Q\n\txr6t/8Imdv+RPTlhWthbxsyrWyFJ0+/xYhK8S7j7dKqb+3LkqLTJBuePCaEgaVPoxp\n\tBUSG/09z19YRblXfM/eqPZ/hrDof5tEZbW314EPc=","Message-ID":"<5bf4070f-6dc9-49db-8c2a-ce1d790f1b0a@ideasonboard.com>","Date":"Fri, 3 Oct 2025 11:52:14 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 1/2] libcamera: ipa_manager: Create IPA by name","To":"Jacopo Mondi ,\n\tlibcamera-devel@lists.libcamera.org, =?utf-8?q?Niklas_S=C3=B6derlund?=\n\t, Hans de Goede ","Cc":"Hans de Goede ","References":"<20251003-ipa-match-by-name-v1-0-07b796729412@ideasonboard.com>\n\t<20251003-ipa-match-by-name-v1-1-07b796729412@ideasonboard.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20251003-ipa-match-by-name-v1-1-07b796729412@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":36104,"web_url":"https://patchwork.libcamera.org/comment/36104/","msgid":"<175948822245.935713.5053996010515591576@ping.linuxembedded.co.uk>","date":"2025-10-03T10:43:42","subject":"Re: [PATCH 1/2] libcamera: ipa_manager: Create IPA by name","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Barnabás Pőcze (2025-10-03 10:52:14)\n> Hi\n> \n> \n> 2025. 10. 03. 11:27 keltezéssel, Jacopo Mondi írta:\n> > From: Hans de Goede \n> > \n> > Currently createIPA() / IPAManager::module() assume that there is a 1:1\n> > relationship between pipeline handlers and IPAs and IPA matching is done\n> > based on matching the pipe to ipaModuleInfo.pipelineName[].\n> > \n> > One way to allow using a single IPA with multiple pipelines would be to\n> > allow the IPA to declare itself compatible with more than one pipeline,\n> > turning ipaModuleInfo.pipelineName[] into e.g. a vector. But the way\n> > ipaModuleInfo is loaded as an ELF symbol requires it to be a simple flat\n> > C-struct.\n> > \n> > Instead, move the IPA creation procedure to be name-based, introducing\n> > an overload to IPAManager::createIPA(pipe, name, minVer, maxVer) that\n> > allows to specify the name of the IPA module to match. Pipeline handlers\n> > that wants to use their name as matching criteria can continue doing so\n> > using the already existing createIPA(pipe, minVer, maxVer) overload.\n> \n> When this was first proposed, I looked at the possibility of adding the name to the\n> generated proxy type as a static constexpr member to avoid any potential type confusion.\n> But sadly the way the raspberry pi modules are handled makes that more complicated.\n> \n> \n> > \n> > Signed-off-by: Hans de Goede \n> > Signed-off-by: Jacopo Mondi \n> > ---\n> > include/libcamera/internal/ipa_manager.h | 14 +++++++++++--\n> > include/libcamera/internal/ipa_module.h | 4 ++--\n> > src/libcamera/ipa_manager.cpp | 34 ++++++++++++++++++++++++++------\n> > src/libcamera/ipa_module.cpp | 12 +++++------\n> > 4 files changed, 48 insertions(+), 16 deletions(-)\n> > \n> > diff --git a/include/libcamera/internal/ipa_manager.h b/include/libcamera/internal/ipa_manager.h\n> > index f8ce780169e617088557888d7c8dae2d3f10ec08..8bc8680be0a4a6db0cdb57c1a9400c23efecda0c 100644\n> > --- a/include/libcamera/internal/ipa_manager.h\n> > +++ b/include/libcamera/internal/ipa_manager.h\n> > @@ -34,12 +34,14 @@ public:\n> > \n> > template\n> > static std::unique_ptr createIPA(PipelineHandler *pipe,\n> > + const char *name,\n> > uint32_t minVersion,\n> > uint32_t maxVersion)\n> > +\n\nI don't think we want this extraneous line here.\n\n> > {\n> > CameraManager *cm = pipe->cameraManager();\n> \n> Since `pipe` is only used to get the camera manager, could we take that as argument instead?\n> \n> \n> Regards,\n> Barnabás Pőcze\n> \n> > IPAManager *self = cm->_d()->ipaManager();\n> > - IPAModule *m = self->module(pipe, minVersion, maxVersion);\n> > + IPAModule *m = self->module(name, minVersion, maxVersion);\n> > if (!m)\n> > return nullptr;\n> > \n> > @@ -60,6 +62,14 @@ public:\n> > return proxy;\n> > }\n> > \n> > + template\n> > + static std::unique_ptr createIPA(PipelineHandler *pipe,\n> > + uint32_t minVersion,\n> > + uint32_t maxVersion)\n> > + {\n> > + return createIPA(pipe, pipe->name(), minVersion, maxVersion);\n> > + }\n> > +\n> > #if HAVE_IPA_PUBKEY\n> > static const PubKey &pubKey()\n> > {\n> > @@ -72,7 +82,7 @@ private:\n> > std::vector &files);\n> > unsigned int addDir(const char *libDir, unsigned int maxDepth = 0);\n> > \n> > - IPAModule *module(PipelineHandler *pipe, uint32_t minVersion,\n> > + IPAModule *module(const char *name, uint32_t minVersion,\n> > uint32_t maxVersion);\n> > \n> > bool isSignatureValid(IPAModule *ipa) const;\n> > diff --git a/include/libcamera/internal/ipa_module.h b/include/libcamera/internal/ipa_module.h\n> > index 15f19492c3a027a0bc4f9572188d13af41fcd450..a0a53764e1394abed3bab92cdde9f33a86441c5f 100644\n> > --- a/include/libcamera/internal/ipa_module.h\n> > +++ b/include/libcamera/internal/ipa_module.h\n> > @@ -36,8 +36,8 @@ public:\n> > \n> > IPAInterface *createInterface();\n> > \n> > - bool match(PipelineHandler *pipe,\n> > - uint32_t minVersion, uint32_t maxVersion) const;\n> > + bool match(const char *name, uint32_t minVersion,\n> > + uint32_t maxVersion) const;\n> > \n> > protected:\n> > std::string logPrefix() const override;\n> > diff --git a/src/libcamera/ipa_manager.cpp b/src/libcamera/ipa_manager.cpp\n> > index 35171d097136a6d85b8f518c099f8228f9eacd6f..f62a4ee5fd012d23ce178d59f84c6ab49513376b 100644\n> > --- a/src/libcamera/ipa_manager.cpp\n> > +++ b/src/libcamera/ipa_manager.cpp\n> > @@ -247,15 +247,15 @@ unsigned int IPAManager::addDir(const char *libDir, unsigned int maxDepth)\n> > \n> > /**\n> > * \\brief Retrieve an IPA module that matches a given pipeline handler\n> > - * \\param[in] pipe The pipeline handler\n> > + * \\param[in] name The IPA module string identifier\n> > * \\param[in] minVersion Minimum acceptable version of IPA module\n> > * \\param[in] maxVersion Maximum acceptable version of IPA module\n> > */\n> > -IPAModule *IPAManager::module(PipelineHandler *pipe, uint32_t minVersion,\n> > +IPAModule *IPAManager::module(const char *name, uint32_t minVersion,\n> > uint32_t maxVersion)\n> > {\n> > for (const auto &module : modules_) {\n> > - if (module->match(pipe, minVersion, maxVersion))\n> > + if (module->match(name, minVersion, maxVersion))\n> > return module.get();\n> > }\n> > \n> > @@ -263,12 +263,34 @@ IPAModule *IPAManager::module(PipelineHandler *pipe, uint32_t minVersion,\n> > }\n> > \n> > /**\n> > - * \\fn IPAManager::createIPA()\n> > - * \\brief Create an IPA proxy that matches a given pipeline handler\n> > - * \\param[in] pipe The pipeline handler that wants a matching IPA proxy\n> > + * \\fn IPAManager::createIPA(PipelineHandler *pipe, const char *ipaName, uint32_t minVersion, uint32_t maxVersion)\n> > + * \\brief Create an IPA proxy that matches the requested name and version\n> > + * \\param[in] pipe The pipeline handler that wants to create the IPA module\n> > + * \\param[in] ipaName The IPA module name\n> > * \\param[in] minVersion Minimum acceptable version of IPA module\n> > * \\param[in] maxVersion Maximum acceptable version of IPA module\n> > *\n> > + * Create an IPA module using \\a name as the matching identifier. This overload\n> > + * allows pipeline handlers to create an IPA module by specifying its name\n> > + * instead of relying on the fact that the IPA module matches the pipeline\n> > + * handler's one.\n> > + *\n> > + * \\return A newly created IPA proxy, or nullptr if no matching IPA module is\n> > + * found or if the IPA proxy fails to initialize\n> > + */\n> > +\n> > +/**\n> > + * \\fn IPAManager::createIPA(PipelineHandler *pipe, uint32_t minVersion, uint32_t maxVersion)\n> > + * \\brief Create an IPA proxy that matches the pipeline handler name and the\n> > + * requested version\n> > + * \\param[in] pipe The pipeline handler that wants to create the IPA module\n> > + * \\param[in] minVersion Minimum acceptable version of IPA module\n> > + * \\param[in] maxVersion Maximum acceptable version of IPA module\n> > + *\n> > + * Create an IPA module using the pipeline handler name as the matching\n> > + * identifier. This overload allows pipeline handler to create an IPA module\n> > + * whose name matches the pipeline handler one.\n> > + *\n> > * \\return A newly created IPA proxy, or nullptr if no matching IPA module is\n> > * found or if the IPA proxy fails to initialize\n> > */\n> > diff --git a/src/libcamera/ipa_module.cpp b/src/libcamera/ipa_module.cpp\n> > index e6ea61e4482983a83b4185c4309f2c514ed24fc2..0bd6f14626fe2038072f48b70ca4341b0eb8cef5 100644\n> > --- a/src/libcamera/ipa_module.cpp\n> > +++ b/src/libcamera/ipa_module.cpp\n> > @@ -463,21 +463,21 @@ IPAInterface *IPAModule::createInterface()\n> > \n> > /**\n> > * \\brief Verify if the IPA module matches a given pipeline handler\n> > - * \\param[in] pipe Pipeline handler to match with\n> > + * \\param[in] name The IPA module name\n> > * \\param[in] minVersion Minimum acceptable version of IPA module\n> > * \\param[in] maxVersion Maximum acceptable version of IPA module\n> > *\n> > - * This function checks if this IPA module matches the \\a pipe pipeline handler,\n> > + * This function checks if this IPA module matches the requested \\a name\n> > * and the input version range.\n> > *\n> > - * \\return True if the pipeline handler matches the IPA module, or false otherwise\n> > + * \\return True if the IPA module matches, or false otherwise\n> > */\n> > -bool IPAModule::match(PipelineHandler *pipe,\n> > - uint32_t minVersion, uint32_t maxVersion) const\n> > +bool IPAModule::match(const char *name, uint32_t minVersion,\n> > + uint32_t maxVersion) const\n> > {\n> > return info_.pipelineVersion >= minVersion &&\n> > info_.pipelineVersion <= maxVersion &&\n> > - !strcmp(info_.pipelineName, pipe->name());\n> > + !strcmp(info_.name, name);\n\nOtherwise nothing stands out to me, and with Barnabás comment handled if\nneeded or as a separate patch?\n\nReviewed-by: Kieran Bingham \n\n> > }\n> > \n> > std::string IPAModule::logPrefix() const\n> > \n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5BA8ABF415\n\tfor ;\n\tFri, 3 Oct 2025 10:43:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9C7A76B5AA;\n\tFri, 3 Oct 2025 12:43:47 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BE58169318\n\tfor ;\n\tFri, 3 Oct 2025 12:43:45 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 03347192C;\n\tFri, 3 Oct 2025 12:42:14 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Tyt19imQ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1759488135;\n\tbh=8BvzlsBKK3veAo0EWs7dCUMlC1xNIBknKJB6/SVByUg=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=Tyt19imQd7fHNLHcpKpTGWfvfGiqP/urK7AjNF8bC5Y88ffe8/Qaz/oYWUPIABQll\n\tKyyzEc+3YmAvgsEUrT6Qdzz/y3sleHhTPdIPvSpSh1u23wU5J3rKa62yZxf4MR1+bz\n\tG0a8GJxw/jimjs7GKruzFqmDLSGLDge39M8RVOCM=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<5bf4070f-6dc9-49db-8c2a-ce1d790f1b0a@ideasonboard.com>","References":"<20251003-ipa-match-by-name-v1-0-07b796729412@ideasonboard.com>\n\t<20251003-ipa-match-by-name-v1-1-07b796729412@ideasonboard.com>\n\t<5bf4070f-6dc9-49db-8c2a-ce1d790f1b0a@ideasonboard.com>","Subject":"Re: [PATCH 1/2] libcamera: ipa_manager: Create IPA by name","From":"Kieran Bingham ","Cc":"Hans de Goede ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tHans de Goede , Jacopo Mondi\n\t, Niklas =?utf-8?q?S=C3=B6derlund?=\n\t,\n\tlibcamera-devel@lists.libcamera.org","Date":"Fri, 03 Oct 2025 11:43:42 +0100","Message-ID":"<175948822245.935713.5053996010515591576@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":36108,"web_url":"https://patchwork.libcamera.org/comment/36108/","msgid":"","date":"2025-10-03T14:00:21","subject":"Re: [PATCH 1/2] libcamera: ipa_manager: Create IPA by name","submitter":{"id":239,"url":"https://patchwork.libcamera.org/api/people/239/","name":"Hans de Goede","email":"hansg@kernel.org"},"content":"Hi Jacopo,\n\nOn 3-Oct-25 11:27 AM, Jacopo Mondi wrote:\n> From: Hans de Goede \n> \n> Currently createIPA() / IPAManager::module() assume that there is a 1:1\n> relationship between pipeline handlers and IPAs and IPA matching is done\n> based on matching the pipe to ipaModuleInfo.pipelineName[].\n> \n> One way to allow using a single IPA with multiple pipelines would be to\n> allow the IPA to declare itself compatible with more than one pipeline,\n> turning ipaModuleInfo.pipelineName[] into e.g. a vector. But the way\n> ipaModuleInfo is loaded as an ELF symbol requires it to be a simple flat\n> C-struct.\n> \n> Instead, move the IPA creation procedure to be name-based, introducing\n> an overload to IPAManager::createIPA(pipe, name, minVer, maxVer) that\n> allows to specify the name of the IPA module to match. Pipeline handlers\n> that wants to use their name as matching criteria can continue doing so\n> using the already existing createIPA(pipe, minVer, maxVer) overload.\n> \n> Signed-off-by: Hans de Goede \n> Signed-off-by: Jacopo Mondi \n\nThank you for dusting off this patch.\n\nNote that hdegoede@redhat.com will stop working after October 31st.\n\nFor v2 can you please update my S-o-b to:\n\nReviewed-by: Hans de Goede \n\nAnd also do a git commit --amend --author=\"Hans de Goede \"\nto update the author / From: field to match ?\n\nRegards,\n\nHans\n\n\n\n\n> ---\n> include/libcamera/internal/ipa_manager.h | 14 +++++++++++--\n> include/libcamera/internal/ipa_module.h | 4 ++--\n> src/libcamera/ipa_manager.cpp | 34 ++++++++++++++++++++++++++------\n> src/libcamera/ipa_module.cpp | 12 +++++------\n> 4 files changed, 48 insertions(+), 16 deletions(-)\n> \n> diff --git a/include/libcamera/internal/ipa_manager.h b/include/libcamera/internal/ipa_manager.h\n> index f8ce780169e617088557888d7c8dae2d3f10ec08..8bc8680be0a4a6db0cdb57c1a9400c23efecda0c 100644\n> --- a/include/libcamera/internal/ipa_manager.h\n> +++ b/include/libcamera/internal/ipa_manager.h\n> @@ -34,12 +34,14 @@ public:\n> \n> \ttemplate\n> \tstatic std::unique_ptr createIPA(PipelineHandler *pipe,\n> +\t\t\t\t\t const char *name,\n> \t\t\t\t\t uint32_t minVersion,\n> \t\t\t\t\t uint32_t maxVersion)\n> +\n> \t{\n> \t\tCameraManager *cm = pipe->cameraManager();\n> \t\tIPAManager *self = cm->_d()->ipaManager();\n> -\t\tIPAModule *m = self->module(pipe, minVersion, maxVersion);\n> +\t\tIPAModule *m = self->module(name, minVersion, maxVersion);\n> \t\tif (!m)\n> \t\t\treturn nullptr;\n> \n> @@ -60,6 +62,14 @@ public:\n> \t\treturn proxy;\n> \t}\n> \n> +\ttemplate\n> +\tstatic std::unique_ptr createIPA(PipelineHandler *pipe,\n> +\t\t\t\t\t uint32_t minVersion,\n> +\t\t\t\t\t uint32_t maxVersion)\n> +\t{\n> +\t\treturn createIPA(pipe, pipe->name(), minVersion, maxVersion);\n> +\t}\n> +\n> #if HAVE_IPA_PUBKEY\n> \tstatic const PubKey &pubKey()\n> \t{\n> @@ -72,7 +82,7 @@ private:\n> \t\t std::vector &files);\n> \tunsigned int addDir(const char *libDir, unsigned int maxDepth = 0);\n> \n> -\tIPAModule *module(PipelineHandler *pipe, uint32_t minVersion,\n> +\tIPAModule *module(const char *name, uint32_t minVersion,\n> \t\t\t uint32_t maxVersion);\n> \n> \tbool isSignatureValid(IPAModule *ipa) const;\n> diff --git a/include/libcamera/internal/ipa_module.h b/include/libcamera/internal/ipa_module.h\n> index 15f19492c3a027a0bc4f9572188d13af41fcd450..a0a53764e1394abed3bab92cdde9f33a86441c5f 100644\n> --- a/include/libcamera/internal/ipa_module.h\n> +++ b/include/libcamera/internal/ipa_module.h\n> @@ -36,8 +36,8 @@ public:\n> \n> \tIPAInterface *createInterface();\n> \n> -\tbool match(PipelineHandler *pipe,\n> -\t\t uint32_t minVersion, uint32_t maxVersion) const;\n> +\tbool match(const char *name, uint32_t minVersion,\n> +\t\t uint32_t maxVersion) const;\n> \n> protected:\n> \tstd::string logPrefix() const override;\n> diff --git a/src/libcamera/ipa_manager.cpp b/src/libcamera/ipa_manager.cpp\n> index 35171d097136a6d85b8f518c099f8228f9eacd6f..f62a4ee5fd012d23ce178d59f84c6ab49513376b 100644\n> --- a/src/libcamera/ipa_manager.cpp\n> +++ b/src/libcamera/ipa_manager.cpp\n> @@ -247,15 +247,15 @@ unsigned int IPAManager::addDir(const char *libDir, unsigned int maxDepth)\n> \n> /**\n> * \\brief Retrieve an IPA module that matches a given pipeline handler\n> - * \\param[in] pipe The pipeline handler\n> + * \\param[in] name The IPA module string identifier\n> * \\param[in] minVersion Minimum acceptable version of IPA module\n> * \\param[in] maxVersion Maximum acceptable version of IPA module\n> */\n> -IPAModule *IPAManager::module(PipelineHandler *pipe, uint32_t minVersion,\n> +IPAModule *IPAManager::module(const char *name, uint32_t minVersion,\n> \t\t\t uint32_t maxVersion)\n> {\n> \tfor (const auto &module : modules_) {\n> -\t\tif (module->match(pipe, minVersion, maxVersion))\n> +\t\tif (module->match(name, minVersion, maxVersion))\n> \t\t\treturn module.get();\n> \t}\n> \n> @@ -263,12 +263,34 @@ IPAModule *IPAManager::module(PipelineHandler *pipe, uint32_t minVersion,\n> }\n> \n> /**\n> - * \\fn IPAManager::createIPA()\n> - * \\brief Create an IPA proxy that matches a given pipeline handler\n> - * \\param[in] pipe The pipeline handler that wants a matching IPA proxy\n> + * \\fn IPAManager::createIPA(PipelineHandler *pipe, const char *ipaName, uint32_t minVersion, uint32_t maxVersion)\n> + * \\brief Create an IPA proxy that matches the requested name and version\n> + * \\param[in] pipe The pipeline handler that wants to create the IPA module\n> + * \\param[in] ipaName The IPA module name\n> * \\param[in] minVersion Minimum acceptable version of IPA module\n> * \\param[in] maxVersion Maximum acceptable version of IPA module\n> *\n> + * Create an IPA module using \\a name as the matching identifier. This overload\n> + * allows pipeline handlers to create an IPA module by specifying its name\n> + * instead of relying on the fact that the IPA module matches the pipeline\n> + * handler's one.\n> + *\n> + * \\return A newly created IPA proxy, or nullptr if no matching IPA module is\n> + * found or if the IPA proxy fails to initialize\n> + */\n> +\n> +/**\n> + * \\fn IPAManager::createIPA(PipelineHandler *pipe, uint32_t minVersion, uint32_t maxVersion)\n> + * \\brief Create an IPA proxy that matches the pipeline handler name and the\n> + * requested version\n> + * \\param[in] pipe The pipeline handler that wants to create the IPA module\n> + * \\param[in] minVersion Minimum acceptable version of IPA module\n> + * \\param[in] maxVersion Maximum acceptable version of IPA module\n> + *\n> + * Create an IPA module using the pipeline handler name as the matching\n> + * identifier. This overload allows pipeline handler to create an IPA module\n> + * whose name matches the pipeline handler one.\n> + *\n> * \\return A newly created IPA proxy, or nullptr if no matching IPA module is\n> * found or if the IPA proxy fails to initialize\n> */\n> diff --git a/src/libcamera/ipa_module.cpp b/src/libcamera/ipa_module.cpp\n> index e6ea61e4482983a83b4185c4309f2c514ed24fc2..0bd6f14626fe2038072f48b70ca4341b0eb8cef5 100644\n> --- a/src/libcamera/ipa_module.cpp\n> +++ b/src/libcamera/ipa_module.cpp\n> @@ -463,21 +463,21 @@ IPAInterface *IPAModule::createInterface()\n> \n> /**\n> * \\brief Verify if the IPA module matches a given pipeline handler\n> - * \\param[in] pipe Pipeline handler to match with\n> + * \\param[in] name The IPA module name\n> * \\param[in] minVersion Minimum acceptable version of IPA module\n> * \\param[in] maxVersion Maximum acceptable version of IPA module\n> *\n> - * This function checks if this IPA module matches the \\a pipe pipeline handler,\n> + * This function checks if this IPA module matches the requested \\a name\n> * and the input version range.\n> *\n> - * \\return True if the pipeline handler matches the IPA module, or false otherwise\n> + * \\return True if the IPA module matches, or false otherwise\n> */\n> -bool IPAModule::match(PipelineHandler *pipe,\n> -\t\t uint32_t minVersion, uint32_t maxVersion) const\n> +bool IPAModule::match(const char *name, uint32_t minVersion,\n> +\t\t uint32_t maxVersion) const\n> {\n> \treturn info_.pipelineVersion >= minVersion &&\n> \t info_.pipelineVersion <= maxVersion &&\n> -\t !strcmp(info_.pipelineName, pipe->name());\n> +\t !strcmp(info_.name, name);\n> }\n> \n> std::string IPAModule::logPrefix() const\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 748AFBF415\n\tfor ;\n\tFri, 3 Oct 2025 14:00:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 29FAA6B5F9;\n\tFri, 3 Oct 2025 16:00:27 +0200 (CEST)","from tor.source.kernel.org (tor.source.kernel.org\n\t[IPv6:2600:3c04:e001:324:0:1991:8:25])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6BE6069318\n\tfor ;\n\tFri, 3 Oct 2025 16:00:25 +0200 (CEST)","from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n\tby tor.source.kernel.org (Postfix) with ESMTP id 1751F62169;\n\tFri, 3 Oct 2025 14:00:24 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id E9C61C4CEF5;\n\tFri, 3 Oct 2025 14:00:22 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=kernel.org header.i=@kernel.org\n\theader.b=\"B/w9j+S+\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1759500023;\n\tbh=UAQK1pDalMprqtCjxSOIeufJmHPuKlkgNMDno6OeuaA=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=B/w9j+S+gDr8Tnam5Ukvxtpl91xmBB+8FZYFZyEk7CSDSJ5Y0frdapaRXFoF86k6B\n\tPNZ7La8jqCKVqZyXvZtxSAF7Qfk8iaYC0FSa9v7R80IAJ7if68zFs/4wAcqkg3Q0lg\n\tk17tykZWwdmhuCqltfqFVLP5T03ZvBGLnLJiS04b/yiq3/JJoDwYEioRzOXaJLEm5M\n\twk7BhIXt6B76TGAcT649PPqpWh8WRAog5EXzX8pGhOlRABcdpyZlMWHlsbGdYXEOTN\n\tE5qShJ/qWqsqEuVdLvzTwAG18qnShej6g1zAog0bq8gG9ECjr7ACpZWxPBnnhnXKaD\n\tUrdfCGMV9YXHg==","Message-ID":"","Date":"Fri, 3 Oct 2025 16:00:21 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 1/2] libcamera: ipa_manager: Create IPA by name","To":"Jacopo Mondi ,\n\tlibcamera-devel@lists.libcamera.org, =?utf-8?q?Niklas_S=C3=B6derlund?=\n\t","Cc":"Hans de Goede ","References":"<20251003-ipa-match-by-name-v1-0-07b796729412@ideasonboard.com>\n\t<20251003-ipa-match-by-name-v1-1-07b796729412@ideasonboard.com>","From":"Hans de Goede ","Content-Language":"en-US, nl","In-Reply-To":"<20251003-ipa-match-by-name-v1-1-07b796729412@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":36117,"web_url":"https://patchwork.libcamera.org/comment/36117/","msgid":"","date":"2025-10-03T16:12:52","subject":"Re: [PATCH 1/2] libcamera: ipa_manager: Create IPA by name","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Barnabás\n\nOn Fri, Oct 03, 2025 at 11:52:14AM +0200, Barnabás Pőcze wrote:\n> Hi\n>\n>\n> 2025. 10. 03. 11:27 keltezéssel, Jacopo Mondi írta:\n> > From: Hans de Goede \n> >\n> > Currently createIPA() / IPAManager::module() assume that there is a 1:1\n> > relationship between pipeline handlers and IPAs and IPA matching is done\n> > based on matching the pipe to ipaModuleInfo.pipelineName[].\n> >\n> > One way to allow using a single IPA with multiple pipelines would be to\n> > allow the IPA to declare itself compatible with more than one pipeline,\n> > turning ipaModuleInfo.pipelineName[] into e.g. a vector. But the way\n> > ipaModuleInfo is loaded as an ELF symbol requires it to be a simple flat\n> > C-struct.\n> >\n> > Instead, move the IPA creation procedure to be name-based, introducing\n> > an overload to IPAManager::createIPA(pipe, name, minVer, maxVer) that\n> > allows to specify the name of the IPA module to match. Pipeline handlers\n> > that wants to use their name as matching criteria can continue doing so\n> > using the already existing createIPA(pipe, minVer, maxVer) overload.\n>\n> When this was first proposed, I looked at the possibility of adding the name to the\n> generated proxy type as a static constexpr member to avoid any potential type confusion.\n> But sadly the way the raspberry pi modules are handled makes that more complicated.\n>\n>\n> >\n> > Signed-off-by: Hans de Goede \n> > Signed-off-by: Jacopo Mondi \n> > ---\n> > include/libcamera/internal/ipa_manager.h | 14 +++++++++++--\n> > include/libcamera/internal/ipa_module.h | 4 ++--\n> > src/libcamera/ipa_manager.cpp | 34 ++++++++++++++++++++++++++------\n> > src/libcamera/ipa_module.cpp | 12 +++++------\n> > 4 files changed, 48 insertions(+), 16 deletions(-)\n> >\n> > diff --git a/include/libcamera/internal/ipa_manager.h b/include/libcamera/internal/ipa_manager.h\n> > index f8ce780169e617088557888d7c8dae2d3f10ec08..8bc8680be0a4a6db0cdb57c1a9400c23efecda0c 100644\n> > --- a/include/libcamera/internal/ipa_manager.h\n> > +++ b/include/libcamera/internal/ipa_manager.h\n> > @@ -34,12 +34,14 @@ public:\n> > \ttemplate\n> > \tstatic std::unique_ptr createIPA(PipelineHandler *pipe,\n> > +\t\t\t\t\t const char *name,\n> > \t\t\t\t\t uint32_t minVersion,\n> > \t\t\t\t\t uint32_t maxVersion)\n> > +\n> > \t{\n> > \t\tCameraManager *cm = pipe->cameraManager();\n>\n> Since `pipe` is only used to get the camera manager, could we take that as argument instead?\n\nIsn't it more natural for callers to pass \"this\" instead of accessing\nthe camera manager themselves ?\n\nDO you feel strongly about this or can I leave it as it is ?\n\n>\n>\n> Regards,\n> Barnabás Pőcze\n>\n> > \t\tIPAManager *self = cm->_d()->ipaManager();\n> > -\t\tIPAModule *m = self->module(pipe, minVersion, maxVersion);\n> > +\t\tIPAModule *m = self->module(name, minVersion, maxVersion);\n> > \t\tif (!m)\n> > \t\t\treturn nullptr;\n> > @@ -60,6 +62,14 @@ public:\n> > \t\treturn proxy;\n> > \t}\n> > +\ttemplate\n> > +\tstatic std::unique_ptr createIPA(PipelineHandler *pipe,\n> > +\t\t\t\t\t uint32_t minVersion,\n> > +\t\t\t\t\t uint32_t maxVersion)\n> > +\t{\n> > +\t\treturn createIPA(pipe, pipe->name(), minVersion, maxVersion);\n> > +\t}\n> > +\n> > #if HAVE_IPA_PUBKEY\n> > \tstatic const PubKey &pubKey()\n> > \t{\n> > @@ -72,7 +82,7 @@ private:\n> > \t\t std::vector &files);\n> > \tunsigned int addDir(const char *libDir, unsigned int maxDepth = 0);\n> > -\tIPAModule *module(PipelineHandler *pipe, uint32_t minVersion,\n> > +\tIPAModule *module(const char *name, uint32_t minVersion,\n> > \t\t\t uint32_t maxVersion);\n> > \tbool isSignatureValid(IPAModule *ipa) const;\n> > diff --git a/include/libcamera/internal/ipa_module.h b/include/libcamera/internal/ipa_module.h\n> > index 15f19492c3a027a0bc4f9572188d13af41fcd450..a0a53764e1394abed3bab92cdde9f33a86441c5f 100644\n> > --- a/include/libcamera/internal/ipa_module.h\n> > +++ b/include/libcamera/internal/ipa_module.h\n> > @@ -36,8 +36,8 @@ public:\n> > \tIPAInterface *createInterface();\n> > -\tbool match(PipelineHandler *pipe,\n> > -\t\t uint32_t minVersion, uint32_t maxVersion) const;\n> > +\tbool match(const char *name, uint32_t minVersion,\n> > +\t\t uint32_t maxVersion) const;\n> > protected:\n> > \tstd::string logPrefix() const override;\n> > diff --git a/src/libcamera/ipa_manager.cpp b/src/libcamera/ipa_manager.cpp\n> > index 35171d097136a6d85b8f518c099f8228f9eacd6f..f62a4ee5fd012d23ce178d59f84c6ab49513376b 100644\n> > --- a/src/libcamera/ipa_manager.cpp\n> > +++ b/src/libcamera/ipa_manager.cpp\n> > @@ -247,15 +247,15 @@ unsigned int IPAManager::addDir(const char *libDir, unsigned int maxDepth)\n> > /**\n> > * \\brief Retrieve an IPA module that matches a given pipeline handler\n> > - * \\param[in] pipe The pipeline handler\n> > + * \\param[in] name The IPA module string identifier\n> > * \\param[in] minVersion Minimum acceptable version of IPA module\n> > * \\param[in] maxVersion Maximum acceptable version of IPA module\n> > */\n> > -IPAModule *IPAManager::module(PipelineHandler *pipe, uint32_t minVersion,\n> > +IPAModule *IPAManager::module(const char *name, uint32_t minVersion,\n> > \t\t\t uint32_t maxVersion)\n> > {\n> > \tfor (const auto &module : modules_) {\n> > -\t\tif (module->match(pipe, minVersion, maxVersion))\n> > +\t\tif (module->match(name, minVersion, maxVersion))\n> > \t\t\treturn module.get();\n> > \t}\n> > @@ -263,12 +263,34 @@ IPAModule *IPAManager::module(PipelineHandler *pipe, uint32_t minVersion,\n> > }\n> > /**\n> > - * \\fn IPAManager::createIPA()\n> > - * \\brief Create an IPA proxy that matches a given pipeline handler\n> > - * \\param[in] pipe The pipeline handler that wants a matching IPA proxy\n> > + * \\fn IPAManager::createIPA(PipelineHandler *pipe, const char *ipaName, uint32_t minVersion, uint32_t maxVersion)\n> > + * \\brief Create an IPA proxy that matches the requested name and version\n> > + * \\param[in] pipe The pipeline handler that wants to create the IPA module\n> > + * \\param[in] ipaName The IPA module name\n> > * \\param[in] minVersion Minimum acceptable version of IPA module\n> > * \\param[in] maxVersion Maximum acceptable version of IPA module\n> > *\n> > + * Create an IPA module using \\a name as the matching identifier. This overload\n> > + * allows pipeline handlers to create an IPA module by specifying its name\n> > + * instead of relying on the fact that the IPA module matches the pipeline\n> > + * handler's one.\n> > + *\n> > + * \\return A newly created IPA proxy, or nullptr if no matching IPA module is\n> > + * found or if the IPA proxy fails to initialize\n> > + */\n> > +\n> > +/**\n> > + * \\fn IPAManager::createIPA(PipelineHandler *pipe, uint32_t minVersion, uint32_t maxVersion)\n> > + * \\brief Create an IPA proxy that matches the pipeline handler name and the\n> > + * requested version\n> > + * \\param[in] pipe The pipeline handler that wants to create the IPA module\n> > + * \\param[in] minVersion Minimum acceptable version of IPA module\n> > + * \\param[in] maxVersion Maximum acceptable version of IPA module\n> > + *\n> > + * Create an IPA module using the pipeline handler name as the matching\n> > + * identifier. This overload allows pipeline handler to create an IPA module\n> > + * whose name matches the pipeline handler one.\n> > + *\n> > * \\return A newly created IPA proxy, or nullptr if no matching IPA module is\n> > * found or if the IPA proxy fails to initialize\n> > */\n> > diff --git a/src/libcamera/ipa_module.cpp b/src/libcamera/ipa_module.cpp\n> > index e6ea61e4482983a83b4185c4309f2c514ed24fc2..0bd6f14626fe2038072f48b70ca4341b0eb8cef5 100644\n> > --- a/src/libcamera/ipa_module.cpp\n> > +++ b/src/libcamera/ipa_module.cpp\n> > @@ -463,21 +463,21 @@ IPAInterface *IPAModule::createInterface()\n> > /**\n> > * \\brief Verify if the IPA module matches a given pipeline handler\n> > - * \\param[in] pipe Pipeline handler to match with\n> > + * \\param[in] name The IPA module name\n> > * \\param[in] minVersion Minimum acceptable version of IPA module\n> > * \\param[in] maxVersion Maximum acceptable version of IPA module\n> > *\n> > - * This function checks if this IPA module matches the \\a pipe pipeline handler,\n> > + * This function checks if this IPA module matches the requested \\a name\n> > * and the input version range.\n> > *\n> > - * \\return True if the pipeline handler matches the IPA module, or false otherwise\n> > + * \\return True if the IPA module matches, or false otherwise\n> > */\n> > -bool IPAModule::match(PipelineHandler *pipe,\n> > -\t\t uint32_t minVersion, uint32_t maxVersion) const\n> > +bool IPAModule::match(const char *name, uint32_t minVersion,\n> > +\t\t uint32_t maxVersion) const\n> > {\n> > \treturn info_.pipelineVersion >= minVersion &&\n> > \t info_.pipelineVersion <= maxVersion &&\n> > -\t !strcmp(info_.pipelineName, pipe->name());\n> > +\t !strcmp(info_.name, name);\n> > }\n> > std::string IPAModule::logPrefix() const\n> >\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8C670BF415\n\tfor ;\n\tFri, 3 Oct 2025 16:12:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5E4A46B5F3;\n\tFri, 3 Oct 2025 18:12:58 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3D68069318\n\tfor ;\n\tFri, 3 Oct 2025 18:12:56 +0200 (CEST)","from ideasonboard.com (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2BE0A192C;\n\tFri, 3 Oct 2025 18:11:25 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"MFKzGsk+\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1759507885;\n\tbh=k62L4PdgG6arywBKUDnFD+/upv/Oc4QTgU3fgmPjlLs=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=MFKzGsk+cG5h1eTj7mrAk9A1D2WE5t2yMMneEOlkwBWCnJyWi7YHrBZTSB32OEvop\n\tg2HHcfxYmmPdDm6CKlR0yd/NWX2DGz1RvLc9ECjW6Ogcdx7HzjNVxfLM7DxpcjjPpG\n\tnzACsvYrQkiUQIehOWCOQOk6n9OEll0bB9ke81gY=","Date":"Fri, 3 Oct 2025 18:12:52 +0200","From":"Jacopo Mondi ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"Jacopo Mondi , \n\tlibcamera-devel@lists.libcamera.org, Niklas =?utf-8?q?S=C3=B6derlund?=\n\t,\n\tHans de Goede , Hans de Goede ","Subject":"Re: [PATCH 1/2] libcamera: ipa_manager: Create IPA by name","Message-ID":"","References":"<20251003-ipa-match-by-name-v1-0-07b796729412@ideasonboard.com>\n\t<20251003-ipa-match-by-name-v1-1-07b796729412@ideasonboard.com>\n\t<5bf4070f-6dc9-49db-8c2a-ce1d790f1b0a@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<5bf4070f-6dc9-49db-8c2a-ce1d790f1b0a@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":36118,"web_url":"https://patchwork.libcamera.org/comment/36118/","msgid":"<5c2f793e-ce95-4c71-b6df-9f450f88575f@ideasonboard.com>","date":"2025-10-03T16:19:29","subject":"Re: [PATCH 1/2] libcamera: ipa_manager: Create IPA by name","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2025. 10. 03. 18:12 keltezéssel, Jacopo Mondi írta:\n> Hi Barnabás\n> \n> On Fri, Oct 03, 2025 at 11:52:14AM +0200, Barnabás Pőcze wrote:\n>> Hi\n>>\n>>\n>> 2025. 10. 03. 11:27 keltezéssel, Jacopo Mondi írta:\n>>> From: Hans de Goede \n>>>\n>>> Currently createIPA() / IPAManager::module() assume that there is a 1:1\n>>> relationship between pipeline handlers and IPAs and IPA matching is done\n>>> based on matching the pipe to ipaModuleInfo.pipelineName[].\n>>>\n>>> One way to allow using a single IPA with multiple pipelines would be to\n>>> allow the IPA to declare itself compatible with more than one pipeline,\n>>> turning ipaModuleInfo.pipelineName[] into e.g. a vector. But the way\n>>> ipaModuleInfo is loaded as an ELF symbol requires it to be a simple flat\n>>> C-struct.\n>>>\n>>> Instead, move the IPA creation procedure to be name-based, introducing\n>>> an overload to IPAManager::createIPA(pipe, name, minVer, maxVer) that\n>>> allows to specify the name of the IPA module to match. Pipeline handlers\n>>> that wants to use their name as matching criteria can continue doing so\n>>> using the already existing createIPA(pipe, minVer, maxVer) overload.\n>>\n>> When this was first proposed, I looked at the possibility of adding the name to the\n>> generated proxy type as a static constexpr member to avoid any potential type confusion.\n>> But sadly the way the raspberry pi modules are handled makes that more complicated.\n>>\n>>\n>>>\n>>> Signed-off-by: Hans de Goede \n>>> Signed-off-by: Jacopo Mondi \n>>> ---\n>>> include/libcamera/internal/ipa_manager.h | 14 +++++++++++--\n>>> include/libcamera/internal/ipa_module.h | 4 ++--\n>>> src/libcamera/ipa_manager.cpp | 34 ++++++++++++++++++++++++++------\n>>> src/libcamera/ipa_module.cpp | 12 +++++------\n>>> 4 files changed, 48 insertions(+), 16 deletions(-)\n>>>\n>>> diff --git a/include/libcamera/internal/ipa_manager.h b/include/libcamera/internal/ipa_manager.h\n>>> index f8ce780169e617088557888d7c8dae2d3f10ec08..8bc8680be0a4a6db0cdb57c1a9400c23efecda0c 100644\n>>> --- a/include/libcamera/internal/ipa_manager.h\n>>> +++ b/include/libcamera/internal/ipa_manager.h\n>>> @@ -34,12 +34,14 @@ public:\n>>> \ttemplate\n>>> \tstatic std::unique_ptr createIPA(PipelineHandler *pipe,\n>>> +\t\t\t\t\t const char *name,\n>>> \t\t\t\t\t uint32_t minVersion,\n>>> \t\t\t\t\t uint32_t maxVersion)\n>>> +\n>>> \t{\n>>> \t\tCameraManager *cm = pipe->cameraManager();\n>>\n>> Since `pipe` is only used to get the camera manager, could we take that as argument instead?\n> \n> Isn't it more natural for callers to pass \"this\" instead of accessing\n> the camera manager themselves ?\n\nI suppose it is.\n\n\n> \n> DO you feel strongly about this or can I leave it as it is ?\n\nLet us leave it as is, if a use case appears, it can always be modified.\n\n\n> \n>>\n>>\n>> Regards,\n>> Barnabás Pőcze\n>>\n>>> \t\tIPAManager *self = cm->_d()->ipaManager();\n>>> -\t\tIPAModule *m = self->module(pipe, minVersion, maxVersion);\n>>> +\t\tIPAModule *m = self->module(name, minVersion, maxVersion);\n>>> \t\tif (!m)\n>>> \t\t\treturn nullptr;\n>>> @@ -60,6 +62,14 @@ public:\n>>> \t\treturn proxy;\n>>> \t}\n>>> +\ttemplate\n>>> +\tstatic std::unique_ptr createIPA(PipelineHandler *pipe,\n>>> +\t\t\t\t\t uint32_t minVersion,\n>>> +\t\t\t\t\t uint32_t maxVersion)\n>>> +\t{\n>>> +\t\treturn createIPA(pipe, pipe->name(), minVersion, maxVersion);\n>>> +\t}\n>>> +\n>>> #if HAVE_IPA_PUBKEY\n>>> \tstatic const PubKey &pubKey()\n>>> \t{\n>>> @@ -72,7 +82,7 @@ private:\n>>> \t\t std::vector &files);\n>>> \tunsigned int addDir(const char *libDir, unsigned int maxDepth = 0);\n>>> -\tIPAModule *module(PipelineHandler *pipe, uint32_t minVersion,\n>>> +\tIPAModule *module(const char *name, uint32_t minVersion,\n>>> \t\t\t uint32_t maxVersion);\n>>> \tbool isSignatureValid(IPAModule *ipa) const;\n>>> diff --git a/include/libcamera/internal/ipa_module.h b/include/libcamera/internal/ipa_module.h\n>>> index 15f19492c3a027a0bc4f9572188d13af41fcd450..a0a53764e1394abed3bab92cdde9f33a86441c5f 100644\n>>> --- a/include/libcamera/internal/ipa_module.h\n>>> +++ b/include/libcamera/internal/ipa_module.h\n>>> @@ -36,8 +36,8 @@ public:\n>>> \tIPAInterface *createInterface();\n>>> -\tbool match(PipelineHandler *pipe,\n>>> -\t\t uint32_t minVersion, uint32_t maxVersion) const;\n>>> +\tbool match(const char *name, uint32_t minVersion,\n>>> +\t\t uint32_t maxVersion) const;\n>>> protected:\n>>> \tstd::string logPrefix() const override;\n>>> diff --git a/src/libcamera/ipa_manager.cpp b/src/libcamera/ipa_manager.cpp\n>>> index 35171d097136a6d85b8f518c099f8228f9eacd6f..f62a4ee5fd012d23ce178d59f84c6ab49513376b 100644\n>>> --- a/src/libcamera/ipa_manager.cpp\n>>> +++ b/src/libcamera/ipa_manager.cpp\n>>> @@ -247,15 +247,15 @@ unsigned int IPAManager::addDir(const char *libDir, unsigned int maxDepth)\n>>> /**\n>>> * \\brief Retrieve an IPA module that matches a given pipeline handler\n>>> - * \\param[in] pipe The pipeline handler\n>>> + * \\param[in] name The IPA module string identifier\n>>> * \\param[in] minVersion Minimum acceptable version of IPA module\n>>> * \\param[in] maxVersion Maximum acceptable version of IPA module\n>>> */\n>>> -IPAModule *IPAManager::module(PipelineHandler *pipe, uint32_t minVersion,\n>>> +IPAModule *IPAManager::module(const char *name, uint32_t minVersion,\n>>> \t\t\t uint32_t maxVersion)\n>>> {\n>>> \tfor (const auto &module : modules_) {\n>>> -\t\tif (module->match(pipe, minVersion, maxVersion))\n>>> +\t\tif (module->match(name, minVersion, maxVersion))\n>>> \t\t\treturn module.get();\n>>> \t}\n>>> @@ -263,12 +263,34 @@ IPAModule *IPAManager::module(PipelineHandler *pipe, uint32_t minVersion,\n>>> }\n>>> /**\n>>> - * \\fn IPAManager::createIPA()\n>>> - * \\brief Create an IPA proxy that matches a given pipeline handler\n>>> - * \\param[in] pipe The pipeline handler that wants a matching IPA proxy\n>>> + * \\fn IPAManager::createIPA(PipelineHandler *pipe, const char *ipaName, uint32_t minVersion, uint32_t maxVersion)\n>>> + * \\brief Create an IPA proxy that matches the requested name and version\n>>> + * \\param[in] pipe The pipeline handler that wants to create the IPA module\n>>> + * \\param[in] ipaName The IPA module name\n>>> * \\param[in] minVersion Minimum acceptable version of IPA module\n>>> * \\param[in] maxVersion Maximum acceptable version of IPA module\n>>> *\n>>> + * Create an IPA module using \\a name as the matching identifier. This overload\n>>> + * allows pipeline handlers to create an IPA module by specifying its name\n>>> + * instead of relying on the fact that the IPA module matches the pipeline\n>>> + * handler's one.\n>>> + *\n>>> + * \\return A newly created IPA proxy, or nullptr if no matching IPA module is\n>>> + * found or if the IPA proxy fails to initialize\n>>> + */\n>>> +\n>>> +/**\n>>> + * \\fn IPAManager::createIPA(PipelineHandler *pipe, uint32_t minVersion, uint32_t maxVersion)\n>>> + * \\brief Create an IPA proxy that matches the pipeline handler name and the\n>>> + * requested version\n>>> + * \\param[in] pipe The pipeline handler that wants to create the IPA module\n>>> + * \\param[in] minVersion Minimum acceptable version of IPA module\n>>> + * \\param[in] maxVersion Maximum acceptable version of IPA module\n>>> + *\n>>> + * Create an IPA module using the pipeline handler name as the matching\n>>> + * identifier. This overload allows pipeline handler to create an IPA module\n>>> + * whose name matches the pipeline handler one.\n>>> + *\n>>> * \\return A newly created IPA proxy, or nullptr if no matching IPA module is\n>>> * found or if the IPA proxy fails to initialize\n>>> */\n>>> diff --git a/src/libcamera/ipa_module.cpp b/src/libcamera/ipa_module.cpp\n>>> index e6ea61e4482983a83b4185c4309f2c514ed24fc2..0bd6f14626fe2038072f48b70ca4341b0eb8cef5 100644\n>>> --- a/src/libcamera/ipa_module.cpp\n>>> +++ b/src/libcamera/ipa_module.cpp\n>>> @@ -463,21 +463,21 @@ IPAInterface *IPAModule::createInterface()\n>>> /**\n>>> * \\brief Verify if the IPA module matches a given pipeline handler\n>>> - * \\param[in] pipe Pipeline handler to match with\n>>> + * \\param[in] name The IPA module name\n>>> * \\param[in] minVersion Minimum acceptable version of IPA module\n>>> * \\param[in] maxVersion Maximum acceptable version of IPA module\n>>> *\n>>> - * This function checks if this IPA module matches the \\a pipe pipeline handler,\n>>> + * This function checks if this IPA module matches the requested \\a name\n>>> * and the input version range.\n>>> *\n>>> - * \\return True if the pipeline handler matches the IPA module, or false otherwise\n>>> + * \\return True if the IPA module matches, or false otherwise\n>>> */\n>>> -bool IPAModule::match(PipelineHandler *pipe,\n>>> -\t\t uint32_t minVersion, uint32_t maxVersion) const\n>>> +bool IPAModule::match(const char *name, uint32_t minVersion,\n>>> +\t\t uint32_t maxVersion) const\n>>> {\n>>> \treturn info_.pipelineVersion >= minVersion &&\n>>> \t info_.pipelineVersion <= maxVersion &&\n>>> -\t !strcmp(info_.pipelineName, pipe->name());\n>>> +\t !strcmp(info_.name, name);\n>>> }\n>>> std::string IPAModule::logPrefix() const\n>>>\n>>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 83E67C324C\n\tfor ;\n\tFri, 3 Oct 2025 16:19:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 90FF069318;\n\tFri, 3 Oct 2025 18:19:37 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0113669318\n\tfor ;\n\tFri, 3 Oct 2025 18:19:34 +0200 (CEST)","from [192.168.33.17] (185.182.214.142.nat.pool.zt.hu\n\t[185.182.214.142])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4210A1F16;\n\tFri, 3 Oct 2025 18:18:03 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ubPWUM39\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1759508283;\n\tbh=h+h0tfRce04wfO813cYmt7oZnHhSMej6i2pAteDhn0g=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=ubPWUM39QCEvDukr56Y5T00Dpv8hDhyx42QnsFixqqb6iEVpDcbuRsX7emDUnnL7D\n\t3LnrzSUoeZva9N44vU8zJj/qMKI1+9ZmP9aUXk0e3y63VVlFkwd+5NcSmSQ+BOtvSM\n\tUCVCN2FRxHq+RxzQSnWm4NwMulFTiIAjsaxSlFGU=","Message-ID":"<5c2f793e-ce95-4c71-b6df-9f450f88575f@ideasonboard.com>","Date":"Fri, 3 Oct 2025 18:19:29 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 1/2] libcamera: ipa_manager: Create IPA by name","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org, =?utf-8?q?Niklas_S=C3=B6derlund?=\n\t, Hans de Goede\n\t, Hans de Goede ","References":"<20251003-ipa-match-by-name-v1-0-07b796729412@ideasonboard.com>\n\t<20251003-ipa-match-by-name-v1-1-07b796729412@ideasonboard.com>\n\t<5bf4070f-6dc9-49db-8c2a-ce1d790f1b0a@ideasonboard.com>\n\t","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]