[{"id":36080,"web_url":"https://patchwork.libcamera.org/comment/36080/","msgid":"<20251002150121.GA20509@pendragon.ideasonboard.com>","date":"2025-10-02T15:01:21","subject":"Re: [PATCH v1] libcamera: pipeline: rpi: Set `werror=false` for\n\tlibpisp","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Barnabás,\n\nOn Thu, Oct 02, 2025 at 04:55:06PM +0200, Barnabás Pőcze wrote:\n> By default libcamera is configured with `werror=true`, and this option can\n> propagate into the subprojects. This can lead to compilation failures due to\n> warnings in those subprojects. This is the case with libpisp. Since these\n> issues are not directly fixable, set `werror=false` for libpisp.\n\nCan't we fix those errors ?\n\n> Signed-off-by: Barnabás Pőcze \n> ---\n> src/libcamera/pipeline/rpi/pisp/meson.build | 4 +++-\n> 1 file changed, 3 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/rpi/pisp/meson.build b/src/libcamera/pipeline/rpi/pisp/meson.build\n> index 178df94c2..642080014 100644\n> --- a/src/libcamera/pipeline/rpi/pisp/meson.build\n> +++ b/src/libcamera/pipeline/rpi/pisp/meson.build\n> @@ -5,7 +5,9 @@ libcamera_internal_sources += files([\n> ])\n> \n> librt = cc.find_library('rt', required : true)\n> -libpisp_dep = dependency('libpisp', fallback : ['libpisp', 'libpisp_dep'])\n> +libpisp_dep = dependency('libpisp',\n> + fallback : ['libpisp', 'libpisp_dep'],\n> + default_options : ['werror=false'])\n> \n> libcamera_deps += [libpisp_dep, librt]\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2D2FDC324C\n\tfor ;\n\tThu, 2 Oct 2025 15:01:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1B88C6B5F8;\n\tThu, 2 Oct 2025 17:01:28 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C01626B5A2\n\tfor ;\n\tThu, 2 Oct 2025 17:01:26 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id C597DC7A;\n\tThu, 2 Oct 2025 16:59:56 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"gb1pA9me\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1759417197;\n\tbh=4LXHr+4UD4KHYOzn2FRbfCbAk0XIzcP18Esl5EdSDoQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=gb1pA9mecbMB49gRMCVHDyT7utXQDeNxri+T2RCWJKFH/XtQYhea0z57Pjufm4g2b\n\tGoDad2qnTXTDXUifM6ZXgZF9ZxVNyp7aaw9tcZXzScz5ieOc0FMtTCrLPU1QpjHc+6\n\tHxDfUPpNUM1CCnLDt9T0gY8BPQuB94QtAHu5eKnQ=","Date":"Thu, 2 Oct 2025 18:01:21 +0300","From":"Laurent Pinchart ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v1] libcamera: pipeline: rpi: Set `werror=false` for\n\tlibpisp","Message-ID":"<20251002150121.GA20509@pendragon.ideasonboard.com>","References":"<20251002145506.996443-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20251002145506.996443-1-barnabas.pocze@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":36081,"web_url":"https://patchwork.libcamera.org/comment/36081/","msgid":"","date":"2025-10-02T15:09:51","subject":"Re: [PATCH v1] libcamera: pipeline: rpi: Set `werror=false` for\n\tlibpisp","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi,\n\n\nOn Thu, 2 Oct 2025 at 16:01, Laurent Pinchart <\nlaurent.pinchart@ideasonboard.com> wrote:\n\n> Hi Barnabás,\n>\n> On Thu, Oct 02, 2025 at 04:55:06PM +0200, Barnabás Pőcze wrote:\n> > By default libcamera is configured with `werror=true`, and this option\n> can\n> > propagate into the subprojects. This can lead to compilation failures\n> due to\n> > warnings in those subprojects. This is the case with libpisp. Since these\n> > issues are not directly fixable, set `werror=false` for libpisp.\n>\n> Can't we fix those errors ?\n>\n\nI've not noticed any compilation warnings over the few versions of gcc and\nclang that we use in CI. We'd be happy to fix any warnings if you can\nshare the compile logs.\n\nRegards,\nNaush\n\n\n>\n> > Signed-off-by: Barnabás Pőcze \n> > ---\n> > src/libcamera/pipeline/rpi/pisp/meson.build | 4 +++-\n> > 1 file changed, 3 insertions(+), 1 deletion(-)\n> >\n> > diff --git a/src/libcamera/pipeline/rpi/pisp/meson.build\n> b/src/libcamera/pipeline/rpi/pisp/meson.build\n> > index 178df94c2..642080014 100644\n> > --- a/src/libcamera/pipeline/rpi/pisp/meson.build\n> > +++ b/src/libcamera/pipeline/rpi/pisp/meson.build\n> > @@ -5,7 +5,9 @@ libcamera_internal_sources += files([\n> > ])\n> >\n> > librt = cc.find_library('rt', required : true)\n> > -libpisp_dep = dependency('libpisp', fallback : ['libpisp',\n> 'libpisp_dep'])\n> > +libpisp_dep = dependency('libpisp',\n> > + fallback : ['libpisp', 'libpisp_dep'],\n> > + default_options : ['werror=false'])\n> >\n> > libcamera_deps += [libpisp_dep, librt]\n> >\n>\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6F66AC328C\n\tfor ;\n\tThu, 2 Oct 2025 15:10:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5C0FF6B5F8;\n\tThu, 2 Oct 2025 17:10:30 +0200 (CEST)","from mail-vs1-xe34.google.com (mail-vs1-xe34.google.com\n\t[IPv6:2607:f8b0:4864:20::e34])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9F85C6B5A2\n\tfor ;\n\tThu, 2 Oct 2025 17:10:28 +0200 (CEST)","by mail-vs1-xe34.google.com with SMTP id\n\tada2fe7eead31-5d17a9dc7a2so76931137.3\n\tfor ;\n\tThu, 02 Oct 2025 08:10:28 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"hHVxdagh\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1759417827; x=1760022627;\n\tdarn=lists.libcamera.org; \n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=QjUdAugYLFUnettGQJI4RbzT4UYueYJliwRnVMxYVWQ=;\n\tb=hHVxdaghTxeA68WMdymvBszvGnxvo0Y3x2pfP2xqwfNE21dFgrV1/NGY0XZ2iBKpVd\n\ta5Jia4RKjLNwZofo+mrbJb9TCNxjJUkf41AjRkHmbHzmsoLwWwMzafn/3Z9aeHWXbqKL\n\tKs/jNOxfU3mLooLAa0rByP2c+6G7aiseIiABiDtIcylqEhva61+45koVcn07+j28kEbK\n\tCCLqLxhvg2wIQf5ELB4BERet4O4TMDQSU7N5hyhLTMMJVbCFMI+VEOyENkBmnj98CmkS\n\tvDI1xkkE8USePOYh8piwVvhipRMCXvvG36033jOuis7HqhuCz6dEkTFc+M5ikBEgnrFi\n\tm3gA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1759417827; x=1760022627;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=QjUdAugYLFUnettGQJI4RbzT4UYueYJliwRnVMxYVWQ=;\n\tb=Fy8x5d3nOJ/acy+BCizKE7B/VnZ2/hMZ0nlgYw4SQ4Wace+yBr95FlcGRGW5+cIc2q\n\tmnxulZRVdZUtIrDXtqZ3vzUxZHueydbblzp7avBx/rFnZ+i/DF013m70zshZiS6Hb28G\n\taCYRwEze7YqYjYCuoJbaGHrINpPV5J1V1FttHAC72Ff2Li/x9Brx7OtH1k+l5snTl4O4\n\tI1l/ggIrvPwyJsVBpmokkbFEWX2tHU2lhzKrYVr/aagBxQDn8Obo91UZEQf7W+r6rAqQ\n\t7xK5mo5U0FBAsidbWxZZgEKxmKXgjg/P/09STWuuqytY/FfvZH8Md+GMbbQIQDaCD9QI\n\twdTw==","X-Forwarded-Encrypted":"i=1;\n\tAJvYcCUnGy7PG/ABT4pi6Z95npLTl80jnY0FgvLl65PvkwQNct0TAb1rNWnzMb4bsFex6N2elcjj6pnJm0HOwJs3tr4=@lists.libcamera.org","X-Gm-Message-State":"AOJu0YzZf8Kq4ExMQWAjC6YC5ew/XdBWElmee9nJJJuhdMgxbipK9x/r\n\tA3b4f0aHTKqYQuwg+goQpPSeJUgx31Atjw3i4zFGqKSdy7QE0GXzOSHdarm6sbdSpOl9znaM3eH\n\tCRcnWFjCDXd8uBrxW+2+jXFPHe27Q+G5B5wO9alCkdVhfdBVnMDHR","X-Gm-Gg":"ASbGnctk69rvt3WqPCC7KEUCahaF1+cl478O8bkel3uAcjuZ/Fy3+UoJpAQatgmfyIb\n\tdZTwQ6sHWEcVV1wEhpOa56DPvnxVWnD6kmwLyfs90DQsLMqoJEPy6MH0FdlqKAfTLvAAE/rBRuA\n\tlElYHthOpOaL94uIGgXPR4QvxOT1yZCXqO1+HcpQPDICK4FPDgI/n1lQvz1mckxTyEzbgizc8sf\n\tLiY7daTsg52P1XJ9H/NzMxES+ttERWVAeQcp56SCBYZk6ZqCD0sDuyMRtkVCHA=","X-Google-Smtp-Source":"AGHT+IFQEf9YELAjVqGaR1RpSrslg6Z/pxgvhC3Tz4W2Gdv3Kk7t8hxwdXm8kgEdDGd3VmpGGyP6fQLa59ZXEjqUllU=","X-Received":"by 2002:a05:6102:5785:b0:525:df9e:936e with SMTP id\n\tada2fe7eead31-5d3fe72f7bemr1441580137.7.1759417827271;\n\tThu, 02 Oct 2025 08:10:27 -0700 (PDT)","MIME-Version":"1.0","References":"<20251002145506.996443-1-barnabas.pocze@ideasonboard.com>\n\t<20251002150121.GA20509@pendragon.ideasonboard.com>","In-Reply-To":"<20251002150121.GA20509@pendragon.ideasonboard.com>","From":"Naushir Patuck ","Date":"Thu, 2 Oct 2025 16:09:51 +0100","X-Gm-Features":"AS18NWC5mJy3_RziD2zHhVQRMo6cHsVeTf3EGSKLJEsyXCM9y54Z7f06ChS7E5k","Message-ID":"","Subject":"Re: [PATCH v1] libcamera: pipeline: rpi: Set `werror=false` for\n\tlibpisp","To":"Laurent Pinchart ","Cc":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tlibcamera-devel@lists.libcamera.org","Content-Type":"multipart/alternative; boundary=\"0000000000009b432e06402e62f5\"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":36082,"web_url":"https://patchwork.libcamera.org/comment/36082/","msgid":"<6d0692f6-9337-4908-ae2a-c54bc029e001@ideasonboard.com>","date":"2025-10-02T15:19:41","subject":"Re: [PATCH v1] libcamera: pipeline: rpi: Set `werror=false` for\n\tlibpisp","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"Hi\n\n2025. 10. 02. 17:01 keltezéssel, Laurent Pinchart írta:\n> Hi Barnabás,\n> \n> On Thu, Oct 02, 2025 at 04:55:06PM +0200, Barnabás Pőcze wrote:\n>> By default libcamera is configured with `werror=true`, and this option can\n>> propagate into the subprojects. This can lead to compilation failures due to\n>> warnings in those subprojects. This is the case with libpisp. Since these\n>> issues are not directly fixable, set `werror=false` for libpisp.\n> \n> Can't we fix those errors ?\n\nI might be misunderstanding, but I think that should be done in the context of the\nlibpisp project. I would argue you cannot immediately act on the errors as if they were\ninside the libcamera code base; short of adding patch files and having meson apply them.\nBut seems like a lot of effort.\n\nThe specific issue I have is already fixed: https://github.com/raspberrypi/libpisp/pull/53\nbut no release has been made, and the wrap file uses the last release, not the master branch.\n\n\nRegards,\nBarnabás Pőcze\n\n> \n>> Signed-off-by: Barnabás Pőcze \n>> ---\n>> src/libcamera/pipeline/rpi/pisp/meson.build | 4 +++-\n>> 1 file changed, 3 insertions(+), 1 deletion(-)\n>>\n>> diff --git a/src/libcamera/pipeline/rpi/pisp/meson.build b/src/libcamera/pipeline/rpi/pisp/meson.build\n>> index 178df94c2..642080014 100644\n>> --- a/src/libcamera/pipeline/rpi/pisp/meson.build\n>> +++ b/src/libcamera/pipeline/rpi/pisp/meson.build\n>> @@ -5,7 +5,9 @@ libcamera_internal_sources += files([\n>> ])\n>>\n>> librt = cc.find_library('rt', required : true)\n>> -libpisp_dep = dependency('libpisp', fallback : ['libpisp', 'libpisp_dep'])\n>> +libpisp_dep = dependency('libpisp',\n>> + fallback : ['libpisp', 'libpisp_dep'],\n>> + default_options : ['werror=false'])\n>>\n>> libcamera_deps += [libpisp_dep, librt]\n>>\n> \n> --\n> Regards,\n> \n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CA600C324C\n\tfor ;\n\tThu, 2 Oct 2025 15:19:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 14A6C6B5AA;\n\tThu, 2 Oct 2025 17:19:47 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C24586B5A2\n\tfor ;\n\tThu, 2 Oct 2025 17:19:44 +0200 (CEST)","from [192.168.33.12] (185.221.142.146.nat.pool.zt.hu\n\t[185.221.142.146])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C5C2FE01;\n\tThu, 2 Oct 2025 17:18:14 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"XVT+Z93e\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1759418294;\n\tbh=7gczsg1uM2LWQWgRykBYvJiJsXXawGiOuvekVqZwuc4=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=XVT+Z93elK/klM9UXcqZBUGmxauXmE8Sa7/JsZiyHyjEWdhQza/fY7GQDqDomhmNU\n\tDiT9Z+CrsHv+3yGGigzkSiduEmtt4mQod4wEIBT5+/qE9S8+X7wGe23+VSWwsU16B1\n\taGyOFQI8E6Ot1XBgEMbbn6RDEkHc+zXSEHcZ0cso=","Message-ID":"<6d0692f6-9337-4908-ae2a-c54bc029e001@ideasonboard.com>","Date":"Thu, 2 Oct 2025 17:19:41 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v1] libcamera: pipeline: rpi: Set `werror=false` for\n\tlibpisp","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","References":"<20251002145506.996443-1-barnabas.pocze@ideasonboard.com>\n\t\n\t<20251002150121.GA20509@pendragon.ideasonboard.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20251002150121.GA20509@pendragon.ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":36084,"web_url":"https://patchwork.libcamera.org/comment/36084/","msgid":"<20251002170314.GD16185@pendragon.ideasonboard.com>","date":"2025-10-02T17:03:14","subject":"Re: [PATCH v1] libcamera: pipeline: rpi: Set `werror=false` for\n\tlibpisp","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Barnabás,\n\nOn Thu, Oct 02, 2025 at 05:19:41PM +0200, Barnabás Pőcze wrote:\n> 2025. 10. 02. 17:01 keltezéssel, Laurent Pinchart írta:\n> > On Thu, Oct 02, 2025 at 04:55:06PM +0200, Barnabás Pőcze wrote:\n> >> By default libcamera is configured with `werror=true`, and this option can\n> >> propagate into the subprojects. This can lead to compilation failures due to\n> >> warnings in those subprojects. This is the case with libpisp. Since these\n> >> issues are not directly fixable, set `werror=false` for libpisp.\n> > \n> > Can't we fix those errors ?\n> \n> I might be misunderstanding, but I think that should be done in the context of the\n> libpisp project.\n\nYes you're right.\n\n> I would argue you cannot immediately act on the errors as if they were\n> inside the libcamera code base; short of adding patch files and having meson apply them.\n> But seems like a lot of effort.\n\nAgreed, I don't think we should do that.\n\n> The specific issue I have is already fixed: https://github.com/raspberrypi/libpisp/pull/53\n> but no release has been made, and the wrap file uses the last release, not the master branch.\n\nNaush, could you make a release ?\n\nIf this issue occurs again we would set werror=false for libpisp, but if\nit's easy to fix this time we can just update to a new release.\n\nI see libpisp has werror=true in meson.build, and there's a CI pipeline\nthat compiles the project with both gcc and clang. Why wasn't this\ndetected, different gcc versions maybe ?\n\nThis being said, keeping werror=true for this dependency means things\ncould break again in the future, and we'll have then to deal with the\nissue. I'm wondering if there's value in us noticing compiler warnings\nin libpisp, maybe it's best to ignore them for all dependencies ?\n\n> >> Signed-off-by: Barnabás Pőcze \n> >> ---\n> >> src/libcamera/pipeline/rpi/pisp/meson.build | 4 +++-\n> >> 1 file changed, 3 insertions(+), 1 deletion(-)\n> >>\n> >> diff --git a/src/libcamera/pipeline/rpi/pisp/meson.build b/src/libcamera/pipeline/rpi/pisp/meson.build\n> >> index 178df94c2..642080014 100644\n> >> --- a/src/libcamera/pipeline/rpi/pisp/meson.build\n> >> +++ b/src/libcamera/pipeline/rpi/pisp/meson.build\n> >> @@ -5,7 +5,9 @@ libcamera_internal_sources += files([\n> >> ])\n> >>\n> >> librt = cc.find_library('rt', required : true)\n> >> -libpisp_dep = dependency('libpisp', fallback : ['libpisp', 'libpisp_dep'])\n> >> +libpisp_dep = dependency('libpisp',\n> >> + fallback : ['libpisp', 'libpisp_dep'],\n> >> + default_options : ['werror=false'])\n> >>\n> >> libcamera_deps += [libpisp_dep, librt]\n> >>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 49434C324C\n\tfor ;\n\tThu, 2 Oct 2025 17:03:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 22FA56B5AA;\n\tThu, 2 Oct 2025 19:03:22 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C99ED6B5A2\n\tfor ;\n\tThu, 2 Oct 2025 19:03:20 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id A8C48122A; \n\tThu, 2 Oct 2025 19:01:50 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"BYOWDTkr\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1759424510;\n\tbh=IH+kXJlPImV+MJ1KWdhl4XEXeajlXRqMU+M4WRSEk28=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=BYOWDTkrDKn+f9i8Rahfjv3o4IHKiEfGtQK20MdCL/quZ/m4Myz059K3SKZ7FB7Ou\n\tRztpCPJkFd0OgI32Ofa9cuDA8P2YZ+vkMdjkuBRFmwwI1ZjFJelfJmchV12C18D0TW\n\tHphhr/2pzXyiz/MSF8MHGMHea4CmRP411iVMmvaY=","Date":"Thu, 2 Oct 2025 20:03:14 +0300","From":"Laurent Pinchart ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org,\n\tNaushir Patuck ","Subject":"Re: [PATCH v1] libcamera: pipeline: rpi: Set `werror=false` for\n\tlibpisp","Message-ID":"<20251002170314.GD16185@pendragon.ideasonboard.com>","References":"<20251002145506.996443-1-barnabas.pocze@ideasonboard.com>\n\t\n\t<20251002150121.GA20509@pendragon.ideasonboard.com>\n\t<6d0692f6-9337-4908-ae2a-c54bc029e001@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<6d0692f6-9337-4908-ae2a-c54bc029e001@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":36085,"web_url":"https://patchwork.libcamera.org/comment/36085/","msgid":"","date":"2025-10-02T17:30:45","subject":"Re: [PATCH v1] libcamera: pipeline: rpi: Set `werror=false` for\n\tlibpisp","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2025. 10. 02. 19:03 keltezéssel, Laurent Pinchart írta:\n> Hi Barnabás,\n> \n> On Thu, Oct 02, 2025 at 05:19:41PM +0200, Barnabás Pőcze wrote:\n>> 2025. 10. 02. 17:01 keltezéssel, Laurent Pinchart írta:\n>>> On Thu, Oct 02, 2025 at 04:55:06PM +0200, Barnabás Pőcze wrote:\n>>>> By default libcamera is configured with `werror=true`, and this option can\n>>>> propagate into the subprojects. This can lead to compilation failures due to\n>>>> warnings in those subprojects. This is the case with libpisp. Since these\n>>>> issues are not directly fixable, set `werror=false` for libpisp.\n>>>\n>>> Can't we fix those errors ?\n>>\n>> I might be misunderstanding, but I think that should be done in the context of the\n>> libpisp project.\n> \n> Yes you're right.\n> \n>> I would argue you cannot immediately act on the errors as if they were\n>> inside the libcamera code base; short of adding patch files and having meson apply them.\n>> But seems like a lot of effort.\n> \n> Agreed, I don't think we should do that.\n> \n>> The specific issue I have is already fixed: https://github.com/raspberrypi/libpisp/pull/53\n>> but no release has been made, and the wrap file uses the last release, not the master branch.\n> \n> Naush, could you make a release ?\n> \n> If this issue occurs again we would set werror=false for libpisp, but if\n> it's easy to fix this time we can just update to a new release.\n> \n> I see libpisp has werror=true in meson.build, and there's a CI pipeline\n> that compiles the project with both gcc and clang. Why wasn't this\n> detected, different gcc versions maybe ?\n\nI think one issue with that CI pipeline is that, as far as I can see, it runs\nonly on x86 and compiles natively. So it does not pick up the slight idiosyncrasies\nof the (glibc) headers of different architectures.\n\nThere are aarch64 runners available nowadays, I believe that would be an easy way\nto add aarch64 compilation coverage: https://github.com/orgs/community/discussions/148648\n\n\nRegards,\nBarnabás Pőcze\n\n\n> \n> This being said, keeping werror=true for this dependency means things\n> could break again in the future, and we'll have then to deal with the\n> issue. I'm wondering if there's value in us noticing compiler warnings\n> in libpisp, maybe it's best to ignore them for all dependencies ?\n> \n>>>> Signed-off-by: Barnabás Pőcze \n>>>> ---\n>>>> src/libcamera/pipeline/rpi/pisp/meson.build | 4 +++-\n>>>> 1 file changed, 3 insertions(+), 1 deletion(-)\n>>>>\n>>>> diff --git a/src/libcamera/pipeline/rpi/pisp/meson.build b/src/libcamera/pipeline/rpi/pisp/meson.build\n>>>> index 178df94c2..642080014 100644\n>>>> --- a/src/libcamera/pipeline/rpi/pisp/meson.build\n>>>> +++ b/src/libcamera/pipeline/rpi/pisp/meson.build\n>>>> @@ -5,7 +5,9 @@ libcamera_internal_sources += files([\n>>>> ])\n>>>>\n>>>> librt = cc.find_library('rt', required : true)\n>>>> -libpisp_dep = dependency('libpisp', fallback : ['libpisp', 'libpisp_dep'])\n>>>> +libpisp_dep = dependency('libpisp',\n>>>> + fallback : ['libpisp', 'libpisp_dep'],\n>>>> + default_options : ['werror=false'])\n>>>>\n>>>> libcamera_deps += [libpisp_dep, librt]\n>>>>\n> \n> --\n> Regards,\n> \n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0460EC324C\n\tfor ;\n\tThu, 2 Oct 2025 17:30:53 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B25CE6B5A2;\n\tThu, 2 Oct 2025 19:30:51 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 62BC26B5A2\n\tfor ;\n\tThu, 2 Oct 2025 19:30:49 +0200 (CEST)","from [192.168.33.12] (185.221.142.146.nat.pool.zt.hu\n\t[185.221.142.146])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B3B25149B;\n\tThu, 2 Oct 2025 19:29:18 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ummm65ua\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1759426159;\n\tbh=8E9PgiwgZ/5bFYEtVWw/yrspNYGTxLfos91hdkbYDjs=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=ummm65uaJK7tiCvCiIX8mvrF77HCI4I2Plbmo4gK+MO3+312gKHPT0HRNu/m6WqjA\n\tOlI1bjmPoeT8svDrGwylwOvosVb/DcD/G2oWvitvZjUOjuMZCW194XmzGD6C3spNHf\n\tqrCIx3BNwqf46EW2oTmL4w8AjUUewGgr9ExgEL6A=","Message-ID":"","Date":"Thu, 2 Oct 2025 19:30:45 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v1] libcamera: pipeline: rpi: Set `werror=false` for\n\tlibpisp","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org,\n\tNaushir Patuck ","References":"<20251002145506.996443-1-barnabas.pocze@ideasonboard.com>\n\t\n\t<20251002150121.GA20509@pendragon.ideasonboard.com>\n\t<6d0692f6-9337-4908-ae2a-c54bc029e001@ideasonboard.com>\n\t<4Codvp64tqmGsx2Vv_k_rTFVz5Ot-qIJ4ujom0cjCTFbZM12kWyYV_igR6Ty8GVTJxF7XuD1dVa5xKtP9apY4A==@protonmail.internalid>\n\t<20251002170314.GD16185@pendragon.ideasonboard.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20251002170314.GD16185@pendragon.ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":36086,"web_url":"https://patchwork.libcamera.org/comment/36086/","msgid":"<20251002181117.GE16185@pendragon.ideasonboard.com>","date":"2025-10-02T18:11:17","subject":"Re: [PATCH v1] libcamera: pipeline: rpi: Set `werror=false` for\n\tlibpisp","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Thu, Oct 02, 2025 at 07:30:45PM +0200, Barnabás Pőcze wrote:\n> 2025. 10. 02. 19:03 keltezéssel, Laurent Pinchart írta:\n> > On Thu, Oct 02, 2025 at 05:19:41PM +0200, Barnabás Pőcze wrote:\n> >> 2025. 10. 02. 17:01 keltezéssel, Laurent Pinchart írta:\n> >>> On Thu, Oct 02, 2025 at 04:55:06PM +0200, Barnabás Pőcze wrote:\n> >>>> By default libcamera is configured with `werror=true`, and this option can\n> >>>> propagate into the subprojects. This can lead to compilation failures due to\n> >>>> warnings in those subprojects. This is the case with libpisp. Since these\n> >>>> issues are not directly fixable, set `werror=false` for libpisp.\n> >>>\n> >>> Can't we fix those errors ?\n> >>\n> >> I might be misunderstanding, but I think that should be done in the context of the\n> >> libpisp project.\n> > \n> > Yes you're right.\n> > \n> >> I would argue you cannot immediately act on the errors as if they were\n> >> inside the libcamera code base; short of adding patch files and having meson apply them.\n> >> But seems like a lot of effort.\n> > \n> > Agreed, I don't think we should do that.\n> > \n> >> The specific issue I have is already fixed: https://github.com/raspberrypi/libpisp/pull/53\n> >> but no release has been made, and the wrap file uses the last release, not the master branch.\n> > \n> > Naush, could you make a release ?\n> > \n> > If this issue occurs again we would set werror=false for libpisp, but if\n> > it's easy to fix this time we can just update to a new release.\n> > \n> > I see libpisp has werror=true in meson.build, and there's a CI pipeline\n> > that compiles the project with both gcc and clang. Why wasn't this\n> > detected, different gcc versions maybe ?\n> \n> I think one issue with that CI pipeline is that, as far as I can see, it runs\n> only on x86 and compiles natively. So it does not pick up the slight idiosyncrasies\n> of the (glibc) headers of different architectures.\n> \n> There are aarch64 runners available nowadays, I believe that would be an easy way\n> to add aarch64 compilation coverage: https://github.com/orgs/community/discussions/148648\n\nEspecially for libpisp compilation on aarch64 is more useful than\ncompilation on x86 :-)\n\nIf you would like to merge this patch,\n\nReviewed-by: Laurent Pinchart \n\n> > This being said, keeping werror=true for this dependency means things\n> > could break again in the future, and we'll have then to deal with the\n> > issue. I'm wondering if there's value in us noticing compiler warnings\n> > in libpisp, maybe it's best to ignore them for all dependencies ?\n> > \n> >>>> Signed-off-by: Barnabás Pőcze \n> >>>> ---\n> >>>> src/libcamera/pipeline/rpi/pisp/meson.build | 4 +++-\n> >>>> 1 file changed, 3 insertions(+), 1 deletion(-)\n> >>>>\n> >>>> diff --git a/src/libcamera/pipeline/rpi/pisp/meson.build b/src/libcamera/pipeline/rpi/pisp/meson.build\n> >>>> index 178df94c2..642080014 100644\n> >>>> --- a/src/libcamera/pipeline/rpi/pisp/meson.build\n> >>>> +++ b/src/libcamera/pipeline/rpi/pisp/meson.build\n> >>>> @@ -5,7 +5,9 @@ libcamera_internal_sources += files([\n> >>>> ])\n> >>>>\n> >>>> librt = cc.find_library('rt', required : true)\n> >>>> -libpisp_dep = dependency('libpisp', fallback : ['libpisp', 'libpisp_dep'])\n> >>>> +libpisp_dep = dependency('libpisp',\n> >>>> + fallback : ['libpisp', 'libpisp_dep'],\n> >>>> + default_options : ['werror=false'])\n> >>>>\n> >>>> libcamera_deps += [libpisp_dep, librt]\n> >>>>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7AA9CC328C\n\tfor ;\n\tThu, 2 Oct 2025 18:11:25 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6EC216B5AA;\n\tThu, 2 Oct 2025 20:11:24 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C483D6B5A2\n\tfor ;\n\tThu, 2 Oct 2025 20:11:22 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id B8209149B; \n\tThu, 2 Oct 2025 20:09:52 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"kCMzsSFU\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1759428592;\n\tbh=w+nySpsG9ngC3DPrFJH2k7cMbfc5FEN2obUkTMMIVwU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=kCMzsSFUDvHfI/nIMlfLc+tA0pw37qC3+bz9cHzsDPjLiaBG5NpNsjj/GJ0KFZrpn\n\tnR67W6m08fVvK5x5gPZA8xcoDeCD3jNhfrrWqbMySQaRVz2C+IxItDMXlqIwVqCsxD\n\tpY5cOZI07mhU7GRiK2tOfVvSfjfkDFeSIJrdtVdg=","Date":"Thu, 2 Oct 2025 21:11:17 +0300","From":"Laurent Pinchart ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org,\n\tNaushir Patuck ","Subject":"Re: [PATCH v1] libcamera: pipeline: rpi: Set `werror=false` for\n\tlibpisp","Message-ID":"<20251002181117.GE16185@pendragon.ideasonboard.com>","References":"<20251002145506.996443-1-barnabas.pocze@ideasonboard.com>\n\t\n\t<20251002150121.GA20509@pendragon.ideasonboard.com>\n\t<6d0692f6-9337-4908-ae2a-c54bc029e001@ideasonboard.com>\n\t<4Codvp64tqmGsx2Vv_k_rTFVz5Ot-qIJ4ujom0cjCTFbZM12kWyYV_igR6Ty8GVTJxF7XuD1dVa5xKtP9apY4A==@protonmail.internalid>\n\t<20251002170314.GD16185@pendragon.ideasonboard.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":36094,"web_url":"https://patchwork.libcamera.org/comment/36094/","msgid":"","date":"2025-10-03T06:50:10","subject":"Re: [PATCH v1] libcamera: pipeline: rpi: Set `werror=false` for\n\tlibpisp","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"On Thu, 2 Oct 2025 at 19:11, Laurent Pinchart <\nlaurent.pinchart@ideasonboard.com> wrote:\n\n> On Thu, Oct 02, 2025 at 07:30:45PM +0200, Barnabás Pőcze wrote:\n> > 2025. 10. 02. 19:03 keltezéssel, Laurent Pinchart írta:\n> > > On Thu, Oct 02, 2025 at 05:19:41PM +0200, Barnabás Pőcze wrote:\n> > >> 2025. 10. 02. 17:01 keltezéssel, Laurent Pinchart írta:\n> > >>> On Thu, Oct 02, 2025 at 04:55:06PM +0200, Barnabás Pőcze wrote:\n> > >>>> By default libcamera is configured with `werror=true`, and this\n> option can\n> > >>>> propagate into the subprojects. This can lead to compilation\n> failures due to\n> > >>>> warnings in those subprojects. This is the case with libpisp. Since\n> these\n> > >>>> issues are not directly fixable, set `werror=false` for libpisp.\n> > >>>\n> > >>> Can't we fix those errors ?\n> > >>\n> > >> I might be misunderstanding, but I think that should be done in the\n> context of the\n> > >> libpisp project.\n> > >\n> > > Yes you're right.\n> > >\n> > >> I would argue you cannot immediately act on the errors as if they were\n> > >> inside the libcamera code base; short of adding patch files and\n> having meson apply them.\n> > >> But seems like a lot of effort.\n> > >\n> > > Agreed, I don't think we should do that.\n> > >\n> > >> The specific issue I have is already fixed:\n> https://github.com/raspberrypi/libpisp/pull/53\n> > >> but no release has been made, and the wrap file uses the last\n> release, not the master branch.\n> > >\n> > > Naush, could you make a release ?\n>\n\nI can arrange a release shortly. Also happy to update the wrap file to\npoint to master instead of a particular release if you prefer?\n\n\n> > >\n> > > If this issue occurs again we would set werror=false for libpisp, but\n> if\n> > > it's easy to fix this time we can just update to a new release.\n> > >\n> > > I see libpisp has werror=true in meson.build, and there's a CI pipeline\n> > > that compiles the project with both gcc and clang. Why wasn't this\n> > > detected, different gcc versions maybe ?\n> >\n> > I think one issue with that CI pipeline is that, as far as I can see, it\n> runs\n> > only on x86 and compiles natively. So it does not pick up the slight\n> idiosyncrasies\n> > of the (glibc) headers of different architectures.\n> >\n> > There are aarch64 runners available nowadays, I believe that would be an\n> easy way\n> > to add aarch64 compilation coverage:\n> https://github.com/orgs/community/discussions/148648\n>\n> Especially for libpisp compilation on aarch64 is more useful than\n> compilation on x86 :-)\n>\n\nThe aarch64 build happens as part of the device run-tests, but it's a later\nversion of gcc which seems to complain.\n\nRegards,\nNaush\n\n\n>\n> If you would like to merge this patch,\n>\n> Reviewed-by: Laurent Pinchart \n>\n> > > This being said, keeping werror=true for this dependency means things\n> > > could break again in the future, and we'll have then to deal with the\n> > > issue. I'm wondering if there's value in us noticing compiler warnings\n> > > in libpisp, maybe it's best to ignore them for all dependencies ?\n> > >\n> > >>>> Signed-off-by: Barnabás Pőcze \n> > >>>> ---\n> > >>>> src/libcamera/pipeline/rpi/pisp/meson.build | 4 +++-\n> > >>>> 1 file changed, 3 insertions(+), 1 deletion(-)\n> > >>>>\n> > >>>> diff --git a/src/libcamera/pipeline/rpi/pisp/meson.build\n> b/src/libcamera/pipeline/rpi/pisp/meson.build\n> > >>>> index 178df94c2..642080014 100644\n> > >>>> --- a/src/libcamera/pipeline/rpi/pisp/meson.build\n> > >>>> +++ b/src/libcamera/pipeline/rpi/pisp/meson.build\n> > >>>> @@ -5,7 +5,9 @@ libcamera_internal_sources += files([\n> > >>>> ])\n> > >>>>\n> > >>>> librt = cc.find_library('rt', required : true)\n> > >>>> -libpisp_dep = dependency('libpisp', fallback : ['libpisp',\n> 'libpisp_dep'])\n> > >>>> +libpisp_dep = dependency('libpisp',\n> > >>>> + fallback : ['libpisp', 'libpisp_dep'],\n> > >>>> + default_options : ['werror=false'])\n> > >>>>\n> > >>>> libcamera_deps += [libpisp_dep, librt]\n> > >>>>\n>\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 900AABF415\n\tfor ;\n\tFri, 3 Oct 2025 06:50:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 897506B5F3;\n\tFri, 3 Oct 2025 08:50:48 +0200 (CEST)","from mail-vk1-xa2f.google.com (mail-vk1-xa2f.google.com\n\t[IPv6:2607:f8b0:4864:20::a2f])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B59C06B58E\n\tfor ;\n\tFri, 3 Oct 2025 08:50:45 +0200 (CEST)","by mail-vk1-xa2f.google.com with SMTP id\n\t71dfb90a1353d-54a7e6a4316so81648e0c.2\n\tfor ;\n\tThu, 02 Oct 2025 23:50:45 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"FdT673Ij\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1759474244; x=1760079044;\n\tdarn=lists.libcamera.org; \n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=jzOTMBVfGNHjKOmjIEz+lJ7rgY2uIpPGWvzOQ/rSHLc=;\n\tb=FdT673IjE0olG/d/oDrELDJYtX1BMuHJ4zMXI4g8JHC+I+jtSJCqz4eUH2oZzG7xpB\n\ttV+44Vdhm3kD2KcDhWxJP0tyr9JJTc8QrApMemuIughCLR5Qrv5dEzyjrAxTF1AO0VMg\n\t+GndUVOQEeSC5szdjPrWzw5EQbwuEQIC77wcu6eTczXbsjXzqaNQLg52N9RGygeZfhIZ\n\tIT/1MCv1ImZsHM1r5Ni7Ux1iVOay44UAgtRqt2QceH0fLtSPJY5XQB7ASThMxVSoHwSq\n\t/DbpYfamlJqwoVeK/enJ50TxYCc0cv7XjS1ffUBbwUiAaYQov5ru5D0IJrkUICebkDca\n\tRD8g==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1759474244; x=1760079044;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=jzOTMBVfGNHjKOmjIEz+lJ7rgY2uIpPGWvzOQ/rSHLc=;\n\tb=qZnEuEDi5wvm5arVb8CP0WKwqXxVs2fcrlBzHpnNpWtYyXDeMxXt+xmPTrKNJt13ta\n\tNB2LNny/EEN7hJ+K0/+wdu7bu1/27X6opqyhBYutfQPmTAejjivygaPCDGTnuNV3NvGO\n\tO8rxcEqu+JlNt7rpFByLGdueny0npiEeNdvg0I0zR7pst0m5MZVQFj6AHlcWC3wWiTUC\n\twHKDGv08tDlEMbLsPCilMrU5fgqqfie8SKG/vvWqQxzHmTZmppZwx1/IjYjnYtFa08jj\n\tOdM16lBEqyxqybITJlokwBfadXtFCGtLZT+XSY+eLGAW01eOUtSaynVfOpmdDiatS7Vt\n\tVHjw==","X-Forwarded-Encrypted":"i=1;\n\tAJvYcCVTIlnnGCN/13WEoU12iKCierRotd8JgV8ZqLEypOniOk5Nz2sXp3NTookjolFOckq6NG0JnVyaZtbPgEz8muA=@lists.libcamera.org","X-Gm-Message-State":"AOJu0YxeJ15bzgMF2OuWibeIprPGh/vLNU5vgk9gOnG5STOS48ox7MYL\n\td32Y6l4QNF0LGdGyOlkVC+x+BT/V5/YGdW2b9xS4GIbIhjDsQp+NDS3Gm4IExFPu/i72YBxN77D\n\tDMbu74yH99nztdZNArdp65I6PE6iSB5xo7A95ZfvCZsZn6QmV/7RH","X-Gm-Gg":"ASbGncsGeOCRQosozhrfaYJPqoAWB/fOVHcbLfHRxqZxQFndjk8K5qQa1l3deISu5b7\n\tSwdnDcNZATjgJK22qzWv/UpbiBAwh4br2F8URRIvWMUdJfWXnESZ6pPK4Ms3iyNXna8gsMrLzMK\n\tJoEhpkxYevEEHF9hRkjjjlvMOYDqTk98sNjSlsFnzYxHq46jC7MEnN0vsm9f3dwIO8teBQ84VpY\n\tmawwDAE8Jo9NE9VidgDTcG5aEI/P2LnjVRbsjumdpRbep1la9EE6IvArjQOve4=","X-Google-Smtp-Source":"AGHT+IG0fJhwvd++LWQ2ByHdRsJBdTbC5Y/Ht54rfTdSup8AQQOWqy2iewqdTYEaXMAuXowoBlrPgiQG40tL3EhS6aI=","X-Received":"by 2002:a05:6122:c2c7:20b0:552:40cd:4d8 with SMTP id\n\t71dfb90a1353d-5524e420225mr203833e0c.0.1759474244330; Thu, 02 Oct 2025\n\t23:50:44 -0700 (PDT)","MIME-Version":"1.0","References":"<20251002145506.996443-1-barnabas.pocze@ideasonboard.com>\n\t\n\t<20251002150121.GA20509@pendragon.ideasonboard.com>\n\t<6d0692f6-9337-4908-ae2a-c54bc029e001@ideasonboard.com>\n\t<4Codvp64tqmGsx2Vv_k_rTFVz5Ot-qIJ4ujom0cjCTFbZM12kWyYV_igR6Ty8GVTJxF7XuD1dVa5xKtP9apY4A==@protonmail.internalid>\n\t<20251002170314.GD16185@pendragon.ideasonboard.com>\n\t\n\t<20251002181117.GE16185@pendragon.ideasonboard.com>","In-Reply-To":"<20251002181117.GE16185@pendragon.ideasonboard.com>","From":"Naushir Patuck ","Date":"Fri, 3 Oct 2025 07:50:10 +0100","X-Gm-Features":"AS18NWA4pjtmWZ7zwZgwvCLfUQ2j5xYS7jx2Sz2ex3k_84xtn-g826-K1YTSMpI","Message-ID":"","Subject":"Re: [PATCH v1] libcamera: pipeline: rpi: Set `werror=false` for\n\tlibpisp","To":"Laurent Pinchart ","Cc":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tlibcamera-devel@lists.libcamera.org","Content-Type":"multipart/alternative; boundary=\"00000000000053380c06403b85a6\"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":36095,"web_url":"https://patchwork.libcamera.org/comment/36095/","msgid":"<98e4a56c-23ab-40e0-a0e8-1e0ad2110742@ideasonboard.com>","date":"2025-10-03T07:32:25","subject":"Re: [PATCH v1] libcamera: pipeline: rpi: Set `werror=false` for\n\tlibpisp","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2025. 10. 03. 8:50 keltezéssel, Naushir Patuck írta:\n> \n> \n> On Thu, 2 Oct 2025 at 19:11, Laurent Pinchart > wrote:\n> \n> On Thu, Oct 02, 2025 at 07:30:45PM +0200, Barnabás Pőcze wrote:\n> > 2025. 10. 02. 19:03 keltezéssel, Laurent Pinchart írta:\n> > > On Thu, Oct 02, 2025 at 05:19:41PM +0200, Barnabás Pőcze wrote:\n> > >> 2025. 10. 02. 17:01 keltezéssel, Laurent Pinchart írta:\n> > >>> On Thu, Oct 02, 2025 at 04:55:06PM +0200, Barnabás Pőcze wrote:\n> > >>>> By default libcamera is configured with `werror=true`, and this option can\n> > >>>> propagate into the subprojects. This can lead to compilation failures due to\n> > >>>> warnings in those subprojects. This is the case with libpisp. Since these\n> > >>>> issues are not directly fixable, set `werror=false` for libpisp.\n> > >>>\n> > >>> Can't we fix those errors ?\n> > >>\n> > >> I might be misunderstanding, but I think that should be done in the context of the\n> > >> libpisp project.\n> > >\n> > > Yes you're right.\n> > >\n> > >> I would argue you cannot immediately act on the errors as if they were\n> > >> inside the libcamera code base; short of adding patch files and having meson apply them.\n> > >> But seems like a lot of effort.\n> > >\n> > > Agreed, I don't think we should do that.\n> > >\n> > >> The specific issue I have is already fixed: https://github.com/raspberrypi/libpisp/pull/53 \n> > >> but no release has been made, and the wrap file uses the last release, not the master branch.\n> > >\n> > > Naush, could you make a release ?\n> \n> \n> I can arrange a release shortly.  Also happy to update the wrap file to point to master instead of a particular release if you prefer?\n> \n> > >\n> > > If this issue occurs again we would set werror=false for libpisp, but if\n> > > it's easy to fix this time we can just update to a new release.\n> > >\n> > > I see libpisp has werror=true in meson.build, and there's a CI pipeline\n> > > that compiles the project with both gcc and clang. Why wasn't this\n> > > detected, different gcc versions maybe ?\n> >\n> > I think one issue with that CI pipeline is that, as far as I can see, it runs\n> > only on x86 and compiles natively. So it does not pick up the slight idiosyncrasies\n> > of the (glibc) headers of different architectures.\n> >\n> > There are aarch64 runners available nowadays, I believe that would be an easy way\n> > to add aarch64 compilation coverage: https://github.com/orgs/community/discussions/148648 \n> \n> Especially for libpisp compilation on aarch64 is more useful than\n> compilation on x86 :-)\n> \n> \n> The aarch64 build happens as part of the device run-tests, but it's a later version of gcc which seems to complain.\n\nAhh, sorry, I see now that you have on device tests using self-hosted runners in\npisp-verification.test.yaml. I still think adding the github-provided aarch64\nrunners to libpisp-build-test.yaml should be simple and is still useful.\n\n\nRegards,\nBarnabás Pőcze\n\n> \n> Regards,\n> Naush\n> \n> \n> If you would like to merge this patch,\n> \n> Reviewed-by: Laurent Pinchart >\n> \n> > > This being said, keeping werror=true for this dependency means things\n> > > could break again in the future, and we'll have then to deal with the\n> > > issue. I'm wondering if there's value in us noticing compiler warnings\n> > > in libpisp, maybe it's best to ignore them for all dependencies ?\n> > >\n> > >>>> Signed-off-by: Barnabás Pőcze >\n> > >>>> ---\n> > >>>>    src/libcamera/pipeline/rpi/pisp/meson.build | 4 +++-\n> > >>>>    1 file changed, 3 insertions(+), 1 deletion(-)\n> > >>>>\n> > >>>> diff --git a/src/libcamera/pipeline/rpi/pisp/meson.build b/src/libcamera/pipeline/rpi/pisp/meson.build\n> > >>>> index 178df94c2..642080014 100644\n> > >>>> --- a/src/libcamera/pipeline/rpi/pisp/meson.build\n> > >>>> +++ b/src/libcamera/pipeline/rpi/pisp/meson.build\n> > >>>> @@ -5,7 +5,9 @@ libcamera_internal_sources += files([\n> > >>>>    ])\n> > >>>>\n> > >>>>    librt = cc.find_library('rt', required : true)\n> > >>>> -libpisp_dep = dependency('libpisp', fallback : ['libpisp', 'libpisp_dep'])\n> > >>>> +libpisp_dep = dependency('libpisp',\n> > >>>> +                         fallback : ['libpisp', 'libpisp_dep'],\n> > >>>> +                         default_options : ['werror=false'])\n> > >>>>\n> > >>>>    libcamera_deps += [libpisp_dep, librt]\n> > >>>>\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 65059C324C\n\tfor ;\n\tFri, 3 Oct 2025 07:32:33 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 229796B5AA;\n\tFri, 3 Oct 2025 09:32:32 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2C9E66B599\n\tfor ;\n\tFri, 3 Oct 2025 09:32:29 +0200 (CEST)","from [192.168.33.17] (185.221.140.76.nat.pool.zt.hu\n\t[185.221.140.76])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 60EA7929;\n\tFri, 3 Oct 2025 09:30:58 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"grcloeia\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1759476658;\n\tbh=k+f4lqETVeHvnnlyfcWqJAJBGTaeujQDszQ9upQ0KVo=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=grcloeiaUTBxk/8IsKcxGiwiNeWCzV1/EnKzks0O8czwUeBR27KOuo1AZAimB8uts\n\tFZeNISE7fBE7CI1tcaYQwLlSs2WP8OnvUJ8f2jOyJbhF1I4GODg9I75HqisubazTPw\n\t+poLtDyKzMbAEQ1apOqDSBm4dM4/q8tuZarCbpY8=","Message-ID":"<98e4a56c-23ab-40e0-a0e8-1e0ad2110742@ideasonboard.com>","Date":"Fri, 3 Oct 2025 09:32:25 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v1] libcamera: pipeline: rpi: Set `werror=false` for\n\tlibpisp","To":"Naushir Patuck ","Cc":"libcamera-devel@lists.libcamera.org,\n\tLaurent Pinchart ","References":"<20251002145506.996443-1-barnabas.pocze@ideasonboard.com>\n\t\n\t<20251002150121.GA20509@pendragon.ideasonboard.com>\n\t<6d0692f6-9337-4908-ae2a-c54bc029e001@ideasonboard.com>\n\t<4Codvp64tqmGsx2Vv_k_rTFVz5Ot-qIJ4ujom0cjCTFbZM12kWyYV_igR6Ty8GVTJxF7XuD1dVa5xKtP9apY4A==@protonmail.internalid>\n\t<20251002170314.GD16185@pendragon.ideasonboard.com>\n\t\n\t<20251002181117.GE16185@pendragon.ideasonboard.com>\n\t\n\t","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":36096,"web_url":"https://patchwork.libcamera.org/comment/36096/","msgid":"","date":"2025-10-03T07:38:23","subject":"Re: [PATCH v1] libcamera: pipeline: rpi: Set `werror=false` for\n\tlibpisp","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"On Fri, 3 Oct 2025 at 08:32, Barnabás Pőcze \nwrote:\n\n> 2025. 10. 03. 8:50 keltezéssel, Naushir Patuck írta:\n> >\n> >\n> > On Thu, 2 Oct 2025 at 19:11, Laurent Pinchart <\n> laurent.pinchart@ideasonboard.com laurent.pinchart@ideasonboard.com>> wrote:\n> >\n> > On Thu, Oct 02, 2025 at 07:30:45PM +0200, Barnabás Pőcze wrote:\n> > > 2025. 10. 02. 19:03 keltezéssel, Laurent Pinchart írta:\n> > > > On Thu, Oct 02, 2025 at 05:19:41PM +0200, Barnabás Pőcze wrote:\n> > > >> 2025. 10. 02. 17:01 keltezéssel, Laurent Pinchart írta:\n> > > >>> On Thu, Oct 02, 2025 at 04:55:06PM +0200, Barnabás Pőcze\n> wrote:\n> > > >>>> By default libcamera is configured with `werror=true`, and\n> this option can\n> > > >>>> propagate into the subprojects. This can lead to compilation\n> failures due to\n> > > >>>> warnings in those subprojects. This is the case with\n> libpisp. Since these\n> > > >>>> issues are not directly fixable, set `werror=false` for\n> libpisp.\n> > > >>>\n> > > >>> Can't we fix those errors ?\n> > > >>\n> > > >> I might be misunderstanding, but I think that should be done\n> in the context of the\n> > > >> libpisp project.\n> > > >\n> > > > Yes you're right.\n> > > >\n> > > >> I would argue you cannot immediately act on the errors as if\n> they were\n> > > >> inside the libcamera code base; short of adding patch files\n> and having meson apply them.\n> > > >> But seems like a lot of effort.\n> > > >\n> > > > Agreed, I don't think we should do that.\n> > > >\n> > > >> The specific issue I have is already fixed:\n> https://github.com/raspberrypi/libpisp/pull/53 <\n> https://github.com/raspberrypi/libpisp/pull/53>\n> > > >> but no release has been made, and the wrap file uses the last\n> release, not the master branch.\n> > > >\n> > > > Naush, could you make a release ?\n> >\n> >\n> > I can arrange a release shortly. Also happy to update the wrap file to\n> point to master instead of a particular release if you prefer?\n> >\n> > > >\n> > > > If this issue occurs again we would set werror=false for\n> libpisp, but if\n> > > > it's easy to fix this time we can just update to a new release.\n> > > >\n> > > > I see libpisp has werror=true in meson.build, and there's a CI\n> pipeline\n> > > > that compiles the project with both gcc and clang. Why wasn't\n> this\n> > > > detected, different gcc versions maybe ?\n> > >\n> > > I think one issue with that CI pipeline is that, as far as I can\n> see, it runs\n> > > only on x86 and compiles natively. So it does not pick up the\n> slight idiosyncrasies\n> > > of the (glibc) headers of different architectures.\n> > >\n> > > There are aarch64 runners available nowadays, I believe that\n> would be an easy way\n> > > to add aarch64 compilation coverage:\n> https://github.com/orgs/community/discussions/148648 <\n> https://github.com/orgs/community/discussions/148648>\n> >\n> > Especially for libpisp compilation on aarch64 is more useful than\n> > compilation on x86 :-)\n> >\n> >\n> > The aarch64 build happens as part of the device run-tests, but it's a\n> later version of gcc which seems to complain.\n>\n> Ahh, sorry, I see now that you have on device tests using self-hosted\n> runners in\n> pisp-verification.test.yaml. I still think adding the github-provided\n> aarch64\n> runners to libpisp-build-test.yaml should be simple and is still useful.\n>\n\nMakes sense, I'll make the update to the CI.\n\nNaush\n\n\n>\n> Regards,\n> Barnabás Pőcze\n>\n> >\n> > Regards,\n> > Naush\n> >\n> >\n> > If you would like to merge this patch,\n> >\n> > Reviewed-by: Laurent Pinchart >\n> >\n> > > > This being said, keeping werror=true for this dependency means\n> things\n> > > > could break again in the future, and we'll have then to deal\n> with the\n> > > > issue. I'm wondering if there's value in us noticing compiler\n> warnings\n> > > > in libpisp, maybe it's best to ignore them for all dependencies\n> ?\n> > > >\n> > > >>>> Signed-off-by: Barnabás Pőcze <\n> barnabas.pocze@ideasonboard.com >\n> > > >>>> ---\n> > > >>>> src/libcamera/pipeline/rpi/pisp/meson.build | 4 +++-\n> > > >>>> 1 file changed, 3 insertions(+), 1 deletion(-)\n> > > >>>>\n> > > >>>> diff --git a/src/libcamera/pipeline/rpi/pisp/meson.build\n> b/src/libcamera/pipeline/rpi/pisp/meson.build\n> > > >>>> index 178df94c2..642080014 100644\n> > > >>>> --- a/src/libcamera/pipeline/rpi/pisp/meson.build\n> > > >>>> +++ b/src/libcamera/pipeline/rpi/pisp/meson.build\n> > > >>>> @@ -5,7 +5,9 @@ libcamera_internal_sources += files([\n> > > >>>> ])\n> > > >>>>\n> > > >>>> librt = cc.find_library('rt', required : true)\n> > > >>>> -libpisp_dep = dependency('libpisp', fallback : ['libpisp',\n> 'libpisp_dep'])\n> > > >>>> +libpisp_dep = dependency('libpisp',\n> > > >>>> + fallback : ['libpisp',\n> 'libpisp_dep'],\n> > > >>>> + default_options : ['werror=false'])\n> > > >>>>\n> > > >>>> libcamera_deps += [libpisp_dep, librt]\n> > > >>>>\n> >\n> > --\n> > Regards,\n> >\n> > Laurent Pinchart\n> >\n>\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 52C35BF415\n\tfor ;\n\tFri, 3 Oct 2025 07:39:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8A7D46B5AA;\n\tFri, 3 Oct 2025 09:39:01 +0200 (CEST)","from mail-vs1-xe2d.google.com (mail-vs1-xe2d.google.com\n\t[IPv6:2607:f8b0:4864:20::e2d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9C2376B599\n\tfor ;\n\tFri, 3 Oct 2025 09:38:58 +0200 (CEST)","by mail-vs1-xe2d.google.com with SMTP id\n\tada2fe7eead31-5b6fa11df79so108943137.2\n\tfor ;\n\tFri, 03 Oct 2025 00:38:58 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"SXKZ4tRf\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1759477137; x=1760081937;\n\tdarn=lists.libcamera.org; \n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=GDQjY5idSE5YjyrBnmDbsQPOeiY6QphQgaB2lNNKjf0=;\n\tb=SXKZ4tRf9Xw3zbiZ7Qk+ZIHW44zJVS9EIADonaCqFtym41fy9ZiqBWMeUGAePxHprW\n\tMhJ5hMVEkPy6GKovBuLNaVyaH9HM61vvZ796CqvIdMRJttekiA1fDROWKv8oaARxxtpA\n\t7313S3ltozzGH/FzhNjpvGm749Z80yAows7nOYqG5JAA6W9BjCkrSOdYAtvgTEX70MwL\n\to0nHNLH0ugKGxKbwIAJ8w4Ce1rpG14ERfVA/zaviUELOYRgZbjCw9x2LnDhOLyDE+IoY\n\tPC/c4RWivQ5CMTFhiK+6uQQ6zWfZ5QnyykhUbDOgOOnSUoVdBLynb/gi2oFKk4eclUro\n\tm91g==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1759477137; x=1760081937;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=GDQjY5idSE5YjyrBnmDbsQPOeiY6QphQgaB2lNNKjf0=;\n\tb=U+TbCWVxqiO/Y8uMvftrbYOg8yQ9DKmo/3qwneGxXDA6W2UJAkOPXnbaTRFs8ieB1u\n\t2BM1DPu9PsNt3PfH1sG9+zSA3ae4z4fF9ivJk9er/ftddUppuZq0eYhz1raC3Bqi9duy\n\tygFxbF2dZKpuTu6fhJnbFM+f3SplsVKKPj7F8wYU2gETf41hPPzvI8tme8MO2UINA0Va\n\txFVWCFkm0TDBVlw2XH8VcwWScU2brMsgkVsBNxEdklb0AwqiJjIj3xN+MNcPwyRziIL8\n\tt1XCTjmrclKmmi8cam/glA/z1+1JT/rIyhJL7yx4z+IgngoMhrdV6LZRPPuz3hdKxiwq\n\tZpwQ==","X-Gm-Message-State":"AOJu0YytbACJN85sfH1XmML4BbFaMFbXi+gua5wNz65oFkSKTMnMskHS\n\tqmCq3uAQf/SOZovERUGg2gzr5qIk8osRUQg8ujgjjv+8qOjV1y3nxi4JV7OP3M6E6tkVny31ZjV\n\tYwjPVQwUyp+eoU8JlGMWo1+nilrsm2+HE0NoUMpLMag==","X-Gm-Gg":"ASbGncuUaTrEKnZaNYWfpNIVPBY73ewkMlmQdoRPJOxjSqBveU6IBH2ydlHiDwQtugZ\n\tMhgd+vzCdocIKnUU6yoWjcCWA91xdIZz72w0KQ+7CBZ+v92B0A9+n0EijPhNCgCtW+wCVhcw8df\n\txF4u4Z6RVz/SrHQy+utGi/WFV8vsvl9r/ezKEABK5EmhXMd6awxk633j4JojdNZeBsrH9Xsmc7M\n\t5jbBv/rhDeByTPClFoCjcfd5WdORis5a0C5LebLmylCd4xnVVvOGAmG7ozFkZE=","X-Google-Smtp-Source":"AGHT+IF0245qGXC6ocApKZixXok+g2PJSrPOyDuBWP8f6hqEsBVgSVxJ5K/ZXsqb7FtjUZQi/tvdfsb97bbOGNiMMDU=","X-Received":"by 2002:a05:6122:511a:20b0:54c:1c83:f8c5 with SMTP id\n\t71dfb90a1353d-5524e4277f3mr213526e0c.0.1759477137185; Fri, 03 Oct 2025\n\t00:38:57 -0700 (PDT)","MIME-Version":"1.0","References":"<20251002145506.996443-1-barnabas.pocze@ideasonboard.com>\n\t\n\t<20251002150121.GA20509@pendragon.ideasonboard.com>\n\t<6d0692f6-9337-4908-ae2a-c54bc029e001@ideasonboard.com>\n\t<4Codvp64tqmGsx2Vv_k_rTFVz5Ot-qIJ4ujom0cjCTFbZM12kWyYV_igR6Ty8GVTJxF7XuD1dVa5xKtP9apY4A==@protonmail.internalid>\n\t<20251002170314.GD16185@pendragon.ideasonboard.com>\n\t\n\t<20251002181117.GE16185@pendragon.ideasonboard.com>\n\t\n\t\n\t<98e4a56c-23ab-40e0-a0e8-1e0ad2110742@ideasonboard.com>","In-Reply-To":"<98e4a56c-23ab-40e0-a0e8-1e0ad2110742@ideasonboard.com>","From":"Naushir Patuck ","Date":"Fri, 3 Oct 2025 08:38:23 +0100","X-Gm-Features":"AS18NWDmzYQafBZhpZzM0Qrog-S6uQQ2jHo34nNj83X2lwZ3qZgdmWQJSgQVD0M","Message-ID":"","Subject":"Re: [PATCH v1] libcamera: pipeline: rpi: Set `werror=false` for\n\tlibpisp","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org, \n\tLaurent Pinchart ","Content-Type":"multipart/alternative; boundary=\"000000000000c0abd406403c318d\"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":36097,"web_url":"https://patchwork.libcamera.org/comment/36097/","msgid":"","date":"2025-10-03T07:42:16","subject":"Re: [PATCH v1] libcamera: pipeline: rpi: Set `werror=false` for\n\tlibpisp","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2025. 10. 03. 9:32 keltezéssel, Barnabás Pőcze írta:\n> 2025. 10. 03. 8:50 keltezéssel, Naushir Patuck írta:\n>>\n>>\n>> On Thu, 2 Oct 2025 at 19:11, Laurent Pinchart > wrote:\n>>\n>>     On Thu, Oct 02, 2025 at 07:30:45PM +0200, Barnabás Pőcze wrote:\n>>      > 2025. 10. 02. 19:03 keltezéssel, Laurent Pinchart írta:\n>>      > > On Thu, Oct 02, 2025 at 05:19:41PM +0200, Barnabás Pőcze wrote:\n>>      > >> 2025. 10. 02. 17:01 keltezéssel, Laurent Pinchart írta:\n>>      > >>> On Thu, Oct 02, 2025 at 04:55:06PM +0200, Barnabás Pőcze wrote:\n>>      > >>>> By default libcamera is configured with `werror=true`, and this option can\n>>      > >>>> propagate into the subprojects. This can lead to compilation failures due to\n>>      > >>>> warnings in those subprojects. This is the case with libpisp. Since these\n>>      > >>>> issues are not directly fixable, set `werror=false` for libpisp.\n>>      > >>>\n>>      > >>> Can't we fix those errors ?\n>>      > >>\n>>      > >> I might be misunderstanding, but I think that should be done in the context of the\n>>      > >> libpisp project.\n>>      > >\n>>      > > Yes you're right.\n>>      > >\n>>      > >> I would argue you cannot immediately act on the errors as if they were\n>>      > >> inside the libcamera code base; short of adding patch files and having meson apply them.\n>>      > >> But seems like a lot of effort.\n>>      > >\n>>      > > Agreed, I don't think we should do that.\n>>      > >\n>>      > >> The specific issue I have is already fixed: https://github.com/raspberrypi/libpisp/pull/53 \n>>      > >> but no release has been made, and the wrap file uses the last release, not the master branch.\n>>      > >\n>>      > > Naush, could you make a release ?\n>>\n>>\n>> I can arrange a release shortly.  Also happy to update the wrap file to point to master instead of a particular release if you prefer?\n>>\n>>      > >\n>>      > > If this issue occurs again we would set werror=false for libpisp, but if\n>>      > > it's easy to fix this time we can just update to a new release.\n>>      > >\n>>      > > I see libpisp has werror=true in meson.build, and there's a CI pipeline\n>>      > > that compiles the project with both gcc and clang. Why wasn't this\n>>      > > detected, different gcc versions maybe ?\n>>      >\n>>      > I think one issue with that CI pipeline is that, as far as I can see, it runs\n>>      > only on x86 and compiles natively. So it does not pick up the slight idiosyncrasies\n>>      > of the (glibc) headers of different architectures.\n>>      >\n>>      > There are aarch64 runners available nowadays, I believe that would be an easy way\n>>      > to add aarch64 compilation coverage: https://github.com/orgs/community/discussions/148648 \n>>\n>>     Especially for libpisp compilation on aarch64 is more useful than\n>>     compilation on x86 :-)\n>>\n>>\n>> The aarch64 build happens as part of the device run-tests, but it's a later version of gcc which seems to complain.\n> \n> Ahh, sorry, I see now that you have on device tests using self-hosted runners in\n> pisp-verification.test.yaml. I still think adding the github-provided aarch64\n> runners to libpisp-build-test.yaml should be simple and is still useful.\n\nAccording to\n * https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2404-Readme.md\n * https://github.com/actions/partner-runner-images/blob/main/images/arm-ubuntu-24-image.md\nthe images have multiple versions of gcc and clang by default, so should be possible to extend\nthe coverage even more by just adding `ubuntu-24.04-arm` and the available compiler versions\nin the \"strategy matrix\", I think. (Although arguably hard-coding the compiler version when\nusing the \"dynamic\" `ubuntu-latest` may not be a good idea.)\n\n\n> \n> \n> Regards,\n> Barnabás Pőcze\n> \n>>\n>> Regards,\n>> Naush\n>>\n>>\n>>     If you would like to merge this patch,\n>>\n>>     Reviewed-by: Laurent Pinchart >\n>>\n>>      > > This being said, keeping werror=true for this dependency means things\n>>      > > could break again in the future, and we'll have then to deal with the\n>>      > > issue. I'm wondering if there's value in us noticing compiler warnings\n>>      > > in libpisp, maybe it's best to ignore them for all dependencies ?\n>>      > >\n>>      > >>>> Signed-off-by: Barnabás Pőcze >\n>>      > >>>> ---\n>>      > >>>>    src/libcamera/pipeline/rpi/pisp/meson.build | 4 +++-\n>>      > >>>>    1 file changed, 3 insertions(+), 1 deletion(-)\n>>      > >>>>\n>>      > >>>> diff --git a/src/libcamera/pipeline/rpi/pisp/meson.build b/src/libcamera/pipeline/rpi/pisp/meson.build\n>>      > >>>> index 178df94c2..642080014 100644\n>>      > >>>> --- a/src/libcamera/pipeline/rpi/pisp/meson.build\n>>      > >>>> +++ b/src/libcamera/pipeline/rpi/pisp/meson.build\n>>      > >>>> @@ -5,7 +5,9 @@ libcamera_internal_sources += files([\n>>      > >>>>    ])\n>>      > >>>>\n>>      > >>>>    librt = cc.find_library('rt', required : true)\n>>      > >>>> -libpisp_dep = dependency('libpisp', fallback : ['libpisp', 'libpisp_dep'])\n>>      > >>>> +libpisp_dep = dependency('libpisp',\n>>      > >>>> +                         fallback : ['libpisp', 'libpisp_dep'],\n>>      > >>>> +                         default_options : ['werror=false'])\n>>      > >>>>\n>>      > >>>>    libcamera_deps += [libpisp_dep, librt]\n>>      > >>>>\n>>\n>>     --     Regards,\n>>\n>>     Laurent Pinchart\n>>\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 68EADBF415\n\tfor ;\n\tFri, 3 Oct 2025 07:42:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 292416B5AA;\n\tFri, 3 Oct 2025 09:42:22 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8C4406B599\n\tfor ;\n\tFri, 3 Oct 2025 09:42:19 +0200 (CEST)","from [192.168.33.17] (185.221.140.76.nat.pool.zt.hu\n\t[185.221.140.76])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 095CC929;\n\tFri, 3 Oct 2025 09:40:48 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"W+TXGTYh\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1759477249;\n\tbh=DJO3SmyezApLsusFhetxsF0XfUtwdxEgJJrsGT8jst4=;\n\th=Date:Subject:From:To:Cc:References:In-Reply-To:From;\n\tb=W+TXGTYhk+qBBFaaMT3NDYyxOK20v3p0qm33xO/WWLWZSSMyUD8nJ4ecZtzw8HfE5\n\tz25EPJHHv3xIXUxZQpitKOSq9N+xIrtAmsxbPjvsNxgx2LHR5mi9QFQrUIXlKZ0heo\n\tdmIeQX7rJvYXPVUPYweZAcQAdHjSjNI0aBytLtcM=","Message-ID":"","Date":"Fri, 3 Oct 2025 09:42:16 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v1] libcamera: pipeline: rpi: Set `werror=false` for\n\tlibpisp","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"Naushir Patuck ","Cc":"libcamera-devel@lists.libcamera.org,\n\tLaurent Pinchart ","References":"<20251002145506.996443-1-barnabas.pocze@ideasonboard.com>\n\t\n\t<20251002150121.GA20509@pendragon.ideasonboard.com>\n\t<6d0692f6-9337-4908-ae2a-c54bc029e001@ideasonboard.com>\n\t<4Codvp64tqmGsx2Vv_k_rTFVz5Ot-qIJ4ujom0cjCTFbZM12kWyYV_igR6Ty8GVTJxF7XuD1dVa5xKtP9apY4A==@protonmail.internalid>\n\t<20251002170314.GD16185@pendragon.ideasonboard.com>\n\t\n\t<20251002181117.GE16185@pendragon.ideasonboard.com>\n\t\n\t\n\t<98e4a56c-23ab-40e0-a0e8-1e0ad2110742@ideasonboard.com>","Content-Language":"en-US, hu-HU","In-Reply-To":"<98e4a56c-23ab-40e0-a0e8-1e0ad2110742@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":36098,"web_url":"https://patchwork.libcamera.org/comment/36098/","msgid":"","date":"2025-10-03T07:42:57","subject":"Re: [PATCH v1] libcamera: pipeline: rpi: Set `werror=false` for\n\tlibpisp","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2025. 10. 03. 9:38 keltezéssel, Naushir Patuck írta:\n> \n> \n> On Fri, 3 Oct 2025 at 08:32, Barnabás Pőcze > wrote:\n> \n> 2025. 10. 03. 8:50 keltezéssel, Naushir Patuck írta:\n> >\n> >\n> > On Thu, 2 Oct 2025 at 19:11, Laurent Pinchart >> wrote:\n> >\n> >     On Thu, Oct 02, 2025 at 07:30:45PM +0200, Barnabás Pőcze wrote:\n> >      > 2025. 10. 02. 19:03 keltezéssel, Laurent Pinchart írta:\n> >      > > On Thu, Oct 02, 2025 at 05:19:41PM +0200, Barnabás Pőcze wrote:\n> >      > >> 2025. 10. 02. 17:01 keltezéssel, Laurent Pinchart írta:\n> >      > >>> On Thu, Oct 02, 2025 at 04:55:06PM +0200, Barnabás Pőcze wrote:\n> >      > >>>> By default libcamera is configured with `werror=true`, and this option can\n> >      > >>>> propagate into the subprojects. This can lead to compilation failures due to\n> >      > >>>> warnings in those subprojects. This is the case with libpisp. Since these\n> >      > >>>> issues are not directly fixable, set `werror=false` for libpisp.\n> >      > >>>\n> >      > >>> Can't we fix those errors ?\n> >      > >>\n> >      > >> I might be misunderstanding, but I think that should be done in the context of the\n> >      > >> libpisp project.\n> >      > >\n> >      > > Yes you're right.\n> >      > >\n> >      > >> I would argue you cannot immediately act on the errors as if they were\n> >      > >> inside the libcamera code base; short of adding patch files and having meson apply them.\n> >      > >> But seems like a lot of effort.\n> >      > >\n> >      > > Agreed, I don't think we should do that.\n> >      > >\n> >      > >> The specific issue I have is already fixed: https://github.com/raspberrypi/libpisp/pull/53 >\n> >      > >> but no release has been made, and the wrap file uses the last release, not the master branch.\n> >      > >\n> >      > > Naush, could you make a release ?\n> >\n> >\n> > I can arrange a release shortly.  Also happy to update the wrap file to point to master instead of a particular release if you prefer?\n> >\n> >      > >\n> >      > > If this issue occurs again we would set werror=false for libpisp, but if\n> >      > > it's easy to fix this time we can just update to a new release.\n> >      > >\n> >      > > I see libpisp has werror=true in meson.build, and there's a CI pipeline\n> >      > > that compiles the project with both gcc and clang. Why wasn't this\n> >      > > detected, different gcc versions maybe ?\n> >      >\n> >      > I think one issue with that CI pipeline is that, as far as I can see, it runs\n> >      > only on x86 and compiles natively. So it does not pick up the slight idiosyncrasies\n> >      > of the (glibc) headers of different architectures.\n> >      >\n> >      > There are aarch64 runners available nowadays, I believe that would be an easy way\n> >      > to add aarch64 compilation coverage: https://github.com/orgs/community/discussions/148648 >\n> >\n> >     Especially for libpisp compilation on aarch64 is more useful than\n> >     compilation on x86 :-)\n> >\n> >\n> > The aarch64 build happens as part of the device run-tests, but it's a later version of gcc which seems to complain.\n> \n> Ahh, sorry, I see now that you have on device tests using self-hosted runners in\n> pisp-verification.test.yaml. I still think adding the github-provided aarch64\n> runners to libpisp-build-test.yaml should be simple and is still useful.\n> \n> \n> Makes sense, I'll make the update to the CI.\n\nThanks, I hope it is as simple as it seems.\n\n\n> \n> Naush\n> \n> \n> \n> Regards,\n> Barnabás Pőcze\n> \n> >\n> > Regards,\n> > Naush\n> >\n> >\n> >     If you would like to merge this patch,\n> >\n> >     Reviewed-by: Laurent Pinchart >>\n> >\n> >      > > This being said, keeping werror=true for this dependency means things\n> >      > > could break again in the future, and we'll have then to deal with the\n> >      > > issue. I'm wondering if there's value in us noticing compiler warnings\n> >      > > in libpisp, maybe it's best to ignore them for all dependencies ?\n> >      > >\n> >      > >>>> Signed-off-by: Barnabás Pőcze >>\n> >      > >>>> ---\n> >      > >>>>    src/libcamera/pipeline/rpi/pisp/meson.build | 4 +++-\n> >      > >>>>    1 file changed, 3 insertions(+), 1 deletion(-)\n> >      > >>>>\n> >      > >>>> diff --git a/src/libcamera/pipeline/rpi/pisp/meson.build b/src/libcamera/pipeline/rpi/pisp/meson.build\n> >      > >>>> index 178df94c2..642080014 100644\n> >      > >>>> --- a/src/libcamera/pipeline/rpi/pisp/meson.build\n> >      > >>>> +++ b/src/libcamera/pipeline/rpi/pisp/meson.build\n> >      > >>>> @@ -5,7 +5,9 @@ libcamera_internal_sources += files([\n> >      > >>>>    ])\n> >      > >>>>\n> >      > >>>>    librt = cc.find_library('rt', required : true)\n> >      > >>>> -libpisp_dep = dependency('libpisp', fallback : ['libpisp', 'libpisp_dep'])\n> >      > >>>> +libpisp_dep = dependency('libpisp',\n> >      > >>>> +                         fallback : ['libpisp', 'libpisp_dep'],\n> >      > >>>> +                         default_options : ['werror=false'])\n> >      > >>>>\n> >      > >>>>    libcamera_deps += [libpisp_dep, librt]\n> >      > >>>>\n> >\n> >     --\n> >     Regards,\n> >\n> >     Laurent Pinchart\n> >\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 799CDC324C\n\tfor ;\n\tFri, 3 Oct 2025 07:43:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2A0726B5F9;\n\tFri, 3 Oct 2025 09:43:02 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5FEA16B599\n\tfor ;\n\tFri, 3 Oct 2025 09:43:00 +0200 (CEST)","from [192.168.33.17] (185.221.140.76.nat.pool.zt.hu\n\t[185.221.140.76])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0841C929;\n\tFri, 3 Oct 2025 09:41:29 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Gx7jXBBa\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1759477290;\n\tbh=bxlowhH+BRvRvaGRe1dyQTBnyVcPK9gTymsZu1zSXaQ=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=Gx7jXBBa+uMOmFm7g5td7wWTXDwHpMdhhFwFMhSr4iszzGVMpvINzP6joBILzmCsh\n\tgo23998i5zn92ZHlZJvBNDHtBcFZbbbHaftNWjJvoJjo/WzOsK5RQvY/Ibgg1s9jeh\n\tv6P02wQ+0cYCgAKDJU3+GpnBGgh71ib51impPV0E=","Message-ID":"","Date":"Fri, 3 Oct 2025 09:42:57 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v1] libcamera: pipeline: rpi: Set `werror=false` for\n\tlibpisp","To":"Naushir Patuck ","Cc":"libcamera-devel@lists.libcamera.org,\n\tLaurent Pinchart ","References":"<20251002145506.996443-1-barnabas.pocze@ideasonboard.com>\n\t\n\t<20251002150121.GA20509@pendragon.ideasonboard.com>\n\t<6d0692f6-9337-4908-ae2a-c54bc029e001@ideasonboard.com>\n\t<4Codvp64tqmGsx2Vv_k_rTFVz5Ot-qIJ4ujom0cjCTFbZM12kWyYV_igR6Ty8GVTJxF7XuD1dVa5xKtP9apY4A==@protonmail.internalid>\n\t<20251002170314.GD16185@pendragon.ideasonboard.com>\n\t\n\t<20251002181117.GE16185@pendragon.ideasonboard.com>\n\t\n\t\n\t<98e4a56c-23ab-40e0-a0e8-1e0ad2110742@ideasonboard.com>\n\t","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]