{"id":24553,"url":"https://patchwork.libcamera.org/api/patches/24553/?format=json","web_url":"https://patchwork.libcamera.org/patch/24553/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251002145506.996443-1-barnabas.pocze@ideasonboard.com>","date":"2025-10-02T14:55:06","name":"[v1] libcamera: pipeline: rpi: Set `werror=false` for libpisp","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"2c7bd5d5a7fd45a5bd5215fa6a8c072d76e1e537","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24553/mbox/","series":[{"id":5475,"url":"https://patchwork.libcamera.org/api/series/5475/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5475","date":"2025-10-02T14:55:06","name":"[v1] libcamera: pipeline: rpi: Set `werror=false` for libpisp","version":1,"mbox":"https://patchwork.libcamera.org/series/5475/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24553/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24553/checks/","tags":{},"headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 19732C328C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu,  2 Oct 2025 14:55:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 16DA86B5F0;\n\tThu,  2 Oct 2025 16:55:12 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 68AA06B5A2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu,  2 Oct 2025 16:55:10 +0200 (CEST)","from pb-laptop.local (185.221.142.146.nat.pool.zt.hu\n\t[185.221.142.146])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 64723929\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu,  2 Oct 2025 16:53:40 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Um13jlCn\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1759416820;\n\tbh=QSfGtiblYnYUoxhRH71OeRwEB9uxXW1sBtVKiclsKfg=;\n\th=From:To:Subject:Date:From;\n\tb=Um13jlCntp6rPdu7zQ6KSDJBSKnr/gbiJQoKyDpHihMdWIEP3kmlUfqfkNKBwvWfb\n\t7lbVDd1/ME6L0D5SQvtyPgnsGWIaYabewJyV/mffI0cCvwBAVnSnWjA9T/23OOZfap\n\tgzrptnrbB/JmxIaDykfaApacAjKZNAW1mdziP01U=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>","To":"libcamera-devel@lists.libcamera.org","Subject":"[PATCH v1] libcamera: pipeline: rpi: Set `werror=false` for libpisp","Date":"Thu,  2 Oct 2025 16:55:06 +0200","Message-ID":"<20251002145506.996443-1-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.51.0","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"By default libcamera is configured with `werror=true`, and this option can\npropagate into the subprojects. This can lead to compilation failures due to\nwarnings in those subprojects. This is the case with libpisp. Since these\nissues are not directly fixable, set `werror=false` for libpisp.\n\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n src/libcamera/pipeline/rpi/pisp/meson.build | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/pipeline/rpi/pisp/meson.build b/src/libcamera/pipeline/rpi/pisp/meson.build\nindex 178df94c2..642080014 100644\n--- a/src/libcamera/pipeline/rpi/pisp/meson.build\n+++ b/src/libcamera/pipeline/rpi/pisp/meson.build\n@@ -5,7 +5,9 @@ libcamera_internal_sources += files([\n ])\n \n librt = cc.find_library('rt', required : true)\n-libpisp_dep = dependency('libpisp', fallback : ['libpisp', 'libpisp_dep'])\n+libpisp_dep = dependency('libpisp',\n+                         fallback : ['libpisp', 'libpisp_dep'],\n+                         default_options : ['werror=false'])\n \n libcamera_deps += [libpisp_dep, librt]\n \n","prefixes":["v1"]}