{"id":24534,"url":"https://patchwork.libcamera.org/api/patches/24534/?format=json","web_url":"https://patchwork.libcamera.org/patch/24534/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250930150428.11101-2-hansg@kernel.org>","date":"2025-09-30T15:04:23","name":"[v4,1/6] ipa: software_isp: Fix context_.configuration.agc.againMin init","commit_ref":"7a7935e4bc6f4360d1406ce9a7b4eaa07bbdc82f","pull_url":null,"state":"accepted","archived":false,"hash":"ce05dd561721d3d83776876150b2dbbc7e6aa19a","submitter":{"id":239,"url":"https://patchwork.libcamera.org/api/people/239/?format=json","name":"Hans de Goede","email":"hansg@kernel.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24534/mbox/","series":[{"id":5470,"url":"https://patchwork.libcamera.org/api/series/5470/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5470","date":"2025-09-30T15:04:22","name":"ipa: software_isp: AGC: Fix AGC oscillation bug","version":4,"mbox":"https://patchwork.libcamera.org/series/5470/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24534/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24534/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D0ABAC328C\n\tfor ;\n\tTue, 30 Sep 2025 15:04:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9C8A06B5FF;\n\tTue, 30 Sep 2025 17:04:39 +0200 (CEST)","from tor.source.kernel.org (tor.source.kernel.org\n\t[IPv6:2600:3c04:e001:324:0:1991:8:25])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9496269367\n\tfor ;\n\tTue, 30 Sep 2025 17:04:35 +0200 (CEST)","from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n\tby tor.source.kernel.org (Postfix) with ESMTP id CCE0162392;\n\tTue, 30 Sep 2025 15:04:34 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 0A002C116B1;\n\tTue, 30 Sep 2025 15:04:32 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=kernel.org header.i=@kernel.org\n\theader.b=\"FjXSMHRw\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1759244674;\n\tbh=ai8KVMNvlLzP8vSPJW7zKzjEWtbw5jwS5ofzUqqDeWs=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=FjXSMHRwIlwo43PbMyvhtdAN3zgfUXSSQYq+i+Tn6Ne29gebaWmIO74NQrRQdRY9O\n\tWLYP/z3CBb13Ox3q8kv6jLzkpt2OjH2nfbfesW+DWbdyDHIZYXuR05treV0p5vu3j6\n\tjE+XR7oZNRSYUEK02EDvsGjdV5OpKlKGjkS5UyOBm6TVTCq/jLxkxKo9xldjuWF9sE\n\t5tX8qruI/FBPJeD+F2nbgJjQVLt/a+nBdcTnmfFcREWUZuxwiq3Mqtu9CBn5xnPMvv\n\tONP0EN0+fLetjEfrk5tAwLU/wXhtUfuNmqBWnyACXmtcqlFjSGiqLMRKKWDrY94W11\n\t0mlw66wUcEdkw==","From":"Hans de Goede ","To":"libcamera-devel@lists.libcamera.org","Cc":"Hans de Goede , Milan Zamazal ,\n\tIsaac Scott ,\n\tKieran Bingham ","Subject":"[PATCH v4 1/6] ipa: software_isp: Fix\n\tcontext_.configuration.agc.againMin init","Date":"Tue, 30 Sep 2025 17:04:23 +0200","Message-ID":"<20250930150428.11101-2-hansg@kernel.org>","X-Mailer":"git-send-email 2.51.0","In-Reply-To":"<20250930150428.11101-1-hansg@kernel.org>","References":"<20250930150428.11101-1-hansg@kernel.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Currently context_.configuration.agc.againMin is not initialized\nwhen the control reports a non 0 minimum gain value.\n\nSo far only the againMin == 0 case was handled and\ncontext_.configuration.agc.againMin was left unset otherwise.\n\nReviewed-by: Milan Zamazal \nReviewed-by: Isaac Scott \nTested-by: Milan Zamazal \nTested-by: Kieran Bingham \nSigned-off-by: Hans de Goede \n---\n src/ipa/simple/soft_simple.cpp | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)","diff":"diff --git a/src/ipa/simple/soft_simple.cpp b/src/ipa/simple/soft_simple.cpp\nindex c94c4cd55..e70439ee5 100644\n--- a/src/ipa/simple/soft_simple.cpp\n+++ b/src/ipa/simple/soft_simple.cpp\n@@ -246,7 +246,9 @@ int IPASoftSimple::configure(const IPAConfigInfo &configInfo)\n \t\t * other) we limit the range of the gain values used.\n \t\t */\n \t\tcontext_.configuration.agc.againMax = againMax;\n-\t\tif (!againMin) {\n+\t\tif (againMin) {\n+\t\t\tcontext_.configuration.agc.againMin = againMin;\n+\t\t} else {\n \t\t\tLOG(IPASoft, Warning)\n \t\t\t\t<< \"Minimum gain is zero, that can't be linear\";\n \t\t\tcontext_.configuration.agc.againMin =\n","prefixes":["v4","1/6"]}