[{"id":36089,"web_url":"https://patchwork.libcamera.org/comment/36089/","msgid":"<175944013809.3754595.3739097072302119406@ping.linuxembedded.co.uk>","date":"2025-10-02T21:22:18","subject":"Re: [PATCH v1 32/33] libcamera: rkisp1: Implement LensDewarpEnable\n\tcontrol","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Stefan Klug (2025-09-30 13:26:53)\n> Implement the LensDewarpEnable control for the rkisp1 pipeline using the\n> dw100 converter.\n> \n> Signed-off-by: Stefan Klug \n> ---\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 6 +++++-\n> 1 file changed, 5 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> index 13d82c9957bc..98521c804d84 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> @@ -1514,12 +1514,13 @@ int PipelineHandlerRkISP1::updateControls(RkISP1CameraData *data)\n> maxCrop);\n> }\n> \n> -\n\nLets squash that down to where it was added ?\n\n> if (dewarper_->supportsRequests()) {\n> controls[&controls::draft::Dw100Scale] = ControlInfo(0.2f, 8.0f, 1.0f);\n> controls[&controls::draft::Dw100Rotation] = ControlInfo(-180.0f, 180.0f, 0.0f);\n> controls[&controls::draft::Dw100Offset] = ControlInfo(Point(-10000, -10000), Point(10000, 10000), Point(0, 0));\n> controls[&controls::draft::Dw100ScaleMode] = ControlInfo(controls::draft::Dw100ScaleModeValues, controls::draft::Fill);\n> + if (data->dewarpParams_.has_value())\n> + controls[&controls::LensDewarpEnable] = ControlInfo(false, true, true);\n\nSo - if we have a dewarp parameter set - we expose a control to allow it\nto be enabled or disabled...\n\nWe default to true. Great :-)\n\n> } else {\n> LOG(RkISP1, Warning)\n> << \"dw100 kernel driver has no requests support.\"\n> @@ -1873,6 +1874,9 @@ void PipelineHandlerRkISP1::imageBufferReady(FrameBuffer *buffer)\n> meta.set(controls::draft::Dw100Rotation, vertexMap.rotation());\n> meta.set(controls::draft::Dw100Offset, vertexMap.effectiveOffset());\n> meta.set(controls::ScalerCrop, vertexMap.effectiveScalerCrop());\n> +\n> + if (vertexMap.dewarpParamsValid())\n> + meta.set(controls::LensDewarpEnable, vertexMap.lensDewarpEnable());\n\nAnd we report if it was enabled...\n\nBut does anything parse LensDewarpEnable to allow it to be disabled ?\n\n> }\n> \n> void PipelineHandlerRkISP1::dewarpRequestReady(V4L2Request *request)\n> -- \n> 2.48.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8A91CC324C\n\tfor ;\n\tThu, 2 Oct 2025 21:22:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DD4706B5F3;\n\tThu, 2 Oct 2025 23:22:21 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2B0CE6B5A2\n\tfor ;\n\tThu, 2 Oct 2025 23:22:21 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 08406F06;\n\tThu, 2 Oct 2025 23:20:50 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"oy2E5lbo\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1759440051;\n\tbh=/+S09lRY9fO48VrfpaFYKiPz30mmAAeo2jKLsMELBEQ=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=oy2E5lboXVAdmPWZjXf7OXePEHvznetzWX1pQhYJWnzY7KadlH0uA5jgvIPG9fMRv\n\tnwFkv5lQkEkd5F3aONk/W0RexG9XU0QFKkk3lUQXLY2XarZaBmWNwarHLp5V2JKHzX\n\tIH/4YHBFEHhmq9EvjwxBsfI4S5iqD8wnCwVlkTfI=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250930122726.1837524-33-stefan.klug@ideasonboard.com>","References":"<20250930122726.1837524-1-stefan.klug@ideasonboard.com>\n\t<20250930122726.1837524-33-stefan.klug@ideasonboard.com>","Subject":"Re: [PATCH v1 32/33] libcamera: rkisp1: Implement LensDewarpEnable\n\tcontrol","From":"Kieran Bingham ","Cc":"Stefan Klug ","To":"Stefan Klug ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 02 Oct 2025 22:22:18 +0100","Message-ID":"<175944013809.3754595.3739097072302119406@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":36136,"web_url":"https://patchwork.libcamera.org/comment/36136/","msgid":"<175974348907.3214037.15476478303923820734@localhost>","date":"2025-10-06T09:38:09","subject":"Re: [PATCH v1 32/33] libcamera: rkisp1: Implement LensDewarpEnable\n\tcontrol","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the review.\n\nQuoting Kieran Bingham (2025-10-02 23:22:18)\n> Quoting Stefan Klug (2025-09-30 13:26:53)\n> > Implement the LensDewarpEnable control for the rkisp1 pipeline using the\n> > dw100 converter.\n> > \n> > Signed-off-by: Stefan Klug \n> > ---\n> > src/libcamera/pipeline/rkisp1/rkisp1.cpp | 6 +++++-\n> > 1 file changed, 5 insertions(+), 1 deletion(-)\n> > \n> > diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> > index 13d82c9957bc..98521c804d84 100644\n> > --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> > +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> > @@ -1514,12 +1514,13 @@ int PipelineHandlerRkISP1::updateControls(RkISP1CameraData *data)\n> > maxCrop);\n> > }\n> > \n> > -\n> \n> Lets squash that down to where it was added ?\n\nSure, no problem.\n\n> \n> > if (dewarper_->supportsRequests()) {\n> > controls[&controls::draft::Dw100Scale] = ControlInfo(0.2f, 8.0f, 1.0f);\n> > controls[&controls::draft::Dw100Rotation] = ControlInfo(-180.0f, 180.0f, 0.0f);\n> > controls[&controls::draft::Dw100Offset] = ControlInfo(Point(-10000, -10000), Point(10000, 10000), Point(0, 0));\n> > controls[&controls::draft::Dw100ScaleMode] = ControlInfo(controls::draft::Dw100ScaleModeValues, controls::draft::Fill);\n> > + if (data->dewarpParams_.has_value())\n> > + controls[&controls::LensDewarpEnable] = ControlInfo(false, true, true);\n> \n> So - if we have a dewarp parameter set - we expose a control to allow it\n> to be enabled or disabled...\n> \n> We default to true. Great :-)\n> \n> > } else {\n> > LOG(RkISP1, Warning)\n> > << \"dw100 kernel driver has no requests support.\"\n> > @@ -1873,6 +1874,9 @@ void PipelineHandlerRkISP1::imageBufferReady(FrameBuffer *buffer)\n> > meta.set(controls::draft::Dw100Rotation, vertexMap.rotation());\n> > meta.set(controls::draft::Dw100Offset, vertexMap.effectiveOffset());\n> > meta.set(controls::ScalerCrop, vertexMap.effectiveScalerCrop());\n> > +\n> > + if (vertexMap.dewarpParamsValid())\n> > + meta.set(controls::LensDewarpEnable, vertexMap.lensDewarpEnable());\n> \n> And we report if it was enabled...\n> \n> But does anything parse LensDewarpEnable to allow it to be disabled ?\n\nOuch where did that get lost... it was still there a while ago. Thanks\nfor spotting this.\n\nBest regards,\nStefan\n\n> \n> > }\n> > \n> > void PipelineHandlerRkISP1::dewarpRequestReady(V4L2Request *request)\n> > -- \n> > 2.48.1\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 03360BF415\n\tfor ;\n\tMon, 6 Oct 2025 09:38:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7012F6B5F3;\n\tMon, 6 Oct 2025 11:38:13 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 972DB62C35\n\tfor ;\n\tMon, 6 Oct 2025 11:38:11 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:2e2:f331:f320:caae])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id BA4C41741; \n\tMon, 6 Oct 2025 11:36:38 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"bxfbTIDY\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1759743398;\n\tbh=o3+Kl2Zg4a8N1jJ8ORPcHm4zSO+8r0cQcPZkNzOs63w=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=bxfbTIDYctiUqea16Ppp5fCNxIn3kirlURBPtsqtgRNPlDdTMCN5liI8LoNlxw7/Q\n\tzpg+Q6y9xavTUnFbPATARSPnqpqLNUWFk40BAF8zruqo9R1SMcRs+RnwuKhfqMib/t\n\tD+58hQD9srks0RSJR36oPD1iSIm1awU1sQsuDCW8=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<175944013809.3754595.3739097072302119406@ping.linuxembedded.co.uk>","References":"<20250930122726.1837524-1-stefan.klug@ideasonboard.com>\n\t<20250930122726.1837524-33-stefan.klug@ideasonboard.com>\n\t<175944013809.3754595.3739097072302119406@ping.linuxembedded.co.uk>","Subject":"Re: [PATCH v1 32/33] libcamera: rkisp1: Implement LensDewarpEnable\n\tcontrol","From":"Stefan Klug ","Cc":"","To":"Kieran Bingham ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 06 Oct 2025 11:38:09 +0200","Message-ID":"<175974348907.3214037.15476478303923820734@localhost>","User-Agent":"alot/0.12.dev8+g2c003385c862.d20250602","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]