[{"id":36057,"web_url":"https://patchwork.libcamera.org/comment/36057/","msgid":"<175923971437.216853.6223978724278436600@ping.linuxembedded.co.uk>","date":"2025-09-30T13:41:54","subject":"Re: [PATCH v1 25/33] libcamera: internal: camera_sensor: Add\n\taccessor for mountingOrientation_","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Stefan Klug (2025-09-30 13:26:46)\n> To properly handle the orientation in the dewarper, the mounting\n> orientation of the sensor needs to be queryable. Add that.\n> \n> Signed-off-by: Stefan Klug \n> ---\n> include/libcamera/internal/camera_sensor.h | 1 +\n> src/libcamera/sensor/camera_sensor_legacy.cpp | 1 +\n> src/libcamera/sensor/camera_sensor_raw.cpp | 1 +\n> 3 files changed, 3 insertions(+)\n> \n> diff --git a/include/libcamera/internal/camera_sensor.h b/include/libcamera/internal/camera_sensor.h\n> index f6ef4df170d4..e6b72d22ac21 100644\n> --- a/include/libcamera/internal/camera_sensor.h\n> +++ b/include/libcamera/internal/camera_sensor.h\n> @@ -73,6 +73,7 @@ public:\n> virtual int sensorInfo(IPACameraSensorInfo *info) const = 0;\n> virtual Transform computeTransform(Orientation *orientation) const = 0;\n> virtual BayerFormat::Order bayerOrder(Transform t) const = 0;\n> + virtual Orientation mountingOrientation() const = 0;\n> \n> virtual const ControlInfoMap &controls() const = 0;\n> virtual ControlList getControls(Span ids) = 0;\n> diff --git a/src/libcamera/sensor/camera_sensor_legacy.cpp b/src/libcamera/sensor/camera_sensor_legacy.cpp\n> index f9e685a9acc4..39c34200b0ff 100644\n> --- a/src/libcamera/sensor/camera_sensor_legacy.cpp\n> +++ b/src/libcamera/sensor/camera_sensor_legacy.cpp\n> @@ -88,6 +88,7 @@ public:\n> int sensorInfo(IPACameraSensorInfo *info) const override;\n> Transform computeTransform(Orientation *orientation) const override;\n> BayerFormat::Order bayerOrder(Transform t) const override;\n> + Orientation mountingOrientation() const override { return mountingOrientation_; }\n\nI guess we don't have enough in the base class to return this commonly\nto both classes ?\n\n\n> \n> const ControlInfoMap &controls() const override;\n> ControlList getControls(Span ids) override;\n> diff --git a/src/libcamera/sensor/camera_sensor_raw.cpp b/src/libcamera/sensor/camera_sensor_raw.cpp\n> index 8ea4423698cd..759cccafe4a9 100644\n> --- a/src/libcamera/sensor/camera_sensor_raw.cpp\n> +++ b/src/libcamera/sensor/camera_sensor_raw.cpp\n> @@ -94,6 +94,7 @@ public:\n> int sensorInfo(IPACameraSensorInfo *info) const override;\n> Transform computeTransform(Orientation *orientation) const override;\n> BayerFormat::Order bayerOrder(Transform t) const override;\n> + Orientation mountingOrientation() const override { return mountingOrientation_; }\n> \n> const ControlInfoMap &controls() const override;\n> ControlList getControls(Span ids) override;\n> -- \n> 2.48.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 515F1C328C\n\tfor ;\n\tTue, 30 Sep 2025 13:41:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 126866B601;\n\tTue, 30 Sep 2025 15:41:59 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6A6CE69367\n\tfor ;\n\tTue, 30 Sep 2025 15:41:57 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2854E226;\n\tTue, 30 Sep 2025 15:40:29 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"XxgCBO9u\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1759239629;\n\tbh=qprXZrhb21aegGULpIg0xEXVBWv4kBbP+rmBCDIc0Hg=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=XxgCBO9uFde9z4FIYKmzk5LKJBZ/DHwiTXifJiO7m8+5egdteaZqvhWuOCpe3Tpll\n\tUrTSB5nEopTPRDdvX/H09QOzhAjCZWeA70gfMQGOXvdlmLVbqHU0b1zolMB8+oa8BQ\n\tRZMHtaeW9VbJSOboTJHF5mb4lYR2ylRcK5E1M87E=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250930122726.1837524-26-stefan.klug@ideasonboard.com>","References":"<20250930122726.1837524-1-stefan.klug@ideasonboard.com>\n\t<20250930122726.1837524-26-stefan.klug@ideasonboard.com>","Subject":"Re: [PATCH v1 25/33] libcamera: internal: camera_sensor: Add\n\taccessor for mountingOrientation_","From":"Kieran Bingham ","Cc":"Stefan Klug ","To":"Stefan Klug ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 30 Sep 2025 14:41:54 +0100","Message-ID":"<175923971437.216853.6223978724278436600@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":36133,"web_url":"https://patchwork.libcamera.org/comment/36133/","msgid":"<175974167698.3214037.6660972096993188865@localhost>","date":"2025-10-06T09:07:56","subject":"Re: [PATCH v1 25/33] libcamera: internal: camera_sensor: Add\n\taccessor for mountingOrientation_","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the review. \n\nQuoting Kieran Bingham (2025-09-30 15:41:54)\n> Quoting Stefan Klug (2025-09-30 13:26:46)\n> > To properly handle the orientation in the dewarper, the mounting\n> > orientation of the sensor needs to be queryable. Add that.\n> > \n> > Signed-off-by: Stefan Klug \n> > ---\n> > include/libcamera/internal/camera_sensor.h | 1 +\n> > src/libcamera/sensor/camera_sensor_legacy.cpp | 1 +\n> > src/libcamera/sensor/camera_sensor_raw.cpp | 1 +\n> > 3 files changed, 3 insertions(+)\n> > \n> > diff --git a/include/libcamera/internal/camera_sensor.h b/include/libcamera/internal/camera_sensor.h\n> > index f6ef4df170d4..e6b72d22ac21 100644\n> > --- a/include/libcamera/internal/camera_sensor.h\n> > +++ b/include/libcamera/internal/camera_sensor.h\n> > @@ -73,6 +73,7 @@ public:\n> > virtual int sensorInfo(IPACameraSensorInfo *info) const = 0;\n> > virtual Transform computeTransform(Orientation *orientation) const = 0;\n> > virtual BayerFormat::Order bayerOrder(Transform t) const = 0;\n> > + virtual Orientation mountingOrientation() const = 0;\n> > \n> > virtual const ControlInfoMap &controls() const = 0;\n> > virtual ControlList getControls(Span ids) = 0;\n> > diff --git a/src/libcamera/sensor/camera_sensor_legacy.cpp b/src/libcamera/sensor/camera_sensor_legacy.cpp\n> > index f9e685a9acc4..39c34200b0ff 100644\n> > --- a/src/libcamera/sensor/camera_sensor_legacy.cpp\n> > +++ b/src/libcamera/sensor/camera_sensor_legacy.cpp\n> > @@ -88,6 +88,7 @@ public:\n> > int sensorInfo(IPACameraSensorInfo *info) const override;\n> > Transform computeTransform(Orientation *orientation) const override;\n> > BayerFormat::Order bayerOrder(Transform t) const override;\n> > + Orientation mountingOrientation() const override { return mountingOrientation_; }\n> \n> I guess we don't have enough in the base class to return this commonly\n> to both classes ?\n\nNo, not really. The base class is mostly pure virtual.\n\nBest regards,\nStefan\n\n> \n> \n> > \n> > const ControlInfoMap &controls() const override;\n> > ControlList getControls(Span ids) override;\n> > diff --git a/src/libcamera/sensor/camera_sensor_raw.cpp b/src/libcamera/sensor/camera_sensor_raw.cpp\n> > index 8ea4423698cd..759cccafe4a9 100644\n> > --- a/src/libcamera/sensor/camera_sensor_raw.cpp\n> > +++ b/src/libcamera/sensor/camera_sensor_raw.cpp\n> > @@ -94,6 +94,7 @@ public:\n> > int sensorInfo(IPACameraSensorInfo *info) const override;\n> > Transform computeTransform(Orientation *orientation) const override;\n> > BayerFormat::Order bayerOrder(Transform t) const override;\n> > + Orientation mountingOrientation() const override { return mountingOrientation_; }\n> > \n> > const ControlInfoMap &controls() const override;\n> > ControlList getControls(Span ids) override;\n> > -- \n> > 2.48.1\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5B6AAC324C\n\tfor ;\n\tMon, 6 Oct 2025 09:08:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 90D126B5F3;\n\tMon, 6 Oct 2025 11:08:02 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DC27162C35\n\tfor ;\n\tMon, 6 Oct 2025 11:07:59 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:2e2:f331:f320:caae])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 2CB101741; \n\tMon, 6 Oct 2025 11:06:27 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"upCpImlM\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1759741587;\n\tbh=m5yzPxpgOhvGyuaM7gcR8J2UOZCNmgzyZUoW1n9/IJ4=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=upCpImlMMbfYJhH9jmKug+c1pohIOR/temYDhpBeMVpeDd22lALi0r5oFmV3LoRUQ\n\teCDmsIM0833J+Nv/26oQQODfrnfYcMCeKsGa1zP8jHQksllMUisiTOqnjz8g2tmqA6\n\taaJ+vFij5mowmLL54Wfqlt7STZKAbZVlMC6dHdhY=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<175923971437.216853.6223978724278436600@ping.linuxembedded.co.uk>","References":"<20250930122726.1837524-1-stefan.klug@ideasonboard.com>\n\t<20250930122726.1837524-26-stefan.klug@ideasonboard.com>\n\t<175923971437.216853.6223978724278436600@ping.linuxembedded.co.uk>","Subject":"Re: [PATCH v1 25/33] libcamera: internal: camera_sensor: Add\n\taccessor for mountingOrientation_","From":"Stefan Klug ","Cc":"","To":"Kieran Bingham ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 06 Oct 2025 11:07:56 +0200","Message-ID":"<175974167698.3214037.6660972096993188865@localhost>","User-Agent":"alot/0.12.dev8+g2c003385c862.d20250602","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":36141,"web_url":"https://patchwork.libcamera.org/comment/36141/","msgid":"<175974831537.756374.2824741283771799062@ping.linuxembedded.co.uk>","date":"2025-10-06T10:58:35","subject":"Re: [PATCH v1 25/33] libcamera: internal: camera_sensor: Add\n\taccessor for mountingOrientation_","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Stefan Klug (2025-10-06 10:07:56)\n> Hi Kieran,\n> \n> Thank you for the review. \n> \n> Quoting Kieran Bingham (2025-09-30 15:41:54)\n> > Quoting Stefan Klug (2025-09-30 13:26:46)\n> > > To properly handle the orientation in the dewarper, the mounting\n> > > orientation of the sensor needs to be queryable. Add that.\n> > > \n> > > Signed-off-by: Stefan Klug \n> > > ---\n> > > include/libcamera/internal/camera_sensor.h | 1 +\n> > > src/libcamera/sensor/camera_sensor_legacy.cpp | 1 +\n> > > src/libcamera/sensor/camera_sensor_raw.cpp | 1 +\n> > > 3 files changed, 3 insertions(+)\n> > > \n> > > diff --git a/include/libcamera/internal/camera_sensor.h b/include/libcamera/internal/camera_sensor.h\n> > > index f6ef4df170d4..e6b72d22ac21 100644\n> > > --- a/include/libcamera/internal/camera_sensor.h\n> > > +++ b/include/libcamera/internal/camera_sensor.h\n> > > @@ -73,6 +73,7 @@ public:\n> > > virtual int sensorInfo(IPACameraSensorInfo *info) const = 0;\n> > > virtual Transform computeTransform(Orientation *orientation) const = 0;\n> > > virtual BayerFormat::Order bayerOrder(Transform t) const = 0;\n> > > + virtual Orientation mountingOrientation() const = 0;\n> > > \n> > > virtual const ControlInfoMap &controls() const = 0;\n> > > virtual ControlList getControls(Span ids) = 0;\n> > > diff --git a/src/libcamera/sensor/camera_sensor_legacy.cpp b/src/libcamera/sensor/camera_sensor_legacy.cpp\n> > > index f9e685a9acc4..39c34200b0ff 100644\n> > > --- a/src/libcamera/sensor/camera_sensor_legacy.cpp\n> > > +++ b/src/libcamera/sensor/camera_sensor_legacy.cpp\n> > > @@ -88,6 +88,7 @@ public:\n> > > int sensorInfo(IPACameraSensorInfo *info) const override;\n> > > Transform computeTransform(Orientation *orientation) const override;\n> > > BayerFormat::Order bayerOrder(Transform t) const override;\n> > > + Orientation mountingOrientation() const override { return mountingOrientation_; }\n> > \n> > I guess we don't have enough in the base class to return this commonly\n> > to both classes ?\n> \n> No, not really. The base class is mostly pure virtual.\n\nWell if it should stay pure virtual then we have to duplicate the\nhelpers I guess so:\n\nReviewed-by: Kieran Bingham \n\n> \n> Best regards,\n> Stefan\n> \n> > \n> > \n> > > \n> > > const ControlInfoMap &controls() const override;\n> > > ControlList getControls(Span ids) override;\n> > > diff --git a/src/libcamera/sensor/camera_sensor_raw.cpp b/src/libcamera/sensor/camera_sensor_raw.cpp\n> > > index 8ea4423698cd..759cccafe4a9 100644\n> > > --- a/src/libcamera/sensor/camera_sensor_raw.cpp\n> > > +++ b/src/libcamera/sensor/camera_sensor_raw.cpp\n> > > @@ -94,6 +94,7 @@ public:\n> > > int sensorInfo(IPACameraSensorInfo *info) const override;\n> > > Transform computeTransform(Orientation *orientation) const override;\n> > > BayerFormat::Order bayerOrder(Transform t) const override;\n> > > + Orientation mountingOrientation() const override { return mountingOrientation_; }\n> > > \n> > > const ControlInfoMap &controls() const override;\n> > > ControlList getControls(Span ids) override;\n> > > -- \n> > > 2.48.1\n> > >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EF8C8BF415\n\tfor ;\n\tMon, 6 Oct 2025 10:58:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A820E6B5AA;\n\tMon, 6 Oct 2025 12:58:40 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 779CF6936E\n\tfor ;\n\tMon, 6 Oct 2025 12:58:38 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C0E28BD2;\n\tMon, 6 Oct 2025 12:57:05 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"el0qzE2U\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1759748225;\n\tbh=7OKqW/rLTuHvUNUHkITey4PFF7yTAEfvJTMJC37UuAg=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=el0qzE2UYuM9Vhh3YpBqm9jr/+mW9DTyJxsZ+7PsKoNBmLxMwvqx2bIpEttSJVT/W\n\txzZJKXphE8sVyz0taGYs5VBqeFbEa9urDY/hum11joLtbgckRj0iUNmAMb/SyHPxhF\n\tejhme+n1/gUGWi3+XnAAA2pwLFJGompvbLxm0/Cs=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<175974167698.3214037.6660972096993188865@localhost>","References":"<20250930122726.1837524-1-stefan.klug@ideasonboard.com>\n\t<20250930122726.1837524-26-stefan.klug@ideasonboard.com>\n\t<175923971437.216853.6223978724278436600@ping.linuxembedded.co.uk>\n\t<175974167698.3214037.6660972096993188865@localhost>","Subject":"Re: [PATCH v1 25/33] libcamera: internal: camera_sensor: Add\n\taccessor for mountingOrientation_","From":"Kieran Bingham ","Cc":"","To":"Stefan Klug ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 06 Oct 2025 11:58:35 +0100","Message-ID":"<175974831537.756374.2824741283771799062@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]