{"id":24518,"url":"https://patchwork.libcamera.org/api/patches/24518/?format=json","web_url":"https://patchwork.libcamera.org/patch/24518/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250930122726.1837524-20-stefan.klug@ideasonboard.com>","date":"2025-09-30T12:26:40","name":"[v1,19/33] libcamera: converter: Add dw100 converter class","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"e28abd9363b84e0dfa90f6eed700ccc6b9434384","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24518/mbox/","series":[{"id":5468,"url":"https://patchwork.libcamera.org/api/series/5468/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5468","date":"2025-09-30T12:26:21","name":"Full dewarper support on imx8mp","version":1,"mbox":"https://patchwork.libcamera.org/series/5468/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24518/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24518/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 01114C328C\n\tfor ;\n\tTue, 30 Sep 2025 13:13:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E36D66B5F3;\n\tTue, 30 Sep 2025 15:13:15 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 01D3362C35\n\tfor ;\n\tTue, 30 Sep 2025 15:13:14 +0200 (CEST)","from ideasonboard.com (unknown [94.31.94.171])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 7D493169;\n\tTue, 30 Sep 2025 15:11:45 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"D3IPmcG3\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1759237905;\n\tbh=J6wdRKX4t1TTjP87zpFBoyEupSFZnyIrjRuRvJtHsyc=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=D3IPmcG3/DXi0WddFTU3cFxTG5p4vKJfb5xZJskAfZfQ/EoMMIxv+x1Pt/fpvuYYR\n\t21pK1s+nS+n2a8tH74Pth7NNlQptE2Rs58WNNA9Gu8Gv6bYKVS9IpK+419+CsJRzDT\n\teX3FN3ymKhQimV+usQHxUmVFY5zAuBiBSVsEkFKE=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ,\n\tUmang Jain ,\n\tPaul Elder ","Subject":"[PATCH v1 19/33] libcamera: converter: Add dw100 converter class","Date":"Tue, 30 Sep 2025 14:26:40 +0200","Message-ID":"<20250930122726.1837524-20-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.48.1","In-Reply-To":"<20250930122726.1837524-1-stefan.klug@ideasonboard.com>","References":"<20250930122726.1837524-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"From: Umang Jain \n\nDW100 Dewarp engine is present on i.MX8MP SoC. This patch\nprovides a dedicated converter class (inherited from V4L2M2MConverter).\n\nThe DW100 dewarp engine has scaling capabilites and can be used\nto set crop rectangles in the rkisp1 pipeline handler. Plumbing\nin the RkISP1 pipeline-handler is done in the subsequent patch.\n\nThe ConverterDW100 class will be extended by upcoming patches to support\nthe dewarping by setting a dewarp vertex map as well.\n\nSigned-off-by: Umang Jain \nReviewed-by: Paul Elder \nSigned-off-by: Stefan Klug \n\n---\n\nChanges in v0.9\n- Use shared_ptr in constructor\n---\n .../internal/converter/converter_dw100.h | 26 +++++++++++\n .../libcamera/internal/converter/meson.build | 1 +\n src/libcamera/converter/converter_dw100.cpp | 43 +++++++++++++++++++\n src/libcamera/converter/meson.build | 1 +\n 4 files changed, 71 insertions(+)\n create mode 100644 include/libcamera/internal/converter/converter_dw100.h\n create mode 100644 src/libcamera/converter/converter_dw100.cpp","diff":"diff --git a/include/libcamera/internal/converter/converter_dw100.h b/include/libcamera/internal/converter/converter_dw100.h\nnew file mode 100644\nindex 000000000000..deb0125a0dbc\n--- /dev/null\n+++ b/include/libcamera/internal/converter/converter_dw100.h\n@@ -0,0 +1,26 @@\n+/* SPDX-License-Identifier: GPL-2.0-or-later */\n+/*\n+ * Copyright (C) 2024, Ideas On Board Oy\n+ *\n+ * i.MX8MP Dewarp Engine integration\n+ */\n+\n+#pragma once\n+\n+#include \"libcamera/internal/converter/converter_v4l2_m2m.h\"\n+\n+namespace libcamera {\n+\n+class MediaDevice;\n+class Rectangle;\n+class Stream;\n+\n+class ConverterDW100 : public V4L2M2MConverter\n+{\n+public:\n+\tConverterDW100(std::shared_ptr media);\n+\n+\tvoid validateSize(Size *size) const;\n+};\n+\n+} /* namespace libcamera */\ndiff --git a/include/libcamera/internal/converter/meson.build b/include/libcamera/internal/converter/meson.build\nindex 891e79e7d493..85007a4b0f8b 100644\n--- a/include/libcamera/internal/converter/meson.build\n+++ b/include/libcamera/internal/converter/meson.build\n@@ -1,5 +1,6 @@\n # SPDX-License-Identifier: CC0-1.0\n \n libcamera_internal_headers += files([\n+ 'converter_dw100.h',\n 'converter_v4l2_m2m.h',\n ])\ndiff --git a/src/libcamera/converter/converter_dw100.cpp b/src/libcamera/converter/converter_dw100.cpp\nnew file mode 100644\nindex 000000000000..da1d88214a6e\n--- /dev/null\n+++ b/src/libcamera/converter/converter_dw100.cpp\n@@ -0,0 +1,43 @@\n+/* SPDX-License-Identifier: GPL-2.0-or-later */\n+/*\n+ * Copyright (C) 2024, Ideas On Board Oy\n+ *\n+ * i.MX8MP Dewarp Engine integration\n+ */\n+\n+#include \"libcamera/internal/converter/converter_dw100.h\"\n+\n+#include \n+\n+#include \n+\n+#include \"libcamera/internal/media_device.h\"\n+#include \"libcamera/internal/v4l2_videodevice.h\"\n+\n+namespace libcamera {\n+\n+LOG_DECLARE_CATEGORY(Converter)\n+\n+/**\n+ * \\class libcamera::ConverterDW100\n+ * \\brief The i.MX8MP dewarp converter implements the converter interface based\n+ * on V4L2 M2M device.\n+*/\n+\n+/**\n+ * \\fn ConverterDW100::ConverterDW100\n+ * \\brief Construct a ConverterDW100 instance\n+ * \\param[in] media The media device implementing the converter\n+ */\n+ConverterDW100::ConverterDW100(std::shared_ptr media)\n+\t: V4L2M2MConverter(media)\n+{\n+}\n+\n+void ConverterDW100::validateSize(Size *size) const\n+{\n+\tif (size)\n+\t\tsize->alignDownTo(8, 8);\n+}\n+\n+} /* namespace libcamera */\ndiff --git a/src/libcamera/converter/meson.build b/src/libcamera/converter/meson.build\nindex af1a80fec683..fe2dcebb67da 100644\n--- a/src/libcamera/converter/meson.build\n+++ b/src/libcamera/converter/meson.build\n@@ -1,5 +1,6 @@\n # SPDX-License-Identifier: CC0-1.0\n \n libcamera_internal_sources += files([\n+ 'converter_dw100.cpp',\n 'converter_v4l2_m2m.cpp'\n ])\n","prefixes":["v1","19/33"]}