[{"id":36058,"web_url":"https://patchwork.libcamera.org/comment/36058/","msgid":"<175923976130.216853.17591025852038957593@ping.linuxembedded.co.uk>","date":"2025-09-30T13:42:41","subject":"Re: [PATCH v1 14/33] libcamera: converter_v4l2_m2m: Add debug\n\tlogging for formats","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Stefan Klug (2025-09-30 13:26:35)\n> Getting the requested input/output format is crucial for debugging. Add\n> log statements for that.\n> \n\nReviewed-by: Kieran Bingham \n\n> Signed-off-by: Stefan Klug \n> ---\n> src/libcamera/converter/converter_v4l2_m2m.cpp | 2 ++\n> 1 file changed, 2 insertions(+)\n> \n> diff --git a/src/libcamera/converter/converter_v4l2_m2m.cpp b/src/libcamera/converter/converter_v4l2_m2m.cpp\n> index 82e6d56e3d5c..43379b31881d 100644\n> --- a/src/libcamera/converter/converter_v4l2_m2m.cpp\n> +++ b/src/libcamera/converter/converter_v4l2_m2m.cpp\n> @@ -111,6 +111,7 @@ int V4L2M2MConverter::V4L2M2MStream::configure(const StreamConfiguration &inputC\n> format.planesCount = 1;\n> format.planes[0].bpl = inputCfg.stride;\n> \n> + LOG(Converter, Debug) << \"Set input format to: \" << format;\n> int ret = m2m_->output()->setFormat(&format);\n> if (ret < 0) {\n> LOG(Converter, Error)\n> @@ -133,6 +134,7 @@ int V4L2M2MConverter::V4L2M2MStream::configure(const StreamConfiguration &inputC\n> format.fourcc = videoFormat;\n> format.size = outputCfg.size;\n> \n> + LOG(Converter, Debug) << \"Set output format to: \" << format;\n> ret = m2m_->capture()->setFormat(&format);\n> if (ret < 0) {\n> LOG(Converter, Error)\n> -- \n> 2.48.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3896FC328C\n\tfor ;\n\tTue, 30 Sep 2025 13:42:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E0D646B5F0;\n\tTue, 30 Sep 2025 15:42:45 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 37F1462C35\n\tfor ;\n\tTue, 30 Sep 2025 15:42:44 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id F106F16A;\n\tTue, 30 Sep 2025 15:41:15 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"lda+DgnJ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1759239676;\n\tbh=PC2h6oNIPwkLeFoT76GATsFab/p8I6vIKj9BbGuSDrY=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=lda+DgnJy+1sEnpqLC+N708h16wkQNeYy/eXUJJqjoPDsEB+D6fp9j1PqbKUHj34O\n\tvc9/7FrOcDyTLcUoDkxs0ZiqPulW8k8I99TsMRuDXVU9qcY2hgL8qKGNExAzk485eB\n\t2IXwXrQ6tbtrpES8F0VMxmxUGK4cn92G6vmr39uQ=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250930122726.1837524-15-stefan.klug@ideasonboard.com>","References":"<20250930122726.1837524-1-stefan.klug@ideasonboard.com>\n\t<20250930122726.1837524-15-stefan.klug@ideasonboard.com>","Subject":"Re: [PATCH v1 14/33] libcamera: converter_v4l2_m2m: Add debug\n\tlogging for formats","From":"Kieran Bingham ","Cc":"Stefan Klug ","To":"Stefan Klug ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 30 Sep 2025 14:42:41 +0100","Message-ID":"<175923976130.216853.17591025852038957593@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]