[{"id":36092,"web_url":"https://patchwork.libcamera.org/comment/36092/","msgid":"<175944286872.3754595.7725838591604613045@ping.linuxembedded.co.uk>","date":"2025-10-02T22:07:48","subject":"Re: [PATCH v1 09/33] libcamera: converter_v4l2_m2m: Always set\n\tstride","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Stefan Klug (2025-09-30 13:26:30)\n> Ensure the stride is properly set after a call to validateOutput().\n> \n\nWell this one seems easy and reasonable ;-)\n\n\nReviewed-by: Kieran Bingham \n\n> Signed-off-by: Stefan Klug \n> ---\n> src/libcamera/converter/converter_v4l2_m2m.cpp | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/src/libcamera/converter/converter_v4l2_m2m.cpp b/src/libcamera/converter/converter_v4l2_m2m.cpp\n> index c6153d728c9a..e57db8a438ab 100644\n> --- a/src/libcamera/converter/converter_v4l2_m2m.cpp\n> +++ b/src/libcamera/converter/converter_v4l2_m2m.cpp\n> @@ -680,6 +680,7 @@ int V4L2M2MConverter::validateOutput(StreamConfiguration *cfg, bool *adjusted,\n> \n> const Size cfgSize = cfg->size;\n> cfg->size = adjustSizes(cfgSize, it->second, align);\n> + cfg->stride = PixelFormatInfo::info(cfg->pixelFormat).stride(cfg->size.width, 0);\n> \n> if (cfg->size.isNull())\n> return -EINVAL;\n> -- \n> 2.48.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1E3C5C324C\n\tfor ;\n\tThu, 2 Oct 2025 22:07:55 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 10E066B5F3;\n\tFri, 3 Oct 2025 00:07:54 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3F2DB6B58E\n\tfor ;\n\tFri, 3 Oct 2025 00:07:52 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EF05F82E;\n\tFri, 3 Oct 2025 00:06:21 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ewA2JaHc\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1759442782;\n\tbh=4kF7HC5AilqqoH18NYg6bznZPVqYfOBgkysFd72kBHU=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=ewA2JaHc9rhZzKtcy7br0vpRu6r39UfHIQNO86ir10ND9nKFLmxBSW1hPz0DpK8jY\n\tA1IhEp+gfuKxFFQGNF3VeSBqqwyWB2F96oxYZkfWMnKscdv58ZzK/UODqz7YnZsbLw\n\t2pgNyEzgWIaWZHUVKtJTwxgmbERI4JoAWg4KDApc=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250930122726.1837524-10-stefan.klug@ideasonboard.com>","References":"<20250930122726.1837524-1-stefan.klug@ideasonboard.com>\n\t<20250930122726.1837524-10-stefan.klug@ideasonboard.com>","Subject":"Re: [PATCH v1 09/33] libcamera: converter_v4l2_m2m: Always set\n\tstride","From":"Kieran Bingham ","Cc":"Stefan Klug ","To":"Stefan Klug ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 02 Oct 2025 23:07:48 +0100","Message-ID":"<175944286872.3754595.7725838591604613045@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]