[{"id":352,"web_url":"https://patchwork.libcamera.org/comment/352/","msgid":"<20190116002108.GB32066@pendragon.ideasonboard.com>","date":"2019-01-16T00:21:08","subject":"Re: [libcamera-devel] [PATCH v3 1/3] include: linux: Import\n\tvideodev2.h from Linux v4.19","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Tue, Jan 15, 2019 at 11:19:07PM +0000, Kieran Bingham wrote:\n> Import the linux/videodev2.h from the installed linux kernel headers.\n> \n> Signed-off-by: Kieran Bingham \n> ---\n> include/linux/videodev2.h | 2412 +++++++++++++++++++++++++++++++++++++\n> 1 file changed, 2412 insertions(+)\n> create mode 100644 include/linux/videodev2.h\n> \n> diff --git a/include/linux/videodev2.h b/include/linux/videodev2.h\n> new file mode 100644\n> index 000000000000..1a95662f5ad0\n> --- /dev/null\n> +++ b/include/linux/videodev2.h\n> @@ -0,0 +1,2412 @@\n> +/* SPDX-License-Identifier: ((GPL-2.0+ WITH Linux-syscall-note) OR BSD-3-Clause) */\n> +/*\n> + * Video for Linux Two header file\n> + *\n> + * Copyright (C) 1999-2012 the contributors\n> + *\n> + * This program is free software; you can redistribute it and/or modify\n> + * it under the terms of the GNU General Public License as published by\n> + * the Free Software Foundation; either version 2 of the License, or\n> + * (at your option) any later version.\n> + *\n> + * This program is distributed in the hope that it will be useful,\n> + * but WITHOUT ANY WARRANTY; without even the implied warranty of\n> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the\n> + * GNU General Public License for more details.\n> + *\n> + * Alternatively you can redistribute this file under the terms of the\n> + * BSD license as stated below:\n> + *\n> + * Redistribution and use in source and binary forms, with or without\n> + * modification, are permitted provided that the following conditions\n> + * are met:\n> + * 1. Redistributions of source code must retain the above copyright\n> + * notice, this list of conditions and the following disclaimer.\n> + * 2. Redistributions in binary form must reproduce the above copyright\n> + * notice, this list of conditions and the following disclaimer in\n> + * the documentation and/or other materials provided with the\n> + * distribution.\n> + * 3. The names of its contributors may not be used to endorse or promote\n> + * products derived from this software without specific prior written\n> + * permission.\n> + *\n> + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS\n> + * \"AS IS\" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT\n> + * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR\n> + * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT\n> + * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,\n> + * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED\n> + * TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR\n> + * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF\n> + * LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING\n> + * NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS\n> + * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.\n> + *\n> + *\tHeader file for v4l or V4L2 drivers and applications\n> + * with public API.\n> + * All kernel-specific stuff were moved to media/v4l2-dev.h, so\n> + * no #if __KERNEL tests are allowed here\n> + *\n> + *\tSee https://linuxtv.org for more info\n> + *\n> + *\tAuthor: Bill Dirks \n> + *\t\tJustin Schoeman\n> + * Hans Verkuil \n> + *\t\tet al.\n> + */\n> +#ifndef __LINUX_VIDEODEV2_H\n> +#define __LINUX_VIDEODEV2_H\n> +\n> +#include \n> +\n> +#include \n> +#include \n> +#include \n> +#include \n\nI would recommend importing v4l2-common.h and v4l2-controls.h as well to\nmake sure the V4L2 API stays consistent.\n\nWith this fixed,\n\nReviewed-by: Laurent Pinchart \n\n[snip]","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CFEC160C6A\n\tfor ;\n\tWed, 16 Jan 2019 01:21:08 +0100 (CET)","from pendragon.ideasonboard.com\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3EBC44F8;\n\tWed, 16 Jan 2019 01:21:08 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1547598068;\n\tbh=zywVpxot9pab+g6WOz5A0LUdA1Ult29Zi1mbHA/96G4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=prz3/0/Nh6ZqayF0/0YZv0hL4TKBZHn/UQFpDdRV0NiaQDHZ6a73Adawjc7f6+iso\n\tZkRZCYtPbCvfXHF01eQbOGNFKQmoekCcu/x5OBf+TRSmNz7Rv/EotViuq8ss9z+Ihm\n\t54Acgtsa7VqryBGqfUMhtHtpQ0CLleaSZkcTeGmI=","Date":"Wed, 16 Jan 2019 02:21:08 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"LibCamera Devel ","Message-ID":"<20190116002108.GB32066@pendragon.ideasonboard.com>","References":"<20190115231909.19893-1-kieran.bingham@ideasonboard.com>\n\t<20190115231909.19893-2-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20190115231909.19893-2-kieran.bingham@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v3 1/3] include: linux: Import\n\tvideodev2.h from Linux v4.19","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 16 Jan 2019 00:21:09 -0000"}},{"id":355,"web_url":"https://patchwork.libcamera.org/comment/355/","msgid":"<6e91104b-9b89-b215-b834-87e35a133f2c@ideasonboard.com>","date":"2019-01-16T10:24:17","subject":"Re: [libcamera-devel] [PATCH v3 1/3] include: linux: Import\n\tvideodev2.h from Linux v4.19","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 16/01/2019 00:21, Laurent Pinchart wrote:\n> Hi Kieran,\n> \n> Thank you for the patch.\n> \n> On Tue, Jan 15, 2019 at 11:19:07PM +0000, Kieran Bingham wrote:\n>> Import the linux/videodev2.h from the installed linux kernel headers.\n>>\n>> Signed-off-by: Kieran Bingham \n>> ---\n>> include/linux/videodev2.h | 2412 +++++++++++++++++++++++++++++++++++++\n>> 1 file changed, 2412 insertions(+)\n>> create mode 100644 include/linux/videodev2.h\n>>\n>> diff --git a/include/linux/videodev2.h b/include/linux/videodev2.h\n>> new file mode 100644\n>> index 000000000000..1a95662f5ad0\n>> --- /dev/null\n>> +++ b/include/linux/videodev2.h\n>> @@ -0,0 +1,2412 @@\n>> +/* SPDX-License-Identifier: ((GPL-2.0+ WITH Linux-syscall-note) OR BSD-3-Clause) */\n>> +/*\n>> + * Video for Linux Two header file\n>> + *\n>> + * Copyright (C) 1999-2012 the contributors\n>> + *\n>> + * This program is free software; you can redistribute it and/or modify\n>> + * it under the terms of the GNU General Public License as published by\n>> + * the Free Software Foundation; either version 2 of the License, or\n>> + * (at your option) any later version.\n>> + *\n>> + * This program is distributed in the hope that it will be useful,\n>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of\n>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the\n>> + * GNU General Public License for more details.\n>> + *\n>> + * Alternatively you can redistribute this file under the terms of the\n>> + * BSD license as stated below:\n>> + *\n>> + * Redistribution and use in source and binary forms, with or without\n>> + * modification, are permitted provided that the following conditions\n>> + * are met:\n>> + * 1. Redistributions of source code must retain the above copyright\n>> + * notice, this list of conditions and the following disclaimer.\n>> + * 2. Redistributions in binary form must reproduce the above copyright\n>> + * notice, this list of conditions and the following disclaimer in\n>> + * the documentation and/or other materials provided with the\n>> + * distribution.\n>> + * 3. The names of its contributors may not be used to endorse or promote\n>> + * products derived from this software without specific prior written\n>> + * permission.\n>> + *\n>> + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS\n>> + * \"AS IS\" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT\n>> + * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR\n>> + * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT\n>> + * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,\n>> + * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED\n>> + * TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR\n>> + * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF\n>> + * LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING\n>> + * NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS\n>> + * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.\n>> + *\n>> + *\tHeader file for v4l or V4L2 drivers and applications\n>> + * with public API.\n>> + * All kernel-specific stuff were moved to media/v4l2-dev.h, so\n>> + * no #if __KERNEL tests are allowed here\n>> + *\n>> + *\tSee https://linuxtv.org for more info\n>> + *\n>> + *\tAuthor: Bill Dirks \n>> + *\t\tJustin Schoeman\n>> + * Hans Verkuil \n>> + *\t\tet al.\n>> + */\n>> +#ifndef __LINUX_VIDEODEV2_H\n>> +#define __LINUX_VIDEODEV2_H\n>> +\n>> +#include \n>> +\n>> +#include \n>> +#include \n>> +#include \n>> +#include \n> \n> I would recommend importing v4l2-common.h and v4l2-controls.h as well to\n> make sure the V4L2 API stays consistent.\n\nI still really dislike keeping kernel headers in the project - but if\nit's the best route - how about we keep a set of all the V4L2 headers ?\n\nWe already have media.h, (and now videodev2.h)\nPerhaps we should in one hit import :\n\n v4l2-common.h v4l2-controls.h v4l2-dv-timings.h\n v4l2-mediabus.h v4l2-subdev.h media-bus-format.h\n\nas well ?\n\nIf we have to keep a copy of the V4L2(well linux-media) API definitions\n- I'd rather have a full complete version synchronised set, which is\nupdated together whenever it gets updated.\n\nAny immediate objections?\n\n--\nKieran\n\n\n\n> With this fixed,\n> \n> Reviewed-by: Laurent Pinchart \n> \n> [snip]\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C690260C97\n\tfor ;\n\tWed, 16 Jan 2019 11:24:21 +0100 (CET)","from [192.168.0.21]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 21F234F8;\n\tWed, 16 Jan 2019 11:24:21 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1547634261;\n\tbh=RpmMnP9U/BUWMGu902Ud1+ZBNP3s2X6fyIYOI8N0WpY=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=R5y68Ksv8qHa77X3e654drR4x7nKSh4zeMhj17XB+JMR9AsDePlJCpCmwM23bEoFz\n\tZZqceH6O7cAkUvdnx8O4hyY+uz2R7n897Tdswc0+i3Qclh/xZGYfGMjPVLrE1pki1k\n\tkX9hKh6OARWS7N++nNUMEPc5OCttFc+e+Ez0w3dY=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Laurent Pinchart ","Cc":"LibCamera Devel ","References":"<20190115231909.19893-1-kieran.bingham@ideasonboard.com>\n\t<20190115231909.19893-2-kieran.bingham@ideasonboard.com>\n\t<20190116002108.GB32066@pendragon.ideasonboard.com>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAkAEEwEKACoCGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEFAlnDk/gFCQeA/YsACgkQoR5GchCkYf3X5w/9EaZ7\n\tcnUcT6dxjxrcmmMnfFPoQA1iQXr/MXQJBjFWfxRUWYzjvUJb2D/FpA8FY7y+vksoJP7pWDL7\n\tQTbksdwzagUEk7CU45iLWL/CZ/knYhj1I/+5LSLFmvZ/5Gf5xn2ZCsmg7C0MdW/GbJ8IjWA8\n\t/LKJSEYH8tefoiG6+9xSNp1p0Gesu3vhje/GdGX4wDsfAxx1rIYDYVoX4bDM+uBUQh7sQox/\n\tR1bS0AaVJzPNcjeC14MS226mQRUaUPc9250aj44WmDfcg44/kMsoLFEmQo2II9aOlxUDJ+x1\n\txohGbh9mgBoVawMO3RMBihcEjo/8ytW6v7xSF+xP4Oc+HOn7qebAkxhSWcRxQVaQYw3S9iZz\n\t2iA09AXAkbvPKuMSXi4uau5daXStfBnmOfalG0j+9Y6hOFjz5j0XzaoF6Pln0jisDtWltYhP\n\tX9LjFVhhLkTzPZB/xOeWGmsG4gv2V2ExbU3uAmb7t1VSD9+IO3Km4FtnYOKBWlxwEd8qOFpS\n\tjEqMXURKOiJvnw3OXe9MqG19XdeENA1KyhK5rqjpwdvPGfSn2V+SlsdJA0DFsobUScD9qXQw\n\tOvhapHe3XboK2+Rd7L+g/9Ud7ZKLQHAsMBXOVJbufA1AT+IaOt0ugMcFkAR5UbBg5+dZUYJj\n\t1QbPQcGmM3wfvuaWV5+SlJ+WeKIb8ta5Ag0EVgT9ZgEQAM4o5G/kmruIQJ3K9SYzmPishRHV\n\tDcUcvoakyXSX2mIoccmo9BHtD9MxIt+QmxOpYFNFM7YofX4lG0ld8H7FqoNVLd/+a0yru5Cx\n\tadeZBe3qr1eLns10Q90LuMo7/6zJhCW2w+HE7xgmCHejAwuNe3+7yt4QmwlSGUqdxl8cgtS1\n\tPlEK93xXDsgsJj/bw1EfSVdAUqhx8UQ3aVFxNug5OpoX9FdWJLKROUrfNeBE16RLrNrq2ROc\n\tiSFETpVjyC/oZtzRFnwD9Or7EFMi76/xrWzk+/b15RJ9WrpXGMrttHUUcYZEOoiC2lEXMSAF\n\tSSSj4vHbKDJ0vKQdEFtdgB1roqzxdIOg4rlHz5qwOTynueiBpaZI3PHDudZSMR5Fk6QjFooE\n\tXTw3sSl/km/lvUFiv9CYyHOLdygWohvDuMkV/Jpdkfq8XwFSjOle+vT/4VqERnYFDIGBxaRx\n\tkoBLfNDiiuR3lD8tnJ4A1F88K6ojOUs+jndKsOaQpDZV6iNFv8IaNIklTPvPkZsmNDhJMRHH\n\tIu60S7BpzNeQeT4yyY4dX9lC2JL/LOEpw8DGf5BNOP1KgjCvyp1/KcFxDAo89IeqljaRsCdP\n\t7WCIECWYem6pLwaw6IAL7oX+tEqIMPph/G/jwZcdS6Hkyt/esHPuHNwX4guqTbVEuRqbDzDI\n\t2DJO5FbxABEBAAGJAiUEGAEKAA8CGwwFAlnDlGsFCQeA/gIACgkQoR5GchCkYf1yYRAAq+Yo\n\tnbf9DGdK1kTAm2RTFg+w9oOp2Xjqfhds2PAhFFvrHQg1XfQR/UF/SjeUmaOmLSczM0s6XMeO\n\tVcE77UFtJ/+hLo4PRFKm5X1Pcar6g5m4xGqa+Xfzi9tRkwC29KMCoQOag1BhHChgqYaUH3yo\n\tUzaPwT/fY75iVI+yD0ih/e6j8qYvP8pvGwMQfrmN9YB0zB39YzCSdaUaNrWGD3iCBxg6lwSO\n\tLKeRhxxfiXCIYEf3vwOsP3YMx2JkD5doseXmWBGW1U0T/oJF+DVfKB6mv5UfsTzpVhJRgee7\n\t4jkjqFq4qsUGxcvF2xtRkfHFpZDbRgRlVmiWkqDkT4qMA+4q1y/dWwshSKi/uwVZNycuLsz+\n\t+OD8xPNCsMTqeUkAKfbD8xW4LCay3r/dD2ckoxRxtMD9eOAyu5wYzo/ydIPTh1QEj9SYyvp8\n\tO0g6CpxEwyHUQtF5oh15O018z3ZLztFJKR3RD42VKVsrnNDKnoY0f4U0z7eJv2NeF8xHMuiU\n\tRCIzqxX1GVYaNkKTnb/Qja8hnYnkUzY1Lc+OtwiGmXTwYsPZjjAaDX35J/RSKAoy5wGo/YFA\n\tJxB1gWThL4kOTbsqqXj9GLcyOImkW0lJGGR3o/fV91Zh63S5TKnf2YGGGzxki+ADdxVQAm+Q\n\tsbsRB8KNNvVXBOVNwko86rQqF9drZuw=","Organization":"Ideas on Board","Message-ID":"<6e91104b-9b89-b215-b834-87e35a133f2c@ideasonboard.com>","Date":"Wed, 16 Jan 2019 10:24:17 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.2.1","MIME-Version":"1.0","In-Reply-To":"<20190116002108.GB32066@pendragon.ideasonboard.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH v3 1/3] include: linux: Import\n\tvideodev2.h from Linux v4.19","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 16 Jan 2019 10:24:22 -0000"}},{"id":362,"web_url":"https://patchwork.libcamera.org/comment/362/","msgid":"<20190116142538.GA6484@bigcity.dyn.berto.se>","date":"2019-01-16T14:25:38","subject":"Re: [libcamera-devel] [PATCH v3 1/3] include: linux: Import\n\tvideodev2.h from Linux v4.19","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Kieran,\n\nThanks for your work.\n\nOn 2019-01-16 10:24:17 +0000, Kieran Bingham wrote:\n> Hi Laurent,\n> \n> On 16/01/2019 00:21, Laurent Pinchart wrote:\n> > Hi Kieran,\n> > \n> > Thank you for the patch.\n> > \n> > On Tue, Jan 15, 2019 at 11:19:07PM +0000, Kieran Bingham wrote:\n> >> Import the linux/videodev2.h from the installed linux kernel headers.\n> >>\n> >> Signed-off-by: Kieran Bingham \n> >> ---\n> >> include/linux/videodev2.h | 2412 +++++++++++++++++++++++++++++++++++++\n> >> 1 file changed, 2412 insertions(+)\n> >> create mode 100644 include/linux/videodev2.h\n> >>\n> >> diff --git a/include/linux/videodev2.h b/include/linux/videodev2.h\n> >> new file mode 100644\n> >> index 000000000000..1a95662f5ad0\n> >> --- /dev/null\n> >> +++ b/include/linux/videodev2.h\n> >> @@ -0,0 +1,2412 @@\n> >> +/* SPDX-License-Identifier: ((GPL-2.0+ WITH Linux-syscall-note) OR BSD-3-Clause) */\n> >> +/*\n> >> + * Video for Linux Two header file\n> >> + *\n> >> + * Copyright (C) 1999-2012 the contributors\n> >> + *\n> >> + * This program is free software; you can redistribute it and/or modify\n> >> + * it under the terms of the GNU General Public License as published by\n> >> + * the Free Software Foundation; either version 2 of the License, or\n> >> + * (at your option) any later version.\n> >> + *\n> >> + * This program is distributed in the hope that it will be useful,\n> >> + * but WITHOUT ANY WARRANTY; without even the implied warranty of\n> >> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the\n> >> + * GNU General Public License for more details.\n> >> + *\n> >> + * Alternatively you can redistribute this file under the terms of the\n> >> + * BSD license as stated below:\n> >> + *\n> >> + * Redistribution and use in source and binary forms, with or without\n> >> + * modification, are permitted provided that the following conditions\n> >> + * are met:\n> >> + * 1. Redistributions of source code must retain the above copyright\n> >> + * notice, this list of conditions and the following disclaimer.\n> >> + * 2. Redistributions in binary form must reproduce the above copyright\n> >> + * notice, this list of conditions and the following disclaimer in\n> >> + * the documentation and/or other materials provided with the\n> >> + * distribution.\n> >> + * 3. The names of its contributors may not be used to endorse or promote\n> >> + * products derived from this software without specific prior written\n> >> + * permission.\n> >> + *\n> >> + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS\n> >> + * \"AS IS\" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT\n> >> + * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR\n> >> + * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT\n> >> + * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,\n> >> + * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED\n> >> + * TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR\n> >> + * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF\n> >> + * LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING\n> >> + * NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS\n> >> + * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.\n> >> + *\n> >> + *\tHeader file for v4l or V4L2 drivers and applications\n> >> + * with public API.\n> >> + * All kernel-specific stuff were moved to media/v4l2-dev.h, so\n> >> + * no #if __KERNEL tests are allowed here\n> >> + *\n> >> + *\tSee https://linuxtv.org for more info\n> >> + *\n> >> + *\tAuthor: Bill Dirks \n> >> + *\t\tJustin Schoeman\n> >> + * Hans Verkuil \n> >> + *\t\tet al.\n> >> + */\n> >> +#ifndef __LINUX_VIDEODEV2_H\n> >> +#define __LINUX_VIDEODEV2_H\n> >> +\n> >> +#include \n> >> +\n> >> +#include \n> >> +#include \n> >> +#include \n> >> +#include \n> > \n> > I would recommend importing v4l2-common.h and v4l2-controls.h as well to\n> > make sure the V4L2 API stays consistent.\n> \n> I still really dislike keeping kernel headers in the project - but if\n> it's the best route - how about we keep a set of all the V4L2 headers ?\n> \n> We already have media.h, (and now videodev2.h)\n> Perhaps we should in one hit import :\n> \n> v4l2-common.h v4l2-controls.h v4l2-dv-timings.h\n> v4l2-mediabus.h v4l2-subdev.h media-bus-format.h\n> \n> as well ?\n> \n> If we have to keep a copy of the V4L2(well linux-media) API definitions\n> - I'd rather have a full complete version synchronised set, which is\n> updated together whenever it gets updated.\n> \n> Any immediate objections?\n\nMy personal view is that we should add headers as we need them but I \nhave no objection to adding all of them if that is the consensus.\n\nWith or without additional headers,\n\nReviewed-by: Niklas Söderlund \n\n> \n> --\n> Kieran\n> \n> \n> \n> > With this fixed,\n> > \n> > Reviewed-by: Laurent Pinchart \n> > \n> > [snip]\n> > \n> \n> -- \n> Regards\n> --\n> Kieran\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lf1-x143.google.com (mail-lf1-x143.google.com\n\t[IPv6:2a00:1450:4864:20::143])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7A1D760B2D\n\tfor ;\n\tWed, 16 Jan 2019 15:25:40 +0100 (CET)","by mail-lf1-x143.google.com with SMTP id b20so5006019lfa.12\n\tfor ;\n\tWed, 16 Jan 2019 06:25:40 -0800 (PST)","from localhost (89-233-230-99.cust.bredband2.com. [89.233.230.99])\n\tby smtp.gmail.com with ESMTPSA id\n\th3sm1214980lfb.49.2019.01.16.06.25.38\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tWed, 16 Jan 2019 06:25:38 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=lAeKikqzkamK1CDJjTlFOiVgnOd2+FU2f+MdiU+OKVw=;\n\tb=etzQowtTjdpsCbevOFuoxPHbYUYJKbALJSgYBqouf1brs4brBrDgCu9M+VQW+Ze6an\n\t9rltF73uBM/GfDeBgGJ2nndRwwznFqedE8LWP1x2HZHJIPn9upecgt1Zwnqm1jkl3MbV\n\tjNQUbs6kjmoYHpOprHk9Fu7G9uIY2pjc0XDVfxHOZFPuq/XZ/J2z6jI3q2jJQDPU66Gk\n\tWydSUB33hA56rp6xzmqTEITh1ZO99Wfo8TcPOmMWt8IfHke4eXkFBaEpe5qHyuNoirq5\n\tVieehr/ClgMC3z1fawg5TBbZ+bVYE1mbIBjCNFrZLXunOPuxloudXzo3UhzgYX4Or66g\n\tuEaQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=lAeKikqzkamK1CDJjTlFOiVgnOd2+FU2f+MdiU+OKVw=;\n\tb=hMW9DDH7gggxpRWmBtK9rDPW4xWwXLrFO/N2GyVvRUZuB1Cywh17DCELs1fJz+ZSlb\n\t5yTUpIVCrXe/IohZrVuYdi6ewjQkqI0bOoxt0LKnICZczaXKGjFsBQzgvBwuU5SuBBRo\n\toaZm+x4sE4CC10SQD+ZFgmWo+tSOyymAsZSuUUNjIIDHd0Fl6gQV62bOP7yBd+xTFlPH\n\txKIh4nJZ/obWr5Lmtodl8QdPJwr+fXsQZobNSwSetWWedcB2O2LyZXllgtqzYtUvfVZ6\n\tk/+vbG0HBK3LjGcDmnN6HyMQqDt4GjBn3T3GsMs3/FgTVyow1T2rlz2rWnAprpjzvpM/\n\t9reA==","X-Gm-Message-State":"AJcUukd05Ex4xbncpOWhmW9myzIz+3PZMcKhhRf1ivp/QEd0KiCGhOWk\n\tVBH6eSgDiFAWDAKeIitSHViZcNm9Hh8=","X-Google-Smtp-Source":"ALg8bN4lYQYCVQJAqyr9nLeLrHaLbmSEURIqImS3pstt4FpJX0f09Px6y31Dm245ttSoD4TYcALc6g==","X-Received":"by 2002:a19:7d42:: with SMTP id y63mr1121829lfc.47.1547648739669;\n\tWed, 16 Jan 2019 06:25:39 -0800 (PST)","Date":"Wed, 16 Jan 2019 15:25:38 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Kieran Bingham ","Cc":"Laurent Pinchart ,\n\tLibCamera Devel ","Message-ID":"<20190116142538.GA6484@bigcity.dyn.berto.se>","References":"<20190115231909.19893-1-kieran.bingham@ideasonboard.com>\n\t<20190115231909.19893-2-kieran.bingham@ideasonboard.com>\n\t<20190116002108.GB32066@pendragon.ideasonboard.com>\n\t<6e91104b-9b89-b215-b834-87e35a133f2c@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<6e91104b-9b89-b215-b834-87e35a133f2c@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v3 1/3] include: linux: Import\n\tvideodev2.h from Linux v4.19","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 16 Jan 2019 14:25:40 -0000"}},{"id":370,"web_url":"https://patchwork.libcamera.org/comment/370/","msgid":"<20190116152005.GA20097@pendragon.ideasonboard.com>","date":"2019-01-16T15:20:05","subject":"Re: [libcamera-devel] [PATCH v3 1/3] include: linux: Import\n\tvideodev2.h from Linux v4.19","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hello,\n\nOn Wed, Jan 16, 2019 at 03:25:38PM +0100, Niklas Söderlund wrote:\n> On 2019-01-16 10:24:17 +0000, Kieran Bingham wrote:\n> > On 16/01/2019 00:21, Laurent Pinchart wrote:\n> > > On Tue, Jan 15, 2019 at 11:19:07PM +0000, Kieran Bingham wrote:\n> > >> Import the linux/videodev2.h from the installed linux kernel headers.\n> > >>\n> > >> Signed-off-by: Kieran Bingham \n> > >> ---\n> > >> include/linux/videodev2.h | 2412 +++++++++++++++++++++++++++++++++++++\n> > >> 1 file changed, 2412 insertions(+)\n> > >> create mode 100644 include/linux/videodev2.h\n> > >>\n> > >> diff --git a/include/linux/videodev2.h b/include/linux/videodev2.h\n> > >> new file mode 100644\n> > >> index 000000000000..1a95662f5ad0\n> > >> --- /dev/null\n> > >> +++ b/include/linux/videodev2.h\n> > >> @@ -0,0 +1,2412 @@\n> > >> +/* SPDX-License-Identifier: ((GPL-2.0+ WITH Linux-syscall-note) OR BSD-3-Clause) */\n> > >> +/*\n> > >> + * Video for Linux Two header file\n> > >> + *\n> > >> + * Copyright (C) 1999-2012 the contributors\n> > >> + *\n> > >> + * This program is free software; you can redistribute it and/or modify\n> > >> + * it under the terms of the GNU General Public License as published by\n> > >> + * the Free Software Foundation; either version 2 of the License, or\n> > >> + * (at your option) any later version.\n> > >> + *\n> > >> + * This program is distributed in the hope that it will be useful,\n> > >> + * but WITHOUT ANY WARRANTY; without even the implied warranty of\n> > >> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the\n> > >> + * GNU General Public License for more details.\n> > >> + *\n> > >> + * Alternatively you can redistribute this file under the terms of the\n> > >> + * BSD license as stated below:\n> > >> + *\n> > >> + * Redistribution and use in source and binary forms, with or without\n> > >> + * modification, are permitted provided that the following conditions\n> > >> + * are met:\n> > >> + * 1. Redistributions of source code must retain the above copyright\n> > >> + * notice, this list of conditions and the following disclaimer.\n> > >> + * 2. Redistributions in binary form must reproduce the above copyright\n> > >> + * notice, this list of conditions and the following disclaimer in\n> > >> + * the documentation and/or other materials provided with the\n> > >> + * distribution.\n> > >> + * 3. The names of its contributors may not be used to endorse or promote\n> > >> + * products derived from this software without specific prior written\n> > >> + * permission.\n> > >> + *\n> > >> + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS\n> > >> + * \"AS IS\" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT\n> > >> + * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR\n> > >> + * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT\n> > >> + * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,\n> > >> + * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED\n> > >> + * TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR\n> > >> + * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF\n> > >> + * LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING\n> > >> + * NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS\n> > >> + * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.\n> > >> + *\n> > >> + *\tHeader file for v4l or V4L2 drivers and applications\n> > >> + * with public API.\n> > >> + * All kernel-specific stuff were moved to media/v4l2-dev.h, so\n> > >> + * no #if __KERNEL tests are allowed here\n> > >> + *\n> > >> + *\tSee https://linuxtv.org for more info\n> > >> + *\n> > >> + *\tAuthor: Bill Dirks \n> > >> + *\t\tJustin Schoeman\n> > >> + * Hans Verkuil \n> > >> + *\t\tet al.\n> > >> + */\n> > >> +#ifndef __LINUX_VIDEODEV2_H\n> > >> +#define __LINUX_VIDEODEV2_H\n> > >> +\n> > >> +#include \n> > >> +\n> > >> +#include \n> > >> +#include \n> > >> +#include \n> > >> +#include \n> > > \n> > > I would recommend importing v4l2-common.h and v4l2-controls.h as well to\n> > > make sure the V4L2 API stays consistent.\n> > \n> > I still really dislike keeping kernel headers in the project - but if\n> > it's the best route - how about we keep a set of all the V4L2 headers ?\n> > \n> > We already have media.h, (and now videodev2.h)\n> > Perhaps we should in one hit import :\n> > \n> > v4l2-common.h v4l2-controls.h v4l2-dv-timings.h\n> > v4l2-mediabus.h v4l2-subdev.h media-bus-format.h\n> > \n> > as well ?\n> > \n> > If we have to keep a copy of the V4L2(well linux-media) API definitions\n> > - I'd rather have a full complete version synchronised set, which is\n> > updated together whenever it gets updated.\n> > \n> > Any immediate objections?\n> \n> My personal view is that we should add headers as we need them but I \n> have no objection to adding all of them if that is the consensus.\n\nThat's my opinion too, but I won't object against adding headers we\ndon't use now but know we will use in the future. I would leave\nv4l2-dv-timings.h out as I don't think we'll need it, the other ones can\nbe added.\n\n> With or without additional headers,\n> \n> Reviewed-by: Niklas Söderlund \n> \n> > > With this fixed,\n> > > \n> > > Reviewed-by: Laurent Pinchart \n> > > \n> > > [snip]","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 98AD860C99\n\tfor ;\n\tWed, 16 Jan 2019 16:20:05 +0100 (CET)","from pendragon.ideasonboard.com\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0977A4F8;\n\tWed, 16 Jan 2019 16:20:04 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1547652005;\n\tbh=MU0PIpw+PLDaFyfTmjN5fdLT+iCBEVdoKsdB3gStPOc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=URNKWTZXU655DnxXmZ7ZmJEURWTXkNTYuoym6MZeEAe4uLRy7yiDLdPZGs8LUZVt1\n\tu+pL0bW6m6yAoasdLwddqElNOqZk77XgEsi5jXMH6FQc3+0I+UWxr3DAnHd1PMtuId\n\tOyy7tIUuZ6vtapnPRCTXpOhnSsyAJ8urJTqANYNw=","Date":"Wed, 16 Jan 2019 17:20:05 +0200","From":"Laurent Pinchart ","To":"Niklas =?iso-8859-1?q?S=F6derlund?= ","Cc":"Kieran Bingham ,\n\tLibCamera Devel ","Message-ID":"<20190116152005.GA20097@pendragon.ideasonboard.com>","References":"<20190115231909.19893-1-kieran.bingham@ideasonboard.com>\n\t<20190115231909.19893-2-kieran.bingham@ideasonboard.com>\n\t<20190116002108.GB32066@pendragon.ideasonboard.com>\n\t<6e91104b-9b89-b215-b834-87e35a133f2c@ideasonboard.com>\n\t<20190116142538.GA6484@bigcity.dyn.berto.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190116142538.GA6484@bigcity.dyn.berto.se>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH v3 1/3] include: linux: Import\n\tvideodev2.h from Linux v4.19","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 16 Jan 2019 15:20:06 -0000"}}]