{"id":24495,"url":"https://patchwork.libcamera.org/api/patches/24495/?format=json","web_url":"https://patchwork.libcamera.org/patch/24495/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250929201924.45019-8-mzamazal@redhat.com>","date":"2025-09-29T20:19:24","name":"[v5,7/7] ipa: simple: agc: Prevent division by zero in AGC","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"a9f874f09af504b37b52144ceb0635a4135d210e","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/?format=json","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24495/mbox/","series":[{"id":5466,"url":"https://patchwork.libcamera.org/api/series/5466/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5466","date":"2025-09-29T20:19:17","name":"Fix stats related problems in software ISP","version":5,"mbox":"https://patchwork.libcamera.org/series/5466/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24495/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24495/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CC6C4C3310\n\tfor ;\n\tMon, 29 Sep 2025 20:20:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 590AB6B64D;\n\tMon, 29 Sep 2025 22:20:03 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 13EAC6B635\n\tfor ;\n\tMon, 29 Sep 2025 22:19:58 +0200 (CEST)","from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-677-R-oZv3UIMTWgFcl-TZ2PHg-1;\n\tMon, 29 Sep 2025 16:19:53 -0400","from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.12])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id CE351195609F; Mon, 29 Sep 2025 20:19:52 +0000 (UTC)","from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.44.32.35])\n\tby mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 5840619560B4; Mon, 29 Sep 2025 20:19:50 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"CX1u28um\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1759177198;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=7GCryMsl+ajnaVE7aS9jBR1GNxGzNJGPxB5HObD4bZU=;\n\tb=CX1u28umM6phZvIm8Iy6UJYKEwsK4qh1bOIXk4SL1Ct20ZHYxLoxCkhWJHmy7B03Fi1eU4\n\tbraDOJiORTsrY1lu0wnLu5rqAHzleJ5/M559JdDftbo1RxC8PLIbb2wfAoaHn8M+JYo6GD\n\tBWdWbq9HeqNbWGembx+ylnd0V4QnZ3A=","X-MC-Unique":"R-oZv3UIMTWgFcl-TZ2PHg-1","X-Mimecast-MFC-AGG-ID":"R-oZv3UIMTWgFcl-TZ2PHg_1759177192","From":"Milan Zamazal ","To":"libcamera-devel@lists.libcamera.org","Cc":"Milan Zamazal , pobrn@protonmail.com,\n\tmail@maciej.szmigiero.name, hansg@kernel.org, =?utf-8?b?QmFybmFiw6Fz?=\n\t=?utf-8?q?_P=C5=91cze?= ","Subject":"[PATCH v5 7/7] ipa: simple: agc: Prevent division by zero in AGC","Date":"Mon, 29 Sep 2025 22:19:24 +0200","Message-ID":"<20250929201924.45019-8-mzamazal@redhat.com>","In-Reply-To":"<20250929201924.45019-1-mzamazal@redhat.com>","References":"<20250929201924.45019-1-mzamazal@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.12","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"LHzvv3WzwAjGpzfm32sVCksRrsSwDR2ULa1APEGtT8s_1759177192","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"If the histogram size is non-zero but lower than the number of bins,\nyHistValsPerBin is zero and then the AGC processing crashes on division\nby it. Let's check yHistValsPerBin for being zero and stop AGC\nprocessing in such a case. The condition also covers the cases where\nhistogramSize or yHistValsPerBinMod are zero.\n\nTested-by: Barnabás Pőcze \nReviewed-by: Hans de Goede \nSigned-off-by: Milan Zamazal \n---\n src/ipa/simple/algorithms/agc.cpp | 6 ++++++\n 1 file changed, 6 insertions(+)","diff":"diff --git a/src/ipa/simple/algorithms/agc.cpp b/src/ipa/simple/algorithms/agc.cpp\nindex c46bb0ebe..e47949ec4 100644\n--- a/src/ipa/simple/algorithms/agc.cpp\n+++ b/src/ipa/simple/algorithms/agc.cpp\n@@ -124,6 +124,12 @@ void Agc::process(IPAContext &context,\n \tunsigned int denom = 0;\n \tunsigned int num = 0;\n \n+\tif (yHistValsPerBin == 0) {\n+\t\tLOG(IPASoftExposure, Debug)\n+\t\t\t<< \"Not adjusting exposure due to insufficient histogram data\";\n+\t\treturn;\n+\t}\n+\n \tfor (unsigned int i = 0; i < histogramSize; i++) {\n \t\tunsigned int idx = (i - (i / yHistValsPerBinMod)) / yHistValsPerBin;\n \t\texposureBins[idx] += histogram[blackLevelHistIdx + i];\n","prefixes":["v5","7/7"]}