{"id":24491,"url":"https://patchwork.libcamera.org/api/patches/24491/?format=json","web_url":"https://patchwork.libcamera.org/patch/24491/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250929201924.45019-4-mzamazal@redhat.com>","date":"2025-09-29T20:19:20","name":"[v5,3/7] libcamera: software_isp: Pass correct y-coordinate to stats","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"e3bbea644f5e64a5d6286f41ea218b96ec9aecc3","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/?format=json","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24491/mbox/","series":[{"id":5466,"url":"https://patchwork.libcamera.org/api/series/5466/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5466","date":"2025-09-29T20:19:17","name":"Fix stats related problems in software ISP","version":5,"mbox":"https://patchwork.libcamera.org/series/5466/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24491/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24491/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9591DC324C\n\tfor ;\n\tMon, 29 Sep 2025 20:19:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4602D6B626;\n\tMon, 29 Sep 2025 22:19:52 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BA5F26B60F\n\tfor ;\n\tMon, 29 Sep 2025 22:19:46 +0200 (CEST)","from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-676-i4pJqKgxNQ2UYJ08fmtccQ-1;\n\tMon, 29 Sep 2025 16:19:42 -0400","from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.12])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id 33781195E916; Mon, 29 Sep 2025 20:19:41 +0000 (UTC)","from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.44.32.35])\n\tby mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 6AB9319560B4; Mon, 29 Sep 2025 20:19:39 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"DtmugV5S\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1759177185;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=Y3EvnC9xVYMjL2+fsG65hSpjsgf/MkaX0weBsZfpdfg=;\n\tb=DtmugV5Sve5W/zSC0R1qXfH9p9nBBREn/DzSqzZ+UjRe4lIFhTQ21Io6ongwx4WyBl8uKY\n\tq7+GjW8Vpbe4s4jISULZFObrWDCJTULwJpciFtNNrt4wDyMgPFtnOt6BzEl3AKZTYrWGIX\n\trZbe16RBxW6bLRDo30oVbxDZsvmyGbw=","X-MC-Unique":"i4pJqKgxNQ2UYJ08fmtccQ-1","X-Mimecast-MFC-AGG-ID":"i4pJqKgxNQ2UYJ08fmtccQ_1759177181","From":"Milan Zamazal ","To":"libcamera-devel@lists.libcamera.org","Cc":"Milan Zamazal , pobrn@protonmail.com,\n\tmail@maciej.szmigiero.name, hansg@kernel.org","Subject":"[PATCH v5 3/7] libcamera: software_isp: Pass correct y-coordinate to\n\tstats","Date":"Mon, 29 Sep 2025 22:19:20 +0200","Message-ID":"<20250929201924.45019-4-mzamazal@redhat.com>","In-Reply-To":"<20250929201924.45019-1-mzamazal@redhat.com>","References":"<20250929201924.45019-1-mzamazal@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.12","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"NY2qL20W9YJEm1mAOdQXuMMO9PkRIrS5JrfJfvyhsy0_1759177181","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","content-type":"text/plain; charset=\"US-ASCII\"; x-default=true","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The window set by SwStatsCpu::setWindow is relative to the processed\nimage area. But debayering passes the processed line y-coordinate to\nthe stats relative to the whole image area. This can result in\ngathering stats from a wrong image area or in not gathering stats at\nall.\n\nLet's pass the correct y-coordinate to the stats processing methods.\n\nBug: https://bugs.libcamera.org/show_bug.cgi?id=280\nSigned-off-by: Maciej S. Szmigiero \nSigned-off-by: Milan Zamazal \nReviewed-by: Hans de Goede \n---\n src/libcamera/software_isp/debayer_cpu.cpp | 12 +++++++-----\n 1 file changed, 7 insertions(+), 5 deletions(-)","diff":"diff --git a/src/libcamera/software_isp/debayer_cpu.cpp b/src/libcamera/software_isp/debayer_cpu.cpp\nindex bcaaa5dee..09d171d6b 100644\n--- a/src/libcamera/software_isp/debayer_cpu.cpp\n+++ b/src/libcamera/software_isp/debayer_cpu.cpp\n@@ -661,7 +661,7 @@ void DebayerCpu::memcpyNextLine(const uint8_t *linePointers[])\n \n void DebayerCpu::process2(const uint8_t *src, uint8_t *dst)\n {\n-\tunsigned int yEnd = window_.y + window_.height;\n+\tunsigned int yEnd = window_.height;\n \t/* Holds [0] previous- [1] current- [2] next-line */\n \tconst uint8_t *linePointers[3];\n \n@@ -676,13 +676,16 @@ void DebayerCpu::process2(const uint8_t *src, uint8_t *dst)\n \t\t/* window_.y == 0, use the next line as prev line */\n \t\tlinePointers[1] = src + inputConfig_.stride;\n \t\tlinePointers[2] = src;\n-\t\t/* Last 2 lines also need special handling */\n+\t\t/*\n+\t\t * Last 2 lines also need special handling.\n+\t\t * (And configure() ensures that yEnd >= 2.)\n+\t\t */\n \t\tyEnd -= 2;\n \t}\n \n \tsetupInputMemcpy(linePointers);\n \n-\tfor (unsigned int y = window_.y; y < yEnd; y += 2) {\n+\tfor (unsigned int y = 0; y < yEnd; y += 2) {\n \t\tshiftLinePointers(linePointers, src);\n \t\tmemcpyNextLine(linePointers);\n \t\tstats_->processLine0(y, linePointers);\n@@ -716,7 +719,6 @@ void DebayerCpu::process2(const uint8_t *src, uint8_t *dst)\n \n void DebayerCpu::process4(const uint8_t *src, uint8_t *dst)\n {\n-\tconst unsigned int yEnd = window_.y + window_.height;\n \t/*\n \t * This holds pointers to [0] 2-lines-up [1] 1-line-up [2] current-line\n \t * [3] 1-line-down [4] 2-lines-down.\n@@ -734,7 +736,7 @@ void DebayerCpu::process4(const uint8_t *src, uint8_t *dst)\n \n \tsetupInputMemcpy(linePointers);\n \n-\tfor (unsigned int y = window_.y; y < yEnd; y += 4) {\n+\tfor (unsigned int y = 0; y < window_.height; y += 4) {\n \t\tshiftLinePointers(linePointers, src);\n \t\tmemcpyNextLine(linePointers);\n \t\tstats_->processLine0(y, linePointers);\n","prefixes":["v5","3/7"]}