{"id":24486,"url":"https://patchwork.libcamera.org/api/patches/24486/?format=json","web_url":"https://patchwork.libcamera.org/patch/24486/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250929074706.420894-1-barnabas.pocze@ideasonboard.com>","date":"2025-09-29T07:47:06","name":"[RFC,v1] libcamera: software_isp: Clear pending async work","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"322bfab42d9dda34ebd166a72b829202a61b08f3","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24486/mbox/","series":[{"id":5464,"url":"https://patchwork.libcamera.org/api/series/5464/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5464","date":"2025-09-29T07:47:06","name":"[RFC,v1] libcamera: software_isp: Clear pending async work","version":1,"mbox":"https://patchwork.libcamera.org/series/5464/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24486/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24486/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CC867C328C\n\tfor ;\n\tMon, 29 Sep 2025 07:47:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5775E6B5F3;\n\tMon, 29 Sep 2025 09:47:12 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 68FFE6B58E\n\tfor ;\n\tMon, 29 Sep 2025 09:47:10 +0200 (CEST)","from pb-laptop.local (185.221.142.146.nat.pool.zt.hu\n\t[185.221.142.146])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E19321121\n\tfor ;\n\tMon, 29 Sep 2025 09:45:42 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"OwtRCzMF\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1759131943;\n\tbh=GMXVxgwzI6+tW4qRSFg6gpXBM7GmOv3+Ohujb3BRSbs=;\n\th=From:To:Subject:Date:From;\n\tb=OwtRCzMFY+q7tHT1MFE6hy+tlCvgFytGVGvWQgAmsTD0im3eyW3EwlnqwtwKUXbKs\n\tjAHxDmT0IlrN7q5IcIItZLI/nLrMmWlBFm87HzU0uTpOMl/xANamAa4wDcKnfNBGKE\n\thqCXkP8VBmwQpzMDVjoWIIB6TTLB1fB5Hb7XrNW4=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org","Subject":"[RFC PATCH v1] libcamera: software_isp: Clear pending async work","Date":"Mon, 29 Sep 2025 09:47:06 +0200","Message-ID":"<20250929074706.420894-1-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.51.0","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Debayering is carried out on `ispWorkerThread_`. When stopping, the queued\nwork needs to be flushed or cancelled to ensure that the next time it starts,\nit won't process stale data. So remove all messages targeting the `Debayer`\nobject on the worker thread.\n\nSigned-off-by: Barnabás Pőcze \n---\n src/libcamera/software_isp/software_isp.cpp | 1 +\n 1 file changed, 1 insertion(+)","diff":"diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp\nindex b7651b7d2..fdadf79e1 100644\n--- a/src/libcamera/software_isp/software_isp.cpp\n+++ b/src/libcamera/software_isp/software_isp.cpp\n@@ -358,6 +358,7 @@ void SoftwareIsp::stop()\n {\n \tispWorkerThread_.exit();\n \tispWorkerThread_.wait();\n+\tispWorkerThread_.removeMessages(debayer_.get());\n \n \tThread::current()->dispatchMessages(Message::Type::InvokeMessage, this);\n \n","prefixes":["RFC","v1"]}