{"id":24481,"url":"https://patchwork.libcamera.org/api/patches/24481/?format=json","web_url":"https://patchwork.libcamera.org/patch/24481/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250927180004.84620-4-hansg@kernel.org>","date":"2025-09-27T18:00:01","name":"[v3,3/6] ipa: software_isp: AGC: Raise exposure or gain not both at the same time","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"1f3aab39be3c9ed8e010e20f3ea5fe88022d79de","submitter":{"id":239,"url":"https://patchwork.libcamera.org/api/people/239/?format=json","name":"Hans de Goede","email":"hansg@kernel.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24481/mbox/","series":[{"id":5462,"url":"https://patchwork.libcamera.org/api/series/5462/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5462","date":"2025-09-27T17:59:58","name":"ipa: software_isp: AGC: Fox AGC oscillation bug","version":3,"mbox":"https://patchwork.libcamera.org/series/5462/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24481/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24481/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0976AC32A9\n\tfor ;\n\tSat, 27 Sep 2025 18:00:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 914116B5AA;\n\tSat, 27 Sep 2025 20:00:22 +0200 (CEST)","from sea.source.kernel.org (sea.source.kernel.org\n\t[IPv6:2600:3c0a:e001:78e:0:1991:8:25])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 918046B5A2\n\tfor ;\n\tSat, 27 Sep 2025 20:00:13 +0200 (CEST)","from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n\tby sea.source.kernel.org (Postfix) with ESMTP id 3E03544A46;\n\tSat, 27 Sep 2025 18:00:12 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 053CCC4CEF8;\n\tSat, 27 Sep 2025 18:00:10 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=kernel.org header.i=@kernel.org\n\theader.b=\"hZqT/+IA\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1758996012;\n\tbh=doDwnVpI3Y2qcYJ1FHiqEpl0+kdSx6c6kK2Df8Avxew=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=hZqT/+IAAb3h75Kk5r2L21NihEnhsLK4iLvC0/YlkclKxo3NwIfNANCpddnEdWxAc\n\t+Pd5QF5UFI6OY7VLCOL4Sr/hpNKlsZvjuxZG0fsDo0Hgx1OlV4FQLNCtxpwnix8+Qb\n\tvCV8zOzzgcDvgZCTQUbEB4VQP0qYAXuYXsHfw6PWIwC8BGj/9QVDMr5Ou56mIs/wvt\n\tGw6t/6IiLAL2A8UyuUGCPHeRZY4/QOP46ro91US7ueVqbbcwDJFzA7kCSWk+iMa9oe\n\tY4qAgO6exNFbBNiodv2n/2bjpSF85qnmFxX3zHBO+uLFNyY3b+1lIkwpVumM6TX7LO\n\tU9W8OHK9VaAoQ==","From":"Hans de Goede ","To":"libcamera-devel@lists.libcamera.org","Cc":"Hans de Goede , Milan Zamazal ,\n\tKieran Bingham ","Subject":"[PATCH v3 3/6] ipa: software_isp: AGC: Raise exposure or gain not\n\tboth at the same time","Date":"Sat, 27 Sep 2025 20:00:01 +0200","Message-ID":"<20250927180004.84620-4-hansg@kernel.org>","X-Mailer":"git-send-email 2.51.0","In-Reply-To":"<20250927180004.84620-1-hansg@kernel.org>","References":"<20250927180004.84620-1-hansg@kernel.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Raise either exposure or gain; not both at the same time.\n\nBefore this change when the last exposure raise is done, hitting\nexposure-max, gain would be increased at the same time.\n\nReviewed-by: Milan Zamazal \nTested-by: Milan Zamazal \nTested-by: Kieran Bingham \nSigned-off-by: Hans de Goede \n---\n src/ipa/simple/algorithms/agc.cpp | 13 +++++++------\n 1 file changed, 7 insertions(+), 6 deletions(-)","diff":"diff --git a/src/ipa/simple/algorithms/agc.cpp b/src/ipa/simple/algorithms/agc.cpp\nindex 1fc8d7f4..f7f73451 100644\n--- a/src/ipa/simple/algorithms/agc.cpp\n+++ b/src/ipa/simple/algorithms/agc.cpp\n@@ -56,12 +56,13 @@ void Agc::updateExposure(IPAContext &context, IPAFrameContext &frameContext, dou\n \tdouble &again = frameContext.sensor.gain;\n \n \tif (exposureMSV < kExposureOptimal - kExposureSatisfactory) {\n-\t\tnext = exposure * kExpNumeratorUp / kExpDenominator;\n-\t\tif (next - exposure < 1)\n-\t\t\texposure += 1;\n-\t\telse\n-\t\t\texposure = next;\n-\t\tif (exposure >= context.configuration.agc.exposureMax) {\n+\t\tif (exposure < context.configuration.agc.exposureMax) {\n+\t\t\tnext = exposure * kExpNumeratorUp / kExpDenominator;\n+\t\t\tif (next - exposure < 1)\n+\t\t\t\texposure += 1;\n+\t\t\telse\n+\t\t\t\texposure = next;\n+\t\t} else {\n \t\t\tnext = again * kExpNumeratorUp / kExpDenominator;\n \t\t\tif (next - again < context.configuration.agc.againMinStep)\n \t\t\t\tagain += context.configuration.agc.againMinStep;\n","prefixes":["v3","3/6"]}