{"id":24459,"url":"https://patchwork.libcamera.org/api/patches/24459/?format=json","web_url":"https://patchwork.libcamera.org/patch/24459/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250925192856.77881-6-mzamazal@redhat.com>","date":"2025-09-25T19:28:54","name":"[v4,5/7] libcamera: simple: Avoid incorrect arithmetic in AWB","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"b7029706aa86bbb6b63d5eebaab29c1aebae2638","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/?format=json","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24459/mbox/","series":[{"id":5458,"url":"https://patchwork.libcamera.org/api/series/5458/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5458","date":"2025-09-25T19:28:49","name":"Fix stats related problems in software ISP","version":4,"mbox":"https://patchwork.libcamera.org/series/5458/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24459/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24459/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B3D44C3331\n\tfor ;\n\tThu, 25 Sep 2025 19:29:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D8ACE6B601;\n\tThu, 25 Sep 2025 21:29:26 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 296206B611\n\tfor ;\n\tThu, 25 Sep 2025 21:29:23 +0200 (CEST)","from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-151-xEPBYVQ4Oe257GFlL1vL5w-1;\n\tThu, 25 Sep 2025 15:29:16 -0400","from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.17])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id A17E1195609F; Thu, 25 Sep 2025 19:29:15 +0000 (UTC)","from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.44.32.62])\n\tby mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id A01691956095; Thu, 25 Sep 2025 19:29:13 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"L7pQtkgy\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1758828562;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=LyZsWx5DwXfv2ZPUtHNL2o3r3JWEFuo++LnL2EVHaVQ=;\n\tb=L7pQtkgyHkUZ6ifdgL8zCbsBYflbSfn/On0xwoMPlY9geuoMjagCvNiOMXRBAj1Buqtf4c\n\tNRsrXjTY76BO9CKYphj390oT09RielF0tHFzuEFNo+Gy7xrbhNzKE1DyTj/tBo/KMvDUat\n\tEN16AOMMgydSPzFkb605ttYlXL6ROEk=","X-MC-Unique":"xEPBYVQ4Oe257GFlL1vL5w-1","X-Mimecast-MFC-AGG-ID":"xEPBYVQ4Oe257GFlL1vL5w_1758828555","From":"Milan Zamazal ","To":"libcamera-devel@lists.libcamera.org","Cc":"Milan Zamazal , pobrn@protonmail.com,\n\tmail@maciej.szmigiero.name","Subject":"[PATCH v4 5/7] libcamera: simple: Avoid incorrect arithmetic in AWB","Date":"Thu, 25 Sep 2025 21:28:54 +0200","Message-ID":"<20250925192856.77881-6-mzamazal@redhat.com>","In-Reply-To":"<20250925192856.77881-1-mzamazal@redhat.com>","References":"<20250925192856.77881-1-mzamazal@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.17","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"7U7vob3z-JDAdOG3_vO7NpaWFkydLLG-4Ip04IcvNIU_1758828555","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","content-type":"text/plain; charset=\"US-ASCII\"; x-default=true","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The R/G/B sums computed in AWB simple IPA may be zero or perhaps even\nnegative. Let's make sure the sums are always positive, to prevent\ndivision by zero or completely nonsense results.\n\nSigned-off-by: Milan Zamazal \n---\n src/ipa/simple/algorithms/awb.cpp | 10 ++++++----\n 1 file changed, 6 insertions(+), 4 deletions(-)","diff":"diff --git a/src/ipa/simple/algorithms/awb.cpp b/src/ipa/simple/algorithms/awb.cpp\nindex cf567e894..8231a4968 100644\n--- a/src/ipa/simple/algorithms/awb.cpp\n+++ b/src/ipa/simple/algorithms/awb.cpp\n@@ -7,6 +7,7 @@\n \n #include \"awb.h\"\n \n+#include \n #include \n #include \n \n@@ -68,10 +69,11 @@ void Awb::process(IPAContext &context,\n \t */\n \tconst uint64_t nPixels = std::accumulate(\n \t\thistogram.begin(), histogram.end(), 0);\n-\tconst uint64_t offset = blackLevel * nPixels;\n-\tconst uint64_t sumR = stats->sumR_ - offset / 4;\n-\tconst uint64_t sumG = stats->sumG_ - offset / 2;\n-\tconst uint64_t sumB = stats->sumB_ - offset / 4;\n+\tconst int64_t offset = blackLevel * nPixels;\n+\tconst int64_t minValid = 1;\n+\tconst uint64_t sumR = std::max(static_cast(stats->sumR_) - offset / 4, minValid);\n+\tconst uint64_t sumG = std::max(static_cast(stats->sumG_) - offset / 2, minValid);\n+\tconst uint64_t sumB = std::max(static_cast(stats->sumB_) - offset / 4, minValid);\n \n \t/*\n \t * Calculate red and blue gains for AWB.\n","prefixes":["v4","5/7"]}