{"id":24455,"url":"https://patchwork.libcamera.org/api/patches/24455/?format=json","web_url":"https://patchwork.libcamera.org/patch/24455/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250925192856.77881-2-mzamazal@redhat.com>","date":"2025-09-25T19:28:50","name":"[v4,1/7] libcamera: software_isp: Fix width adjustment in SwStatsCpu::setWindow","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"8e2716c4824bf330e3cc4b383597bfab97a01584","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/?format=json","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24455/mbox/","series":[{"id":5458,"url":"https://patchwork.libcamera.org/api/series/5458/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5458","date":"2025-09-25T19:28:49","name":"Fix stats related problems in software ISP","version":4,"mbox":"https://patchwork.libcamera.org/series/5458/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24455/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24455/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 430A9C328C\n\tfor ;\n\tThu, 25 Sep 2025 19:29:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C72176B5FB;\n\tThu, 25 Sep 2025 21:29:14 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E61AF69318\n\tfor ;\n\tThu, 25 Sep 2025 21:29:10 +0200 (CEST)","from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-591-Qij5hSRKMP2DEeijs3TKLA-1;\n\tThu, 25 Sep 2025 15:29:06 -0400","from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.17])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id 2D4FE195609E; Thu, 25 Sep 2025 19:29:05 +0000 (UTC)","from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.44.32.62])\n\tby mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 878E91956095; Thu, 25 Sep 2025 19:29:03 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"acZ6Rs8a\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1758828549;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=NwrFJpnHPVrzbjm6OuH8AKj+KCwc3Xtq1lsigQHKLgQ=;\n\tb=acZ6Rs8af4fKn10QR4Em5sEmG5gsFHN2Z3PHysIw6qhhaZ+3T7gVDFKbTVKpXaIxVcWOA9\n\tDRjgZnia82QQDG1/9UX4Fcc1a/La/anP6EMeVIsxceL5DrRi9tBNGCWqHji8FgqIt7m++y\n\tx731pOj4MYTle1bkgXdghDY2+j2R6yg=","X-MC-Unique":"Qij5hSRKMP2DEeijs3TKLA-1","X-Mimecast-MFC-AGG-ID":"Qij5hSRKMP2DEeijs3TKLA_1758828545","From":"Milan Zamazal ","To":"libcamera-devel@lists.libcamera.org","Cc":"Milan Zamazal , pobrn@protonmail.com,\n\tmail@maciej.szmigiero.name","Subject":"[PATCH v4 1/7] libcamera: software_isp: Fix width adjustment in\n\tSwStatsCpu::setWindow","Date":"Thu, 25 Sep 2025 21:28:50 +0200","Message-ID":"<20250925192856.77881-2-mzamazal@redhat.com>","In-Reply-To":"<20250925192856.77881-1-mzamazal@redhat.com>","References":"<20250925192856.77881-1-mzamazal@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.17","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"Z4H8srSy5dJLyFkciTpfr8xkFKB7TxW0RA8RA5XRvPM_1758828545","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","content-type":"text/plain; charset=\"US-ASCII\"; x-default=true","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"SwStatsCpu::setWindow reduces the window width by the added x-offset, to\nprevent exceeding image bounds. But if the window width is smaller than\nthe x-offset, we get unsigned integer underflow. Fix it by setting the\nwindow width to 0 in such a case.\n\nSigned-off-by: Milan Zamazal \n---\n src/libcamera/software_isp/swstats_cpu.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/software_isp/swstats_cpu.cpp b/src/libcamera/software_isp/swstats_cpu.cpp\nindex 4b77b3600..e8a1d52f2 100644\n--- a/src/libcamera/software_isp/swstats_cpu.cpp\n+++ b/src/libcamera/software_isp/swstats_cpu.cpp\n@@ -426,7 +426,7 @@ void SwStatsCpu::setWindow(const Rectangle &window)\n \twindow_.y &= ~(patternSize_.height - 1);\n \n \t/* width_ - xShift_ to make sure the window fits */\n-\twindow_.width -= xShift_;\n+\twindow_.width = (window_.width > xShift_ ? window_.width - xShift_ : 0);\n \twindow_.width &= ~(patternSize_.width - 1);\n \twindow_.height &= ~(patternSize_.height - 1);\n }\n","prefixes":["v4","1/7"]}