{"id":24451,"url":"https://patchwork.libcamera.org/api/patches/24451/?format=json","web_url":"https://patchwork.libcamera.org/patch/24451/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250924124713.3361707-6-barnabas.pocze@ideasonboard.com>","date":"2025-09-24T12:47:10","name":"[RFC,v1,5/7] libcamera: camera: Make `waitingRequests_` an `std::deque`","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"798b8e2b969b4cd1c094a530e67f0cbf9dada95c","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24451/mbox/","series":[{"id":5457,"url":"https://patchwork.libcamera.org/api/series/5457/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5457","date":"2025-09-24T12:47:05","name":"libcamera: camera: Add `applyControls()`","version":1,"mbox":"https://patchwork.libcamera.org/series/5457/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24451/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24451/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C2429C3332\n\tfor ;\n\tWed, 24 Sep 2025 12:47:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C60606B622;\n\tWed, 24 Sep 2025 14:47:32 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D75EA6B5F9\n\tfor ;\n\tWed, 24 Sep 2025 14:47:17 +0200 (CEST)","from pb-laptop.local (185.221.140.70.nat.pool.zt.hu\n\t[185.221.140.70])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E4A16AD0;\n\tWed, 24 Sep 2025 14:45:53 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"UchqAQcv\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1758717954;\n\tbh=1NEsdwLlZPPve6Z848Cw15ik7hXlgefsz1S+d8YnDBQ=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=UchqAQcvUxUNdGfUlx1KP1gXEZ+g7OG2laZAUgrHG9ppGYUB/IbnpYPkko52LFclw\n\tE/mT+yUSf+StenxxrbgoOpARLKmbJyA3guLnkV2rf9pMliK7FZfQCytKHwYNfvMgsz\n\tlV5FI7AdzCM/gTQksvQGedngUnCTkLaYbdHf9REc=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org,\n\tKieran Bingham ","Subject":"[RFC PATCH v1 5/7] libcamera: camera: Make `waitingRequests_` an\n\t`std::deque`","Date":"Wed, 24 Sep 2025 14:47:10 +0200","Message-ID":"<20250924124713.3361707-6-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.51.0","In-Reply-To":"<20250924124713.3361707-1-barnabas.pocze@ideasonboard.com>","References":"<20250924124713.3361707-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Use `std::deque` instead of `std::queue` because an `std::queue` cannot\nbe iterated.\n\nSigned-off-by: Barnabás Pőcze \n---\n include/libcamera/internal/camera.h | 2 +-\n src/libcamera/pipeline_handler.cpp | 8 ++++----\n 2 files changed, 5 insertions(+), 5 deletions(-)","diff":"diff --git a/include/libcamera/internal/camera.h b/include/libcamera/internal/camera.h\nindex 8a2e9ed58..0f50c14a5 100644\n--- a/include/libcamera/internal/camera.h\n+++ b/include/libcamera/internal/camera.h\n@@ -37,7 +37,7 @@ public:\n \tconst PipelineHandler *pipe() const { return pipe_.get(); }\n \n \tstd::list queuedRequests_;\n-\tstd::queue waitingRequests_;\n+\tstd::deque waitingRequests_;\n \tControlInfoMap controlInfo_;\n \tControlList properties_;\n \ndiff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\nindex e5f9e55c9..d0d3fbc79 100644\n--- a/src/libcamera/pipeline_handler.cpp\n+++ b/src/libcamera/pipeline_handler.cpp\n@@ -370,7 +370,7 @@ void PipelineHandler::stop(Camera *camera)\n \t * after the device to keep them in order.\n \t */\n \tCamera::Private *data = camera->_d();\n-\tstd::queue waitingRequests;\n+\tstd::deque waitingRequests;\n \twaitingRequests.swap(data->waitingRequests_);\n \n \t/* Stop the pipeline handler and let the queued requests complete. */\n@@ -379,7 +379,7 @@ void PipelineHandler::stop(Camera *camera)\n \t/* Cancel and signal as complete all waiting requests. */\n \twhile (!waitingRequests.empty()) {\n \t\tRequest *request = waitingRequests.front();\n-\t\twaitingRequests.pop();\n+\t\twaitingRequests.pop_front();\n \t\tcancelRequest(request);\n \t}\n \n@@ -461,7 +461,7 @@ void PipelineHandler::queueRequest(Request *request)\n \n \tCamera *camera = request->_d()->camera();\n \tCamera::Private *data = camera->_d();\n-\tdata->waitingRequests_.push(request);\n+\tdata->waitingRequests_.push_back(request);\n \n \trequest->_d()->prepare(300ms);\n }\n@@ -510,7 +510,7 @@ void PipelineHandler::doQueueRequests(Camera *camera)\n \t\t * Pop the request first, in case doQueueRequests() is called\n \t\t * recursively from within doQueueRequest()\n \t\t */\n-\t\tdata->waitingRequests_.pop();\n+\t\tdata->waitingRequests_.pop_front();\n \t\tdoQueueRequest(request);\n \t}\n }\n","prefixes":["RFC","v1","5/7"]}