{"id":24450,"url":"https://patchwork.libcamera.org/api/patches/24450/?format=json","web_url":"https://patchwork.libcamera.org/patch/24450/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250924124713.3361707-5-barnabas.pocze@ideasonboard.com>","date":"2025-09-24T12:47:09","name":"[RFC,v1,4/7] libcamera: controls: ControlList: Add `erase()`","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"30e6231f9f89125c06430c7f47b21cb24dc89dac","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24450/mbox/","series":[{"id":5457,"url":"https://patchwork.libcamera.org/api/series/5457/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5457","date":"2025-09-24T12:47:05","name":"libcamera: camera: Add `applyControls()`","version":1,"mbox":"https://patchwork.libcamera.org/series/5457/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24450/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24450/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 07F24C32A9\n\tfor ;\n\tWed, 24 Sep 2025 12:47:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 210D96B611;\n\tWed, 24 Sep 2025 14:47:31 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 86FB76B5F8\n\tfor ;\n\tWed, 24 Sep 2025 14:47:17 +0200 (CEST)","from pb-laptop.local (185.221.140.70.nat.pool.zt.hu\n\t[185.221.140.70])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9B6761E35;\n\tWed, 24 Sep 2025 14:45:53 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"PAaLgTt3\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1758717953;\n\tbh=Tk9V+4Yr8AFkD+oqP8mCtSO86gr9R9B0KISNqioEJRs=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=PAaLgTt3nnpTLZKBfescI6ryK+kHOZ2sUuGfdslldFdCev6xiH/yj5y7783YSKDYj\n\tDzX1mB0Wr/XdfTimz8QEr6XNhBiujkwU9nvF74vCTwR16CIIIduOne2B21y0Jfa/U0\n\tV+855xQkmboNCuV8nUTt7X0fe64g2w16uQKSH42Y=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","To":"libcamera-devel@lists.libcamera.org,\n\tKieran Bingham ","Subject":"[RFC PATCH v1 4/7] libcamera: controls: ControlList: Add `erase()`","Date":"Wed, 24 Sep 2025 14:47:09 +0200","Message-ID":"<20250924124713.3361707-5-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.51.0","In-Reply-To":"<20250924124713.3361707-1-barnabas.pocze@ideasonboard.com>","References":"<20250924124713.3361707-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add two `erase()` functions that can be used to remove elements\nfrom a `ControlList` instance.\n\nSigned-off-by: Barnabás Pőcze \n---\n include/libcamera/controls.h | 3 +++\n src/libcamera/controls.cpp | 17 +++++++++++++++++\n 2 files changed, 20 insertions(+)","diff":"diff --git a/include/libcamera/controls.h b/include/libcamera/controls.h\nindex 5d4a53c46..9045caff7 100644\n--- a/include/libcamera/controls.h\n+++ b/include/libcamera/controls.h\n@@ -470,6 +470,9 @@ public:\n \tconst ControlValue &get(unsigned int id) const;\n \tvoid set(unsigned int id, const ControlValue &value);\n \n+\tbool erase(unsigned int id);\n+\tbool erase(const ControlId &ctrl) { return erase(ctrl.id()); }\n+\n \tconst ControlInfoMap *infoMap() const { return infoMap_; }\n \tconst ControlIdMap *idMap() const { return idmap_; }\n \ndiff --git a/src/libcamera/controls.cpp b/src/libcamera/controls.cpp\nindex 54cd3b703..83f8bf056 100644\n--- a/src/libcamera/controls.cpp\n+++ b/src/libcamera/controls.cpp\n@@ -1156,6 +1156,23 @@ void ControlList::set(unsigned int id, const ControlValue &value)\n \t*val = value;\n }\n \n+/**\n+ * \\brief Remove the value of control \\a id\n+ * \\param[in] id The control ID\n+ * \\return \\a true if \\a id was present, \\a false otherwise\n+ */\n+bool ControlList::erase(unsigned int id)\n+{\n+\treturn controls_.erase(id);\n+}\n+\n+/**\n+ * \\fn ControlList::erase(const ControlId &ctrl)\n+ * \\brief Remove the value of control \\a ctrl\n+ * \\param[in] ctrl The control\n+ * \\return \\a true if \\a ctrl was present, \\a false otherwise\n+ */\n+\n /**\n * \\fn ControlList::infoMap()\n * \\brief Retrieve the ControlInfoMap used to construct the ControlList\n","prefixes":["RFC","v1","4/7"]}