{"id":24447,"url":"https://patchwork.libcamera.org/api/patches/24447/?format=json","web_url":"https://patchwork.libcamera.org/patch/24447/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250924124713.3361707-2-barnabas.pocze@ideasonboard.com>","date":"2025-09-24T12:47:06","name":"[RFC,v1,1/7] libcamera: base: bound_method: Strip qualifiers in argument pack","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"37f9f584c403afac08de3c7d9f5ef5cd5138511a","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/?format=json","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24447/mbox/","series":[{"id":5457,"url":"https://patchwork.libcamera.org/api/series/5457/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5457","date":"2025-09-24T12:47:05","name":"libcamera: camera: Add `applyControls()`","version":1,"mbox":"https://patchwork.libcamera.org/series/5457/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24447/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24447/checks/","tags":{},"headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BAE78C32A9\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 24 Sep 2025 12:47:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C7D366B601;\n\tWed, 24 Sep 2025 14:47:23 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CEE756B58E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 24 Sep 2025 14:47:16 +0200 (CEST)","from pb-laptop.local (185.221.140.70.nat.pool.zt.hu\n\t[185.221.140.70])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AFE51EAE;\n\tWed, 24 Sep 2025 14:45:52 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"pMAjPYo/\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1758717952;\n\tbh=0iPQLkJdCZwQYnyoJnp+NllikG/FJHULtR/rQoKRazE=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=pMAjPYo//04nT2uE1tQrElrDYzdHUHSRhR7/OyL+M0RiNKKHBgvSkWWTKSTItS+/k\n\tgKn0GbNRP3i1yAujsjk40SrucuGvVEqZSNo84ZRqQZMS9SujsiUHPf9PUr0NOtmlHy\n\tBJVUUPH+9NWzDDIcDE//UUv0RxvVCSgFKYDclin4=","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>","To":"libcamera-devel@lists.libcamera.org,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>","Subject":"[RFC PATCH v1 1/7] libcamera: base: bound_method: Strip qualifiers\n\tin argument pack","Date":"Wed, 24 Sep 2025 14:47:06 +0200","Message-ID":"<20250924124713.3361707-2-barnabas.pocze@ideasonboard.com>","X-Mailer":"git-send-email 2.51.0","In-Reply-To":"<20250924124713.3361707-1-barnabas.pocze@ideasonboard.com>","References":"<20250924124713.3361707-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"Having extra qualifiers, especially `const`, simply inhibits optimization\nopportunities as it prevents e.g. moving values out of pack object. So\nstrip the qualifiers.\n\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n include/libcamera/base/bound_method.h | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/include/libcamera/base/bound_method.h b/include/libcamera/base/bound_method.h\nindex 91fe8b8cb..cb642e0a9 100644\n--- a/include/libcamera/base/bound_method.h\n+++ b/include/libcamera/base/bound_method.h\n@@ -39,7 +39,7 @@ public:\n \t{\n \t}\n \n-\tstd::tuple<typename std::remove_reference_t<Args>...> args_;\n+\tstd::tuple<std::remove_cv_t<std::remove_reference_t<Args>>...> args_;\n \tR ret_;\n };\n \n@@ -53,7 +53,7 @@ public:\n \t{\n \t}\n \n-\tstd::tuple<typename std::remove_reference_t<Args>...> args_;\n+\tstd::tuple<std::remove_cv_t<std::remove_reference_t<Args>>...> args_;\n };\n \n class BoundMethodBase\n","prefixes":["RFC","v1","1/7"]}