[{"id":3273,"web_url":"https://patchwork.libcamera.org/comment/3273/","msgid":"<56b52feb-428d-1cf5-ebdd-916602bd51a0@linaro.org>","date":"2019-12-18T19:41:59","subject":"Re: [libcamera-devel] [RFC 7/7] libcamera: sensor: ov5670: Add lens\n\tproperties","submitter":{"id":25,"url":"https://patchwork.libcamera.org/api/people/25/","name":"Andrey Konovalov","email":"andrey.konovalov@linaro.org"},"content":"Hi Jacopo,\n\nOn 18.12.2019 17:50, Jacopo Mondi wrote:\n> Signed-off-by: Jacopo Mondi \n> ---\n> src/libcamera/sensor/ov5670.cpp | 6 ++++++\n> 1 file changed, 6 insertions(+)\n> \n> diff --git a/src/libcamera/sensor/ov5670.cpp b/src/libcamera/sensor/ov5670.cpp\n> index c2d996785717..a25bfd246f8b 100644\n> --- a/src/libcamera/sensor/ov5670.cpp\n> +++ b/src/libcamera/sensor/ov5670.cpp\n> @@ -30,6 +30,12 @@ int OV5670CameraSensor::initProperties(const ControlInfoMap &controlMap)\n> \tproperties_.set(properties::BayerFilterArrangement, bayerFilter);\n> \tproperties_.set(properties::ISOSensitivityRange, { 50, 800 });\n> \n> +\t/* Lens Properties. */\n> +\tproperties_.set(properties::LensApertures, 0.0f);\n\nWhat is the meaning of the aperture of zero?\n\n> +\tproperties_.set(properties::LensFocalDistance, 3.69f);\n\nThis means that the lens has the focal length of 3.69 mm, correct?\n\n> +\tproperties_.set(properties::LensHyperfocalDistance, 0.0f);\n\nSame question as for the aperture above (zero value for the property which is essentially non-zero)\n\n> +\tproperties_.set(properties::LensMinimumFocalDistance, 3.69f);\n\nWhy is it the same as the focal length?\nIf this is \"The shortest distance in millimeters from the lens surface in which an\nobject could be brought into sharp focus\", then setting it to 3.69 is most probably\nwrong...\n\n\nThanks,\nAndrey\n\n> +\n> \treturn CameraSensor::initProperties(controlMap);\n> }\n> \n>","headers":{"Return-Path":"","Received":["from mail-lf1-x143.google.com (mail-lf1-x143.google.com\n\t[IPv6:2a00:1450:4864:20::143])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B3DFA60475\n\tfor ;\n\tWed, 18 Dec 2019 20:42:01 +0100 (CET)","by mail-lf1-x143.google.com with SMTP id l18so2575581lfc.1\n\tfor ;\n\tWed, 18 Dec 2019 11:42:01 -0800 (PST)","from [192.168.118.136] (95-28-65-22.broadband.corbina.ru.\n\t[95.28.65.22]) by smtp.gmail.com with ESMTPSA id\n\td25sm1632058ljj.51.2019.12.18.11.42.00\n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tWed, 18 Dec 2019 11:42:00 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=subject:to:references:from:message-id:date:user-agent:mime-version\n\t:in-reply-to:content-language:content-transfer-encoding;\n\tbh=4Anv/zL01/MhQH8UkQv41I/qqM5dwAVN/gXw2rs5uAA=;\n\tb=AdKFEX+ALyI/xbzXUSIc9KXmw+KrEoeBpO2Og+yuYMLVpkSmio3MtxQduS2n+611C0\n\tdIMFSeo2G/TAVZNKMXp/net6KrXxGVMimDAEyCEHciqzWUSFqQhcvfhg+aYxTFE8jc7k\n\t2UK+8xB0dr9xE1o+//Tw3ZZ/aBRVI4+07qtBcUCaRrqDVDQHp0W90owuhfNALV0N3gSt\n\tuIFvgZ5TsH3UFJKZsFhGH8lLQQAbG/QZTBfMnBmLZwZlsOJZJ6dmTh0BJsPrz/4YBkiO\n\tGjeaHH0D7nqnJCwxr2S5VEMuSNsxEri6DgJmoBnVRipj037pzeqTpIosSaVZj+FdVqME\n\tUO3w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=4Anv/zL01/MhQH8UkQv41I/qqM5dwAVN/gXw2rs5uAA=;\n\tb=nVgxJQUMMOKgkdZbCg0yUQOac0fnLS2BGrjN1cYurEYYs3tmexR1d16CoG8wK6X+Xs\n\t1jFZ0Oh1l2OzcRYajmB5mr4RUjRXENTw45wdV0cXOGXbpRqUvuqNy5UGDnu6WLugP68I\n\tIiXxeimVmMDgjXeZkR2y87s1AHbMYSuTBguhBxHziiBXKIs9SWOxX0DSeO2TDJ/x6515\n\tsd+9tSNUQusqI+RzlY+LGszMWw+JplUePrKtxAqc8qBs2gAIaBnDBEvHc2ImEJZmRN6k\n\t3NFVkyhZqskZiQ53hsbMffRkYUtVJXHCrqvT9ccdt4KH8h9JlkNFJh0hJFD6tXVeSKWV\n\t80Yg==","X-Gm-Message-State":"APjAAAVsQqtPzC25mUrmXslK+R9r9Ldwppevdd85LlURljRWipjlMeEu\n\tT5dgTrKsZNTAwOz1iKGMaet0GjajzKQ=","X-Google-Smtp-Source":"APXvYqwUF+ldIupEVozOODOEF1dPJNK/wGYbyp7FC5CpE1UMKPwmvrGpC+kSSBJa6ZVP1idUcG28nA==","X-Received":"by 2002:ac2:4849:: with SMTP id 9mr2863181lfy.11.1576698121118; \n\tWed, 18 Dec 2019 11:42:01 -0800 (PST)","To":"libcamera-devel@lists.libcamera.org","References":"<20191218145001.22283-1-jacopo@jmondi.org>\n\t<20191218145001.22283-8-jacopo@jmondi.org>","From":"Andrey Konovalov ","Message-ID":"<56b52feb-428d-1cf5-ebdd-916602bd51a0@linaro.org>","Date":"Wed, 18 Dec 2019 22:41:59 +0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.2.2","MIME-Version":"1.0","In-Reply-To":"<20191218145001.22283-8-jacopo@jmondi.org>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [RFC 7/7] libcamera: sensor: ov5670: Add lens\n\tproperties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 18 Dec 2019 19:42:01 -0000"}},{"id":3275,"web_url":"https://patchwork.libcamera.org/comment/3275/","msgid":"<20191219115853.2i4dczhswjon3ddc@uno.localdomain>","date":"2019-12-19T11:59:40","subject":"Re: [libcamera-devel] [RFC 7/7] libcamera: sensor: ov5670: Add lens\n\tproperties","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Andrey,\n\n I premit I don't have a manual for the sensor nor the optical\n specification, so I referred to the ChromeOS BSP to retrieve this\n information. All the values here are copied from there.\n\nOn Wed, Dec 18, 2019 at 10:41:59PM +0300, Andrey Konovalov wrote:\n> Hi Jacopo,\n>\n> On 18.12.2019 17:50, Jacopo Mondi wrote:\n> > Signed-off-by: Jacopo Mondi \n> > ---\n> > src/libcamera/sensor/ov5670.cpp | 6 ++++++\n> > 1 file changed, 6 insertions(+)\n> >\n> > diff --git a/src/libcamera/sensor/ov5670.cpp b/src/libcamera/sensor/ov5670.cpp\n> > index c2d996785717..a25bfd246f8b 100644\n> > --- a/src/libcamera/sensor/ov5670.cpp\n> > +++ b/src/libcamera/sensor/ov5670.cpp\n> > @@ -30,6 +30,12 @@ int OV5670CameraSensor::initProperties(const ControlInfoMap &controlMap)\n> > \tproperties_.set(properties::BayerFilterArrangement, bayerFilter);\n> > \tproperties_.set(properties::ISOSensitivityRange, { 50, 800 });\n> > +\t/* Lens Properties. */\n> > +\tproperties_.set(properties::LensApertures, 0.0f);\n>\n> What is the meaning of the aperture of zero?\n>\n> > +\tproperties_.set(properties::LensFocalDistance, 3.69f);\n>\n> This means that the lens has the focal length of 3.69 mm, correct?\n>\n\nvery short right ? Can't tell if it's plausible or not though\n\n> > +\tproperties_.set(properties::LensHyperfocalDistance, 0.0f);\n>\n> Same question as for the aperture above (zero value for the property which is essentially non-zero)\n>\n> > +\tproperties_.set(properties::LensMinimumFocalDistance, 3.69f);\n>\n> Why is it the same as the focal length?\n> If this is \"The shortest distance in millimeters from the lens surface in which an\n> object could be brought into sharp focus\", then setting it to 3.69 is most probably\n> wrong...\n>\n\nProbably, but as I've said those values come from the ChromeOS BSP and\nI think they're overridden by the binary 3A implementation for the\nplatform where the sensor is installed on. Honestly, I am not sure\nhow to retrieve those values from if not from there...\n\nThanks for you feedback\n j\n\n\n>\n> Thanks,\n> Andrey\n>\n> > +\n> > \treturn CameraSensor::initProperties(controlMap);\n> > }\n> >\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net\n\t[217.70.183.194])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AF42F6047D\n\tfor ;\n\tThu, 19 Dec 2019 12:57:37 +0100 (CET)","from uno.localdomain (unknown [185.82.168.2])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 0A0994000B;\n\tThu, 19 Dec 2019 11:57:36 +0000 (UTC)"],"X-Originating-IP":"185.82.168.2","Date":"Thu, 19 Dec 2019 12:59:40 +0100","From":"Jacopo Mondi ","To":"Andrey Konovalov ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20191219115853.2i4dczhswjon3ddc@uno.localdomain>","References":"<20191218145001.22283-1-jacopo@jmondi.org>\n\t<20191218145001.22283-8-jacopo@jmondi.org>\n\t<56b52feb-428d-1cf5-ebdd-916602bd51a0@linaro.org>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"qsyczf5vqeh7egjb\"","Content-Disposition":"inline","In-Reply-To":"<56b52feb-428d-1cf5-ebdd-916602bd51a0@linaro.org>","Subject":"Re: [libcamera-devel] [RFC 7/7] libcamera: sensor: ov5670: Add lens\n\tproperties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 19 Dec 2019 11:57:37 -0000"}},{"id":3283,"web_url":"https://patchwork.libcamera.org/comment/3283/","msgid":"<3a41e7a6-b035-8b63-1eb7-0a40f9787f11@linaro.org>","date":"2019-12-27T17:30:40","subject":"Re: [libcamera-devel] [RFC 7/7] libcamera: sensor: ov5670: Add lens\n\tproperties","submitter":{"id":25,"url":"https://patchwork.libcamera.org/api/people/25/","name":"Andrey Konovalov","email":"andrey.konovalov@linaro.org"},"content":"Hi Jacopo,\n\nOn 19.12.2019 14:59, Jacopo Mondi wrote:\n> Hi Andrey,\n> \n> I premit I don't have a manual for the sensor nor the optical\n> specification, so I referred to the ChromeOS BSP to retrieve this\n> information. All the values here are copied from there.\n> \n> On Wed, Dec 18, 2019 at 10:41:59PM +0300, Andrey Konovalov wrote:\n>> Hi Jacopo,\n>>\n>> On 18.12.2019 17:50, Jacopo Mondi wrote:\n>>> Signed-off-by: Jacopo Mondi \n>>> ---\n>>> src/libcamera/sensor/ov5670.cpp | 6 ++++++\n>>> 1 file changed, 6 insertions(+)\n>>>\n>>> diff --git a/src/libcamera/sensor/ov5670.cpp b/src/libcamera/sensor/ov5670.cpp\n>>> index c2d996785717..a25bfd246f8b 100644\n>>> --- a/src/libcamera/sensor/ov5670.cpp\n>>> +++ b/src/libcamera/sensor/ov5670.cpp\n>>> @@ -30,6 +30,12 @@ int OV5670CameraSensor::initProperties(const ControlInfoMap &controlMap)\n>>> \tproperties_.set(properties::BayerFilterArrangement, bayerFilter);\n>>> \tproperties_.set(properties::ISOSensitivityRange, { 50, 800 });\n>>> +\t/* Lens Properties. */\n>>> +\tproperties_.set(properties::LensApertures, 0.0f);\n>>\n>> What is the meaning of the aperture of zero?\n\nZero value of aperture looks like \"value not available\" for me.\n(In strict sense, if the aperture is exactly zero then no light can pass through)\n\n>>> +\tproperties_.set(properties::LensFocalDistance, 3.69f);\n>>\n>> This means that the lens has the focal length of 3.69 mm, correct?\n>>\n> \n> very short right ? Can't tell if it's plausible or not though\n\nFor ov5670 (1/5\" sized sensor with the image area of about 2.9mm x 2.2mm) this is quite typical focal length.\nIt will give approximately the same field of view as a 44mm focal length lens on a full frame (36mm x 24mm sensor) camera.\n(A \"normal\" lens for a full frame camera - which produces the perspective closest to how a human eye see - is considered\nto be a 50mm one)\n\n>>> +\tproperties_.set(properties::LensHyperfocalDistance, 0.0f);\n\nHyperfocal distance of 0 is invalid. So I can only take it as \"not known\" or \"not specified\".\n\n>> Same question as for the aperture above (zero value for the property which is essentially non-zero)\n>>\n>>> +\tproperties_.set(properties::LensMinimumFocalDistance, 3.69f);\n>>\n>> Why is it the same as the focal length?\n>> If this is \"The shortest distance in millimeters from the lens surface in which an\n>> object could be brought into sharp focus\", then setting it to 3.69 is most probably\n>> wrong...\n\nI meant that the minimal *focus distance* being equal to properties::LensFocalDistance is by 99.99% wrong.\nBut if \"properties::LensMinimumFocalDistance\" is misspelled \"properties::LensMinimumFocalLength\", then the same value\nas properties::LensFocalDistance is correct (for a fixed focal length lens).\n\n> Probably, but as I've said those values come from the ChromeOS BSP and\n> I think they're overridden by the binary 3A implementation for the\n> platform where the sensor is installed on. Honestly, I am not sure\n> how to retrieve those values from if not from there...\n\nAll those numbers are characteristics of a camera module, the lens used in particular.\nSo all these numbers must come from the camera module or the lens specification.\nOf course the manufacturer is not obliged to share this info with its customers, and we can't do\nmuch with that.\n\nGuess the (special) value used for such a property when the actual value of the property is not known\nmust be explicitly defined somewhere.\n\nThanks,\nAndrey\n\n> Thanks for you feedback\n> j\n> \n> \n>>\n>> Thanks,\n>> Andrey\n>>\n>>> +\n>>> \treturn CameraSensor::initProperties(controlMap);\n>>> }\n>>>\n>> _______________________________________________\n>> libcamera-devel mailing list\n>> libcamera-devel@lists.libcamera.org\n>> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lj1-x236.google.com (mail-lj1-x236.google.com\n\t[IPv6:2a00:1450:4864:20::236])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B6EB86046D\n\tfor ;\n\tFri, 27 Dec 2019 18:30:42 +0100 (CET)","by mail-lj1-x236.google.com with SMTP id w1so5657428ljh.5\n\tfor ;\n\tFri, 27 Dec 2019 09:30:42 -0800 (PST)","from [192.168.119.5] (office.dev.rtsoft.ru. [62.117.114.130])\n\tby smtp.gmail.com with ESMTPSA id\n\t204sm14902298lfj.47.2019.12.27.09.30.41\n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tFri, 27 Dec 2019 09:30:41 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=leRm/0PmtmsmM1BpxAYWxHoS/349zAIN9OPg5zX6JEY=;\n\tb=y9VFrF84Jfzs/joyv2kfKDjZftOPjn3eD5UPF1HhZO/UR3ZxCneeHc7lmSH2QBOJV5\n\tLNObppDH7npmLyFyTVtdrlqddhI+/bCR7e18Za+ZsH/UW4IQxJ3DKK6V8O9AxgVPELQH\n\tU1ltoXPmWcY9BuBHr7ND2ngr9wF0+4sjwQWJCOKhBqmKIJG7wTj9vYzL2fCsGWvD48rD\n\trOzEHlxQgnSnIG77Y3V47tE1A9NAZNv1BykjKcSTf80wTaJK+92YRHGwF8XFO6UlLWn+\n\tQ0hGBt0Z4dgMXUNdlV8B1PJTYDjEU0mVwIn7nxxT47epwo8DixsXp1RmXmIzUMnjlwQ7\n\tXOCA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=leRm/0PmtmsmM1BpxAYWxHoS/349zAIN9OPg5zX6JEY=;\n\tb=DJEG0OIAeZIJ8f/N2FdnhD0LcbKtCJcLfJckdm00JvkipzrBEz04Y5TH7SBaGLKlPI\n\tOUFw7XpzH+ZV2QbM9mzVz6qsp+KQQXAYhf6QCxpA4eq7e1Er3Q2UUa4uOW1R94yHJxvM\n\t2vnLJ/4EnBicUhrQ31CTsBGtLHZoizifBuWwaAUwULfvbLwA0fw1sOEWNmY8vTzTO97Y\n\t545xKtDUxkDkdKhqjWgRrkApxszRuaxhQIJdKe2BET67tc9yxl4LyMJbpb8+MZc3dkd8\n\tlIf0GGqkyIif5+iX2ThK+1beTsEcQNUOj4JTbuHS03hQYfLiM9tQn9XImxxco8Ap8wfP\n\tmW/g==","X-Gm-Message-State":"APjAAAUFJDHEwiHpWSrJ+GPdHlsLm1HPt+CacljKFlytFrggPK35RwnC\n\tcO7UmRy+ykDSSae65LPvPYAxOg==","X-Google-Smtp-Source":"APXvYqxl4dvIu12L0Yz9AKNNBOI2yZ562r6jU+uT2gsQYtxd0ggR6SqxQUhlvD7Aa5laeQIVpXwArg==","X-Received":"by 2002:a2e:b0e3:: with SMTP id h3mr28261407ljl.56.1577467841989;\n\tFri, 27 Dec 2019 09:30:41 -0800 (PST)","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","References":"<20191218145001.22283-1-jacopo@jmondi.org>\n\t<20191218145001.22283-8-jacopo@jmondi.org>\n\t<56b52feb-428d-1cf5-ebdd-916602bd51a0@linaro.org>\n\t<20191219115853.2i4dczhswjon3ddc@uno.localdomain>","From":"Andrey Konovalov ","Message-ID":"<3a41e7a6-b035-8b63-1eb7-0a40f9787f11@linaro.org>","Date":"Fri, 27 Dec 2019 20:30:40 +0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.2.2","MIME-Version":"1.0","In-Reply-To":"<20191219115853.2i4dczhswjon3ddc@uno.localdomain>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [RFC 7/7] libcamera: sensor: ov5670: Add lens\n\tproperties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 27 Dec 2019 17:30:42 -0000"}}]