{"id":24416,"url":"https://patchwork.libcamera.org/api/patches/24416/?format=json","web_url":"https://patchwork.libcamera.org/patch/24416/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250919094041.183031-8-stefan.klug@ideasonboard.com>","date":"2025-09-19T09:40:22","name":"[v5,07/19] libipa: agc_mean_luminance: Fix constraint logging","commit_ref":"3d310f106a1c44162abb70f4a235b5640d95889b","pull_url":null,"state":"accepted","archived":false,"hash":"7f700187c4a28fe4afa47a0e42b1f70dbadf9d7a","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24416/mbox/","series":[{"id":5450,"url":"https://patchwork.libcamera.org/api/series/5450/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5450","date":"2025-09-19T09:40:15","name":"Implement WDR algorithm","version":5,"mbox":"https://patchwork.libcamera.org/series/5450/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24416/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24416/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2081CC3329\n\tfor ;\n\tFri, 19 Sep 2025 09:41:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9C18E6B5B2;\n\tFri, 19 Sep 2025 11:41:17 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0B38A6B5A5\n\tfor ;\n\tFri, 19 Sep 2025 11:41:14 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:4d54:eab8:98ca:163b])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id CBB7999F;\n\tFri, 19 Sep 2025 11:39:53 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"d4zf0GPT\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1758274793;\n\tbh=GT3SNiwf5b0a23Lu4SX6u1wUMPaGCvMLW+NqlVuAkrw=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=d4zf0GPT874mgHhAo2jgA1PXoUxEEUDGkIRI81XGc3fP6LhRaZXN6YetvvFz+YfdA\n\tHsl0Y0sty2iWrjz7aDUEnpBppNaWUc4R55VIKBtD5/RvokqqUkrfxBHuZR58VdhRsZ\n\tk6Is/wnQQkdsKIYJQ3WAxzzCW0ffCmpBD4nbchW0=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ,\n\tDaniel Scally ,\n\tKieran Bingham ,\n\tPaul Elder ","Subject":"[PATCH v5 07/19] libipa: agc_mean_luminance: Fix constraint logging","Date":"Fri, 19 Sep 2025 11:40:22 +0200","Message-ID":"<20250919094041.183031-8-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.48.1","In-Reply-To":"<20250919094041.183031-1-stefan.klug@ideasonboard.com>","References":"<20250919094041.183031-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The debug log statements in constraintClampGain() are after the\nassignment of gain. So they correctly log when the constraint applies,\nbut the gain values logged are the same. Fix that.\n\nFixes: 42e18c96bcb7 (\"libipa: agc_mean_luminance: Add debug logging\")\nSigned-off-by: Stefan Klug \nReviewed-by: Daniel Scally \nReviewed-by: Kieran Bingham \nReviewed-by: Paul Elder \n\n---\n\nChanges in v4:\n- Collected tags\n\nChanges in v3:\n- Added this patch\n---\n src/ipa/libipa/agc_mean_luminance.cpp | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/src/ipa/libipa/agc_mean_luminance.cpp b/src/ipa/libipa/agc_mean_luminance.cpp\nindex ff96a381ffce..fce1a5064870 100644\n--- a/src/ipa/libipa/agc_mean_luminance.cpp\n+++ b/src/ipa/libipa/agc_mean_luminance.cpp\n@@ -488,18 +488,18 @@ double AgcMeanLuminance::constraintClampGain(uint32_t constraintModeIndex,\n \n \t\tif (constraint.bound == AgcConstraint::Bound::Lower &&\n \t\t newGain > gain) {\n-\t\t\tgain = newGain;\n \t\t\tLOG(AgcMeanLuminance, Debug)\n \t\t\t\t<< \"Apply lower bound: \" << gain << \" to \"\n \t\t\t\t<< newGain;\n+\t\t\tgain = newGain;\n \t\t}\n \n \t\tif (constraint.bound == AgcConstraint::Bound::Upper &&\n \t\t newGain < gain) {\n-\t\t\tgain = newGain;\n \t\t\tLOG(AgcMeanLuminance, Debug)\n \t\t\t\t<< \"Apply upper bound: \" << gain << \" to \"\n \t\t\t\t<< newGain;\n+\t\t\tgain = newGain;\n \t\t}\n \t}\n \n","prefixes":["v5","07/19"]}