{"id":24397,"url":"https://patchwork.libcamera.org/api/patches/24397/?format=json","web_url":"https://patchwork.libcamera.org/patch/24397/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250918144333.108695-9-stefan.klug@ideasonboard.com>","date":"2025-09-18T14:43:17","name":"[v4,08/19] libipa: agc_mean_luminance: Configure the exposure mode helpers","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"13ca149f114e10d907990eefc0947321c3528bdb","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24397/mbox/","series":[{"id":5449,"url":"https://patchwork.libcamera.org/api/series/5449/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5449","date":"2025-09-18T14:43:09","name":"Implement WDR algorithm","version":4,"mbox":"https://patchwork.libcamera.org/series/5449/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24397/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24397/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5BBE4C32C2\n\tfor ;\n\tThu, 18 Sep 2025 14:44:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 949316936F;\n\tThu, 18 Sep 2025 16:44:11 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 556406937D\n\tfor ;\n\tThu, 18 Sep 2025 16:44:09 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:ace3:d2c2:5eff:9cc5])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id B7DD111A0; \n\tThu, 18 Sep 2025 16:42:49 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Ilnynh82\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1758206569;\n\tbh=0vf3lFwYoPER+hvWa/iUoCJV/5mJeZC6GD89iKVaKnw=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=Ilnynh82EwqtqJzpELHgLdvtDKpzWQwXeZwsFPGRtN5sTTLpq3r94lMcM3TJ9gLkF\n\tJUd/xsRFwR18xf3pauuGXnO+jAGIXWtYMiEx1TU4aNGqG4ka7mT6GAft+D6A0Tc5rF\n\tNF7Hjrs9U0cO42ODLLKQUJ05QjyWtFOohTVtjnyk=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ,\n\tDaniel Scally ,\n\tKieran Bingham ,\n\tPaul Elder ","Subject":"[PATCH v4 08/19] libipa: agc_mean_luminance: Configure the exposure\n\tmode helpers","Date":"Thu, 18 Sep 2025 16:43:17 +0200","Message-ID":"<20250918144333.108695-9-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.48.1","In-Reply-To":"<20250918144333.108695-1-stefan.klug@ideasonboard.com>","References":"<20250918144333.108695-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add a function to configure the exposure mode helpers with the line\nlength and sensor helper to take quantization effects into account.\n\nSigned-off-by: Stefan Klug \nReviewed-by: Daniel Scally \nReviewed-by: Kieran Bingham \nReviewed-by: Paul Elder \n\n---\n\nChanges in v4:\n- Fixed wrong variable name in configure() documentation\n- Collected tags\n\nChanges in v3:\n- Renamed lineLength to lineDuration\n- Collected tag\n---\n src/ipa/libipa/agc_mean_luminance.cpp | 15 +++++++++++++++\n src/ipa/libipa/agc_mean_luminance.h | 1 +\n 2 files changed, 16 insertions(+)","diff":"diff --git a/src/ipa/libipa/agc_mean_luminance.cpp b/src/ipa/libipa/agc_mean_luminance.cpp\nindex fce1a5064870..ea4709bf4e49 100644\n--- a/src/ipa/libipa/agc_mean_luminance.cpp\n+++ b/src/ipa/libipa/agc_mean_luminance.cpp\n@@ -311,6 +311,21 @@ int AgcMeanLuminance::parseExposureModes(const YamlObject &tuningData)\n \treturn 0;\n }\n \n+/**\n+ * \\brief Configure the exposure mode helpers\n+ * \\param[in] lineDuration The sensor line length\n+ * \\param[in] sensorHelper The sensor helper\n+ *\n+ * This function configures the exposure mode helpers so they can correctly\n+ * take quantization effects into account.\n+ */\n+void AgcMeanLuminance::configure(utils::Duration lineDuration,\n+\t\t\t\t const CameraSensorHelper *sensorHelper)\n+{\n+\tfor (auto &[id, helper] : exposureModeHelpers_)\n+\t\thelper->configure(lineDuration, sensorHelper);\n+}\n+\n /**\n * \\brief Parse tuning data for AeConstraintMode and AeExposureMode controls\n * \\param[in] tuningData the YamlObject representing the tuning data\ndiff --git a/src/ipa/libipa/agc_mean_luminance.h b/src/ipa/libipa/agc_mean_luminance.h\nindex cad7ef845487..49985481ac51 100644\n--- a/src/ipa/libipa/agc_mean_luminance.h\n+++ b/src/ipa/libipa/agc_mean_luminance.h\n@@ -42,6 +42,7 @@ public:\n \t\tdouble yTarget;\n \t};\n \n+\tvoid configure(utils::Duration lineDuration, const CameraSensorHelper *sensorHelper);\n \tint parseTuningData(const YamlObject &tuningData);\n \n \tvoid setExposureCompensation(double gain)\n","prefixes":["v4","08/19"]}