[{"id":35863,"web_url":"https://patchwork.libcamera.org/comment/35863/","msgid":"<175817881055.17312.15231305102810916320@localhost>","date":"2025-09-18T07:00:10","subject":"Re: [PATCH v3 03/10] Documentation: Enable doxygen-awesome-css","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"content":"Hi Laurent,\n\nThank you for the update.\n\nQuoting Laurent Pinchart (2025-09-17 22:17:34)\n> From: Stefan Klug \n> \n> Include doxygen-awesome-css in the doxygen config.\n> \n> The project's documentation indicated that the HTML_COLORSTYLE option\n> needs to be set to LIGHT starting with Doxygen 1.9.5. The reason isn't\n> explained, and tests have not shown any noticeable difference with\n> Doxygen 1.9.5, 1.13.2 and 1.14.0.\n> \n> Unlike Doxygen itself that generates different CSS files depending on\n> the HTML color style, doxygen-awesome-css use the same CSS that defaults\n> to auto-light, and relies on adding \"light-mode\" to the class of the\n> element manually to disable dark mode.\n> \n> As we don't this, doxygen-awesome-css effectively operates in auto-light\n\ns/don't/don't do/\n\n> mode. Given that setting HTML_COLORSTYLE to LIGHT makes no visible\n> difference, leave the option unset to default to auto-light mode that\n> matches the actual behaviour.\n> \n> Signed-off-by: Stefan Klug \n> Signed-off-by: Laurent Pinchart \n\nCan I put my reviewed-by on something I signed off?\n\nAnyways:\nReviewed-by: Stefan Klug \n\nRegards,\nStefan\n\n> ---\n> Changes since v2:\n> \n> - Drop HTML_COLORSTYLE\n> - Drop GENERATE_TREEVIEW=YES as it is the default\n> \n> Changes since v1:\n> \n> - Fix ordering of configuration options\n> - Use TOP_SRCDIR instead of CURRENT_SRCDIR to avoid introducing a new\n> variable\n> ---\n> Documentation/Doxyfile-common.in | 3 +++\n> 1 file changed, 3 insertions(+)\n> \n> diff --git a/Documentation/Doxyfile-common.in b/Documentation/Doxyfile-common.in\n> index c9527da03ed5..23a0e3626f9d 100644\n> --- a/Documentation/Doxyfile-common.in\n> +++ b/Documentation/Doxyfile-common.in\n> @@ -54,6 +54,9 @@ EXCLUDE_SYMBOLS = libcamera::BoundMethodArgs \\\n> \n> IMAGE_PATH = \"@TOP_SRCDIR@/Documentation/images\"\n> \n> +HTML_EXTRA_STYLESHEET = \"@TOP_SRCDIR@/Documentation/doxygen-awesome-css/doxygen-awesome.css\" \\\n> + \"@TOP_SRCDIR@/Documentation/doxygen-awesome-css/doxygen-awesome-sidebar-only.css\"\n> +\n> GENERATE_LATEX = NO\n> \n> MACRO_EXPANSION = YES\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id ECDD8C328C\n\tfor ;\n\tThu, 18 Sep 2025 07:00:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 960546936D;\n\tThu, 18 Sep 2025 09:00:18 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0F04362C39\n\tfor ;\n\tThu, 18 Sep 2025 09:00:13 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:ace3:d2c2:5eff:9cc5])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 894BF19C4; \n\tThu, 18 Sep 2025 08:58:53 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Y4tZWXyV\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1758178733;\n\tbh=f3MGT6ynmAbp3fsSP5w0oodTjhQkuTgrN24gdDMYd14=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=Y4tZWXyVnFBVMO1RxVGTPXgxEt3QJ/2x2G5mHhsHHTwsR+Lw/qZw28xURS+Or1p85\n\t00Jjug8uktbRKM7IR1b4hGdvfzRo+RoyI9JoVdWGjTVwFTwWsYEk45Noue80U1LWqc\n\tmBdN6PHsv8xBsn9nVGeeL3CKAD0HnvNc2hmauEtA=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250917201742.16406-4-laurent.pinchart@ideasonboard.com>","References":"<20250917201742.16406-1-laurent.pinchart@ideasonboard.com>\n\t<20250917201742.16406-4-laurent.pinchart@ideasonboard.com>","Subject":"Re: [PATCH v3 03/10] Documentation: Enable doxygen-awesome-css","From":"Stefan Klug ","Cc":"","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 18 Sep 2025 09:00:10 +0200","Message-ID":"<175817881055.17312.15231305102810916320@localhost>","User-Agent":"alot/0.12.dev8+g2c003385c862.d20250602","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":35881,"web_url":"https://patchwork.libcamera.org/comment/35881/","msgid":"","date":"2025-09-18T10:16:02","subject":"Re: [PATCH v3 03/10] Documentation: Enable doxygen-awesome-css","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2025. 09. 17. 22:17 keltezéssel, Laurent Pinchart írta:\n> From: Stefan Klug \n> \n> Include doxygen-awesome-css in the doxygen config.\n> \n> The project's documentation indicated that the HTML_COLORSTYLE option\n> needs to be set to LIGHT starting with Doxygen 1.9.5. The reason isn't\n> explained, and tests have not shown any noticeable difference with\n> Doxygen 1.9.5, 1.13.2 and 1.14.0.\n> \n> Unlike Doxygen itself that generates different CSS files depending on\n> the HTML color style, doxygen-awesome-css use the same CSS that defaults\n> to auto-light, and relies on adding \"light-mode\" to the class of the\n> element manually to disable dark mode.\n> \n> As we don't this, doxygen-awesome-css effectively operates in auto-light\n> mode. Given that setting HTML_COLORSTYLE to LIGHT makes no visible\n> difference, leave the option unset to default to auto-light mode that\n> matches the actual behaviour.\n> \n> Signed-off-by: Stefan Klug \n> Signed-off-by: Laurent Pinchart \n> ---\n> Changes since v2:\n> \n> - Drop HTML_COLORSTYLE\n> - Drop GENERATE_TREEVIEW=YES as it is the default\n> \n> Changes since v1:\n> \n> - Fix ordering of configuration options\n> - Use TOP_SRCDIR instead of CURRENT_SRCDIR to avoid introducing a new\n> variable\n> ---\n\nNot setting HTML_COLORSTYLE=LIGHT makes it actually look better in dark mode\nwhen using doxygen 1.14.0 ( avoids https://github.com/jothepro/doxygen-awesome-css/issues/185 ).\n\nReviewed-by: Barnabás Pőcze \n\n\n> Documentation/Doxyfile-common.in | 3 +++\n> 1 file changed, 3 insertions(+)\n> \n> diff --git a/Documentation/Doxyfile-common.in b/Documentation/Doxyfile-common.in\n> index c9527da03ed5..23a0e3626f9d 100644\n> --- a/Documentation/Doxyfile-common.in\n> +++ b/Documentation/Doxyfile-common.in\n> @@ -54,6 +54,9 @@ EXCLUDE_SYMBOLS = libcamera::BoundMethodArgs \\\n> \n> IMAGE_PATH = \"@TOP_SRCDIR@/Documentation/images\"\n> \n> +HTML_EXTRA_STYLESHEET = \"@TOP_SRCDIR@/Documentation/doxygen-awesome-css/doxygen-awesome.css\" \\\n> + \"@TOP_SRCDIR@/Documentation/doxygen-awesome-css/doxygen-awesome-sidebar-only.css\"\n> +\n> GENERATE_LATEX = NO\n> \n> MACRO_EXPANSION = YES","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D4CECBE173\n\tfor ;\n\tThu, 18 Sep 2025 10:16:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B9D396936A;\n\tThu, 18 Sep 2025 12:16:11 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6D8B362C3B\n\tfor ;\n\tThu, 18 Sep 2025 12:16:06 +0200 (CEST)","from [192.168.33.22] (185.221.142.115.nat.pool.zt.hu\n\t[185.221.142.115])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D6A929FC;\n\tThu, 18 Sep 2025 12:14:46 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"qOE1mPBN\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1758190487;\n\tbh=pcGuqy+9iZ9ft0BzV6N2UgTPk4tUFd6KihfC+kD8f6E=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=qOE1mPBNZICVrw9ZP0CclVuGPUhgYBFmxurS53TvZnzqGYO6uZOBbf3EM4wT80DuK\n\tN6DrFqQwqx1au+Quz5MZD60siyqEui+XKg4XJvu5rr1fiCFd1EYfeSkRmvcG17xczd\n\tOG0rwaYxd4Vzzr6Xa9rvWlcn3Fq2iORynd52Bph8=","Message-ID":"","Date":"Thu, 18 Sep 2025 12:16:02 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v3 03/10] Documentation: Enable doxygen-awesome-css","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ","References":"<20250917201742.16406-1-laurent.pinchart@ideasonboard.com>\n\t<20250917201742.16406-4-laurent.pinchart@ideasonboard.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20250917201742.16406-4-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":35902,"web_url":"https://patchwork.libcamera.org/comment/35902/","msgid":"<20250918142109.GL10145@pendragon.ideasonboard.com>","date":"2025-09-18T14:21:09","subject":"Re: [PATCH v3 03/10] Documentation: Enable doxygen-awesome-css","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Thu, Sep 18, 2025 at 09:00:10AM +0200, Stefan Klug wrote:\n> Quoting Laurent Pinchart (2025-09-17 22:17:34)\n> > From: Stefan Klug \n> > \n> > Include doxygen-awesome-css in the doxygen config.\n> > \n> > The project's documentation indicated that the HTML_COLORSTYLE option\n> > needs to be set to LIGHT starting with Doxygen 1.9.5. The reason isn't\n> > explained, and tests have not shown any noticeable difference with\n> > Doxygen 1.9.5, 1.13.2 and 1.14.0.\n> > \n> > Unlike Doxygen itself that generates different CSS files depending on\n> > the HTML color style, doxygen-awesome-css use the same CSS that defaults\n> > to auto-light, and relies on adding \"light-mode\" to the class of the\n> > element manually to disable dark mode.\n> > \n> > As we don't this, doxygen-awesome-css effectively operates in auto-light\n> \n> s/don't/don't do/\n> \n> > mode. Given that setting HTML_COLORSTYLE to LIGHT makes no visible\n> > difference, leave the option unset to default to auto-light mode that\n> > matches the actual behaviour.\n> > \n> > Signed-off-by: Stefan Klug \n> > Signed-off-by: Laurent Pinchart \n> \n> Can I put my reviewed-by on something I signed off?\n\nSure, you've reviewed the changes compared to your initial version.\n\n> Anyways:\n> Reviewed-by: Stefan Klug \n> \n> > ---\n> > Changes since v2:\n> > \n> > - Drop HTML_COLORSTYLE\n> > - Drop GENERATE_TREEVIEW=YES as it is the default\n> > \n> > Changes since v1:\n> > \n> > - Fix ordering of configuration options\n> > - Use TOP_SRCDIR instead of CURRENT_SRCDIR to avoid introducing a new\n> > variable\n> > ---\n> > Documentation/Doxyfile-common.in | 3 +++\n> > 1 file changed, 3 insertions(+)\n> > \n> > diff --git a/Documentation/Doxyfile-common.in b/Documentation/Doxyfile-common.in\n> > index c9527da03ed5..23a0e3626f9d 100644\n> > --- a/Documentation/Doxyfile-common.in\n> > +++ b/Documentation/Doxyfile-common.in\n> > @@ -54,6 +54,9 @@ EXCLUDE_SYMBOLS = libcamera::BoundMethodArgs \\\n> > \n> > IMAGE_PATH = \"@TOP_SRCDIR@/Documentation/images\"\n> > \n> > +HTML_EXTRA_STYLESHEET = \"@TOP_SRCDIR@/Documentation/doxygen-awesome-css/doxygen-awesome.css\" \\\n> > + \"@TOP_SRCDIR@/Documentation/doxygen-awesome-css/doxygen-awesome-sidebar-only.css\"\n> > +\n> > GENERATE_LATEX = NO\n> > \n> > MACRO_EXPANSION = YES","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E916BBE173\n\tfor ;\n\tThu, 18 Sep 2025 14:21:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CA4486936F;\n\tThu, 18 Sep 2025 16:21:39 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AE9DA62C3B\n\tfor ;\n\tThu, 18 Sep 2025 16:21:37 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id C0AFD316;\n\tThu, 18 Sep 2025 16:20:17 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"eBSdBUIV\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1758205218;\n\tbh=0E6+ZMEYTJxV0e7GO87DizGNJz00xJJExjSBdfD8mZg=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=eBSdBUIV7yBLCg6DiMxRdm4/7YXzhVAniJq+Qr4GzNTHS6XZfXPCYlEU4MqNtBcAn\n\tepG5nhQL6R3uBidTQ1twRWcgzQz2RQ7C/q7EP+LY2zKJGsVZIss9tfMhhzLx9IndZo\n\tLKDquLcc8+fznoA2WpQZSSr0rukgWHX/WDM3/v3E=","Date":"Thu, 18 Sep 2025 17:21:09 +0300","From":"Laurent Pinchart ","To":"Stefan Klug ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v3 03/10] Documentation: Enable doxygen-awesome-css","Message-ID":"<20250918142109.GL10145@pendragon.ideasonboard.com>","References":"<20250917201742.16406-1-laurent.pinchart@ideasonboard.com>\n\t<20250917201742.16406-4-laurent.pinchart@ideasonboard.com>\n\t<175817881055.17312.15231305102810916320@localhost>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<175817881055.17312.15231305102810916320@localhost>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]