[{"id":35858,"web_url":"https://patchwork.libcamera.org/comment/35858/","msgid":"<175811769654.1246375.1015855732503869851@ping.linuxembedded.co.uk>","date":"2025-09-17T14:01:36","subject":"Re: [PATCH v2 1/4] libcamera: camera_sensor_properties: Add vd55g1\n\tcamera sensor","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Benjamin Mugnier (2025-09-17 14:42:11)\n> Add unit cell size from the 'pixel size' element in the datasheet.\n> Controls are buffered within the sensor and are always applied at frame\n> N+2.\n\nReviewed-by: Kieran Bingham \n\n> Signed-off-by: Benjamin Mugnier \n> ---\n> src/libcamera/sensor/camera_sensor_properties.cpp | 17 +++++++++++++++++\n> 1 file changed, 17 insertions(+)\n> \n> diff --git a/src/libcamera/sensor/camera_sensor_properties.cpp b/src/libcamera/sensor/camera_sensor_properties.cpp\n> index f2da8205372baabca58416e2c0f9da64e722fe02..09f60391fddba1738a5e2409703f023c9ba1655c 100644\n> --- a/src/libcamera/sensor/camera_sensor_properties.cpp\n> +++ b/src/libcamera/sensor/camera_sensor_properties.cpp\n> @@ -461,6 +461,23 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n> },\n> .sensorDelays = { },\n> } },\n> + { \"vd55g1\", {\n> + .unitCellSize = { 2160, 2160 },\n> + .testPatternModes = {\n> + { controls::draft::TestPatternModeOff, 0 },\n> + { controls::draft::TestPatternModePn9, 2},\n> + /*\n> + * No corresponding test pattern mode for:\n> + * 1: \"Diagonal Gray Scale\"\n> + */\n> + },\n> + .sensorDelays = {\n> + .exposureDelay = 2,\n> + .gainDelay = 2,\n> + .vblankDelay = 2,\n> + .hblankDelay = 2\n> + },\n> + } },\n> { \"vd56g3\", {\n> .unitCellSize = { 2610, 2610 },\n> .testPatternModes = {\n> \n> -- \n> 2.25.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 12E3EBE173\n\tfor ;\n\tWed, 17 Sep 2025 14:01:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AC32769370;\n\tWed, 17 Sep 2025 16:01:40 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7ABF269369\n\tfor ;\n\tWed, 17 Sep 2025 16:01:39 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9E6196AE;\n\tWed, 17 Sep 2025 16:00:20 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"GNEzlFtj\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1758117620;\n\tbh=Xv78XEQDrvuZXTQCkUurdzoILHH4QkMJfwqBVm0zChM=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=GNEzlFtj427skR6NuqHuzMKNPg27kbxzCU55Ec5Hc4VfBRQutHt/TPMG9fcZDIh/b\n\tVO/uqqqTW63b4ER1+6pYvEqRSTvmSd8cQFbeyJWEPUKC9dIJNuufw0+U7VrZ02BUYN\n\tJY7aakPrBLmk1aYqZiw/Jq0m3WUPJ81JrRQrbOpI=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250917-vd55g1_support-v2-1-101b53b66add@foss.st.com>","References":"<20250917-vd55g1_support-v2-0-101b53b66add@foss.st.com>\n\t<20250917-vd55g1_support-v2-1-101b53b66add@foss.st.com>","Subject":"Re: [PATCH v2 1/4] libcamera: camera_sensor_properties: Add vd55g1\n\tcamera sensor","From":"Kieran Bingham ","Cc":"Sylvain Petinot ,\n\tBenjamin Mugnier ","To":"Benjamin Mugnier ,\n\tNaushir Patuck ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Wed, 17 Sep 2025 15:01:36 +0100","Message-ID":"<175811769654.1246375.1015855732503869851@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]