[{"id":35800,"web_url":"https://patchwork.libcamera.org/comment/35800/","msgid":"<175767032488.823480.9777590830679681063@ping.linuxembedded.co.uk>","date":"2025-09-12T09:45:24","subject":"Re: [PATCH] libcamera: libipa: camera_sensor: Add Himax HM1246\n\tsensor properties","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Matthias Fend (2025-09-12 10:13:25)\n> Provide the Himax HM1246 camera sensor properties and registration with\n> libipa for the gain code helpers.\n> \n> Signed-off-by: Matthias Fend <matthias.fend@emfend.at>\n> ---\n> The Himax HM1246-AWD is a 1/3.7-Inch CMOS image sensor SoC with an active\n> array size of 1296 x 976 and parallell interface. The sensor has an\n> integrated ISP that is not supported by the kernel driver. The sensor is\n> therefore operated like a normal sensor in raw mode.\n> \n> The kernel driver required for this is currently under review [1].\n> [1] https://lore.kernel.org/r/20250912-hm1246-v3-0-3b89f47dfa43@emfend.at\n\nPublic driver makes the sensor helpers eligible to merge!\n\nWait - the datasheet is public from himax themselves!\n\nhttps://www.himax.com.tw/wp-content/uploads/2024/03/HM1246-AWD_DS_v01.pdf\n\nExcellent...\n\n✓ Pixel Size and Technology 3.0µm x 3.0µm\n✓ Analog gain = X = (ANALOG_GLOBAL_GAIN [7:0] + 16) / 16\n\nSometime soon I hope we'll have a camera calibration tool to be able to\nvalidate the helpers or support creating them even without datasheets.\nParticularly on the delays which are harder to interpret. But I think\nthis is fine to merge, as I anticipate you've been testing this on\ni.MX8MP so if the delays were wrong you would have seen already.\n\n\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\n\n> ---\n>  src/ipa/libipa/camera_sensor_helper.cpp           | 10 +++++++\n>  src/libcamera/sensor/camera_sensor_properties.cpp | 32 +++++++++++++++++++++++\n>  2 files changed, 42 insertions(+)\n> \n> diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\n> index dcd69d9f2bbb39feabfefe41cee8b45f0f958127..df93c0fdeb9c5ae2c3e3dc51dabc62ba4082c0d7 100644\n> --- a/src/ipa/libipa/camera_sensor_helper.cpp\n> +++ b/src/ipa/libipa/camera_sensor_helper.cpp\n> @@ -497,6 +497,16 @@ public:\n>  };\n>  REGISTER_CAMERA_SENSOR_HELPER(\"gc08a3\", CameraSensorHelperGc08a3)\n>  \n> +class CameraSensorHelperHm1246 : public CameraSensorHelper\n> +{\n> +public:\n> +       CameraSensorHelperHm1246()\n> +       {\n> +               gain_ = AnalogueGainLinear{ 1, 16, 0, 16 };\n\nAnd I've validated this against the datasheet with:\n\nhttps://git.uk.ideasonboard.com/kbingham/octave-gains/pulls/1\n\n\n\n> +       }\n> +};\n> +REGISTER_CAMERA_SENSOR_HELPER(\"hm1246\", CameraSensorHelperHm1246)\n> +\n>  class CameraSensorHelperImx214 : public CameraSensorHelper\n>  {\n>  public:\n> diff --git a/src/libcamera/sensor/camera_sensor_properties.cpp b/src/libcamera/sensor/camera_sensor_properties.cpp\n> index f2da8205372baabca58416e2c0f9da64e722fe02..810f0199d41f0582e120687b304c3ff549a19bc8 100644\n> --- a/src/libcamera/sensor/camera_sensor_properties.cpp\n> +++ b/src/libcamera/sensor/camera_sensor_properties.cpp\n> @@ -151,6 +151,38 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n>                         },\n>                         .sensorDelays = { },\n>                 } },\n> +               { \"hm1246\", {\n> +                       .unitCellSize = { 3000, 3000 },\n> +                       .testPatternModes =  {\n> +                               { controls::draft::TestPatternModeOff, 0 },\n> +                               /* Solid white. */\n> +                               { controls::draft::TestPatternModeSolidColor, 6 },\n> +                               /* The six vertical bars (left-to-right) are as follows: black,\n> +                                * blue, red, magenta, green and cyan.\n> +                                */\n> +                               { controls::draft::TestPatternModeCustom1, 5 },\n> +                               /*\n> +                                * No corresponding test pattern mode for:\n> +                                *  1: \"Checkboard\"\n> +                                *  2: \"Ramp\"\n> +                                *  3: \"Moving ones\"\n> +                                *  4: \"Blending color bars\"\n> +                                *  7: \"Solid black\"\n> +                                *  8: \"Solid red\"\n> +                                *  9: \"Solid green\"\n> +                                * 10: \"Solid blue\"\n> +                                *\n> +                                * Even though the sensor supports color bars and faded color bars as test patterns, these are\n> +                                * not offered because these patterns do not meet the expected properties.\n> +                                */\n> +                       },\n> +                       .sensorDelays = {\n> +                               .exposureDelay = 2,\n> +                               .gainDelay = 2,\n> +                               .vblankDelay = 2,\n> +                               .hblankDelay = 2\n> +                       },\n> +               } },\n>                 { \"imx214\", {\n>                         .unitCellSize = { 1120, 1120 },\n>                         .testPatternModes = {\n> \n> ---\n> base-commit: b8d332cdcc130c27232f61369e7bab2d954e7ac6\n> change-id: 20250912-hm1246-5550b4d5d16e\n> \n> Best regards,\n> -- \n> Matthias Fend <matthias.fend@emfend.at>\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2EBE6C324E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 12 Sep 2025 09:45:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DB5F869367;\n\tFri, 12 Sep 2025 11:45:28 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8038469367\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 12 Sep 2025 11:45:27 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6E775F6;\n\tFri, 12 Sep 2025 11:44:12 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Wc9tzc9Z\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1757670252;\n\tbh=Cumt/x1f3y1CxXnlajnPgNdzGkRzGQcpUlj4KJvy4AY=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=Wc9tzc9ZHK3oPSC685Y5dkg20IHAIBIGRe/h9ohDQVFM7keVQpTp2q5ZA1xp5/hQb\n\tYFUhJfnHP8Ah4+OUUpbObzP9G/jwxwZlXISo5sQ6kFNQlkvVGD4Gl9PTNxmj3x0X9y\n\tDS29ABVWNApXw5P0kEcqx5ZFK+PyuJPJmwGedYWw=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250912-hm1246-v1-1-58c814f52a26@emfend.at>","References":"<20250912-hm1246-v1-1-58c814f52a26@emfend.at>","Subject":"Re: [PATCH] libcamera: libipa: camera_sensor: Add Himax HM1246\n\tsensor properties","From":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Cc":"Matthias Fend <matthias.fend@emfend.at>","To":"Matthias Fend <matthias.fend@emfend.at>,\n\tlibcamera-devel@lists.libcamera.org","Date":"Fri, 12 Sep 2025 10:45:24 +0100","Message-ID":"<175767032488.823480.9777590830679681063@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":35805,"web_url":"https://patchwork.libcamera.org/comment/35805/","msgid":"<bd6ed7ea-dfbf-4da6-8c32-164cc5dafe02@emfend.at>","date":"2025-09-12T12:37:01","subject":"Re: [PATCH] libcamera: libipa: camera_sensor: Add Himax HM1246\n\tsensor properties","submitter":{"id":134,"url":"https://patchwork.libcamera.org/api/people/134/","name":"Matthias Fend","email":"matthias.fend@emfend.at"},"content":"Hi Kieran,\n\nthank you for your review and for checking the gain parameters.\n\nAm 12.09.2025 um 11:45 schrieb Kieran Bingham:\n> Quoting Matthias Fend (2025-09-12 10:13:25)\n>> Provide the Himax HM1246 camera sensor properties and registration with\n>> libipa for the gain code helpers.\n>>\n>> Signed-off-by: Matthias Fend <matthias.fend@emfend.at>\n>> ---\n>> The Himax HM1246-AWD is a 1/3.7-Inch CMOS image sensor SoC with an active\n>> array size of 1296 x 976 and parallell interface. The sensor has an\n>> integrated ISP that is not supported by the kernel driver. The sensor is\n>> therefore operated like a normal sensor in raw mode.\n>>\n>> The kernel driver required for this is currently under review [1].\n>> [1] https://lore.kernel.org/r/20250912-hm1246-v3-0-3b89f47dfa43@emfend.at\n> \n> Public driver makes the sensor helpers eligible to merge!\n> \n> Wait - the datasheet is public from himax themselves!\n> \n> https://www.himax.com.tw/wp-content/uploads/2024/03/HM1246-AWD_DS_v01.pdf\n> \n> Excellent...\n> \n> ✓ Pixel Size and Technology 3.0µm x 3.0µm\n> ✓ Analog gain = X = (ANALOG_GLOBAL_GAIN [7:0] + 16) / 16\n> \n> Sometime soon I hope we'll have a camera calibration tool to be able to\n> validate the helpers or support creating them even without datasheets.\n> Particularly on the delays which are harder to interpret. But I think\n> this is fine to merge, as I anticipate you've been testing this on\n> i.MX8MP so if the delays were wrong you would have seen already.\n\nYes, that would be really great. I would also be interested to know how \nothers check these settings in practice.\n\nIMHO the most interesting settings are exposure and gain. I usually \ncheck these by alternating between pairs of values that should result in \nthe same image brightness. If the brightness does not change and there \nis no flickering, the delays and gain calculation are most likely correct.\n\nI have done this in a semi-manual process so far, but I think it could \nalso be automated to a certain extent.\n\n> \n> \n> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n> \n> \n>> ---\n>>   src/ipa/libipa/camera_sensor_helper.cpp           | 10 +++++++\n>>   src/libcamera/sensor/camera_sensor_properties.cpp | 32 +++++++++++++++++++++++\n>>   2 files changed, 42 insertions(+)\n>>\n>> diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\n>> index dcd69d9f2bbb39feabfefe41cee8b45f0f958127..df93c0fdeb9c5ae2c3e3dc51dabc62ba4082c0d7 100644\n>> --- a/src/ipa/libipa/camera_sensor_helper.cpp\n>> +++ b/src/ipa/libipa/camera_sensor_helper.cpp\n>> @@ -497,6 +497,16 @@ public:\n>>   };\n>>   REGISTER_CAMERA_SENSOR_HELPER(\"gc08a3\", CameraSensorHelperGc08a3)\n>>   \n>> +class CameraSensorHelperHm1246 : public CameraSensorHelper\n>> +{\n>> +public:\n>> +       CameraSensorHelperHm1246()\n>> +       {\n>> +               gain_ = AnalogueGainLinear{ 1, 16, 0, 16 };\n> \n> And I've validated this against the datasheet with:\n> \n> https://git.uk.ideasonboard.com/kbingham/octave-gains/pulls/1\n\nThanks for your efforts!\n\n~Matthias\n\n> \n> \n> \n>> +       }\n>> +};\n>> +REGISTER_CAMERA_SENSOR_HELPER(\"hm1246\", CameraSensorHelperHm1246)\n>> +\n>>   class CameraSensorHelperImx214 : public CameraSensorHelper\n>>   {\n>>   public:\n>> diff --git a/src/libcamera/sensor/camera_sensor_properties.cpp b/src/libcamera/sensor/camera_sensor_properties.cpp\n>> index f2da8205372baabca58416e2c0f9da64e722fe02..810f0199d41f0582e120687b304c3ff549a19bc8 100644\n>> --- a/src/libcamera/sensor/camera_sensor_properties.cpp\n>> +++ b/src/libcamera/sensor/camera_sensor_properties.cpp\n>> @@ -151,6 +151,38 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n>>                          },\n>>                          .sensorDelays = { },\n>>                  } },\n>> +               { \"hm1246\", {\n>> +                       .unitCellSize = { 3000, 3000 },\n>> +                       .testPatternModes =  {\n>> +                               { controls::draft::TestPatternModeOff, 0 },\n>> +                               /* Solid white. */\n>> +                               { controls::draft::TestPatternModeSolidColor, 6 },\n>> +                               /* The six vertical bars (left-to-right) are as follows: black,\n>> +                                * blue, red, magenta, green and cyan.\n>> +                                */\n>> +                               { controls::draft::TestPatternModeCustom1, 5 },\n>> +                               /*\n>> +                                * No corresponding test pattern mode for:\n>> +                                *  1: \"Checkboard\"\n>> +                                *  2: \"Ramp\"\n>> +                                *  3: \"Moving ones\"\n>> +                                *  4: \"Blending color bars\"\n>> +                                *  7: \"Solid black\"\n>> +                                *  8: \"Solid red\"\n>> +                                *  9: \"Solid green\"\n>> +                                * 10: \"Solid blue\"\n>> +                                *\n>> +                                * Even though the sensor supports color bars and faded color bars as test patterns, these are\n>> +                                * not offered because these patterns do not meet the expected properties.\n>> +                                */\n>> +                       },\n>> +                       .sensorDelays = {\n>> +                               .exposureDelay = 2,\n>> +                               .gainDelay = 2,\n>> +                               .vblankDelay = 2,\n>> +                               .hblankDelay = 2\n>> +                       },\n>> +               } },\n>>                  { \"imx214\", {\n>>                          .unitCellSize = { 1120, 1120 },\n>>                          .testPatternModes = {\n>>\n>> ---\n>> base-commit: b8d332cdcc130c27232f61369e7bab2d954e7ac6\n>> change-id: 20250912-hm1246-5550b4d5d16e\n>>\n>> Best regards,\n>> -- \n>> Matthias Fend <matthias.fend@emfend.at>\n>>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A77CFC324E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 12 Sep 2025 12:37:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 70B7B6936F;\n\tFri, 12 Sep 2025 14:37:03 +0200 (CEST)","from rmisp-mx-out2.tele.net (rmisp-mx-out2.tele.net\n\t[194.208.23.37])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 13B4269367\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 12 Sep 2025 14:37:01 +0200 (CEST)","from [192.168.0.207] (194-208-208-245.tele.net [194.208.208.245])\n\tby rmisp-mx-out2.tele.net (Postfix) with ESMTPA id 6380B1052E60;\n\tFri, 12 Sep 2025 14:37:01 +0200 (CEST)"],"Message-ID":"<bd6ed7ea-dfbf-4da6-8c32-164cc5dafe02@emfend.at>","Date":"Fri, 12 Sep 2025 14:37:01 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH] libcamera: libipa: camera_sensor: Add Himax HM1246\n\tsensor properties","To":"Kieran Bingham <kieran.bingham@ideasonboard.com>,\n\tlibcamera-devel@lists.libcamera.org","References":"<20250912-hm1246-v1-1-58c814f52a26@emfend.at>\n\t<175767032488.823480.9777590830679681063@ping.linuxembedded.co.uk>","Content-Language":"de-DE","From":"Matthias Fend <matthias.fend@emfend.at>","In-Reply-To":"<175767032488.823480.9777590830679681063@ping.linuxembedded.co.uk>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":35848,"web_url":"https://patchwork.libcamera.org/comment/35848/","msgid":"<175809699219.2724359.5459813382319752774@neptunite.rasen.tech>","date":"2025-09-17T08:16:32","subject":"Re: [PATCH] libcamera: libipa: camera_sensor: Add Himax HM1246\n\tsensor properties","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Matthias,\n\nThanks for the patch.\n\nQuoting Matthias Fend (2025-09-12 18:13:25)\n> Provide the Himax HM1246 camera sensor properties and registration with\n> libipa for the gain code helpers.\n> \n> Signed-off-by: Matthias Fend <matthias.fend@emfend.at>\n\nLooks good to me.\n\nReviewed-by: Paul Elder <paul.elder@ideasonboard.com>\n\n> ---\n> The Himax HM1246-AWD is a 1/3.7-Inch CMOS image sensor SoC with an active\n> array size of 1296 x 976 and parallell interface. The sensor has an\n> integrated ISP that is not supported by the kernel driver. The sensor is\n> therefore operated like a normal sensor in raw mode.\n> \n> The kernel driver required for this is currently under review [1].\n> [1] https://lore.kernel.org/r/20250912-hm1246-v3-0-3b89f47dfa43@emfend.at\n> ---\n>  src/ipa/libipa/camera_sensor_helper.cpp           | 10 +++++++\n>  src/libcamera/sensor/camera_sensor_properties.cpp | 32 +++++++++++++++++++++++\n>  2 files changed, 42 insertions(+)\n> \n> diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\n> index dcd69d9f2bbb39feabfefe41cee8b45f0f958127..df93c0fdeb9c5ae2c3e3dc51dabc62ba4082c0d7 100644\n> --- a/src/ipa/libipa/camera_sensor_helper.cpp\n> +++ b/src/ipa/libipa/camera_sensor_helper.cpp\n> @@ -497,6 +497,16 @@ public:\n>  };\n>  REGISTER_CAMERA_SENSOR_HELPER(\"gc08a3\", CameraSensorHelperGc08a3)\n>  \n> +class CameraSensorHelperHm1246 : public CameraSensorHelper\n> +{\n> +public:\n> +       CameraSensorHelperHm1246()\n> +       {\n> +               gain_ = AnalogueGainLinear{ 1, 16, 0, 16 };\n> +       }\n> +};\n> +REGISTER_CAMERA_SENSOR_HELPER(\"hm1246\", CameraSensorHelperHm1246)\n> +\n>  class CameraSensorHelperImx214 : public CameraSensorHelper\n>  {\n>  public:\n> diff --git a/src/libcamera/sensor/camera_sensor_properties.cpp b/src/libcamera/sensor/camera_sensor_properties.cpp\n> index f2da8205372baabca58416e2c0f9da64e722fe02..810f0199d41f0582e120687b304c3ff549a19bc8 100644\n> --- a/src/libcamera/sensor/camera_sensor_properties.cpp\n> +++ b/src/libcamera/sensor/camera_sensor_properties.cpp\n> @@ -151,6 +151,38 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n>                         },\n>                         .sensorDelays = { },\n>                 } },\n> +               { \"hm1246\", {\n> +                       .unitCellSize = { 3000, 3000 },\n> +                       .testPatternModes =  {\n> +                               { controls::draft::TestPatternModeOff, 0 },\n> +                               /* Solid white. */\n> +                               { controls::draft::TestPatternModeSolidColor, 6 },\n> +                               /* The six vertical bars (left-to-right) are as follows: black,\n> +                                * blue, red, magenta, green and cyan.\n> +                                */\n> +                               { controls::draft::TestPatternModeCustom1, 5 },\n> +                               /*\n> +                                * No corresponding test pattern mode for:\n> +                                *  1: \"Checkboard\"\n> +                                *  2: \"Ramp\"\n> +                                *  3: \"Moving ones\"\n> +                                *  4: \"Blending color bars\"\n> +                                *  7: \"Solid black\"\n> +                                *  8: \"Solid red\"\n> +                                *  9: \"Solid green\"\n> +                                * 10: \"Solid blue\"\n> +                                *\n> +                                * Even though the sensor supports color bars and faded color bars as test patterns, these are\n> +                                * not offered because these patterns do not meet the expected properties.\n> +                                */\n> +                       },\n> +                       .sensorDelays = {\n> +                               .exposureDelay = 2,\n> +                               .gainDelay = 2,\n> +                               .vblankDelay = 2,\n> +                               .hblankDelay = 2\n> +                       },\n> +               } },\n>                 { \"imx214\", {\n>                         .unitCellSize = { 1120, 1120 },\n>                         .testPatternModes = {\n> \n> ---\n> base-commit: b8d332cdcc130c27232f61369e7bab2d954e7ac6\n> change-id: 20250912-hm1246-5550b4d5d16e\n> \n> Best regards,\n> -- \n> Matthias Fend <matthias.fend@emfend.at>\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 98BA7C328C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 17 Sep 2025 08:16:43 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D4D076936F;\n\tWed, 17 Sep 2025 10:16:41 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 61D6662C3A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 17 Sep 2025 10:16:40 +0200 (CEST)","from neptunite.rasen.tech (unknown\n\t[IPv6:2404:7a81:160:2100:b5ec:f217:6590:d4ee])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id DD0703A4;\n\tWed, 17 Sep 2025 10:15:20 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"TtcXRj4X\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1758096921;\n\tbh=e19hcsfJtS9s3m7mom35sdNChcg09UzjlRjD+FVY5wQ=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=TtcXRj4Xr6jZx8m6sFHcv5ss7oSBd9SGu89T/BYZZakmaqr80P+tUa3y9A4293EIZ\n\tL0ofHocW0gajij+X7Va6uoIFuXPFrjyDKp34Ce1azu3J8cz/LIjPBQanNOfTbesqcd\n\tSDr6iqmMr/EjbCjtXuIex+W3J2ajbH7qkuoRTzRY=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250912-hm1246-v1-1-58c814f52a26@emfend.at>","References":"<20250912-hm1246-v1-1-58c814f52a26@emfend.at>","Subject":"Re: [PATCH] libcamera: libipa: camera_sensor: Add Himax HM1246\n\tsensor properties","From":"Paul Elder <paul.elder@ideasonboard.com>","Cc":"Matthias Fend <matthias.fend@emfend.at>","To":"Matthias Fend <matthias.fend@emfend.at>,\n\tlibcamera-devel@lists.libcamera.org","Date":"Wed, 17 Sep 2025 17:16:32 +0900","Message-ID":"<175809699219.2724359.5459813382319752774@neptunite.rasen.tech>","User-Agent":"alot/0.0.0","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]