[{"id":35840,"web_url":"https://patchwork.libcamera.org/comment/35840/","msgid":"<175802108797.103890.375361290232953621@isaac-ThinkPad-T16-Gen-2>","date":"2025-09-16T11:11:27","subject":"Re: [PATCH v2 5/5] rkisp1: Add support for camera flash devices","submitter":{"id":215,"url":"https://patchwork.libcamera.org/api/people/215/","name":"Isaac Scott","email":"isaac.scott@ideasonboard.com"},"content":"Hi Matthias,\n\nThank you for the patch!\n\nQuoting Matthias Fend (2025-09-12 08:13:24)\n> Use the flash device pipeline helpers to bring flash support to the\n> RKISP1 pipeline.\n> \n> Signed-off-by: Matthias Fend \n> ---\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 5 +++++\n> 1 file changed, 5 insertions(+)\n> \n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> index cfcbb3b2590a293106cb4d1a5c5c6adb504a61af..44ffc9b68d17f271fbab5867cc72b4d4f9330381 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> @@ -39,6 +39,7 @@\n> #include \"libcamera/internal/converter/converter_v4l2_m2m.h\"\n> #include \"libcamera/internal/delayed_controls.h\"\n> #include \"libcamera/internal/device_enumerator.h\"\n> +#include \"libcamera/internal/flash_control.h\"\n> #include \"libcamera/internal/framebuffer.h\"\n> #include \"libcamera/internal/ipa_manager.h\"\n> #include \"libcamera/internal/media_device.h\"\n> @@ -1296,6 +1297,8 @@ int PipelineHandlerRkISP1::updateControls(RkISP1CameraData *data)\n> activeCrop_ = scalerMaxCrop_;\n> }\n> \n> + FlashControl::updateFlashControls(data->sensor_->flash(), controls);\n> +\n> /* Add the IPA registered controls to list of camera controls. */\n> for (const auto &ipaControl : data->ipaControls_)\n> controls[ipaControl.first] = ipaControl.second;\n> @@ -1503,6 +1506,8 @@ void PipelineHandlerRkISP1::imageBufferReady(FrameBuffer *buffer)\n> info->metadataProcessed = true;\n> }\n> \n> + FlashControl::handleFlashControls(data->sensor_->flash(), request->controls(), request->metadata());\n> +\n\nNice!\n\nReviewed-by: Isaac Scott \n\n> if (!useDewarper_) {\n> completeBuffer(request, buffer);\n> tryCompleteRequest(info);\n> \n> -- \n> 2.34.1\n> \n\nBest wishes,\n\nIsaac","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 78871BE173\n\tfor ;\n\tTue, 16 Sep 2025 11:11:33 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 21E2F69371;\n\tTue, 16 Sep 2025 13:11:33 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 79726613A1\n\tfor ;\n\tTue, 16 Sep 2025 13:11:31 +0200 (CEST)","from thinkpad.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 693666DF;\n\tTue, 16 Sep 2025 13:10:13 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"tnm7pvwC\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1758021013;\n\tbh=pZApMJNzTWlJzegDw4dgrT4Y4EvhXbdqBcx5RY8S3yg=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=tnm7pvwCTKX2A1QOjskYa5cphKtvvs27KP2Gr+mu3VDlTKMJhEVyBx6mIAfhMPe0i\n\t140kHbAQ1xMXs8cUdH67uFR49s5qdE/v7RAjHSujjYYerD2d8IqKCy9xwQ7ThGt/eh\n\teKcU4D2CVQkVAhqaiIn7/yoMdDa710CA+zprMINc=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250912-flash_reco-v2-5-d5bb80a2e619@emfend.at>","References":"<20250912-flash_reco-v2-0-d5bb80a2e619@emfend.at>\n\t<20250912-flash_reco-v2-5-d5bb80a2e619@emfend.at>","Subject":"Re: [PATCH v2 5/5] rkisp1: Add support for camera flash devices","From":"Isaac Scott ","Cc":"Matthias Fend ","To":"Matthias Fend ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 16 Sep 2025 12:11:27 +0100","Message-ID":"<175802108797.103890.375361290232953621@isaac-ThinkPad-T16-Gen-2>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]