[{"id":35802,"web_url":"https://patchwork.libcamera.org/comment/35802/","msgid":"","date":"2025-09-12T11:00:16","subject":"Re: [PATCH v2 04/10] Documentation: Enable doxygen-awesome-css","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2025. 09. 12. 1:01 keltezéssel, Laurent Pinchart írta:\n> From: Stefan Klug \n> \n> Include doxygen-awesome-css in the doxygen config.\n> \n> Signed-off-by: Stefan Klug \n> ---\n> Changes since v1:\n> \n> - Fix ordering of configuration options\n> - Use TOP_SRCDIR instead of CURRENT_SRCDIR to avoid introducing a new\n> variable\n> ---\n> Documentation/Doxyfile-common.in | 5 +++++\n> 1 file changed, 5 insertions(+)\n> \n> diff --git a/Documentation/Doxyfile-common.in b/Documentation/Doxyfile-common.in\n> index c9527da03ed5..2844d215bc60 100644\n> --- a/Documentation/Doxyfile-common.in\n> +++ b/Documentation/Doxyfile-common.in\n> @@ -54,6 +54,11 @@ EXCLUDE_SYMBOLS = libcamera::BoundMethodArgs \\\n> \n> IMAGE_PATH = \"@TOP_SRCDIR@/Documentation/images\"\n> \n> +HTML_EXTRA_STYLESHEET = \"@TOP_SRCDIR@/Documentation/doxygen-awesome-css/doxygen-awesome.css\" \\\n> + \"@TOP_SRCDIR@/Documentation/doxygen-awesome-css/doxygen-awesome-sidebar-only.css\"\n> +HTML_COLORSTYLE = LIGHT # required with Doxygen >= 1.9.5\n\nUnfortunately while testing locally I ran into a compatibility issue: https://github.com/jothepro/doxygen-awesome-css/issues/185\nExample: https://ibb.co/d0GQWQ1m I suppose the trick is not to update doxygen until is\naddressed in some capacity...\n\n\nRegards,\nBarnabás Pőcze\n\n> +\n> +GENERATE_TREEVIEW = YES\n> GENERATE_LATEX = NO\n> \n> MACRO_EXPANSION = YES","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 69BAABDB13\n\tfor ;\n\tFri, 12 Sep 2025 11:00:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3A4BB6936F;\n\tFri, 12 Sep 2025 13:00:23 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 30BF569367\n\tfor ;\n\tFri, 12 Sep 2025 13:00:21 +0200 (CEST)","from [192.168.33.2] (185.221.142.115.nat.pool.zt.hu\n\t[185.221.142.115])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 745BD11DE;\n\tFri, 12 Sep 2025 12:59:05 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ZH3g3reW\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1757674745;\n\tbh=R1xIJpviJ1PD6p3k8pTmPTL3RfRwnJe0DCdk19QIFYg=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=ZH3g3reWjRCc0VZwPabSPYrzsXnrichgJuZz+yNJEDdwtshaHPcI4eP6dnnTj6o3z\n\tODASw6Iwf1zepjFKky6MXhe2yJSJ9SEVM33hyvtEZWUpZAWsv/2kxFjv0HjH5jXjEm\n\tUttyRC2fAmxtsX7cqmgG/iq/VcOID51jiTf/+sGY=","Message-ID":"","Date":"Fri, 12 Sep 2025 13:00:16 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 04/10] Documentation: Enable doxygen-awesome-css","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ","References":"<20250911230115.25335-1-laurent.pinchart@ideasonboard.com>\n\t<20250911230115.25335-5-laurent.pinchart@ideasonboard.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20250911230115.25335-5-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":35812,"web_url":"https://patchwork.libcamera.org/comment/35812/","msgid":"<20250912171003.GB29172@pendragon.ideasonboard.com>","date":"2025-09-12T17:10:03","subject":"Re: [PATCH v2 04/10] Documentation: Enable doxygen-awesome-css","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Fri, Sep 12, 2025 at 01:00:16PM +0200, Barnabás Pőcze wrote:\n> 2025. 09. 12. 1:01 keltezéssel, Laurent Pinchart írta:\n> > From: Stefan Klug \n> > \n> > Include doxygen-awesome-css in the doxygen config.\n> > \n> > Signed-off-by: Stefan Klug \n> > ---\n> > Changes since v1:\n> > \n> > - Fix ordering of configuration options\n> > - Use TOP_SRCDIR instead of CURRENT_SRCDIR to avoid introducing a new\n> > variable\n> > ---\n> > Documentation/Doxyfile-common.in | 5 +++++\n> > 1 file changed, 5 insertions(+)\n> > \n> > diff --git a/Documentation/Doxyfile-common.in b/Documentation/Doxyfile-common.in\n> > index c9527da03ed5..2844d215bc60 100644\n> > --- a/Documentation/Doxyfile-common.in\n> > +++ b/Documentation/Doxyfile-common.in\n> > @@ -54,6 +54,11 @@ EXCLUDE_SYMBOLS = libcamera::BoundMethodArgs \\\n> > \n> > IMAGE_PATH = \"@TOP_SRCDIR@/Documentation/images\"\n> > \n> > +HTML_EXTRA_STYLESHEET = \"@TOP_SRCDIR@/Documentation/doxygen-awesome-css/doxygen-awesome.css\" \\\n> > + \"@TOP_SRCDIR@/Documentation/doxygen-awesome-css/doxygen-awesome-sidebar-only.css\"\n> > +HTML_COLORSTYLE = LIGHT # required with Doxygen >= 1.9.5\n> \n> Unfortunately while testing locally I ran into a compatibility issue: https://github.com/jothepro/doxygen-awesome-css/issues/185\n> Example: https://ibb.co/d0GQWQ1m I suppose the trick is not to update doxygen until is\n> addressed in some capacity...\n\nThe bug report indicates an issue with dark mode, while here we enable\nlight mode. Is there an issue with light mode too ? Or is there a\nproblem only for people who wants to switch to dark mode, overriding the\nlibcamera default configuration ?\n\n> > +\n> > +GENERATE_TREEVIEW = YES\n> > GENERATE_LATEX = NO\n> > \n> > MACRO_EXPANSION = YES\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 10B52C324E\n\tfor ;\n\tFri, 12 Sep 2025 17:10:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 161766936F;\n\tFri, 12 Sep 2025 19:10:31 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7E13F69367\n\tfor ;\n\tFri, 12 Sep 2025 19:10:29 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id D4A792C5;\n\tFri, 12 Sep 2025 19:09:13 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ZjLVwzex\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1757696954;\n\tbh=p1MwMTlmdtOwQ4s8LiEdjRbmwLqlioi6d2w6Mwy1/yw=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ZjLVwzexYCI8nW7sadL4d4qC2iiZVbMZXz5NAS0nNHxxR3wDPIAWyCmvqpZAtD460\n\t6EcENu0x4ptGa5PCx0iHSDWjPqBNfFvbL/CwbJbGdONE/1c6KtlxrBaKigfwSCTBT0\n\tzuhZstDiPRmIyQBG4jIRlwBhcsZdgncerYWLpb6g=","Date":"Fri, 12 Sep 2025 20:10:03 +0300","From":"Laurent Pinchart ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org,\n\tStefan Klug ","Subject":"Re: [PATCH v2 04/10] Documentation: Enable doxygen-awesome-css","Message-ID":"<20250912171003.GB29172@pendragon.ideasonboard.com>","References":"<20250911230115.25335-1-laurent.pinchart@ideasonboard.com>\n\t<20250911230115.25335-5-laurent.pinchart@ideasonboard.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":35820,"web_url":"https://patchwork.libcamera.org/comment/35820/","msgid":"","date":"2025-09-15T08:23:05","subject":"Re: [PATCH v2 04/10] Documentation: Enable doxygen-awesome-css","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"Hi\n\n2025. 09. 12. 19:10 keltezéssel, Laurent Pinchart írta:\n> On Fri, Sep 12, 2025 at 01:00:16PM +0200, Barnabás Pőcze wrote:\n>> 2025. 09. 12. 1:01 keltezéssel, Laurent Pinchart írta:\n>>> From: Stefan Klug \n>>>\n>>> Include doxygen-awesome-css in the doxygen config.\n>>>\n>>> Signed-off-by: Stefan Klug \n>>> ---\n>>> Changes since v1:\n>>>\n>>> - Fix ordering of configuration options\n>>> - Use TOP_SRCDIR instead of CURRENT_SRCDIR to avoid introducing a new\n>>> variable\n>>> ---\n>>> Documentation/Doxyfile-common.in | 5 +++++\n>>> 1 file changed, 5 insertions(+)\n>>>\n>>> diff --git a/Documentation/Doxyfile-common.in b/Documentation/Doxyfile-common.in\n>>> index c9527da03ed5..2844d215bc60 100644\n>>> --- a/Documentation/Doxyfile-common.in\n>>> +++ b/Documentation/Doxyfile-common.in\n>>> @@ -54,6 +54,11 @@ EXCLUDE_SYMBOLS = libcamera::BoundMethodArgs \\\n>>> \n>>> IMAGE_PATH = \"@TOP_SRCDIR@/Documentation/images\"\n>>> \n>>> +HTML_EXTRA_STYLESHEET = \"@TOP_SRCDIR@/Documentation/doxygen-awesome-css/doxygen-awesome.css\" \\\n>>> + \"@TOP_SRCDIR@/Documentation/doxygen-awesome-css/doxygen-awesome-sidebar-only.css\"\n>>> +HTML_COLORSTYLE = LIGHT # required with Doxygen >= 1.9.5\n>>\n>> Unfortunately while testing locally I ran into a compatibility issue: https://github.com/jothepro/doxygen-awesome-css/issues/185\n>> Example: https://ibb.co/d0GQWQ1m I suppose the trick is not to update doxygen until is\n>> addressed in some capacity...\n> \n> The bug report indicates an issue with dark mode, while here we enable\n> light mode. Is there an issue with light mode too ? Or is there a\n> problem only for people who wants to switch to dark mode, overriding the\n> libcamera default configuration ?\n\nBut the documentation appears to me with a dark theme \"out of the box\" (even if `HTML_COLORSTYLE = LIGHT`).\nIt seems to me that that option has no effect if doxygen-awesome-css is used. And in that case the\nissue I described is present, at least as long as doxygen 1.14 (or newer?) is used.\n\n\nRegards,\nBarnabás Pőcze\n\n> \n>>> +\n>>> +GENERATE_TREEVIEW = YES\n>>> GENERATE_LATEX = NO\n>>> \n>>> MACRO_EXPANSION = YES\n>>\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4FF49BE173\n\tfor ;\n\tMon, 15 Sep 2025 08:23:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F2B6F6936F;\n\tMon, 15 Sep 2025 10:23:13 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 22E2869367\n\tfor ;\n\tMon, 15 Sep 2025 10:23:11 +0200 (CEST)","from [192.168.33.2] (185.221.142.115.nat.pool.zt.hu\n\t[185.221.142.115])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7B1678D4;\n\tMon, 15 Sep 2025 10:21:52 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Lmm97Jqs\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1757924513;\n\tbh=3ri7gzuYdb1GtyIPJf7K10yvBud32mqbW0/Oe3btkHY=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=Lmm97Jqst9nCaMToWZ8cyO8RxI5OqWW5ilU5LJ81cx9KDlAI/Z3IRCeomO+N/OfPE\n\t1nKCgBwmx9cWaDxRqzpBjJhwzJqPZNC3gvGROIxLUg/MOcqtP00sBhxaGJhEpXSgup\n\tTVz3R6DWgGrBdYfR3uWyCNCTLbiv42lW7FKvnPm4=","Message-ID":"","Date":"Mon, 15 Sep 2025 10:23:05 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 04/10] Documentation: Enable doxygen-awesome-css","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org,\n\tStefan Klug ","References":"<20250911230115.25335-1-laurent.pinchart@ideasonboard.com>\n\t<20250911230115.25335-5-laurent.pinchart@ideasonboard.com>\n\t\n\t<20250912171003.GB29172@pendragon.ideasonboard.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20250912171003.GB29172@pendragon.ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":35821,"web_url":"https://patchwork.libcamera.org/comment/35821/","msgid":"<20250915084717.GE22385@pendragon.ideasonboard.com>","date":"2025-09-15T08:47:17","subject":"Re: [PATCH v2 04/10] Documentation: Enable doxygen-awesome-css","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Mon, Sep 15, 2025 at 10:23:05AM +0200, Barnabás Pőcze wrote:\n> 2025. 09. 12. 19:10 keltezéssel, Laurent Pinchart írta:\n> > On Fri, Sep 12, 2025 at 01:00:16PM +0200, Barnabás Pőcze wrote:\n> >> 2025. 09. 12. 1:01 keltezéssel, Laurent Pinchart írta:\n> >>> From: Stefan Klug \n> >>>\n> >>> Include doxygen-awesome-css in the doxygen config.\n> >>>\n> >>> Signed-off-by: Stefan Klug \n> >>> ---\n> >>> Changes since v1:\n> >>>\n> >>> - Fix ordering of configuration options\n> >>> - Use TOP_SRCDIR instead of CURRENT_SRCDIR to avoid introducing a new\n> >>> variable\n> >>> ---\n> >>> Documentation/Doxyfile-common.in | 5 +++++\n> >>> 1 file changed, 5 insertions(+)\n> >>>\n> >>> diff --git a/Documentation/Doxyfile-common.in b/Documentation/Doxyfile-common.in\n> >>> index c9527da03ed5..2844d215bc60 100644\n> >>> --- a/Documentation/Doxyfile-common.in\n> >>> +++ b/Documentation/Doxyfile-common.in\n> >>> @@ -54,6 +54,11 @@ EXCLUDE_SYMBOLS = libcamera::BoundMethodArgs \\\n> >>> \n> >>> IMAGE_PATH = \"@TOP_SRCDIR@/Documentation/images\"\n> >>> \n> >>> +HTML_EXTRA_STYLESHEET = \"@TOP_SRCDIR@/Documentation/doxygen-awesome-css/doxygen-awesome.css\" \\\n> >>> + \"@TOP_SRCDIR@/Documentation/doxygen-awesome-css/doxygen-awesome-sidebar-only.css\"\n> >>> +HTML_COLORSTYLE = LIGHT # required with Doxygen >= 1.9.5\n> >>\n> >> Unfortunately while testing locally I ran into a compatibility issue: https://github.com/jothepro/doxygen-awesome-css/issues/185\n> >> Example: https://ibb.co/d0GQWQ1m I suppose the trick is not to update doxygen until is\n> >> addressed in some capacity...\n> > \n> > The bug report indicates an issue with dark mode, while here we enable\n> > light mode. Is there an issue with light mode too ? Or is there a\n> > problem only for people who wants to switch to dark mode, overriding the\n> > libcamera default configuration ?\n> \n> But the documentation appears to me with a dark theme \"out of the box\" (even if `HTML_COLORSTYLE = LIGHT`).\n\nAh I hadn't understood that. For me it appears in light mode. I'm using\ndoxygen 1.13.2.\n\n> It seems to me that that option has no effect if doxygen-awesome-css is used. And in that case the\n> issue I described is present, at least as long as doxygen 1.14 (or newer?) is used.\n\nI'll give 1.14 a try.\n\n> >>> +\n> >>> +GENERATE_TREEVIEW = YES\n> >>> GENERATE_LATEX = NO\n> >>> \n> >>> MACRO_EXPANSION = YES","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7666BC328C\n\tfor ;\n\tMon, 15 Sep 2025 08:47:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 10F7C6936F;\n\tMon, 15 Sep 2025 10:47:46 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4487469367\n\tfor ;\n\tMon, 15 Sep 2025 10:47:44 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 58D2D1744; \n\tMon, 15 Sep 2025 10:46:26 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"DLxcBn0O\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1757925986;\n\tbh=5N/NdpnL3LFCzyUMuG/6HOlCrgGgfUYy+AmlbDqhEnc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=DLxcBn0OdS9cVOIR6HjIppwONSpwqYoyIxUD2rMOEhcqdcdH6KJ1BJwOV+I7G6jow\n\tQeecSwVDc/Qy1PAzA5Qxjgk8uAgiO8vp8lMdHtdXP7fmlLxeyPZm+9p1s7rxWPAIba\n\tvgRUzoYKsruS8gt36ydlzxuH8uFdAj8svdXhXHQc=","Date":"Mon, 15 Sep 2025 11:47:17 +0300","From":"Laurent Pinchart ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org,\n\tStefan Klug ","Subject":"Re: [PATCH v2 04/10] Documentation: Enable doxygen-awesome-css","Message-ID":"<20250915084717.GE22385@pendragon.ideasonboard.com>","References":"<20250911230115.25335-1-laurent.pinchart@ideasonboard.com>\n\t<20250911230115.25335-5-laurent.pinchart@ideasonboard.com>\n\t\n\t<20250912171003.GB29172@pendragon.ideasonboard.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":35822,"web_url":"https://patchwork.libcamera.org/comment/35822/","msgid":"","date":"2025-09-15T08:50:33","subject":"Re: [PATCH v2 04/10] Documentation: Enable doxygen-awesome-css","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2025. 09. 15. 10:47 keltezéssel, Laurent Pinchart írta:\n> On Mon, Sep 15, 2025 at 10:23:05AM +0200, Barnabás Pőcze wrote:\n>> 2025. 09. 12. 19:10 keltezéssel, Laurent Pinchart írta:\n>>> On Fri, Sep 12, 2025 at 01:00:16PM +0200, Barnabás Pőcze wrote:\n>>>> 2025. 09. 12. 1:01 keltezéssel, Laurent Pinchart írta:\n>>>>> From: Stefan Klug \n>>>>>\n>>>>> Include doxygen-awesome-css in the doxygen config.\n>>>>>\n>>>>> Signed-off-by: Stefan Klug \n>>>>> ---\n>>>>> Changes since v1:\n>>>>>\n>>>>> - Fix ordering of configuration options\n>>>>> - Use TOP_SRCDIR instead of CURRENT_SRCDIR to avoid introducing a new\n>>>>> variable\n>>>>> ---\n>>>>> Documentation/Doxyfile-common.in | 5 +++++\n>>>>> 1 file changed, 5 insertions(+)\n>>>>>\n>>>>> diff --git a/Documentation/Doxyfile-common.in b/Documentation/Doxyfile-common.in\n>>>>> index c9527da03ed5..2844d215bc60 100644\n>>>>> --- a/Documentation/Doxyfile-common.in\n>>>>> +++ b/Documentation/Doxyfile-common.in\n>>>>> @@ -54,6 +54,11 @@ EXCLUDE_SYMBOLS = libcamera::BoundMethodArgs \\\n>>>>> \n>>>>> IMAGE_PATH = \"@TOP_SRCDIR@/Documentation/images\"\n>>>>> \n>>>>> +HTML_EXTRA_STYLESHEET = \"@TOP_SRCDIR@/Documentation/doxygen-awesome-css/doxygen-awesome.css\" \\\n>>>>> + \"@TOP_SRCDIR@/Documentation/doxygen-awesome-css/doxygen-awesome-sidebar-only.css\"\n>>>>> +HTML_COLORSTYLE = LIGHT # required with Doxygen >= 1.9.5\n>>>>\n>>>> Unfortunately while testing locally I ran into a compatibility issue: https://github.com/jothepro/doxygen-awesome-css/issues/185\n>>>> Example: https://ibb.co/d0GQWQ1m I suppose the trick is not to update doxygen until is\n>>>> addressed in some capacity...\n>>>\n>>> The bug report indicates an issue with dark mode, while here we enable\n>>> light mode. Is there an issue with light mode too ? Or is there a\n>>> problem only for people who wants to switch to dark mode, overriding the\n>>> libcamera default configuration ?\n>>\n>> But the documentation appears to me with a dark theme \"out of the box\" (even if `HTML_COLORSTYLE = LIGHT`).\n> \n> Ah I hadn't understood that. For me it appears in light mode. I'm using\n> doxygen 1.13.2.\n\nI forgot to mention that my browser/system preference is set to \"dark\".\n\n\n> \n>> It seems to me that that option has no effect if doxygen-awesome-css is used. And in that case the\n>> issue I described is present, at least as long as doxygen 1.14 (or newer?) is used.\n> \n> I'll give 1.14 a try.\n> \n>>>>> +\n>>>>> +GENERATE_TREEVIEW = YES\n>>>>> GENERATE_LATEX = NO\n>>>>> \n>>>>> MACRO_EXPANSION = YES\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2421CBE173\n\tfor ;\n\tMon, 15 Sep 2025 08:50:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AC3F56936F;\n\tMon, 15 Sep 2025 10:50:38 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6ED0369367\n\tfor ;\n\tMon, 15 Sep 2025 10:50:36 +0200 (CEST)","from [192.168.33.2] (185.221.142.115.nat.pool.zt.hu\n\t[185.221.142.115])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 05AA81744;\n\tMon, 15 Sep 2025 10:49:18 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"U5GKmZ94\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1757926159;\n\tbh=lcXoO+iCXuYgUg13xpJTxiIf6c/n5wsxbIfdlTK+DF0=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=U5GKmZ94DOO2tjlMTbpXCSjyn12NZE67u8j7E8wbeQX+5sM+E7Km6U8LH8M9k1tz8\n\tO9DX6+w9h8mYpyr5JWT5rz3wt5ehR/Bn0/dk8HPis7k0K1hKNtFMhNqDRFtNEc1XIM\n\tWwZBxxTRFCXmqHNIQqU/C2JEg+vSUXtjduNXWW08=","Message-ID":"","Date":"Mon, 15 Sep 2025 10:50:33 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 04/10] Documentation: Enable doxygen-awesome-css","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org,\n\tStefan Klug ","References":"<20250911230115.25335-1-laurent.pinchart@ideasonboard.com>\n\t<20250911230115.25335-5-laurent.pinchart@ideasonboard.com>\n\t\n\t<20250912171003.GB29172@pendragon.ideasonboard.com>\n\t\n\t<20250915084717.GE22385@pendragon.ideasonboard.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20250915084717.GE22385@pendragon.ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":35826,"web_url":"https://patchwork.libcamera.org/comment/35826/","msgid":"<20250915141725.GI22385@pendragon.ideasonboard.com>","date":"2025-09-15T14:17:25","subject":"Re: [PATCH v2 04/10] Documentation: Enable doxygen-awesome-css","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Mon, Sep 15, 2025 at 10:50:33AM +0200, Barnabás Pőcze wrote:\n> 2025. 09. 15. 10:47 keltezéssel, Laurent Pinchart írta:\n> > On Mon, Sep 15, 2025 at 10:23:05AM +0200, Barnabás Pőcze wrote:\n> >> 2025. 09. 12. 19:10 keltezéssel, Laurent Pinchart írta:\n> >>> On Fri, Sep 12, 2025 at 01:00:16PM +0200, Barnabás Pőcze wrote:\n> >>>> 2025. 09. 12. 1:01 keltezéssel, Laurent Pinchart írta:\n> >>>>> From: Stefan Klug \n> >>>>>\n> >>>>> Include doxygen-awesome-css in the doxygen config.\n> >>>>>\n> >>>>> Signed-off-by: Stefan Klug \n> >>>>> ---\n> >>>>> Changes since v1:\n> >>>>>\n> >>>>> - Fix ordering of configuration options\n> >>>>> - Use TOP_SRCDIR instead of CURRENT_SRCDIR to avoid introducing a new\n> >>>>> variable\n> >>>>> ---\n> >>>>> Documentation/Doxyfile-common.in | 5 +++++\n> >>>>> 1 file changed, 5 insertions(+)\n> >>>>>\n> >>>>> diff --git a/Documentation/Doxyfile-common.in b/Documentation/Doxyfile-common.in\n> >>>>> index c9527da03ed5..2844d215bc60 100644\n> >>>>> --- a/Documentation/Doxyfile-common.in\n> >>>>> +++ b/Documentation/Doxyfile-common.in\n> >>>>> @@ -54,6 +54,11 @@ EXCLUDE_SYMBOLS = libcamera::BoundMethodArgs \\\n> >>>>> \n> >>>>> IMAGE_PATH = \"@TOP_SRCDIR@/Documentation/images\"\n> >>>>> \n> >>>>> +HTML_EXTRA_STYLESHEET = \"@TOP_SRCDIR@/Documentation/doxygen-awesome-css/doxygen-awesome.css\" \\\n> >>>>> + \"@TOP_SRCDIR@/Documentation/doxygen-awesome-css/doxygen-awesome-sidebar-only.css\"\n> >>>>> +HTML_COLORSTYLE = LIGHT # required with Doxygen >= 1.9.5\n\nI was wondering why light mode was behaving like auto-light mode. It\nseems that doxygen will generate .css files depending on the\nHTML_COLORSTYLE option. When set to light, the .css will hardcode light\nmode, while with auto-light it will make it dynamic. As\ndoxygen-awesome.css is a static file, it can't do the same. It instead\nimplements auto mode, and allows disabling auto-light mode by setting\nclass=\"light-mode\" in the html element in the header template (see\nhttps://github.com/jothepro/doxygen-awesome-css/blob/main/docs/tricks.md#disable-dark-mode-tricks-darkmode).\n\n> >>>> Unfortunately while testing locally I ran into a compatibility issue: https://github.com/jothepro/doxygen-awesome-css/issues/185\n> >>>> Example: https://ibb.co/d0GQWQ1m I suppose the trick is not to update doxygen until is\n> >>>> addressed in some capacity...\n> >>>\n> >>> The bug report indicates an issue with dark mode, while here we enable\n> >>> light mode. Is there an issue with light mode too ? Or is there a\n> >>> problem only for people who wants to switch to dark mode, overriding the\n> >>> libcamera default configuration ?\n> >>\n> >> But the documentation appears to me with a dark theme \"out of the box\" (even if `HTML_COLORSTYLE = LIGHT`).\n> > \n> > Ah I hadn't understood that. For me it appears in light mode. I'm using\n> > doxygen 1.13.2.\n> \n> I forgot to mention that my browser/system preference is set to \"dark\".\n\nAh that explains it.\n\nI've tried doxygen 1.14 and I can reproduce the problem. Even in light\nmode the page isn't rendered as with doxygen 1.13.2.\n\nThis is an issue in doxygen-awesome-css, they will have to update to\nnewer doxygen versions. I think we could ignore the issue for now and\nupdate our copy of the .css files once the problem gets fixed upstream.\n\nNote that in dark mode the \"light mode leakage\" is worse in\nHTML_COLORSTYLE is set to LIGHT, compared to AUTO_LIGHT (which is the\ndefault value). I think we're better off not setting HTML_COLORSTYLE.\nEven if listed as required since Doxygen 1.9.5, I don't see why that's\nrequired. I've tested Doxygen 1.9.5, thinking that the requirement may\nhave disappeared in newer versions, but that doesn't seem to be the\ncase.\n\n> >> It seems to me that that option has no effect if doxygen-awesome-css is used. And in that case the\n> >> issue I described is present, at least as long as doxygen 1.14 (or newer?) is used.\n> > \n> > I'll give 1.14 a try.\n> > \n> >>>>> +\n> >>>>> +GENERATE_TREEVIEW = YES\n> >>>>> GENERATE_LATEX = NO\n> >>>>> \n> >>>>> MACRO_EXPANSION = YES","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2C822C328C\n\tfor ;\n\tMon, 15 Sep 2025 14:17:55 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AF4B26936F;\n\tMon, 15 Sep 2025 16:17:53 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 28AE6613A0\n\tfor ;\n\tMon, 15 Sep 2025 16:17:52 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 4C66C6DF;\n\tMon, 15 Sep 2025 16:16:34 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"cI4unSuU\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1757945794;\n\tbh=peT4pmX0+PKFO3rEF7T0O2VdUu37XzLoM2DWcoP8lNo=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=cI4unSuUY1PuQUr7CI+JZrhQOfkoCgBZ7AS/ocaaCkyzZfM5tOcK2mB2Co4nnC1Ah\n\te1rkXZhqrAT6N7m5I8Z8IN1VVROSlXuEO7Vyax2ihlgLFYeQ6ZW5HyxvMfq2WwPDdy\n\tgEmN13RlSqt1CsHWjhKDb9uyyjkmFUFliXjFqlGA=","Date":"Mon, 15 Sep 2025 17:17:25 +0300","From":"Laurent Pinchart ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org,\n\tStefan Klug ","Subject":"Re: [PATCH v2 04/10] Documentation: Enable doxygen-awesome-css","Message-ID":"<20250915141725.GI22385@pendragon.ideasonboard.com>","References":"<20250911230115.25335-1-laurent.pinchart@ideasonboard.com>\n\t<20250911230115.25335-5-laurent.pinchart@ideasonboard.com>\n\t\n\t<20250912171003.GB29172@pendragon.ideasonboard.com>\n\t\n\t<20250915084717.GE22385@pendragon.ideasonboard.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]