{"id":24319,"url":"https://patchwork.libcamera.org/api/patches/24319/?format=json","web_url":"https://patchwork.libcamera.org/patch/24319/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250911092945.16517-13-mzamazal@redhat.com>","date":"2025-09-11T09:29:42","name":"[v17,12/12] config: Check configuration file version","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"2b4bfefad483a62b72108f2a495c340280a16456","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/?format=json","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24319/mbox/","series":[{"id":5431,"url":"https://patchwork.libcamera.org/api/series/5431/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5431","date":"2025-09-11T09:29:30","name":"Add global configuration file","version":17,"mbox":"https://patchwork.libcamera.org/series/5431/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24319/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24319/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1423FC324E\n\tfor ;\n\tThu, 11 Sep 2025 09:30:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A52C76937E;\n\tThu, 11 Sep 2025 11:30:37 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 855D36937E\n\tfor ;\n\tThu, 11 Sep 2025 11:30:34 +0200 (CEST)","from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-624-d6lZwhx8NrixdF7-P8qHeQ-1;\n\tThu, 11 Sep 2025 05:30:29 -0400","from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.12])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id BD0B11800447; Thu, 11 Sep 2025 09:30:28 +0000 (UTC)","from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.44.34.98])\n\tby mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 4237419560BB; Thu, 11 Sep 2025 09:30:26 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"IzLlxYjg\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1757583033;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=+QAMHlAPdUbdVXkoxpasqU6UWQCpzXFG9/7BFW452xU=;\n\tb=IzLlxYjg0PviGa7SLniIJJMOR2QOcRXF5yTBYDEiRQH/vf9vRJV4U9W3qKrjvfstFn3GPL\n\tTITAIjjPZzn/a8QQtCPe8mCjLv7yN6WlP47TOISx4clx04wh5AIe7acA98ktoLhdLbBjq2\n\tslJcmfpNDofYz/PRAU4RjPoDZ0J3yUw=","X-MC-Unique":"d6lZwhx8NrixdF7-P8qHeQ-1","X-Mimecast-MFC-AGG-ID":"d6lZwhx8NrixdF7-P8qHeQ_1757583028","From":"Milan Zamazal ","To":"libcamera-devel@lists.libcamera.org","Cc":"Milan Zamazal , Kieran Bingham\n\t, =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?=\n\t, Laurent Pinchart\n\t, Paul Elder\n\t","Subject":"[PATCH v17 12/12] config: Check configuration file version","Date":"Thu, 11 Sep 2025 11:29:42 +0200","Message-ID":"<20250911092945.16517-13-mzamazal@redhat.com>","In-Reply-To":"<20250911092945.16517-1-mzamazal@redhat.com>","References":"<20250911092945.16517-1-mzamazal@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.12","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"YchZfRz4m1SLOlgzZ2BhBU1vQU4zL_ce1tAzK8u3gCw_1757583028","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","content-type":"text/plain; charset=\"US-ASCII\"; x-default=true","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"We don't know what the future versions of the configuration file will\nlook like. The current code can process only version 1; let's check\nthat the read configuration is of this version.\n\nSigned-off-by: Milan Zamazal \n---\n src/libcamera/global_configuration.cpp | 9 +++++++++\n 1 file changed, 9 insertions(+)","diff":"diff --git a/src/libcamera/global_configuration.cpp b/src/libcamera/global_configuration.cpp\nindex 8c2670e03..2eec45363 100644\n--- a/src/libcamera/global_configuration.cpp\n+++ b/src/libcamera/global_configuration.cpp\n@@ -67,6 +67,15 @@ bool GlobalConfiguration::loadFile(const std::filesystem::path &fileName)\n \t\treturn true;\n \t}\n \n+\tconst std::optional version = (*configuration)[\"version\"].get();\n+\tif (version != 1) {\n+\t\tLOG(Configuration, Error)\n+\t\t\t<< \"Failed to read configuration file due to unsupported version \"\n+\t\t\t<< (version ? std::to_string(version.value()) : \"\\\"unspecified\\\"\")\n+\t\t\t<< \", expected version 1\";\n+\t\treturn true;\n+\t}\n+\n \tyamlConfiguration_ = std::move(configuration);\n \treturn true;\n }\n","prefixes":["v17","12/12"]}