[{"id":35792,"web_url":"https://patchwork.libcamera.org/comment/35792/","msgid":"<175766715571.2127323.18383128161526799654@neptunite.rasen.tech>","date":"2025-09-12T08:52:35","subject":"Re: [PATCH v17 06/12] config: Look up pipelines match list in\n\tconfiguration file","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Milan,\n\nThanks for the patch.\n\nQuoting Milan Zamazal (2025-09-11 18:29:36)\n> Let's add a configuration file item for the pipelines match list.\n> \n> The configuration snippet:\n> \n> configuration:\n> pipelines_match_list: rkisp1,simple\n> \n> Signed-off-by: Milan Zamazal \n\nIn the commit message, s/config:/camera_manager:/\n\nWith that changes,\n\nReviewed-by: Paul Elder \n\n> ---\n> src/libcamera/camera_manager.cpp | 10 ++++++----\n> 1 file changed, 6 insertions(+), 4 deletions(-)\n> \n> diff --git a/src/libcamera/camera_manager.cpp b/src/libcamera/camera_manager.cpp\n> index 64df62444..c203b08f7 100644\n> --- a/src/libcamera/camera_manager.cpp\n> +++ b/src/libcamera/camera_manager.cpp\n> @@ -111,14 +111,16 @@ void CameraManager::Private::createPipelineHandlers()\n> * file and only fallback on environment variable or all handlers, if\n> * there is no configuration file.\n> */\n> - const char *pipesList =\n> - utils::secure_getenv(\"LIBCAMERA_PIPELINES_MATCH_LIST\");\n> - if (pipesList) {\n> + const auto pipesList =\n> + configuration().envListOption(\"LIBCAMERA_PIPELINES_MATCH_LIST\",\n> + { \"pipelines_match_list\" },\n> + \",\");\n> + if (pipesList.has_value()) {\n> /*\n> * When a list of preferred pipelines is defined, iterate\n> * through the ordered list to match the enumerated devices.\n> */\n> - for (const auto &pipeName : utils::split(pipesList, \",\")) {\n> + for (const auto &pipeName : pipesList.value()) {\n> const PipelineHandlerFactoryBase *factory;\n> factory = PipelineHandlerFactoryBase::getFactoryByName(pipeName);\n> if (!factory)\n> -- \n> 2.51.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DBDF8BDB13\n\tfor ;\n\tFri, 12 Sep 2025 08:52:43 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 20B0069370;\n\tFri, 12 Sep 2025 10:52:43 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A46A8613A3\n\tfor ;\n\tFri, 12 Sep 2025 10:52:41 +0200 (CEST)","from neptunite.rasen.tech (unknown\n\t[IPv6:2404:7a81:160:2100:5c83:71e0:e0c7:1670])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id E678F6DF;\n\tFri, 12 Sep 2025 10:51:25 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Sir796wp\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1757667086;\n\tbh=6jrkJhHpO9w20seIHF/64I9JOzciFE+rHT/6w8lp4ko=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=Sir796wp59fLLMOtWjXFDTi1mYjv0/1EwL6RCrd41P6RvWbVptzmLekBTjrcOdeZd\n\thBfx5lsE810GHP1iwY6eSyeAZaIgF7Pml5zJFFmEcZmwdOwazGPN1JXRCwt9DTS8pg\n\tE+BdwmQMKWtuXmiysttdKaMVO7lYBBcJDFtLDlxU=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250911092945.16517-7-mzamazal@redhat.com>","References":"<20250911092945.16517-1-mzamazal@redhat.com>\n\t<20250911092945.16517-7-mzamazal@redhat.com>","Subject":"Re: [PATCH v17 06/12] config: Look up pipelines match list in\n\tconfiguration file","From":"Paul Elder ","Cc":"Milan Zamazal , Kieran Bingham\n\t, =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?=\n\t, Laurent Pinchart\n\t","To":"Milan Zamazal , libcamera-devel@lists.libcamera.org","Date":"Fri, 12 Sep 2025 17:52:35 +0900","Message-ID":"<175766715571.2127323.18383128161526799654@neptunite.rasen.tech>","User-Agent":"alot/0.0.0","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]