[{"id":35774,"web_url":"https://patchwork.libcamera.org/comment/35774/","msgid":"<175757779781.1246375.17446002542812159092@ping.linuxembedded.co.uk>","date":"2025-09-11T08:03:17","subject":"Re: [PATCH] Documentation: Fix grammar and typo in meson.build\n\tcomment","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2025-09-10 23:26:33)\n> No functional change, this is only cosmetic.\n> \n\nI see:\n\n/Doxyfile public/Doxyfile-public/\n/cdata cdata, as/cdata, as/\n/Using/Use/\n\nReviewed-by: Kieran Bingham \n\n\n> Signed-off-by: Laurent Pinchart \n> ---\n> Documentation/meson.build | 6 +++---\n> 1 file changed, 3 insertions(+), 3 deletions(-)\n> \n> diff --git a/Documentation/meson.build b/Documentation/meson.build\n> index a8d4afc01dd1..90133c4da938 100644\n> --- a/Documentation/meson.build\n> +++ b/Documentation/meson.build\n> @@ -64,9 +64,9 @@ if doxygen.found() and dot.found()\n> configuration : cdata)\n> \n> # The set of public input files stored in the doxygen_public_input array\n> - # needs to be set in Doxyfile public. We can't pass them through cdata\n> - # cdata, as some of the array members are custom_tgt instances, which\n> - # configuration_data.set() doesn't support. Using a separate script invoked\n> + # needs to be set in Doxyfile-public. We can't pass them through cdata, as\n> + # some of the array members are custom_tgt instances, which\n> + # configuration_data.set() doesn't support. Use a separate script invoked\n> # through custom_target(), which supports custom_tgt instances as inputs.\n> \n> doxyfile = custom_target('doxyfile-public',\n> \n> base-commit: b8d332cdcc130c27232f61369e7bab2d954e7ac6\n> --\n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EE7F4BDB13\n\tfor ;\n\tThu, 11 Sep 2025 08:03:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5111D6935A;\n\tThu, 11 Sep 2025 10:03:23 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 135ED6935A\n\tfor ;\n\tThu, 11 Sep 2025 10:03:21 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0179B6F3;\n\tThu, 11 Sep 2025 10:02:05 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"RSSi/Irs\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1757577726;\n\tbh=wIdnoVl4BeYp3FOqHbSidJ5ylX4U65fqiavTDD6dnUU=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=RSSi/IrsTcq2zXO1dZIIx1ZpJjyfKlbR8pn8pat9cTGr7usRuOtMYT3XmrkWSQFhN\n\tvpbtlt4OnU1a9hP+AS8v6u+8EctTk9t/oJEjF7QyBOSbwuIYuuBSuifJYUyH+m4Nvt\n\t2L9zKC26kHMhdBHOeiOAnXTzMVFX/JXxaNBzQURM=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250910222633.6550-1-laurent.pinchart@ideasonboard.com>","References":"<20250910222633.6550-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [PATCH] Documentation: Fix grammar and typo in meson.build\n\tcomment","From":"Kieran Bingham ","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 11 Sep 2025 09:03:17 +0100","Message-ID":"<175757779781.1246375.17446002542812159092@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":35777,"web_url":"https://patchwork.libcamera.org/comment/35777/","msgid":"","date":"2025-09-11T11:02:42","subject":"Re: [PATCH] Documentation: Fix grammar and typo in meson.build\n\tcomment","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"Hi\n\n2025. 09. 11. 0:26 keltezéssel, Laurent Pinchart írta:\n> No functional change, this is only cosmetic.\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n> Documentation/meson.build | 6 +++---\n> 1 file changed, 3 insertions(+), 3 deletions(-)\n> \n> diff --git a/Documentation/meson.build b/Documentation/meson.build\n> index a8d4afc01dd1..90133c4da938 100644\n> --- a/Documentation/meson.build\n> +++ b/Documentation/meson.build\n> @@ -64,9 +64,9 @@ if doxygen.found() and dot.found()\n> configuration : cdata)\n> \n> # The set of public input files stored in the doxygen_public_input array\n> - # needs to be set in Doxyfile public. We can't pass them through cdata\n> - # cdata, as some of the array members are custom_tgt instances, which\n> - # configuration_data.set() doesn't support. Using a separate script invoked\n> + # needs to be set in Doxyfile-public. We can't pass them through cdata, as\n> + # some of the array members are custom_tgt instances, which\n> + # configuration_data.set() doesn't support. Use a separate script invoked\n> # through custom_target(), which supports custom_tgt instances as inputs.\n\nIsn't the core of the issue that cfg_data.set() does not support arrays as values?\nIn any case, that's not related to the change.\n\nReviewed-by: Barnabás Pőcze \n\n\n\n> \n> doxyfile = custom_target('doxyfile-public',\n> \n> base-commit: b8d332cdcc130c27232f61369e7bab2d954e7ac6\n> --\n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E61A0C324E\n\tfor ;\n\tThu, 11 Sep 2025 11:02:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9BC136936E;\n\tThu, 11 Sep 2025 13:02:48 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0DDF369339\n\tfor ;\n\tThu, 11 Sep 2025 13:02:47 +0200 (CEST)","from [192.168.33.12] (185.221.142.115.nat.pool.zt.hu\n\t[185.221.142.115])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 753ED8BF;\n\tThu, 11 Sep 2025 13:01:32 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"o8/iz7iV\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1757588492;\n\tbh=+XnnvkMvQEygIoutDlfh9mP4lDxpPeXNvyn6xHhp9Sk=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=o8/iz7iVIm0OhycUiuVZ0Ji4XQ/GR9HStTX89MLuPNcC3aJPl1owm2P7CyWSYsQju\n\t8yIP7xDlnOXKObZObVEGL3mD/R1gWhCWOTdgAnj751ucEYmRf2j71eXM7+e9JaP6fc\n\tHrq+dNPRMxuHPWdJvTOwi+q3JZug3LrQ9XQ8QxYU=","Message-ID":"","Date":"Thu, 11 Sep 2025 13:02:42 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH] Documentation: Fix grammar and typo in meson.build\n\tcomment","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20250910222633.6550-1-laurent.pinchart@ideasonboard.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20250910222633.6550-1-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]