[{"id":35630,"web_url":"https://patchwork.libcamera.org/comment/35630/","msgid":"<175648419708.1880759.10239451812530210427@ping.linuxembedded.co.uk>","date":"2025-08-29T16:16:37","subject":"Re: [PATCH] pipeline: simple: Enable simple pipelinehandler with\n\tSoftISP on Intel IPU7","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Hans de Goede (2025-08-29 17:04:25)\n> Enable the simple pipelinehandler with SoftISP on Intel IPU7 machines.\n> \n> This has been successfully tested with the IPU7 CSI2 receiver driver in\n> drivers/media/staging in kernel version 6.17-rc# on a Lenovo ThinkPad X1\n> Carbon Gen 13 (Lunar Lake, ov08x40 sensor).\n> \n> On this specific laptop a couple of kernel patches which are pending\n> upstream are necessary on top of 6.17-rc#:\n> \n> https://lore.kernel.org/linux-usb/20250809102326.6032-1-hansg@kernel.org/\n> https://lore.kernel.org/linux-acpi/20250829142748.21089-1-hansg@kernel.org/\n> \n> Tested-by: Hans de Goede <hansg@kernel.org> # Lenovo ThinkPad Carbon X1 Gen 13\n> Signed-off-by: Hans de Goede <hansg@kernel.org>\n> ---\n>  src/libcamera/pipeline/simple/simple.cpp | 1 +\n>  1 file changed, 1 insertion(+)\n> \n> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n> index 9b24a0db..4f914be8 100644\n> --- a/src/libcamera/pipeline/simple/simple.cpp\n> +++ b/src/libcamera/pipeline/simple/simple.cpp\n> @@ -252,6 +252,7 @@ static const SimplePipelineInfo supportedDevices[] = {\n>         { \"dcmipp\", {}, false },\n>         { \"imx7-csi\", { { \"pxp\", 1 } }, false },\n>         { \"intel-ipu6\", {}, true },\n> +       { \"intel-ipu7\", {}, true },\n\nI think this is easy and valid to merge indeed.\n\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\n\n>         { \"j721e-csi2rx\", {}, true },\n>         { \"mtk-seninf\", { { \"mtk-mdp\", 3 } }, false },\n>         { \"mxc-isi\", {}, false },\n> -- \n> 2.51.0\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7FC97BEFBE\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 29 Aug 2025 16:16:42 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8204F69322;\n\tFri, 29 Aug 2025 18:16:41 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E70C76931C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 29 Aug 2025 18:16:39 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A6958245A;\n\tFri, 29 Aug 2025 18:15:34 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"U6RR0doA\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1756484134;\n\tbh=U/OO6hfi99dof15PEqyOprkOoS+Ly0jEcklHxdJHlyQ=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=U6RR0doABwdLEisQmrJMlhyhG8rIgx6DKSVbwIgl/4BErQqQUvIMCp+/ptV1IxDXg\n\tDVTyu3/pethV526oDDjEox4nS5vqPqcitTq1n0LbJ6Hz8oyidpPRe0ZXgMfQhPMqdJ\n\tSmfen4gNnd0pevn7lpKvC52MfwEBdIrl1OuIetC4=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250829160425.44024-1-hansg@kernel.org>","References":"<20250829160425.44024-1-hansg@kernel.org>","Subject":"Re: [PATCH] pipeline: simple: Enable simple pipelinehandler with\n\tSoftISP on Intel IPU7","From":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Cc":"Hans de Goede <hansg@kernel.org>","To":"Hans de Goede <hansg@kernel.org>, libcamera-devel@lists.libcamera.org","Date":"Fri, 29 Aug 2025 17:16:37 +0100","Message-ID":"<175648419708.1880759.10239451812530210427@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":35636,"web_url":"https://patchwork.libcamera.org/comment/35636/","msgid":"<175652714221.3397211.16853385757578556582@neptunite.rasen.tech>","date":"2025-08-30T04:12:22","subject":"Re: [PATCH] pipeline: simple: Enable simple pipelinehandler with\n\tSoftISP on Intel IPU7","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Quoting Hans de Goede (2025-08-30 01:04:25)\n> Enable the simple pipelinehandler with SoftISP on Intel IPU7 machines.\n> \n> This has been successfully tested with the IPU7 CSI2 receiver driver in\n> drivers/media/staging in kernel version 6.17-rc# on a Lenovo ThinkPad X1\n> Carbon Gen 13 (Lunar Lake, ov08x40 sensor).\n\n\\o/\n\n> \n> On this specific laptop a couple of kernel patches which are pending\n> upstream are necessary on top of 6.17-rc#:\n> \n> https://lore.kernel.org/linux-usb/20250809102326.6032-1-hansg@kernel.org/\n> https://lore.kernel.org/linux-acpi/20250829142748.21089-1-hansg@kernel.org/\n> \n> Tested-by: Hans de Goede <hansg@kernel.org> # Lenovo ThinkPad Carbon X1 Gen 13\n> Signed-off-by: Hans de Goede <hansg@kernel.org>\n\nReviewed-by: Paul Elder <paul.elder@ideasonboard.com>\n\n> ---\n>  src/libcamera/pipeline/simple/simple.cpp | 1 +\n>  1 file changed, 1 insertion(+)\n> \n> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n> index 9b24a0db..4f914be8 100644\n> --- a/src/libcamera/pipeline/simple/simple.cpp\n> +++ b/src/libcamera/pipeline/simple/simple.cpp\n> @@ -252,6 +252,7 @@ static const SimplePipelineInfo supportedDevices[] = {\n>         { \"dcmipp\", {}, false },\n>         { \"imx7-csi\", { { \"pxp\", 1 } }, false },\n>         { \"intel-ipu6\", {}, true },\n> +       { \"intel-ipu7\", {}, true },\n>         { \"j721e-csi2rx\", {}, true },\n>         { \"mtk-seninf\", { { \"mtk-mdp\", 3 } }, false },\n>         { \"mxc-isi\", {}, false },\n> -- \n> 2.51.0\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9E9CABD87C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSat, 30 Aug 2025 04:12:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4177469321;\n\tSat, 30 Aug 2025 06:12:29 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8DEFB613AD\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 30 Aug 2025 06:12:28 +0200 (CEST)","from neptunite.rasen.tech (unknown\n\t[IPv6:2404:7a81:160:2100:675b:5305:1ae:ae0d])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 858E813BE; \n\tSat, 30 Aug 2025 06:11:22 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"brEJdWyd\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1756527083;\n\tbh=ZqzTQWMQ1zjWrrCKPfrFhDnNt452ti+1PpCkYDbFSvU=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=brEJdWydGExGXdpFbVTnqhcnUK/R+PMSWDArmNci5JVvpIPafFc6PHCZ4i/yfL0yR\n\tR+O9C+5f+nISEFLl3BaoMJOIcL8PEo/UIpyFHzZ4ZROxxDW3YYGn7yYC3pPa0G0h7q\n\tV0EkfNLU56hOwgHCRPrYXdFSQJAkKdFu+0y/Ko/c=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250829160425.44024-1-hansg@kernel.org>","References":"<20250829160425.44024-1-hansg@kernel.org>","Subject":"Re: [PATCH] pipeline: simple: Enable simple pipelinehandler with\n\tSoftISP on Intel IPU7","From":"Paul Elder <paul.elder@ideasonboard.com>","Cc":"Hans de Goede <hansg@kernel.org>","To":"Hans de Goede <hansg@kernel.org>, libcamera-devel@lists.libcamera.org","Date":"Sat, 30 Aug 2025 13:12:22 +0900","Message-ID":"<175652714221.3397211.16853385757578556582@neptunite.rasen.tech>","User-Agent":"alot/0.0.0","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]