[{"id":35994,"web_url":"https://patchwork.libcamera.org/comment/35994/","msgid":"<175887586813.180528.2657933331416427167@isaac-ThinkPad-T16-Gen-2>","date":"2025-09-26T08:37:48","subject":"Re: [PATCH 1/4] controls: Add SyncAdjustment and SyncInterface\n\tcontrols","submitter":{"id":215,"url":"https://patchwork.libcamera.org/api/people/215/","name":"Isaac Scott","email":"isaac.scott@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for te patch!\n\nQuoting Paul Elder (2025-08-29 10:10:07)\n> Add a couple of controls related to the sync algorithm.\n> \n> The SyncAdjustment control signals to the Camera the amount to adjust\n> the frame duration by for a single frame. Any Camera that implements\n> this control (and FrameDurationLimits and SensorTimestamp metadata) will\n> be supported by the sync algorithm layer.\n> \n> The SyncInterface control signals to the sync layer which network\n> interface to use for listening (on client mode) or for multicasting (on\n> server mode). Given that enabling/disabling sync is done via control (as\n> opposed to always being on via environment variable), choosing the\n> network interface should be chosen in a similar manner.\n> \n> Signed-off-by: Paul Elder \n> ---\n> src/libcamera/control_ids_core.yaml | 23 +++++++++++++++++++++++\n> 1 file changed, 23 insertions(+)\n> \n> diff --git a/src/libcamera/control_ids_core.yaml b/src/libcamera/control_ids_core.yaml\n> index eec4b4f937ee..8721b5e80e97 100644\n> --- a/src/libcamera/control_ids_core.yaml\n> +++ b/src/libcamera/control_ids_core.yaml\n> @@ -1284,4 +1284,27 @@ controls:\n> \n> The FrameWallClock control can only be returned in metadata.\n> \n> + - SyncAdjustment:\n> + type: int32_t\n> + direction: inout\n> + description: |\n> + This is an adjustment value that can be either positive or negative, in\n> + microseconds, that tells the Camera how much to adjust the frame\n> + duration by. This is meant to be used by the Sync layer, and any camera\n> + that implements this control (and FrameDurationLimits) will be\n> + supported by the sync layer. When reported in metadata, this reports\n> + any frame duration adjustment that occurred based on the control value\n> + that was passed in.\n> +\n> + - SyncInterface:\n> + type: string\n> + direction: inout\n> + description: |\n> + This is the IP address of the network interface to use for the Sync\n> + algorithm provided by the Sync layer. When set using the SyncMode\n> + control to client mode, this will be the network interface to listen\n> + on, and for server mode it will multicast from this network interface.\n> + If no network interface is supplied by this control then INADDR_ANY\n> + will be used.\n> +\n\nReviewed-by: Isaac Scott \n\n> ...\n> -- \n> 2.47.2\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 74D59BDB1C\n\tfor ;\n\tFri, 26 Sep 2025 08:37:54 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7F3836B5F3;\n\tFri, 26 Sep 2025 10:37:53 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 36FF56936E\n\tfor ;\n\tFri, 26 Sep 2025 10:37:52 +0200 (CEST)","from thinkpad.ideasonboard.com\n\t(cpc90716-aztw32-2-0-cust408.18-1.cable.virginm.net [86.26.101.153])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 91811152D;\n\tFri, 26 Sep 2025 10:36:26 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"GemmOoio\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1758875786;\n\tbh=IW5nu2sX618BxUXwipmszaDhuxsGWUZd0D8SulqQCKM=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=GemmOoiomrGKfxD1D19flwBX7edYkr6s9uwarlMyi4V5qssqTGk9EFEp18ispmJ60\n\tnOuQePTwzle8lzoaiRKqS2ZjC0wEwVZKmBhoAN04fq+3y/r2ETtyVNiDjlE+9YIPFW\n\tO51iZtlI9NkIakiaEOJShwJRMiFbGo6ACVlDSlNQ=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20250829091011.2628954-2-paul.elder@ideasonboard.com>","References":"<20250829091011.2628954-1-paul.elder@ideasonboard.com>\n\t<20250829091011.2628954-2-paul.elder@ideasonboard.com>","Subject":"Re: [PATCH 1/4] controls: Add SyncAdjustment and SyncInterface\n\tcontrols","From":"Isaac Scott ","Cc":"Paul Elder , david.plowman@raspberrypi.com, \n\tnaush@raspberrypi.com, kieran.bingham@ideasonboard.com,\n\tstefan.klug@ideasonboard.com","To":"Paul Elder ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Fri, 26 Sep 2025 09:37:48 +0100","Message-ID":"<175887586813.180528.2657933331416427167@isaac-ThinkPad-T16-Gen-2>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]