[{"id":35587,"web_url":"https://patchwork.libcamera.org/comment/35587/","msgid":"","date":"2025-08-27T07:11:32","subject":"Re: [PATCH v2 2/2] libcamera: sensor: imx462: Add sensor delays to\n\tCameraSensorProperties","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"content":"Hi Naush\n\nThanks for this. I assume it fixes any \"winking\" problems...!\n\nReviewed-by: David Plowman \n\nDavid\n\nOn Wed, 27 Aug 2025 at 08:07, Naushir Patuck wrote:\n\n> The sensor delays for IMX462 were missing from the CameraSensorProperties\n> table. They are identical to the IMX290, so copy those values.\n>\n> Signed-off-by: Naushir Patuck \n> ---\n> src/libcamera/sensor/camera_sensor_properties.cpp | 7 ++++++-\n> 1 file changed, 6 insertions(+), 1 deletion(-)\n>\n> diff --git a/src/libcamera/sensor/camera_sensor_properties.cpp\n> b/src/libcamera/sensor/camera_sensor_properties.cpp\n> index f297341770d0..f2da8205372b 100644\n> --- a/src/libcamera/sensor/camera_sensor_properties.cpp\n> +++ b/src/libcamera/sensor/camera_sensor_properties.cpp\n> @@ -242,7 +242,12 @@ const CameraSensorProperties\n> *CameraSensorProperties::get(const std::string &sen\n> { \"imx462\", {\n> .unitCellSize = { 2900, 2900 },\n> .testPatternModes = {},\n> - .sensorDelays = { },\n> + .sensorDelays = {\n> + .exposureDelay = 2,\n> + .gainDelay = 2,\n> + .vblankDelay = 2,\n> + .hblankDelay = 2\n> + },\n> } },\n> { \"imx477\", {\n> .unitCellSize = { 1550, 1550 },\n> --\n> 2.43.0\n>\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 23200BD87C\n\tfor ;\n\tWed, 27 Aug 2025 07:11:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 39FAB692EE;\n\tWed, 27 Aug 2025 09:11:47 +0200 (CEST)","from mail-qk1-x733.google.com (mail-qk1-x733.google.com\n\t[IPv6:2607:f8b0:4864:20::733])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2B84E613C0\n\tfor ;\n\tWed, 27 Aug 2025 09:11:45 +0200 (CEST)","by mail-qk1-x733.google.com with SMTP id\n\taf79cd13be357-7e870316b79so702768585a.0\n\tfor ;\n\tWed, 27 Aug 2025 00:11:45 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"iKU2kyJk\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1756278704; x=1756883504;\n\tdarn=lists.libcamera.org; \n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=dmycAg7PNBqzQDCK3xkhOH/rM4PVIdMftLDqm0eHuPI=;\n\tb=iKU2kyJkkOp5VLg7Gnvy9fPfv89Z7jNVQncsl8rwGYDa8XvvOUgxo/jQdiQb+2Wdga\n\tI6VDikKEa3R3FrN2tNni2dILzss22i60wWLnX0gxw8aC6rs7nYkyLI8DKny9qJNwS9Fm\n\tPfI52k8DQm20QyMaRzfWZN1dnbo9RHGvtXm4lW7vWg7GGF36x78lPLKqd4ahy2k2Y7v7\n\txiF98smwDYeDR9EsaTGwXRWGuUCW6utUoQqwxotpdfaDJyyDBLslzi5Hw4jRcnvrG4fs\n\tvnI2QZnIjMCRKsOlrjzrApVrsa1PhNyQkf18CAtmXwv1/9KxhUgAGiSg41roVIwcG6/e\n\tCcvA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1756278704; x=1756883504;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=dmycAg7PNBqzQDCK3xkhOH/rM4PVIdMftLDqm0eHuPI=;\n\tb=KQCJYrBbYt7cvPMisGe13GV2bw58aJCSAPlNrPKqFzzx8O+7+iewlx7ARvaYQyKVsn\n\tOGZ8gAo2L9FUQ79Ifjl1dobeNL8Hom2EZQj58MQidvFgyTw8INAmpBCN+HDFJBFppczg\n\tYLgAZNiA8ZK0f98/YW3nUUKhbETd+mOGvKs0VODiI41+Zhuf22o2n2npFqoe4V6QRoWN\n\tWk6f9Ep3Wv+o9nD/qxa+4CrDpQE2FCH9edjcQBRoA6BH/Y5rw2ba8LvbSMXcQh8lOhAg\n\tSpSd96jmrP01Fk8U4OhkB++dcjoreCDa8cHOlarqu6wyc+37pj45M72gxpJQtzwh2XeC\n\tKYjw==","X-Gm-Message-State":"AOJu0Yya3JcVy4nVYlZTtoatmQ/THGjAwYcy1NxhBFIs7yoPGd2L/dRe\n\tGzx/hfh44mevdN/QIOBnMR0zx0x+IWSpPhPyQQnmVxNd6FiMcua5bIQw2BheJ/sNF0Iw77WECV2\n\txt8JwLPKI2DEvwg9Ac8TU1uMFUjuGmANSTj2oeTct3AQU03gLFk9y","X-Gm-Gg":"ASbGnctr5joMdA2W5VgbPjyRo5VY/UqZfXLWgWLhKWW1NPRobprVfU6TusnATNlA9M4\n\typE+AMKtp0/TdW1nUQwcoCK33lJJLaPirQkwFa642aBbC9u4VSWEdWqri53QLe3TUl3HyMTw0D4\n\tmA49Qq2Kk8FVBD3r0eyksnGkgQNEMdiNBc9JRGjQbF0dz6EebWriIQiUPwRgzT/8fwBRmhoeRJ8\n\tyZxnoT6+Aa/WZeHtqpBBQbzW8hkLz8AbotZH/V3SwFA5GGnkXKDvtt18JyJGriY/RanxlpBlu9O\n\t1M/NhgGygjL7QR0ZS8loUSfYR6WUAG9q9eI=","X-Google-Smtp-Source":"AGHT+IF3cJ1hVtUsQ1cQTPkOevk5aROND9froKpSuioZvUFKroaqBR6RHdJV/K9EZgZNQYHcrgGoo+Z2CvW0smnfnWc=","X-Received":"by 2002:a05:620a:1988:b0:7e9:f820:2b74 with SMTP id\n\taf79cd13be357-7ea110635a8mr1677571285a.74.1756278703946;\n\tWed, 27 Aug 2025 00:11:43 -0700 (PDT)","MIME-Version":"1.0","References":"<20250827070656.286258-1-naush@raspberrypi.com>\n\t<20250827070656.286258-3-naush@raspberrypi.com>","In-Reply-To":"<20250827070656.286258-3-naush@raspberrypi.com>","From":"David Plowman ","Date":"Wed, 27 Aug 2025 08:11:32 +0100","X-Gm-Features":"Ac12FXzn_gHneBFdlBsTNat-qs56ZtaU51Zdkli-lj5T8VkiG60vBVv43G2nFKg","Message-ID":"","Subject":"Re: [PATCH v2 2/2] libcamera: sensor: imx462: Add sensor delays to\n\tCameraSensorProperties","To":"Naushir Patuck ","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"multipart/alternative; boundary=\"00000000000046a1ad063d5380c8\"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]