{"id":24217,"url":"https://patchwork.libcamera.org/api/patches/24217/?format=json","web_url":"https://patchwork.libcamera.org/patch/24217/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20250824-b4-v0-5-2-gpuisp-v2-a-v2-34-96f4576c814e@linaro.org>","date":"2025-08-24T00:48:46","name":"[v2,34/37] libcamera: software_isp: GPU support for unpacked 10/12-bit formats","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"74a98ea1f7a8b8a53865fda6e7defcaa9b7eca14","submitter":{"id":175,"url":"https://patchwork.libcamera.org/api/people/175/?format=json","name":"Bryan O'Donoghue","email":"bryan.odonoghue@linaro.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/24217/mbox/","series":[{"id":5400,"url":"https://patchwork.libcamera.org/api/series/5400/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5400","date":"2025-08-24T00:48:12","name":"Add GLES 2.0 GPUISP to libcamera","version":2,"mbox":"https://patchwork.libcamera.org/series/5400/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/24217/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/24217/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EB846C332A\n\tfor ;\n\tSun, 24 Aug 2025 00:49:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 459FE69340;\n\tSun, 24 Aug 2025 02:49:45 +0200 (CEST)","from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com\n\t[IPv6:2a00:1450:4864:20::42c])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F0D1569326\n\tfor ;\n\tSun, 24 Aug 2025 02:49:07 +0200 (CEST)","by mail-wr1-x42c.google.com with SMTP id\n\tffacd0b85a97d-3c7ba6c2b2cso301099f8f.1\n\tfor ;\n\tSat, 23 Aug 2025 17:49:07 -0700 (PDT)","from [192.168.0.13] (188-141-3-146.dynamic.upc.ie. [188.141.3.146])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-45b4e1d530esm69347225e9.0.2025.08.23.17.49.06\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSat, 23 Aug 2025 17:49:07 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"OBQKZwbW\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1755996547; x=1756601347;\n\tdarn=lists.libcamera.org; \n\th=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n\t:mime-version:subject:date:from:from:to:cc:subject:date:message-id\n\t:reply-to; bh=y98V/Wfhw54+CkoioSLFFdRNZUBWzOwveM7ePFBUm2o=;\n\tb=OBQKZwbWiSQHoWUlPAHe6aC9xOdO/kUKgYmvX+5zok8rbEUJU1X8eAbEcErKXRKyBC\n\t7xy4jgDL5hIRmxJy5noJZdKsD+4Lzg37Ukcs+UvDpPMHONGvHOYLA56WSwTW4YByayft\n\tVuODAzvhtFsN3XULQouapnYNZLhOmgXIQSJOPEca6rrRwJ3AFNzfuY+cMPXSsaVjpq6I\n\t3F77W20jjTdEaAS4lBm2S6IQfAoD/RueIq/NhDOLCpg5Z5eQWU9ucUVLaiRBYy3AnmUz\n\tMuobKFSdknDqScMMlayPZjEc1Sc2I/C2GYLwrqSxwwaqpBxktacRbmy8TXSCDaCr4ppK\n\tY4Uw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1755996547; x=1756601347;\n\th=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n\t:mime-version:subject:date:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=y98V/Wfhw54+CkoioSLFFdRNZUBWzOwveM7ePFBUm2o=;\n\tb=fhQHYMESppeV8z3ZREOOY3T0jAFjp4/1aIhtoS1d+q9p6USdLp/AmNhkinL7z+q23Q\n\ttGRxc9ZlL2Z+AD0CERS3kCZO2DSodytHdKo1bM/Can4dlxpruwCvpSEJixd5DureF9sm\n\tiVe7ikT5aC2OgSrgGxfHAModFcgK5ZEjdlwg1Xd4jvpBdFuD1KvgB+ugTB3vPyLs3MoE\n\tcitUYMO1WzruOo+IGmYAltPMgFCmXPdAMDwSGcH1XlfenpC7TgwzlSgVsPcs+SGIP3CT\n\tVMXLnuRyCO/RVLLAv79Ogb1eLeE7XhjUW2quFd3OozxFFhqOMosnd57mm30GdIQdUsAv\n\tZQhw==","X-Gm-Message-State":"AOJu0YwgQhW570xjJeQ83YAs2/qUyXlSii5bSbuVHWDYp2KY6KkhY7NX\n\tOhmvNDuXatGAnyafhRXgLDfGZo6s8rya7nHvGiWNQdcUVOvcAbCj2cSJsUPjNZX/L0g=","X-Gm-Gg":"ASbGnctSy9rcSBnma/X6pzncd6kzSjQ6fiCjspW1+XAXtj07viba2lmq2HQfXh/aINY\n\t+cQjq9eB377rK5Fe1pvg//gAZuhtmcC64BjPLflPUGW2pYWI9OBVB1JyoXspPH0utzLL5WFzhtJ\n\tUW0uj5jvfFnRqNLkxvCCkzDvdLkrpsJrMbRaxi5Z8810z7aQMJ2pKbQbTBuwGRqVUk0Fe638nH3\n\t2PA9u9EMQv2X8elKl+o2SebpcbPn7psfq8s2nG8ODgZJNtucoMDR0ArIZ6OqQHMp0YH9dxdDaNr\n\tP4IAsZki1zOstKgZoypIHt2x2QZ/dImcv18UTFIuppHrMTUzsM1d6Q0BqrwZiNOSQ55cZNxueqA\n\t+J0NHOVwkfM1hXAVtlRLG96tMIgoZvQjEG+immx9VuAJ42XG0/fI/LKFF1DoPmycJxtzCidyjCK\n\t3LYWE+TvTswd6wDBwGx0sl","X-Google-Smtp-Source":"AGHT+IGArlkhupXYgsQjNG4MdbioOyMc+4EZMkfpe65Hae/rUtLg6FKVbuAsi4/GpPfdowXluA+V1A==","X-Received":"by 2002:a05:6000:4181:b0:3c6:cb4:e07a with SMTP id\n\tffacd0b85a97d-3c60cb4e5f4mr3965469f8f.30.1755996547458; \n\tSat, 23 Aug 2025 17:49:07 -0700 (PDT)","From":"Bryan O'Donoghue ","Date":"Sun, 24 Aug 2025 01:48:46 +0100","Subject":"[PATCH v2 34/37] libcamera: software_isp: GPU support for unpacked\n\t10/12-bit formats","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","Message-Id":"<20250824-b4-v0-5-2-gpuisp-v2-a-v2-34-96f4576c814e@linaro.org>","References":"<20250824-b4-v0-5-2-gpuisp-v2-a-v2-0-96f4576c814e@linaro.org>","In-Reply-To":"<20250824-b4-v0-5-2-gpuisp-v2-a-v2-0-96f4576c814e@linaro.org>","To":"libcamera-devel@lists.libcamera.org","Cc":"Bryan O'Donoghue , \n\tMilan Zamazal ","X-Mailer":"b4 0.14.2","X-Developer-Signature":"v=1; a=openpgp-sha256; l=1983;\n\ti=bryan.odonoghue@linaro.org; h=from:subject:message-id;\n\tbh=nA+2gEBXhbesAcyA55e+vkj/TQlUo/6L5jrjUpeJ3/g=;\n\tb=owEBbQKS/ZANAwAKASJxO7Ohjcg6AcsmYgBoqmFiJ71gXX+WwDBmSTWhQeaF5CcLJSDs/fOXq\n\t/DQ13ML0UKJAjMEAAEKAB0WIQTmk/sqq6Nt4Rerb7QicTuzoY3IOgUCaKphYgAKCRAicTuzoY3I\n\tOg5vD/9PfpFJeUYLqjGDlZlUO5uXDmMqIbgY+HSUZHTiX6wrl6kdVdRLCJBl0+g1f3IB2QRKA2A\n\tx+MEznuY72XjUujgK+ZO1OXGPdaSW90N1zHRgtcEY+KA16EZWeRAKPRxkjfx1sS8N5MiVKgScrq\n\t4avQE9tqr/rsfoQ2Xg213tYNnFb0R882DmfKCCXZlbcaNGN7hdL4ZKbZK4hJXs2yOJZY4dDxLgB\n\tcm+dq3P/J9NtQgpOmo84l/eAKKy3MVQHk/8pQBJ8Z5XC5iYM/JbFrI6Q3kzqMqJKJuJrMrDwweM\n\tvKG3c/OLzj0nPO0Ei0gElCBrZ1ejAQu7m1JZt0GIOqepgWCkpTc3rhmB2coX0BqjnIJaBNI47Y4\n\tz+6HUbBrSXNWrPIfw+z7CU2nXKmmOXfuzt07m0S/CHJo/1B3WhxarqKdMCcqS5+XwMToxSw/v7O\n\tcSiBTmS4vw75Qd84xw3cL/A2UnBFMp2EmBUb0pqDNc+lf43Icd7LdrCIyvLszQwCY6FjEu1inds\n\taYMN/pt/Ve2oQ7mhDGT0RAyBf9T4DCJ6pHsBt1HUPko/7UdvLSkwQvIPWkW0MKDImu3XhKhoiLe\n\tbm0Q8sQ8KX9nu7Ekz1BgPo/jhzPACxiexX6p4DQP8yZ4qxGW2/TEZuiM1ANniKbKIN+lP/YyGT9\n\tM9/f37e72Nl7Uig==","X-Developer-Key":"i=bryan.odonoghue@linaro.org; a=openpgp;\n\tfpr=E693FB2AABA36DE117AB6FB422713BB3A18DC83A","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"From: Milan Zamazal \n\nThe GPU processing supports 8-bit sensor formats and 10/12-bit packed\nformats. Support for 10/12-bit unpacked formats is missing, let's add\nit.\n\n10/12-bit unpacked formats use two adjacent bytes to store the value.\nThis means the 8-bit shaders can be used if we can modify them for\nadditional support of 16-bit addressing. This requires the following\nmodifications:\n\n- Using GL_RG (two bytes per pixel) instead of GL_LUMINANCE (one byte\n per pixel) as the texture format for the given input formats.\n\n- Setting the texture width to the number of pixels rather than the\n number of bytes.\n\n- Making the definition of `fetch' macro variable, according to the\n pixel format.\n\n- Using only `fetch' for accessing the texture.\n\nSigned-off-by: Milan Zamazal \nSigned-off-by: Bryan O'Donoghue \n---\n include/libcamera/internal/shaders/bayer_8.frag | 10 +++++++++-\n 1 file changed, 9 insertions(+), 1 deletion(-)","diff":"diff --git a/include/libcamera/internal/shaders/bayer_8.frag b/include/libcamera/internal/shaders/bayer_8.frag\nindex 74ce15096ac0b8a221175d111d982d1222b7db38..78c2609c26d115e9d7522cf18a3ebbb7d82a7267 100644\n--- a/include/libcamera/internal/shaders/bayer_8.frag\n+++ b/include/libcamera/internal/shaders/bayer_8.frag\n@@ -32,9 +32,17 @@ uniform mat3\t\tccm;\n void main(void) {\n vec3 rgb;\n \n+ #if defined(RAW10P)\n+ #define pixel(p) p.r / 4.0 + p.g * 64.0\n+ #define fetch(x, y) pixel(texture2D(tex_y, vec2(x, y)))\n+ #elif defined(RAW12P)\n+ #define pixel(p) p.r / 16.0 + p.g * 16.0\n+ #define fetch(x, y) pixel(texture2D(tex_y, vec2(x, y)))\n+ #else\n #define fetch(x, y) texture2D(tex_y, vec2(x, y)).r\n+ #endif\n \n- float C = texture2D(tex_y, center.xy).r; // ( 0, 0)\n+ float C = fetch(center.x, center.y); // ( 0, 0)\n const vec4 kC = vec4( 4.0, 6.0, 5.0, 5.0) / 8.0;\n \n // Determine which of four types of pixels we are on.\n","prefixes":["v2","34/37"]}